vb.org Archive - Integration with vBulletin - [Neoobs] Teamspeak3 Integration

Page 7 of 27

Show 40 post(s) from this thread on one page

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vBulletin 4.x Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=245)

- - Integration with vBulletin - [Neoobs] Teamspeak3 Integration (https://vborg.vbsupport.ru/showthread.php?t=255700)

Kraxell

02-20-2011 07:59 PM

I add the right "b_virtualserver_token_add" and get now this error:
"Teamspeak Error 2568: insufficient client permissions (failed on privilegekeyadd 17300/0x4394). "

Neo_obs

02-20-2011 11:14 PM

Can you PM me details to your TS server including server query login so I can check your permissions?

LuucEarth

02-21-2011 08:15 PM

Found a problem in the viewer where custom icon's were not downloading properly.

Traced it down to a problem in the ts3icon.php

Code:

/* load framework library */

require_once("../libraries/TeamSpeak3/TeamSpeak3.php");

needs to be changed to:

Code:

/* load framework library */

require_once("../teamSpeak/TeamSpeak3.php");

to match the structure you have set up in your product.

Once done with that custom channel and group icons do appear properly.

**This is in the 0.9.7b version***

On another note 0.9.7b did solve my token generation error of improper paramaters.

Neo_obs

02-21-2011 09:16 PM

Quote:

Originally Posted by LuucEarth (Post 2165141)

Found a problem in the viewer where custom icon's were not downloading properly.

Traced it down to a problem in the ts3icon.php

Code:

/* load framework library */

require_once("../libraries/TeamSpeak3/TeamSpeak3.php");

needs to be changed to:

Code:

/* load framework library */

require_once("../teamSpeak/TeamSpeak3.php");

Thank you for the bug fix, it is now fixed in the source code. Glad to hear 9.7 solved token generation errors for you.

LuucEarth

02-22-2011 03:17 AM

Found another bug fix in the Post bit Display.

Line 191 - 193 of String.php (Helper Folder)

Code:

    if($regexp)

    {

      return (preg_match("/" . $pattern . "/i", $this->string)) ? TRUE : FALSE;

    }

This throws an error when Unique ID's have a / in them

Fix:

Code:

    if($regexp)

    {

       $pattern= preg_quote($pattern, '/ ');

      return (preg_match("/" . $pattern . "/i", $this->string)) ? TRUE : FALSE;

    }

Without the preg-quote there could be a serious security vulnerability in some situations.

If you allow users to set their own UID and have postbit on/offline notification turned on it calls this function.
Someone could put a highly recursive Regex pattern in place of their Unique ID and cause a CPU Cycle related DoS

Neo_obs

02-22-2011 03:59 AM

Quote:

Originally Posted by LuucEarth (Post 2165255)

Found another bug fix in the Post bit Display.

Line 191 - 193 of String.php (Helper Folder)

Code:

    if($regexp)

    {

      return (preg_match("/" . $pattern . "/i", $this->string)) ? TRUE : FALSE;

    }

This throws an error when Unique ID's have a / in them

Fix:

Code:

    if($regexp)

    {

       $pattern= preg_quote($pattern, '/ ');

      return (preg_match("/" . $pattern . "/i", $this->string)) ? TRUE : FALSE;

    }

That is actually part of the framework I use... I will let the developer know and add this to my release now.

Neo_obs

02-22-2011 06:40 PM

I have 4 more bug fixes before I release Beta 0.9.8, however I need people to help me figure out what is wrong. If you reported a bug fix please contact me via PM or check the googlecode site for information.

Also a lot of people have been having issues with serverquery information. I will be adding more information to the readme in 0.9.8 that will explain better how to get your serverquery information. If you are hosting your own server, the username is usually serverquery and the password is a randomly generated password that contains numbers, letters, and symbols. You can not change the username or password. However if you are using another company to host your server, then you will need to contact them as your information may need to be set up either by them or by you.

LuucEarth

02-22-2011 08:35 PM

Quote:

Originally Posted by Neo_obs (Post 2165265)

That is actually part of the framework I use... I will let the developer know and add this to my release now.

Its an issue in the framework if that function is intended to work with something that can be based on human input.

The problem I ran into was when the postbit online status was turned on.

I would get multiple:

Warning: preg_match(): Unknown modifier 'n' in [path]\teamspeak\Helper\String.php on line 192

One for each post that had a user with a UID entered in a particular thread.
And only when that UID had a / in it

Having a very small test bed of users with their UID known, it wasnt hard to notice that each unknown modifier was a part of the UID directly proceeding a /
That was causing the issue in that one bit of code. I guess the question is whether the function was flawed or the usage of it. =o)

Neo_obs

02-23-2011 02:37 AM

I can tell you that the usage is exactly the way it is written in the documentation, however because teamspeak 3 is still in beta, the php framework for working with ts3 is still in beta, and that is a major reason my mod is still beta.

However I have redesigned the way the postbit display works and should fix almost all issues you have. I have also applied the patch you gave me just in case. I still have 4 more open bugs but if the users don't respond with more information or an updated status I will be closing the bugs as invalid and releasing beta 0.9.8 this Thursday or Friday.

fishinstud

02-23-2011 09:25 AM

The TS Viewer is the nicest that I've ever seen. We have custom user group icons aswell as channel icons. Will your script display the channel icons? My custom group icons aren't showing. I saw the default icon picks in the folder. However my issue is that my user groups are: Guest, Friend, Trusted, Server Editor, and Admin; so the user group icons wont download and I cant alter your images due to the amount of user groups. Thanks for the hard work on the scripting.

All times are GMT. The time now is 09:32 PM.

Page 7 of 27

« First

Last »

Show 40 post(s) from this thread on one page

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01505 seconds Memory Usage 1,751KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (8)bbcode_code_printable (3)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (4)pagenav_pagelink (1)pagenav_pagelinkrel (1)post_thanks_navbar_search (1)printthread (10)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: