vb.org Archive - Administrative and Maintenance Tools - vbStopForumSpam - known spammer lookup for new registrations

Page 7 of 123

Show 40 post(s) from this thread on one page

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vBulletin 3.6 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=194)

- - Administrative and Maintenance Tools - vbStopForumSpam - known spammer lookup for new registrations (https://vborg.vbsupport.ru/showthread.php?t=176481)

pedigree

05-27-2008 06:32 PM

Hmm, Ive done something bad here.

In between testing, copying/pasting from the server to my local machine to ZIP up the files, Ive made a bad mistake in the instructions

ALL THOSE THAT MODDED THEIR TEMPLATES, NEED TO DO THIS

Edit template MEMBERINFO

- Find this and delete

Code:

<if condition="$permissions[vbstopforumspamviewpermissions]1">

        <div class="fieldset">Last IP Address : $bbuserinfo[ipaddress]

                <a href="http://www.stopforumspam.com/ipcheck/$bbuserinfo[ipaddress]" target="_blank"><img 



src="$stylevar[imgdir_statusicon]/vbsfs_view.gif" alt="View IP details at www.StopForumSpam.com" border="0">

                </a>

                <if condition="$permissions[vbstopforumspamsubmitpermissions]"><a href="#not_working_yet_$bbuserinfo[ipaddress]"><img 



src="$stylevar[imgdir_statusicon]/vbsfs_submit.gif" alt="Submit spam user details to www.StopForumSpam.com"  border="0"></a></if>

        </div>

</if>

Or revert the template if youve made no other changes

God knows what I was thinking but unless you do this, people will see IP numbers of visitors.

Ive very sorry for this and thanks to Wired1 for making me think about it.

Ill be removing this from the instructions, reloading v0.61 without any template changes. In v0.7, the template changes will be automatic and verified completely

Wired1

05-27-2008 06:37 PM

Quote:

Originally Posted by pedigree (Post 1533216)

Ahh, thats why I think I didnt mod that block in the mod. :)

Instructions need to be clarified then (at least for 3.7.x). Currently they say edit MEMBERINFO and look for:

Code:

<if condition="$vboptions['usereferrer']">

Looks like as of 3.7.x, they moved that code into the template I mentioned.

J98680Bxxxxx

05-27-2008 06:57 PM

Thanks pedigree!

I have been blocking, using other mods, quite a lot of spammers coming from China lately. Will add this mod as an additional line of defense.

:up:

pedigree

05-27-2008 06:57 PM

Quote:

Originally Posted by Wired1 (Post 1533220)

Instructions need to be clarified then (at least for 3.7.x). Currently they say edit MEMBERINFO and look for:

Code:

<if condition="$vboptions['usereferrer']">

Looks like as of 3.7.x, they moved that code into the template I mentioned.

Well, I completely bollocks up one of the most basic mistakes in PHP, the = and == comparisons :( If you modded the MEMBERINFO template, you need to undo the changes (or revert the template if no other changes have been made to it)

Ive uploaded v0.61 without template mods in the instructions, have notified those with "installed" to undo the template changes.

The core backend code will work on 3.6 and 3.7 and Ive code most of the code written for 3.7 that integrates a tab in the User Profile, based on the group list in the options (new configuration lists in v0.7) Until then however, Ill be testing the access controls like a nut job trying to get out of a box. All the template changes will be automatically parsed with hooks.

Twin_Turbo

05-27-2008 07:03 PM

Why remove that section of code? Just add conditionals around it, that'll hide it from normal users

PHP Code:


		
			
<if condition="can_moderate()"> .... </if>

pedigree

05-27-2008 07:08 PM

Quote:

Originally Posted by Twin_Turbo (Post 1533258)

Why remove that section of code? Just add conditionals around it, that'll hide it from normal users

PHP Code:


		
			
<if condition="can_moderate()"> .... </if>

and

That as well but I wanted to make sure that nothing sneaked out... It was "Panic stations"

Wired1

05-27-2008 07:14 PM

Quote:

Originally Posted by pedigree (Post 1533249)

Ive uploaded v0.61 without template mods in the instructions, have notified those with "installed" to undo the template changes.

Was that the only template edit in the old instructions?

When attempting to upgrade from 0.6 to 0.61, I get this error:

Code:

Database error in vBulletin 3.7.0:



Invalid SQL:

ALTER TABLE usergroup ADD vbstopforumspamviewpermissions INT( 10 ) UNSIGNED DEFAULT '0' NOT NULL;



MySQL Error   : Duplicate column name 'vbstopforumspamviewpermissions'

Error Number  : 1060

Request Date  : Tuesday, May 27th 2008 @ 03:11:56 PM

Error Date    : Tuesday, May 27th 2008 @ 03:11:56 PM

Script        : <ADMIN CP LOCATION>/plugin.php?do=productimport

Referrer      : <ADMIN CP LOCATION>/plugin.php?do=productadd

IP Address    : 97.100.166.130

Username      : Wired

Classname     : vB_Database

MySQL Version : 5.0.51b-community-nt

pedigree

05-27-2008 07:36 PM

It was only the template edit, you dont need to reimport from 0.60 to 0.61

Although Im suprised to see that error. Ill have to add a check to test for suplicate posbfits like that.. It shouldnt ever happen

The uninstall drops those two columns from the database

Code:

    $db->query_write("ALTER TABLE " . TABLE_PREFIX . "usergroup DROP vbstopforumspamviewpermissions");

    $db->query_write("ALTER TABLE " . TABLE_PREFIX . "usergroup DROP vbstopforumspamsubmitpermissions");

You might have to run drop uninstall/reinstall and if that fails, drop them from phpMyAdmin.

Im going to look how that could possibly happen

Theyre going to be gone in v0.7 anyway.

Thomas P

05-28-2008 04:52 PM

Great work - I think this is very promising.

@pedigree: You got PN, I think I have something for you ;)

pedigree

05-28-2008 08:48 PM

Wired I can only think that you didnt uninstall, thus it tried to recreate the postbits. Ive set the XML to ignore DB errors in the case of a force reinstall/overwrite

All times are GMT. The time now is 01:08 PM.

Page 7 of 123

« First

107

Last »

Show 40 post(s) from this thread on one page

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01782 seconds Memory Usage 1,756KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (5)bbcode_code_printable (2)bbcode_php_printable (4)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (4)pagenav_pagelink (3)pagenav_pagelinkrel (1)post_thanks_navbar_search (1)printthread (10)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: