vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.5 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=113)
-   -   vB News Ticker (https://vborg.vbsupport.ru/showthread.php?t=123126)

Eagle Creek 08-08-2006 06:14 PM

That's cool :D.
All of my news items are underlined. At your screenshot they aren't.

What's 'wrong'?

davidw 08-08-2006 07:03 PM

That happened to me one time because I was playing around with my FORUMHOME template and accidentally removed $spacer_open (right above where the $vbnews_ticker goes). Check there to see if it is located there. If not, you may want to put it in there.

Eagle Creek 08-08-2006 09:43 PM

Ahh.. My members don't like it.. :(.

But I have more forums. I will support this hack till the end! :D.

Buraq 08-09-2006 05:43 PM

Version 1.0.2 makes my forumhome load even slower (yes I did the edits to the php).

I'm not sure how feasible this is, but why not just include the latest thread titles via RSS instead of queries into the db. I know we implemented something like this on our main website, where we get the latest threads from a specific forum in vBulletin. I have to ask my co-admin how he did it.

Until then, I'm gonna have to disable this plugin. 14+ seconds is just too much, and sometimes the page doesn't load at all until you refresh again.

davidw 08-09-2006 07:39 PM

How many forums were you pulling these from? Also what other plugins were you running with this (in forumhome_complete)? I found this mod doesn't play well with vbshout, for example.

Buraq 08-09-2006 08:06 PM

Quote:

Originally Posted by christianb
How many forums were you pulling these from? Also what other plugins were you running with this (in forumhome_complete)? I found this mod doesn't play well with vbshout, for example.

I'm pulling threads from 2 forums, and the only other plugin I'm using is a banner rotator plugin I wrote. The banner plugin does not perform any complicated db queries or anything of the sort. It mainly just pulls a couple of variables stored in $vbulletin->options[] via an adminCP back end.

davidw 08-09-2006 08:20 PM

It should be ok then - I don't know why the delay. I'd be interested in the RSS transfer as that might speed things up - but I'm not sure how to do that. Of course, I've always had trouble with using marquees. I will be looking into speeding up the query though.

Eagle Creek 08-11-2006 03:34 PM

You fixed it? (cause I don't see your reply anymore)

davidw 08-11-2006 03:46 PM

I thought I did. lol
I fixed one thing, but removing that line cause it to pull more forums that were not chosen lol. The only reason why it was in there was for a preview - but for some reason it broke something else.

davidw 08-11-2006 03:58 PM

Ok, silly me, accidentally removed the WHERE statement because I thoughtlessly left it on the same line as the one I needed removed.

anyways, here's the potential fix (again)...

@Buraq (and anyone else who may be having a slow response time) - try editing the plugin and changing the query...

Find this:
PHP Code:

            $gettickers $db->query_read("
                SELECT t.threadid, t.title, t.forumid, t.open, t.dateline, t.visible, t.firstpostid 
                FROM " 
TABLE_PREFIX "forum f 
                INNER JOIN " 
TABLE_PREFIX "thread t ON t.forumid = f.forumid AND t.visible = 1 AND " $desclim " > ( SELECT count(" $desclim ") FROM " TABLE_PREFIX "thread WHERE forumid = f.forumid AND visible = 1 AND dateline > t.dateline )
                LEFT OUTER JOIN " 
TABLE_PREFIX "post AS post ON post.postid = t.firstpostid WHERE t.forumid IN (" implode(','$tickarray) . ") 
                ORDER BY field(f.forumid," 
implode(','$tickarray) . "), t.dateline desc
            "
); 

remove this code:
PHP Code:

LEFT OUTER JOIN " . TABLE_PREFIX . "post AS post ON post.postid t.firstpostid 

which changes it to this:
PHP Code:

            $gettickers $db->query_read("
                SELECT t.threadid, t.title, t.forumid, t.open, t.dateline, t.visible, t.firstpostid 
                FROM " 
TABLE_PREFIX "forum f 
                INNER JOIN " 
TABLE_PREFIX "thread t ON t.forumid = f.forumid AND t.visible = 1 AND " $desclim " > ( SELECT count(" $desclim ") FROM " TABLE_PREFIX "thread WHERE forumid = f.forumid AND visible = 1 AND dateline > t.dateline )
                WHERE t.forumid IN (" 
implode(','$tickarray) . ")
                ORDER BY field(f.forumid," 
implode(','$tickarray) . "), t.dateline desc
            "
); 

That code served no purpose and may actually be causing the problem. It is only used for allowing a preview of the post/thread and it is something I forgot to take out.
This will be fixed in the next version.


All times are GMT. The time now is 10:40 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01216 seconds
  • Memory Usage 1,754KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (3)bbcode_php_printable
  • (1)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete