vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.5 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=113)
-   -   Randomly positioned ad in between postbits in showthread (https://vborg.vbsupport.ru/showthread.php?t=98057)

DeeperImage 10-11-2005 10:44 PM

Quote:

Originally Posted by Gottcha

I can see the ads. See my previous post..

Gottcha 10-11-2005 10:56 PM

just checked a friends computer and all is well...great hack.... now to find out why i cant see the ads

UK Jimbo 10-11-2005 11:22 PM

I don't think that it's the same problem but worth me mentioning it here.

When I tested this yesterday on visordown.com I noticed on some pages that the adsense ad won't appear when there's already a Google ad on the page and they don't have sufficient information about the page that the ad's on. The issue is covered in the Google Adsense FAQ here

Quote:

The multiple ad units system detects the number of ad units that are on your page, and automatically serves unique ads to each ad unit. The system is optimised for pages that have highly targeted ads available - as a result, you may sometimes see that only the first ad unit contains ads. As our ad inventory changes, or if your page content changes, you may start seeing more ads on your page.

When only one ad unit is displaying ads, any additional ad units will display as transparent boxes, or will display the alternate ad or colour that is defined in their ad code. Please note that each instance of ad code must have the alternate URL or colour specified in order to display alternate content.
I'd recommend that you put alternate ads or ad/collapsing in place in case no ad or PSAs get served.


On a totally different note the CTR has significantly increased since we moved from the old system of fixed position after the third ad to using this hack on.

Doc Great 10-12-2005 06:19 AM

I think you have a "&" too much in you first line :)
Quote:

<if condition="$GLOBALS['adsense_position'] == $post['postcount'] && $GLOBALS['adsense_position'] > 0">

UK Jimbo 10-12-2005 06:58 AM

Quote:

Originally Posted by Doc Great
I think you have a "&" too much in you first line :)

I've got just the right amount of "&"s in my first line :)

&& is the same as writing AND and is a logical AND
& is a bitwise operator

http://uk.php.net/manual/en/language...rs.logical.php
http://uk.php.net/manual/en/language...rs.bitwise.php

Doc Great 10-12-2005 07:49 AM

Thats very strage, i get a parse error when i use your version, but with one it works perfectly....

UK Jimbo 10-12-2005 07:59 AM

Copy/paste your template code please.

Doc Great 10-12-2005 08:19 AM

Code:

<!-- post #$post[postid] -->
<if condition="$show['spacer']">
        $spacer_open
        <div id="edit$post[postid]" style="padding:0px 0px $stylevar[cellpadding]px 0px">
        <if condition="!$post['islastshown']"><!-- this is not the last post shown on the page --></if>       
</if>


<table class="tborder" id="post$post[postid]" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="0" width="100%" align="center">
<tr>
        <td class="thead" $post[scrolltothis]>
                <div class="normal" style="float:$stylevar[right]">
                        &nbsp;
                        <if condition="$show['postcount']">#<a href="showpost.php?$session[sessionurl]p=$post[postid]&amp;postcount=$post[postcount]" target="new" rel="nofollow" id="postcount$post[postid]" name="$post[postcount]"><strong>$post[postcount]</strong></a> &nbsp;</if>
                        <if condition="$show['reputationlink']"><a href="#" onclick="reputation($post[postid]); return false;"><img class="inlineimg" src="$stylevar[imgdir_button]/reputation.gif" alt="<phrase 1="$post[username]">$vbphrase[add_to_xs_reputation]</phrase>" border="0" /></a> &nbsp;</if>
                        <if condition="$show['reportlink']"><a href="report.php?$session[sessionurl]p=$post[postid]" rel="nofollow"><img class="inlineimg" src="$stylevar[imgdir_button]/report.gif" alt="$vbphrase[report_bad_post]" border="0" /></a> &nbsp;</if>
                        $post[iplogged]
                        <if condition="$show['inlinemod']">
                        <input type="checkbox" name="plist[$postid]" id="plist_$postid" style="vertical-align:middle; padding:0px; margin:0px 0px 0px 5px" value="$post[checkbox_value]" onclick="inlineMod.toggle(this)" />
                        </if>
                </div>
               
                <div class="normal">
                        <!-- status icon and date -->
                        <a name="post$post[postid]"><img class="inlineimg" src="$stylevar[imgdir_statusicon]/post_$post[statusicon].gif" alt="$post[statustitle]" border="0" /></a>
                        <if condition="!$show['announcement']">
                                $post[postdate]<if condition="!$show['detailedtime']">, $post[posttime]</if>
                        <else />
                                <phrase 1="$post[startdate]" 2="$post[enddate]">$vbphrase[x_until_y]</phrase>
                        </if>
                        $post[firstnewinsert]
                        <!-- / status icon and date -->
                </div>
        </td>
</tr>
<tr>
        <td class="alt2" style="padding:0px">
                <!-- user info -->
                <table cellpadding="0" cellspacing="$stylevar[cellpadding]" border="0" width="100%">
                <tr>
                        <if condition="$show['avatar']"><td class="alt2"><a href="member.php?$session[sessionurl]u=$post[userid]"><img src="$post[avatarurl]" $post[avwidth] $post[avheight] alt="<phrase 1="$post[username]">$vbphrase[xs_avatar]</phrase>" border="0" /></a></td></if>
                        <td nowrap="nowrap">
                       
                                <div id="postmenu_$post[postid]">
                                        <if condition="$show['profile']">
                                        <a class="bigusername" href="member.php?$session[sessionurl]u=$post[userid]">$post[musername]</a>
                                        $post[onlinestatus]
                                        <script type="text/javascript"> vbmenu_register("postmenu_$post[postid]", true); </script>
                                        <else />
                                        $post[musername]
                                        </if>
                                </div>
                               
                                <if condition="$post['usertitle']"><div class="smallfont">$post[usertitle]</div></if>
                                <if condition="$post['rank']"><div class="smallfont">$post[rank]</div></if>
                               
<if condition="$thread[postuserid] == $post[userid] and $post[postcount] > '1'"><div class="smallfont"> Themenstarter <img src="/images/misc/threadstarter.gif" alt="Threadstarter" /></div></if>


                        </td>
                        <td width="100%">&nbsp;</td>
                        <td valign="top" nowrap="nowrap">
                                <div class="nzbpostbit">
                                      <div class="smallfont">
                                        <if condition="$post['joindate']"><div>$vbphrase[join_date]: $post[joindate]</div></if>
                                        <if condition="$post['field2']"><div>$vbphrase[location_perm]: $post[field2]</div></if>
                                        <if condition="$post['age']"><div>$vbphrase[age]: $post[age]</div></if>
                                        <div>
                                                $vbphrase[posts]: $post[posts]

                                        </div>
                                        <if condition="$show['reputation']"><if condition="$show['reppower']">$vbphrase[reppower]: $post[reppower] </if><div>$post[reputationdisplay]</div></if>
                                        <div><if condition="$post[icqicon] or $post[aimicon] or $post[msnicon] or $post[yahooicon]">&nbsp; $post[icqicon] $post[aimicon] $post[msnicon] $post[yahooicon]
</if></div>
                                </div></div>
                               
                        </td>
                </tr>
                </table>
                <!-- / user info -->
        </td>
</tr>
<tr>
        <td class="alt1" id="td_post_$post[postid]">
        <!-- message, attachments, sig -->
       
                <if condition="$show['messageicon'] OR $post['title']">
                        <!-- icon and title -->
                        <div class="smallfont">
                                <if condition="$show['messageicon']"><img class="inlineimg" src="$post[iconpath]" alt="$post[icontitle]" border="0" /></if>
                                <if condition="$post['title']"><strong>$post[title]</strong></if>
                        </div>
                        <hr size="1" style="color:$stylevar[tborder_bgcolor]" />
                        <!-- / icon and title -->
                </if>
               
                <!-- message -->
                <div id="post_message_$post[postid]">$post[message]</div>
                <!-- / message -->
       
                <if condition="$show['attachments']">
                <!-- attachments -->
                        <div style="padding:$stylevar[cellpadding]px">
                       
                        <if condition="$show['thumbnailattachment']">
                                <fieldset class="fieldset">
                                        <legend>$vbphrase[attached_thumbnails]</legend>
                                        <div style="padding:$stylevar[formspacer]px">
                                        $post[thumbnailattachments]
                                        </div>
                                </fieldset>
                        </if>
               
                        <if condition="$show['imageattachment']">
                                <fieldset class="fieldset">
                                        <legend>$vbphrase[attached_images]</legend>
                                        <div style="padding:$stylevar[formspacer]px">
                                        $post[imageattachments]
                                        </div>
                                </fieldset>
                        </if>
                       
                        <if condition="$show['imageattachmentlink']">
                                <fieldset class="fieldset">
                                        <legend>$vbphrase[attached_images]</legend>
                                        <table cellpadding="0" cellspacing="$stylevar[formspacer]" border="0">
                                        $post[imageattachmentlinks]
                                        </table>
                                        </fieldset>
                        </if>
                       
                        <if condition="$show['otherattachment']">
                                <fieldset class="fieldset">
                                        <legend>$vbphrase[attached_files]</legend>
                                        <table cellpadding="0" cellspacing="$stylevar[formspacer]" border="0">
                                        $post[otherattachments]
                                        </table>
                                </fieldset>
                        </if>
                       
                        <if condition="$show['moderatedattachment']">
                                <fieldset class="fieldset">
                                        <legend>$vbphrase[attachments_pending_approval]</legend>
                                        <table cellpadding="0" cellspacing="$stylevar[formspacer]" border="0">
                                        $post[moderatedattachments]
                                        </table>
                                </fieldset>               
                        </if>
                       
                        </div>
                <!-- / attachments -->
                </if>
               
                <if condition="$post['signature']">
                <!-- sig -->
                        <div>
                                __________________<br />
                                $post[signature]
                        </div>
                <!-- / sig -->
                </if>
               
                <if condition="$show['postedited']">
                <!-- edit note -->
                        <div class="smallfont">                        <hr size="1" style="color:$stylevar[tborder_bgcolor]" />
                                <em>
                                <phrase 1="$post[edit_username]" 2="$post[edit_date]" 3="$post[edit_time]">$vbphrase[last_edited_by_x_on_y_at_z]</phrase>.
                                <if condition="$post['edit_reason']">$vbphrase[reason]: $post[edit_reason]</if>
                                </em>
                        </div>
                <!-- / edit note -->
                </if>
       
                <div align="$stylevar[right]">
                        <!-- controls -->

                        <if condition="$post['editlink']">
                                <a href="$post[editlink]" name="vB::QuickEdit::$post[postid]"><img src="$stylevar[imgdir_button]/edit.gif" alt="$vbphrase[edit_delete_message]" border="0" /></a>
                        </if>
                        <if condition="$post['forwardlink']">
                                <a href="$post[forwardlink]"><img src="$stylevar[imgdir_button]/forward.gif" alt="$vbphrase[forward_message]" border="0" /></a>
                        </if>
                        <if condition="$post['replylink']">
                                <a href="$post[replylink]" rel="nofollow"><img src="$stylevar[imgdir_button]/<if condition="$post['forwardlink']">reply_small<else />quote</if>.gif" alt="$vbphrase[reply_with_quote]" border="0" /></a>
                        </if><a href="#top" onclick="self.scrollTo(0, 0); return false;"><img src="$stylevar[imgdir_button]/up.gif" alt="nach oben" border="0" /></a>
                        <if condition="$show['quickreply'] AND !$show['threadedmode']">
                                <a href="$post[replylink]" rel="nofollow" id="qr_$post[postid]" onclick="return false"><img src="$stylevar[imgdir_button]/quickreply.gif" alt="$vbphrase[quick_reply_to_this_message]" border="0" /></a>
                        </if>
                        <if condition="$show['moderated']">
                                <img src="$stylevar[imgdir_misc]/moderated.gif" alt="$vbphrase[moderated_post]" border="0" />
                        </if>
<if condition="$post['replylink'] AND $show['multiquote']">
          <img src="$stylevar[imgdir_misc]/mq_img_off.gif" alt="$vbphrase[multiquote]" border="0" width="21" height="15" name="multiquote_$post[postid]" id="multiquote_$post[postid]" onclick="toggleMultiQuote($post[postid], this)" style="cursor:pointer" />
  </if>
                        <!-- / controls -->
                </div>
               
        <!-- message, attachments, sig -->
       
        </td>
</tr>
</table>

<!-- post $post[postid] popup menu -->
<div class="vbmenu_popup" id="postmenu_$post[postid]_menu" style="display:none">
        <table cellpadding="4" cellspacing="1" border="0">
        <tr>
                <td class="thead">$post[username]</td>
        </tr>
        <if condition="$show['profile']">
                <tr><td class="vbmenu_option"><a href="member.php?$session[sessionurl]u=$post[userid]">$vbphrase[view_public_profile]</a></td></tr>
        </if>
        <if condition="$show['pmlink']">
                <tr><td class="vbmenu_option"><a href="private.php?$session[sessionurl]do=newpm&amp;u=$post[userid]"><phrase 1="$post[username]">$vbphrase[send_private_message_to_x]</phrase></a></td></tr>
        </if>
        <if condition="$show['emaillink']">
                <tr><td class="vbmenu_option"><a href="sendmessage.php?$session[sessionurl]do=mailmember&amp;u=$post[userid]" rel="nofollow"><phrase 1="$post[username]">$vbphrase[send_email_to_x]</phrase></a></td></tr>
        </if>
        <if condition="$show['homepage']">
                <tr><td class="vbmenu_option"><a href="$post[homepage]"><phrase 1="$post[username]">$vbphrase[visit_xs_homepage]</phrase></a></td></tr>
        </if>
        <if condition="$show['search']">
                <tr><td class="vbmenu_option"><a href="search.php?$session[sessionurl]do=finduser&amp;u=$post[userid]" rel="nofollow"><phrase 1="$post[username]">$vbphrase[find_all_posts_by_x]</phrase></a></td></tr>
        </if>
        <if condition="$post['userid'] AND $show['member']">
        <tr><td class="vbmenu_option"><a href="profile.php?$session[sessionurl]do=addlist&amp;userlist=buddy&amp;u=$post[userid]"><phrase 1="$post[username]">$vbphrase[add_x_to_buddy_list]</phrase></a></td></tr>
        </if>
        </table>
</div>
<!-- / post $post[postid] popup menu -->




<if condition="$show['spacer']">
        </div>
        $spacer_close
</if>
<!-- / post #$post[postid] -->


<if condition="in_array($bbuserinfo[usergroupid], array(1))">
<if condition="$GLOBALS['adsense_position'] == $post['postcount'] & $GLOBALS['adsense_position'] > 0">
$spacer_open
<div style="padding:0px 0px $stylevar[cellpadding]px 0px">

<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="0" width="100%" align="center">
<tr>
        <td class="thead" align="left">Sponsored Links</td>
</tr>
<tr>
        <td class="alt1" align="center">

<!-- Werbung Start -->

<!-- Werbung Ende -->


        </td>
</tr>
</table>

</div>
$spacer_close
</if></if>


UK Jimbo 10-12-2005 08:42 AM

Hi DG,

It might be a plan to remove the vBulletin code from that post above.

Copy/pasted that template from above and it works fine for me with the &&.

I don't why there should/would be an error, it's low level fundamental PHP.

You might be better off replacing the && with AND on your system.

James, puzzled

Doc Great 10-12-2005 08:51 AM

Hi Jimbo,

ok now i'm gettn crazy :D i tested AND --> works perfectly - then thought bout testing && again --> also works :confused: why ....

I'm shure i tested it before several times with getting parse errors.


All times are GMT. The time now is 09:14 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01256 seconds
  • Memory Usage 1,836KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_code_printable
  • (4)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete