![]() |
@Darmak
What MySQL version are you running? the ON DUPLICATE was introduced in MySQL 4.1 if i recall correct. |
Quote:
|
Quote:
Just download the zip file attached, and replace your current signature include files functions_signature.php and adminfunctions_signature.php with the ones included in this zip file! NOTE: ONLY FOR MySQL Server 4.0.24 Enjoy... Sonia |
Then you must hope for Sonia to update her hack to support older MySQL versions.
Edit: Oops never noticed that Sonia was faster with a solution then i was with my reply. :D |
Quote:
I am doing this for the final release, just like Usergroups you can inherit another groups permissions so as to save time not having to configure each group with a new set of permissions! Tere will also be a multi select box at the bottom on the permissions configuration page that will be shown if there are other groups that inherit the same permissions! After the final release I will be doing another plugin that will allow for multi groups for each user, so a user can be a member of many groups and have different permissions based on forum and permissions that s/he has for the forum they are currently accessing. That will be as far as will be going with this mod, besides keeping it updated until the need for it has been replaced with a better vBulletin control. Thanks for your input, it will help me make this better for everyone! Sonia |
Quote:
|
Fix (2) coding errors!
1. Array to String error for bbcode SIZE tag. 2. Missing dot operator for smilies path. NOTES: 1. If I have installed this on your forum or fixed a install then you do not need to do this! 2. Darmak or anyone else that I gave MySQL version 3 or 4 files to, do not need these edits! Everyone else should do this! Open './includes/functions_signature.php' FIND THIS Code:
$errors[] = construct_phrase ( $vbphrase['sig_editor_size_bbc'], $in[$i], $code['size'][0], $code['size'][1] ); REPLACE WITH Code:
$errors[] = construct_phrase ( $vbphrase['sig_editor_size_bbc'], $in[1][$i], $code['size'][0], $code['size'][1] ); Open './includes/adminfunctions_signature.php' FIND THIS Code:
$path = ( substr ( $path, -1 ) != '/' ? '/' : '' ); REPLACE WITH Code:
$path .= ( substr ( $path, -1 ) != '/' ? '/' : '' ); Done with error edits! Sonia |
Two bugs I found
It doesnt seem to do any of the signature image checks (with the exception the domain restriction which is missing the help file so far :P). And the domain check is bugged in the way that https://vborg.vbsupport.ru/ doesnt work (properly restricted) but https://vborg.vbsupport.ru/ does work (avoids check). And as said, the signature image doesnt get checked for the size, height and width |
Quote:
Which one is not getting checked! Please give a real example because both of those you gave will not help me find what the problem is, if there is any! This would not be checked because it would be a error... {img}http://www.duhweb.com/sig.duh{/img} :S/ERROR: A [IMG] link is invalid or using a unsupported (image extension). We only allow [gif, jpg, png, jpeg] for image type linking. If the extension was valid you would get this error! If the image was not found A invalid {IMG} link (http://www.duhweb.com/sig.gif) was found. :E/ERROR: This would not be checked because it is not a valid img url, it missing the protocol (http://...), so the signature control will not even validate it because it will never be displayed as a image! {img}www.duhweb.com/sig.duh{/img} The signature control will only validate a IMAGE that is contained in valid BBCODE or valid HTML code if that is turned on. There is no need to validate IMAGE links that are not valid because they will not be converted! if you want to validate {img}www.duhweb.com/sig.duh{/img} then I will add it for you personally, but I won't add it to the Final release because it is wasteful resources being used. Why, because I would have to guess where the image is (http, https, ftp, ftps) which would result in (4) remote calls because the person is to lazy to add the protocol to the image tag! So like I said give me a real working example, because I am not very good at guessing! Oh, ya.... I forgot the HELP file for all the options (Domain blocking configuration and the rest of the options) will be up tonight, plus the HELP phrases will be added tonght so you can add them to the Admin Panel if you want! Sonia |
error in phrases:
PHP Code:
PHP Code:
phrase: PHP Code:
PHP Code:
edit: more issues! the phrase signature_permissions would not display as a Control Panel homepage type. I had to make it a CP global before it would display. I have the same issue mentioned above, it doesn't check the image's dimensions at all using proper img tags and gives this error: A [IMG] link is invalid or using a unsupported (image extension). We only allow [gif, jpg, png, jpeg] for image type linking. |
All times are GMT. The time now is 02:00 PM. |
Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information | |
---|---|
|
|
![]() |
|
Template Usage:
Phrase Groups Available:
|
Included Files:
Hooks Called:
|