vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.0 Full Releases (https://vborg.vbsupport.ru/forumdisplay.php?f=33)
-   -   Trader Ratings v1.2.0 (https://vborg.vbsupport.ru/showthread.php?t=65730)

Spinball 06-02-2004 12:28 PM

One point Jason. If the person given a rating is now deleted, there are empty brackets in the rating screen. Perhaps you could put 'Guest' in there instead? Or whatever the default is for deleted users?

Beermonster 06-02-2004 02:17 PM

unbelievable easy to install :)

[high]* Beermonster clicks install[/high]

eoc_Jason 06-02-2004 02:30 PM

Spinball - It would probably be wiser to edit your postbit and add an <if condition=> for a guest to not display a trader rating link.

I'll make that correction in the code, and also I need to fix a divide by zero that someone posted above. So 1.01 should be released within the next hour or so.

Quote:

Originally Posted by Spinball
One point Jason. If the person given a rating is now deleted, there are empty brackets in the rating screen. Perhaps you could put 'Guest' in there instead? Or whatever the default is for deleted users?


eoc_Jason 06-02-2004 03:20 PM

Okay, v1.01 has been posted. I sent out an email to the list. There are also all the intructions in the readme for upgrading from 1.0->1.01

Anyone who still can't get their TR to work, please PM me or post again with your specific problem, I'm not sure who has fixed their issues and who hasn't in this thread. ;)

Odoin 06-02-2004 03:26 PM

This might have been asked... Also this might be simple or hard but I do not understand VB enough to know what it will take.... I want to display the user rating only in the forums that have items for sale or wanted.... Right now it displays in every forum... (postbit). Any ideas?

Thank you for your time.

Spinball 06-02-2004 03:31 PM

Hi Jason,
can I bring the other issue we were discussing by PM into the public arena incase there are other people in the same position?
Basically before we installed Jason's excellent hack for vB2, we manually kept records of trader ratings.
Our users naturally want to keep these points.
In the vB2 system, I just incremented their points in the user table the once and that was all that was needed.
Now, however, with the groovy list of ratings, I think an explanation as to where the extra points are from is neccessary.
To test this I have created a dummy entry in the rating table assigning 20 points to myself with the explanation that they were carried over from the manual system.
These points are shown in the posts for users - (excellent!) but not, however, in the ratings page for that user.
Now I appreciate that this might be difficult to achieve with the extra data like 'members who left a positive' and 'members whi left a negative' type statistics.
But would it be possible to make the feedback score at the top be
Quote:

SELECT sum(userrating) FROM user_rate_trade WHERE rateduser = the_user_id

eoc_Jason 06-02-2004 07:44 PM

One issue that comes up when you manually changed it is, you don't know how many were postitive, and how many were negative (or even neutral), nor do you know how many were from unique members. You just have an arbitrary number that sums up to something. Your solution is to simply take the difference of what is stored in the trade table and the rating you created, and create only all pos/neg entries to balance them out.

In all honesty I think it would just be better to drop what numbers you manually changed, and allow users to either re-rate whatever they can truly remember, or just let them live with their new (err, old) score and it can build up if they buy or sell more stuff. I don't consider it a life-altering event if a few points were lost.

However, since you seem intent on keeping their new numbers, your first SQL query that you PMed me will give you the score difference between the new and old. Then for each rating you will need to create the corresponding amount of rating rows in the trade table, which you can use either userid 0 (it should display a blank username) or 1 (which should be yours).

The whole point of the new ratings system is to display mostly by unique members, as to not over inflate a users rating (eBay, among many other sites and software packages do the same). I think it is more correct to see that X person has had X postitive feedback from unique people, rather than the same number from a single person. Changing the feedback score to not count by unique members is not difficult, however in the long run I don't think it should be done just for the sake of the few ratings that had to be manually inserted.

But, to answer your question, with v1.01 you will need to edit the traderratings.php file in two places to adjust the counting method. First at the very bottom in the tratings_user function, this is what recalculates and updates the rating score in the user tabel whenever a rating is added or deleted. Second is in the do=view section near the top, it's similar to the code in the function (In v1.02 I've actually changed it some so that it uses the same function.) But you can basically remove the "DISTINCT" clause out and that will count all entried, not members. But then you should probably change the text on the page accordingly since the pos/neg totals will no longer be by members either. (and the All positive feedback received part will be redudant).

Like I said before, I think it would probably be best just to drop the manual edits and let people gripe and moan for a while until they get over it, so that your ratings will be consistent with everyone elses and you won't have to always hack up code every time I post a new release (since I'm planning on adding a lot more features, I don't know how many will interfere with your plans for how you want it to function).

eoc_Jason 06-02-2004 07:51 PM

Oh yeah, I forgot to ask you guys, but would you be interested in me adding the ability for users to rate based on usergroups? It's not terribly hard. I actually use it on my site currently because new users can't use/see the FS/WTB section so it only makes sense for them not to be able to rate people.

lifesourcerec 06-02-2004 10:45 PM

For those with the

PHP Code:

Trader Ratings: () 

issue, try logging out of the forum and re-signing in. Usually works for oue users.

lifesourcerec 06-02-2004 11:11 PM

Dunno if this is already a feature or not, but how can you make:

Specific URL mandatory and somehow make it where that a link a\can only be used twice (one time for each involved).


All times are GMT. The time now is 05:32 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01635 seconds
  • Memory Usage 1,748KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_php_printable
  • (2)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (2)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete