vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.8 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=235)
-   -   Miscellaneous Hacks - Two-Step External Links for Link Weight Retention (https://vborg.vbsupport.ru/showthread.php?t=217708)

TWTCommish 07-03-2009 09:10 PM

I didn't really follow how that would be possible, either. Either the mod didn't do anything, or it redirected all links and the whitelist didn't work. It can't be both.

Regardless, I'd be glad to take a look at the user's site, but he seems to have given up on it pretty quickly. If you change your mind, Saviour, I'm fairly certain we could find the problem.

Alfa1 07-03-2009 09:34 PM

Quote:

Originally Posted by aspen0 (Post 1842011)
You mean show different content to search engines than you show to other guests Alfa1 for the purposes of SEO? That'd technically be cloaking Alfa1 and is against guidelines and while it is a minor offense and probably wouldn't result in a penalty or ban, it is not really that worth it.

All vbulletin boards do this, because member groups have different permissions than others. Most boards restrict guests from posting or from various functionality. That's the nature of the permissions system.
Cloaking would be treating guests differently than SE bots.

Quote:

Originally Posted by aspen0 (Post 1842011)
I have no idea why someone would become logged out, the external link does nothing with cookies. Perhaps it is a browser issue? No one else has reported that, perhaps that user's cookies got corrupted or overwritten randomly, just as they clicked the link.

I am not sure either. I always have a fair amount of members online, so bugs tend to surface quickly.

After installing your hack, my members report the following issues:
- If a member has not listed a website in profile, then this dead link is displayed on profiles: http://www.mysite.com/forum/externalredirect.php?url=
I have about 40.000 of those dead links now.
- signature pictures that are on another site, no longer display.
- the link to a members home page from postbit dropdown does not work.

Please advise.

TWTCommish 07-03-2009 10:35 PM

The cloaking bit wasn't addressed to me, but restricting posting is a bit different than restricting content, since content is the issue here.

Anyway, I'm afraid I need some more information to debug these issues; a link to your site, for example, would help a great deal. Regarding these:

signature pictures that are on another site, no longer display.

Does this mean the images don't display, the images are broken, or the link is not directed?

the link to a members home page from postbit dropdown does not work.

How does it not work? Is it not redirected as it should be, redirected when it shouldn't, or does it something else? I can't see any of these things, obviously, so I need much more information in order to help debug these problems.

TWTCommish 07-03-2009 10:41 PM

Quote:

Originally Posted by Alfa1 (Post 1842385)
- If a member has not listed a website in profile, then this dead link is displayed on profiles: http://www.mysite.com/forum/externalredirect.php?url=

I'm PMIng you a small patch now. Looks like this is caused because vBulletin is parsing this field even when it's blank, or something similar. Odd, but easily fixed. Check your PMs in a minute. :)

aspen0 07-03-2009 11:15 PM

Quote:

Does this mean the images don't display, the images are broken, or the link is not directed?
I think I know what is happening here, the image URL is being rewritten as a redirect as well, causing the image to fail and be broken. That would be my guess anyways.

TWTCommish 07-03-2009 11:17 PM

That was my guess, as well, but the only part of the script that adds the URL rewrite is the function which handles bbCode links, which shouldn't effect the image tag's URL.

aspen0 07-04-2009 12:13 AM

Yes, it'd be best to see the exact examples, or a snippet of view source from the page.

Alfa1 07-04-2009 12:45 AM

Quote:

Originally Posted by TWTCommish (Post 1842416)
signature pictures that are on another site, no longer display.

Does this mean the images don't display, the images are broken, or the link is not directed?

Images displayed with the [SIGPIC] bbcode are not displayed. Here is the source:
PHP Code:

        <!-- sig -->
            <
div>
                
__________________<br />
                <
div align="center">[nopparse][SIGPIC][/SIGPIC][/nopparse]</div>

            </
div>
        <!-- / 
sig --> 

^ignore the noparse code please.

Quote:

Originally Posted by aspen0 (Post 1842421)
I think I know what is happening here, the image URL is being rewritten as a redirect as well, causing the image to fail and be broken. That would be my guess anyways.

Quote:

Originally Posted by TWTCommish (Post 1842422)
That was my guess, as well, but the only part of the script that adds the URL rewrite is the function which handles bbCode links, which shouldn't effect the image tag's URL.

Please check if affects the [SIGPIC] bbcode.

Quote:

Originally Posted by TWTCommish (Post 1842416)
the link to a members home page from postbit dropdown does not work.

How does it not work? Is it not redirected as it should be, redirected when it shouldn't, or does it something else?

Nothing happens when clicking the link. This is caused by this being added to the link:
PHP Code:

 rel

Now that i see it, I am not sure if this is related to this hack.

Quote:

Originally Posted by TWTCommish (Post 1842417)
I'm PMIng you a small patch now. Looks like this is caused because vBulletin is parsing this field even when it's blank, or something similar. Odd, but easily fixed. Check your PMs in a minute. :)

Thank you. That works well.

TWTCommish 07-04-2009 12:52 AM

Glad that worked for you. :) We'll incorporate that change into the official release.

I've tried adding signature pictures to my test board without incident so far. I'll try a few more things and let you know if that helps me duplicate the problem.

I think you're correct about the homepage link and the rel= issue being related to another mod, as this particular hack doesn't add any rel attitributes, except in the EXTERNAL_LINK template.

Saviour 07-04-2009 02:51 AM

Quote:

Originally Posted by TWTCommish (Post 1842370)
I didn't really follow how that would be possible, either. Either the mod didn't do anything, or it redirected all links and the whitelist didn't work. It can't be both.

Regardless, I'd be glad to take a look at the user's site, but he seems to have given up on it pretty quickly. If you change your mind, Saviour, I'm fairly certain we could find the problem.

Okay guys...

I'll try to describe the problem again...hopefully, this time, I won't lose you.

When your mod is installed...and a user clicks an external link, it's supposed to redirect them with a message that they are leaving the current site...correct? Your mod does not do this for me.

Your mod also opens internal links (from my site) in a new window or tab. I'm using Firefox 3.5. I included glitchpc.com in the whitelist. I had set "rel=nofollow" to off. All other settings were set to "yes".

Those are the issues I'm having with your mod. For the life of me, though, I don't see the difference between your mod and NuHit's mod. How is your mod any different than NuHit's...other than the fact there's supposed to be a redirect message that does not seem to be working for me...along with the fact that internal links are opened in a new window...which shouldn't be happening.

When I installed your mod...I made sure NuHit's mod was uninstalled, first. I tried several times to get your mod to work, but was unsuccessful. It's not that I had given up...I just decided to return to the previous mod I was using that worked fine. The only reason I wanted to try your mod was due to the fact a message was supposed to be displayed notifying the person who clicks an external link that they are being redirected to another site.

Again...I gave this mod every opportunity and it failed on every attempt to get the redirect message to display or to prevent internal links from opening in a new window...even after rebuilding the post cache. If it matters...I'm running vb 3.8.3, vba CMPS 3.2.0 and vba Links Directory 3.2.0. I use quite a few mods...so...I'm not sure if any of them are conflicting with your mod...but that could be a possibility. However...like I said...NuHit's mod is working flawlessly.

Also...aspen0 stated this:

Quote:

If you mean this mod:

https://vborg.vbsupport.ru/showthread.php?t=145402

It hurts you, technically.
How? NuHit's mod gives you the ability to turn "rel=nofollow" on/off. It opens external links in a new window and you can choose whether to open internal links in the same (or a new) window. It also uses a whitelist. So tell me...how can using their mod technically have me at a disadvantage? Other than the fact if I'm using their mod, I'm not using yours.

Well...that's it...in a nutshell. I look forward to your replies.


All times are GMT. The time now is 09:30 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01275 seconds
  • Memory Usage 1,766KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_php_printable
  • (11)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete