vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.7 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=228)
-   -   New Posting Features - QHSF Private Thread (https://vborg.vbsupport.ru/showthread.php?t=187992)

gmerin 01-25-2009 05:41 PM

Quote:

Originally Posted by btotw (Post 1723626)
I kinda agree. To me, its not even "Not Quite Private Threads." Its more like "Deny Post Viewing For Certain Users or Groups."

@The author: Dont get me wrong, the hack itself is excellent...I simply feel that its misnamed.

For example, a private message cant be seen by anyone at all except for those whom its intended for. Thus i think that a private THREAD should be 100% invisible if you arent part of the usergroup(s)/ person(s) who are allowed to see it...

It should be like ts not even there. If I start a private thread as an admin, I should be able to see it...but if I log in as a regualr user, it should be as it it doesnt exist at ALL...

Again, just my two cents. Its partially there by disallowing the viewing of the conversation in question. If it were to be taken to that last step? It'd be killer...

and if the denied users or groups really want to see what they're begin denied they only have to go to the thread creator's public profile and look at all posts by user to read everything in the thread. it's kind of like when children make something invisible by covering their eyes ;)

other than that little issue, the hack is beautiful and my users value it so much that they are willing to lose the searching facilities of VB in order to maintain the security of the hack.

Rene Kriest 01-26-2009 08:44 PM

Hello folks!

I am finally back after some testing and I also had a look at the source code of this addon aswell.

To make it short:
  1. This addon is save only under certain additional conditions which need to be set by an admin
  2. The addon has no flaws
Kinda paradoxical, or? But read on! :)

Here are now the results of my investigations regarding the so-called security flaws

The "search postings" issue is a flaw but not of the addon but of the cache.
You need to rebuild your search index cache to make the addon work 100%. After rebuilding there will be a message in the search posting preview "This is message from private thread". Technically the addon is flawless - the problem is the forum search cache.

How to fix that issue
  • Rebuild your cache often via cron
  • Allow the addon only in certain forums which aren't searchable
  • Allow the addon only in certain forums which are restricted to certain usergroups only, but take care: then the problem applies to the members of the usergroup itself if you do not alter the search rules to the forum
  • Turn of "posting preview" or reduce the number of letters (standard: 200, to be found in search.php)
  • Use a spoiler to at least 200 letters for each posting
My suggestions
Use the addon only in forums where the search function is put off or at least restricted to titles only.

Rebuildung your Search Index Cache somehow sucks, because of the time gaps and the huge server load it creates.

murekhalir 01-28-2009 04:42 AM

So does this mod still work.

Does it really create thread privacy or are there loopholes?

gmerin 01-29-2009 12:01 PM

Quote:

Originally Posted by murekhalir (Post 1726860)
So does this mod still work.

Does it really create thread privacy or are there loopholes?

If I'm reading Rene correctly the mod does create fully private threads if you limit it to forums that are not searchable, and if you rebuild your search cache often.

Unfortunately constantly rebuilding the search cache is not realistic due to the time and server resources required.

So this leaves us with the option of shutting off the search function on the board or limiting the mod to forums which have the search function disabled.

I have no problem with exchanging the search functionality for the private threads.

I am indifferent as to where the fault lies: I prefer to fix the flaws than to affix the blame. Whether you want to say the mod is flawed or the caching algorithm of VB is flawed, is immaterial to me.

I do believe the limitations and implicit requirements should be noted prominently in the mod's documentation so that admins are forewarned, rather than finding out about it after one of your members realizes that she posted info about her adulterous affairs in a private thread that wasn't all that private...

Phornixx 02-06-2009 10:37 PM

Can't find the ON/OFF Switch!!!

What does Admin Panel/Forum Rights/?

There is no such option in the Admin CP

Thanks!

gmerin 02-06-2009 11:49 PM

Quote:

Originally Posted by Phornixx (Post 1736556)
Can't find the ON/OFF Switch!!!

What does Admin Panel/Forum Rights/?

There is no such option in the Admin CP

Thanks!

go into the Admin CP -> Forums & Moderators -> Forum Manager

expand the forums and permission each in the Enable / Disable Private Thread Option towards the bottom.

btotw 02-22-2009 07:37 PM

Quote:

Originally Posted by gmerin (Post 1724461)
and if the denied users or groups really want to see what they're begin denied they only have to go to the thread creator's public profile and look at all posts by user to read everything in the thread. it's kind of like when children make something invisible by covering their eyes ;)

other than that little issue, the hack is beautiful and my users value it so much that they are willing to lose the searching facilities of VB in order to maintain the security of the hack.

I understand your point.

Understand mine.

My point is that the hack is GREAT. But it should be called "Private POSTS" instead of "Private Thread" :)

Birched 08-09-2009 05:25 PM

There is a plugin that is disabled by default:
Private Threads: Get Private/Restricted Users showthread_complete
What does that one do? Why is it disabled?

Also -- do you know how the mod interacts with mysql fulltext search? Does it still have the same problems?

Also -- is it still set up for admin only to be able to 'private' things?

It's an excellent mod -- I used the older version (long ago) and found them useful for our boards. Thanks for putting it together (it's BIG!) and thanks for supporting it.

One comment: I am running a huge board with many forums. It would be great if the admin controls had a setting that would propagate through child forums.

Birched 09-16-2009 12:44 PM

BUG: Edit (AJAX) of the first post of a thread results in the loss of the private flag for the thread.

buro9 12-29-2009 05:31 PM

A question, does this work with VB4?

Has anyone tested it?


All times are GMT. The time now is 08:26 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01069 seconds
  • Memory Usage 1,751KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (4)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete