vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.5 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=113)
-   -   Toplist (https://vborg.vbsupport.ru/showthread.php?t=98646)

derekivey 03-11-2006 02:37 PM

Thanks for the suggestion. I like the idea and am adding it to my todo list.

Thanks,
Derek

derekivey 03-12-2006 11:35 PM

Quote:

Originally Posted by derfelix
been testing it .. and it is great...

found one little bug.. (or feature? :surprised: )

Example:
A user uploads a pic.. and the sitename, description etc...
everything is fine..

now the user sees he has a typo in the text.. so he edits it.
when he saves it.. everything is fine..
BUT: the picture is gone.. as a matter of fact the file is still there..
but somehow in the db it is gone.. the user sees a broken image.

I think its a little bug in edit_site.php

because when you edit your sites it stores the $key variable into the database. BUT if you have not modified the image.. the variable $key is not defined anywhere (actually it takes the $key variable out of the included global.php)

My workaround is the following (maybe there is a more elegant way to do it)
First make a backup copy of edit_site.php


in edit_site.php
find:
PHP Code:

if (!empty($vbulletin->GPC['image']['name'])) 

above add:
PHP Code:

$query_key ""

a little lower find:
PHP Code:

$height $size[1]; 

below add:
PHP Code:

                    $query_key ", imagecode='" $key "' WHERE id='" $vbulletin->GPC['id'] . "'"

and finally find:
PHP Code:

                        imagesize='".$image_size."',
                        
imagecode='".$key."' WHERE id='".$vbulletin->GPC['id']."'"; 

and replace with:

PHP Code:

                        imagesize='" . $image_size . "'" . $query_key . ""; 

this is just a first guess..
maybe its not very elegant.. but it works for me.

which meens that when i edit a site without changing the image.. it does not delete the image.

Felix

Hey,

You are right, that is a bug. I will release a fix shortly.

Derek

derekivey 03-13-2006 12:04 AM

Ok here is the fix. Please download this attached file, upload, and select overwrite if your FTP program asks you.

Thanks,
Derek

derfelix 03-13-2006 03:08 AM

Thx for the quick fix..!!!

will test ist this evening..
just looked at the code.. much better than mine!!!

Felix

derekivey 03-13-2006 06:42 PM

No Problem :)

derfelix 03-14-2006 06:05 AM

works like a charm

Hoffi 03-14-2006 07:28 AM

After update my Images are also not shown up and I have the same Problem as Ramsesx. What was the solutions?

Edit: During update I get the following Error for every Entry:

Code:

Warnung: copy(): URL file-access is disabled in the server configuration in /admincp/plugin.php(1239) : eval()'d code (Zeile 13)

Warnung: copy(http://www.dunklesvest.de/avatar/bannervest.gif): failed to open stream: no suitable wrapper could be found in /admincp/plugin.php(1239) : eval()'d code (Zeile 13)


derfelix 03-15-2006 07:43 AM

Found another little bug... no its not.. its rather an annoyance..

AND it will NOT AFFECT (I think) all systems (only the phpmyadmin users)

I stumbled into it when backing up my database with phpmyadmin...
when i wanted to get the backup.sql file back into the database.. it gave me an error...

Why?

because one field is named "in" and phpmyadmin thinks it is a sql statement.

so what i did to upload the backup.sql file.. I edited the field name to "ins" and everything was ok..

then in phpmyadmin (once the file was loaded) I renamed the field back to "in" and everything was ok..

What would be nice in a future version would be to have that field called: "ins" once and for all.. then there would be no more problems..

Felix

derekivey 03-15-2006 07:45 PM

Quote:

Originally Posted by Hoffi
After update my Images are also not shown up and I have the same Problem as Ramsesx. What was the solutions?

Edit: During update I get the following Error for every Entry:

Code:

Warnung: copy(): URL file-access is disabled in the server configuration in /admincp/plugin.php(1239) : eval()'d code (Zeile 13)
 
Warnung: copy(http://www.dunklesvest.de/avatar/bannervest.gif): failed to open stream: no suitable wrapper could be found in /admincp/plugin.php(1239) : eval()'d code (Zeile 13)


Hi,

Try the attached product file instead. I took out the code that grabs any images that people have already added before you upgraded, and uploads them to your server. Since your server configuration doesn't allow file uploads, you will have to edit the hack to not allow image uploads, or get your php configuration changed to allow it.

Derek

derekivey 03-15-2006 07:46 PM

Quote:

Originally Posted by derfelix
Found another little bug... no its not.. its rather an annoyance..

AND it will NOT AFFECT (I think) all systems (only the phpmyadmin users)

I stumbled into it when backing up my database with phpmyadmin...
when i wanted to get the backup.sql file back into the database.. it gave me an error...

Why?

because one field is named "in" and phpmyadmin thinks it is a sql statement.

so what i did to upload the backup.sql file.. I edited the field name to "ins" and everything was ok..

then in phpmyadmin (once the file was loaded) I renamed the field back to "in" and everything was ok..


What would be nice in a future version would be to have that field called: "ins" once and for all.. then there would be no more problems..

Felix

I will take a look at this. PHPMyAdmin never gave me that problem, but I will change the name of it for the next release.

Derek


All times are GMT. The time now is 04:25 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01682 seconds
  • Memory Usage 1,756KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_code_printable
  • (6)bbcode_php_printable
  • (3)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (5)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete