vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 4.x Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=245)
-   -   Miscellaneous Hacks - More Share Options TNG by BOP5 (Facebook, Twitter, Google +1, AddThis) Share Buttons (https://vborg.vbsupport.ru/showthread.php?t=266159)

monkeyboy1916 03-16-2012 10:47 AM

I've had to disable this modification unfortunately. I'm unsure why, but it seems to be causing 50+ extra queries on all pages. The specific plugin causing this to happen to me is:

Plugin: Add Share Options to Templates
Hook: process_templates_complete

After removing the following from the plugin, the 50+ extra queries disappear:
Code:

require_once(DIR . '/includes/adminfunctions_template.php');
Any ideas? It could possibly be my setup, but I'm not too sure about that.

Thanks!

Edit: I should note, this only started after updating to vBulletin 4.1.11. Previously my Forum was running 4.1.7 with no issues, or extra queries.

Vick98 03-16-2012 11:58 AM

Does this work properly for version 4.1.11?

BirdOPrey5 03-16-2012 12:43 PM

Monkeyboy,

I believe it is a side effect of this bug in 4.1.11: http://tracker.vbulletin.com/browse/VBIV-14446

It is set to be fixed in 4.1.12.

The main issue with this bug is it doesn't allow translated phases to be used on some situations and kh99 provided a fix for that part: https://vborg.vbsupport.ru/showpost....60&postcount=4

But it does not appear to help the query situation much. I saw mine from 76 to 72 on a 1 post thread. :eek:

I will investigate the issue further.

Does the mod still work for you with the "require" statement removed? It was used only for adding share buttons to albums, pictures, and member profiles. I'm curious if these areas still work with it removed.


Quote:

Originally Posted by Vick98 (Post 2310002)
Does this work properly for version 4.1.11?

It does work on 4.1.11 except for the extra queries due to the bug described above.

BirdOPrey5 03-18-2012 11:24 AM

OK I believe I have a fix for the extra 50 query issue.

I have posted it in JIRA for comment: http://tracker.vbulletin.com/browse/VBIV-14451

I know it solves the query issue on the front end, the only discussion is if it will still fix the bug that brought about this edit to begin with.

The bug only involved exporting styles when using a language other than the master language so if you don't ever do that you can use the fix without issue.

It has reduced query usage on my forum for a post from 77 to 27.

This mod is not the only one that uses adminfunctions_template.php but this fix will fix the query issue for all of them.

The fix is to edit adminfunctions_template.php in the /includes/ direcotry.'

There's a big block of code starting at line 5855 we want to put in an if condition.

So change:
PHP Code:

$only = array
(
  
// phrased groups
  
'buddylist'      => fetch_phrase('group_buddy_list''style'''falsefalse$languageid),
  
'calendar'       => fetch_phrase('group_calendar''style'''falsefalse$languageid),
  
'faq'            => fetch_phrase('group_faq''style'''falsefalse$languageid),
  
'reputation'     => fetch_phrase('group_user_reputation''style'''falsefalse$languageid),
  
'poll'           => fetch_phrase('group_poll''style'''falsefalse$languageid),
  
'pm'             => fetch_phrase('group_private_message''style'''falsefalse$languageid),
  
'register'       => fetch_phrase('group_registration''style'''falsefalse$languageid),
  
'search'         => fetch_phrase('group_search''style'''falsefalse$languageid),
  
'usercp'         => fetch_phrase('group_user_control_panel''style'''falsefalse$languageid),
  
'usernote'       => fetch_phrase('group_user_note''style'''falsefalse$languageid),
  
'whosonline'     => fetch_phrase('group_whos_online''style'''falsefalse$languageid),
  
'showgroup'      => fetch_phrase('group_show_groups''style'''falsefalse$languageid),
  
'posticon'       => fetch_phrase('group_post_icon''style'''falsefalse$languageid),
  
'userfield'      => fetch_phrase('group_user_profile_field''style'''falsefalse$languageid),
  
'bbcode'         => fetch_phrase('group_bb_code_layout''style'''falsefalse$languageid),
  
'help'           => fetch_phrase('group_help''style'''falsefalse$languageid),
  
'editor'         => fetch_phrase('group_editor''style'''falsefalse$languageid),
  
'forumdisplay'   => fetch_phrase('group_forum_display''style'''falsefalse$languageid),
  
'forumhome'      => fetch_phrase('group_forum_home''style'''falsefalse$languageid),
  
'pagenav'        => fetch_phrase('group_page_navigation''style'''falsefalse$languageid),
  
'postbit'        => fetch_phrase('group_postbit''style'''falsefalse$languageid),
  
'posthistory'    => fetch_phrase('group_posthistory''style'''falsefalse$languageid),
  
'threadbit'      => fetch_phrase('group_threadbit''style'''falsefalse$languageid),
  
'im_'            => fetch_phrase('group_instant_messaging''style'''falsefalse$languageid),
  
'memberinfo'     => fetch_phrase('group_member_info''style'''falsefalse$languageid),
  
'memberlist'     => fetch_phrase('group_members_list''style'''falsefalse$languageid),
  
'moderation'     => fetch_phrase('group_moderation''style'''falsefalse$languageid),
  
'modify'         => fetch_phrase('group_modify_user_option''style'''falsefalse$languageid),
  
'new'            => fetch_phrase('group_new_posting''style'''falsefalse$languageid),
  
'showthread'     => fetch_phrase('group_show_thread''style'''falsefalse$languageid),
  
'smiliepopup'    => fetch_phrase('group_smilie_popup''style'''falsefalse$languageid),
  
'subscribe'      => fetch_phrase('group_subscribed_thread''style'''falsefalse$languageid),
  
'whoposted'      => fetch_phrase('group_who_posted''style'''falsefalse$languageid),
  
'threadadmin'    => fetch_phrase('group_thread_administration''style'''falsefalse$languageid),
  
'navbar'         => fetch_phrase('group_navigation_breadcrumb''style'''falsefalse$languageid),
  
'printthread'    => fetch_phrase('group_printable_thread''style'''falsefalse$languageid),
  
'attachmentlist' => fetch_phrase('group_attachment_list''style'''falsefalse$languageid),
  
'userinfraction' => fetch_phrase('group_user_infraction''style'''falsefalse$languageid),
  
'subscription'   => fetch_phrase('group_paid_subscriptions''style'''falsefalse$languageid),
  
'announcement'   => fetch_phrase('announcement''global'''falsefalse$languageid),
  
'visitormessage' => fetch_phrase('group_visitor_message''style'''falsefalse$languageid),
  
'humanverify'    => fetch_phrase('group_human_verification''style'''falsefalse$languageid),
  
'socialgroups'     => fetch_phrase('group_socialgroups''style'''falsefalse$languageid),
  
'picture'        => fetch_phrase('group_picture_comment''style'''falsefalse$languageid),
  
'ad_'            => fetch_phrase('group_ad_location''style'''falsefalse$languageid),
  
'album'          => fetch_phrase('group_album''style'''falsefalse$languageid),
  
'tag'            => fetch_phrase('tag''global'''falsefalse$languageid),
  
'assetmanager'   => fetch_phrase('group_asset_manager''style'''falsefalse$languageid),
  
'css'            => fetch_phrase('group_css''style'''falsefalse$languageid),
  
'block'          => fetch_phrase('group_block''style'''falsefalse$languageid),
  
'facebook'           => fetch_phrase('group_facebook''global'''falsefalse$languageid),
  
'aaa'            => 'AAA Old Backup'
); 

to

PHP Code:

if (THIS_SCRIPT == "")  //Check if being run from front end or back end. Admincp-template.php has no script defined
{
  
$only = array
  (
    
// phrased groups
    
'buddylist'      => fetch_phrase('group_buddy_list''style'''falsefalse$languageid),
    
'calendar'       => fetch_phrase('group_calendar''style'''falsefalse$languageid),
    
'faq'            => fetch_phrase('group_faq''style'''falsefalse$languageid),
    
'reputation'     => fetch_phrase('group_user_reputation''style'''falsefalse$languageid),
    
'poll'           => fetch_phrase('group_poll''style'''falsefalse$languageid),
    
'pm'             => fetch_phrase('group_private_message''style'''falsefalse$languageid),
    
'register'       => fetch_phrase('group_registration''style'''falsefalse$languageid),
    
'search'         => fetch_phrase('group_search''style'''falsefalse$languageid),
    
'usercp'         => fetch_phrase('group_user_control_panel''style'''falsefalse$languageid),
    
'usernote'       => fetch_phrase('group_user_note''style'''falsefalse$languageid),
    
'whosonline'     => fetch_phrase('group_whos_online''style'''falsefalse$languageid),
    
'showgroup'      => fetch_phrase('group_show_groups''style'''falsefalse$languageid),
    
'posticon'       => fetch_phrase('group_post_icon''style'''falsefalse$languageid),
    
'userfield'      => fetch_phrase('group_user_profile_field''style'''falsefalse$languageid),
    
'bbcode'         => fetch_phrase('group_bb_code_layout''style'''falsefalse$languageid),
    
'help'           => fetch_phrase('group_help''style'''falsefalse$languageid),
    
'editor'         => fetch_phrase('group_editor''style'''falsefalse$languageid),
    
'forumdisplay'   => fetch_phrase('group_forum_display''style'''falsefalse$languageid),
    
'forumhome'      => fetch_phrase('group_forum_home''style'''falsefalse$languageid),
    
'pagenav'        => fetch_phrase('group_page_navigation''style'''falsefalse$languageid),
    
'postbit'        => fetch_phrase('group_postbit''style'''falsefalse$languageid),
    
'posthistory'    => fetch_phrase('group_posthistory''style'''falsefalse$languageid),
    
'threadbit'      => fetch_phrase('group_threadbit''style'''falsefalse$languageid),
    
'im_'            => fetch_phrase('group_instant_messaging''style'''falsefalse$languageid),
    
'memberinfo'     => fetch_phrase('group_member_info''style'''falsefalse$languageid),
    
'memberlist'     => fetch_phrase('group_members_list''style'''falsefalse$languageid),
    
'moderation'     => fetch_phrase('group_moderation''style'''falsefalse$languageid),
    
'modify'         => fetch_phrase('group_modify_user_option''style'''falsefalse$languageid),
    
'new'            => fetch_phrase('group_new_posting''style'''falsefalse$languageid),
    
'showthread'     => fetch_phrase('group_show_thread''style'''falsefalse$languageid),
    
'smiliepopup'    => fetch_phrase('group_smilie_popup''style'''falsefalse$languageid),
    
'subscribe'      => fetch_phrase('group_subscribed_thread''style'''falsefalse$languageid),
    
'whoposted'      => fetch_phrase('group_who_posted''style'''falsefalse$languageid),
    
'threadadmin'    => fetch_phrase('group_thread_administration''style'''falsefalse$languageid),
    
'navbar'         => fetch_phrase('group_navigation_breadcrumb''style'''falsefalse$languageid),
    
'printthread'    => fetch_phrase('group_printable_thread''style'''falsefalse$languageid),
    
'attachmentlist' => fetch_phrase('group_attachment_list''style'''falsefalse$languageid),
    
'userinfraction' => fetch_phrase('group_user_infraction''style'''falsefalse$languageid),
    
'subscription'   => fetch_phrase('group_paid_subscriptions''style'''falsefalse$languageid),
    
'announcement'   => fetch_phrase('announcement''global'''falsefalse$languageid),
    
'visitormessage' => fetch_phrase('group_visitor_message''style'''falsefalse$languageid),
    
'humanverify'    => fetch_phrase('group_human_verification''style'''falsefalse$languageid),
    
'socialgroups'     => fetch_phrase('group_socialgroups''style'''falsefalse$languageid),
    
'picture'        => fetch_phrase('group_picture_comment''style'''falsefalse$languageid),
    
'ad_'            => fetch_phrase('group_ad_location''style'''falsefalse$languageid),
    
'album'          => fetch_phrase('group_album''style'''falsefalse$languageid),
    
'tag'            => fetch_phrase('tag''global'''falsefalse$languageid),
    
'assetmanager'   => fetch_phrase('group_asset_manager''style'''falsefalse$languageid),
    
'css'            => fetch_phrase('group_css''style'''falsefalse$languageid),
    
'block'          => fetch_phrase('group_block''style'''falsefalse$languageid),
    
'facebook'           => fetch_phrase('group_facebook''global'''falsefalse$languageid),
    
'aaa'            => 'AAA Old Backup'
  
);
}
else 
//Used in the front end, use the less-query version
{
  
$only = array
  (
    
// phrased groups
    
'buddylist'      => $vbphrase['group_buddy_list'],
    
'calendar'       => $vbphrase['group_calendar'],
    
'faq'            => $vbphrase['group_faq'],
    
'reputation'     => $vbphrase['group_user_reputation'],
    
'poll'           => $vbphrase['group_poll'],
    
'pm'             => $vbphrase['group_private_message'],
    
'register'       => $vbphrase['group_registration'],
    
'search'         => $vbphrase['group_search'],
    
'usercp'         => $vbphrase['group_user_control_panel'],
    
'usernote'       => $vbphrase['group_user_note'],
    
'whosonline'     => $vbphrase['group_whos_online'],
    
'showgroup'      => $vbphrase['group_show_groups'],
    
'posticon'       => $vbphrase['group_post_icon'],
    
'userfield'      => $vbphrase['group_user_profile_field'],
    
'bbcode'         => $vbphrase['group_bb_code_layout'],
    
'help'           => $vbphrase['group_help'],
    
'editor'         => $vbphrase['group_editor'],
    
'forumdisplay'   => $vbphrase['group_forum_display'],
    
'forumhome'      => $vbphrase['group_forum_home'],
    
'pagenav'        => $vbphrase['group_page_navigation'],
    
'postbit'        => $vbphrase['group_postbit'],
    
'posthistory'    => $vbphrase['group_posthistory'],
    
'threadbit'      => $vbphrase['group_threadbit'],
    
'im_'            => $vbphrase['group_instant_messaging'],
    
'memberinfo'     => $vbphrase['group_member_info'],
    
'memberlist'     => $vbphrase['group_members_list'],
    
'moderation'     => $vbphrase['group_moderation'],
    
'modify'         => $vbphrase['group_modify_user_option'],
    
'new'            => $vbphrase['group_new_posting'],
    
'showthread'     => $vbphrase['group_show_thread'],
    
'smiliepopup'    => $vbphrase['group_smilie_popup'],
    
'subscribe'      => $vbphrase['group_subscribed_thread'],
    
'whoposted'      => $vbphrase['group_who_posted'],
    
'threadadmin'    => $vbphrase['group_thread_administration'],
    
'navbar'         => $vbphrase['group_navigation_breadcrumb'],
    
'printthread'    => $vbphrase['group_printable_thread'],
    
'attachmentlist' => $vbphrase['group_attachment_list'],
    
'userinfraction' => $vbphrase['group_user_infraction'],
    
'subscription'   => $vbphrase['group_paid_subscriptions'],
    
'announcement'   => $vbphrase['announcement'],
    
'visitormessage' => $vbphrase['group_visitor_message'],
    
'humanverify'    => $vbphrase['group_human_verification'],
    
'socialgroups'     => $vbphrase['group_socialgroups'],
    
'picture'        => $vbphrase['group_picture_comment'],
    
'ad_'            => $vbphrase['group_ad_location'],
    
'album'          => $vbphrase['group_album'],
    
'tag'            => $vbphrase['tag'],
    
'assetmanager'   => $vbphrase['group_asset_manager'],
    
'css'            => $vbphrase['group_css'],
    
'block'          => $vbphrase['group_block'],
    
'facebook'           => $vbphrase['group_facebook']
  );



satlazone 03-25-2012 02:39 PM

and if i want to just use addthis for analytics?

BirdOPrey5 03-25-2012 04:50 PM

If you go to addthis.com you can get your own addthis userid and add it to the mod. This will allow you to use basic analytics (you will get a report in email with recent shares and such.)

If you want to use their advanced tracking features then don't use this mod.

Naijasite 03-25-2012 07:59 PM

Wooo it works well on http://www.naijafinder.com/forum.php

Emeralda 03-26-2012 10:54 AM

Quote:

Originally Posted by BirdOPrey5 (Post 2309861)
To edit the the image (the "thumbs up") easiest way would be to replace (overwrite) the image "share_like.png" (in images/misc/) with one you do want to use.

If you have to do more specific editing the code is not in a template, I never intended it to be edited- but if you want to try you need to go to the Plugin on the "parse_templates" hook and find the line:

PHP Code:

         $template_hook['forumhome_wgo_pos5'] .= '<div id="wgo_bopshare" class="wgo_subblock section"><h3 class="blocksubhead"><img src="'.$vbulletin->stylevars['imgdir_misc']['imagedir'].'/share_like.png" alt="Share" />'.$vbphrase['bop5_share_this_forum'].'</h3><div>'$moreshare '</div></div>'


Rawr, thanks, I somehow skipped this reply before >.<

Before: http://prntscr.com/7f8t4
After: http://prntscr.com/7f8tz

But I think the way I try to insert the code is somehow wrong, because before there was this nice space on the lower part: http://prntscr.com/7f8u9 but now there's none: http://prntscr.com/7f8wh

Here's how I've inserted the image:

PHP Code:

$template_hook['forumhome_wgo_pos5'] .= '<div id="wgo_bopshare" class="wgo_subblock section"><img src="images/misc/konata4.gif" alt="" style="float:left; margin: 3px 10px 3px 3px" /><h3 class="blocksubhead"><img src="'.$vbulletin->stylevars['imgdir_misc']['imagedir'].'/share_like.png" alt="Share" />'.$vbphrase['bop5_share_this_forum'].'</h3><div>'$moreshare '</div></div>'


BirdOPrey5 03-26-2012 11:26 AM

I'm not sure what is causing the space to be removed but you can force it back with this code:

Code:

$template_hook['forumhome_wgo_pos5'] .= '<div id="wgo_bopshare" class="wgo_subblock section"><img src="images/misc/konata4.gif" alt="" style="float:left; margin: 3px 10px 3px 3px" /><h3 class="blocksubhead"><img src="'.$vbulletin->stylevars['imgdir_misc']['imagedir'].'/share_like.png" alt="Share" />'.$vbphrase['bop5_share_this_forum'].'</h3><div>&nbsp;&nbsp;&nbsp;'. $moreshare . '</div></div>';

Emeralda 03-26-2012 11:32 AM

It doesn't seem to be it, it put the buttons lower, instead of more to the right:

Before: http://prntscr.com/7f9tw
After: http://prntscr.com/7f9to


All times are GMT. The time now is 05:21 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.03427 seconds
  • Memory Usage 1,995KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_code_printable
  • (4)bbcode_php_printable
  • (2)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (3)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete