When it's all said and done, nobody minds that you want to improve the code on this site Dark. What is torking people is that you seem to need some official title and label to do it.

When Kirby makes suggestions about my code, I listen to it. He has earned my respect and I know he knows his stuff. He doesn't need a label, and I don't get the feeling that he's running around judging code. I get the feeling that he's interested in the mod and is entering a conversation about improving it. No label. No committee. Just better code when he's done.

You don't need a committee to improve the code here. You need manners, a good reputation and tact. (I'm not saying you don't have those things. I'm just saying that anybody who is going to run around making corrections needs them.)

The last go around with the committee idea was killed by ego. And, I'm not getting a warm fuzzy feeling this go around either.

One final point, I could care less about the coding style of the mods posted here. Why? What I am looking for is IDEAS. I am looking for the creative mind that comes up with things that make vbulletin better. I seldom use mods exactly as they are written. You wouldn't recognize a lot of the Inferno Quiz any more on my site. I've gutted it and made it what I need. Zero's coding style is certainly nothing like Jelsoft's , but it's clearly organized and easy to read. Good enough for me.

And, if your labels drive away even one coder, this place loses. Such a small minority contributes anything around here so as it is. RELEASE good code as examples. Help improve the mods you use. Contribute. Be a peer and not a judge. You get the results you want, and you haven't insulted anybody.

Amy

Its to satifsy all the wackos that insist on debating 'is it a mod or a hack?'.

Much in the same way a train wreck forces you to stare.

A very wise lady just made that post. Good one, Amy. ;)

Best post in this thread ( other than maybe my retard in olympics pic :) ) thanks amy.



~Curt

Couldn't have said it any better myself. Kirby has helped me many times in my threads with code. Hes not judging me, he is telling me there is an eaiser way to do what I did. And it's up too me if i want to update my code. Normaly, I will...

That's because YOU are a coder...some of us HAVE to use the codes EXACTLY as written, Amy, we have NO OPTION! We are NOT coders, remember?

I've never said use a label. I simple said do not release non-valid code to the unsuspecting public. Liz

You may be right. This site probably needs a warning label. It should clearly say that the code released here is written by unpaid hobbyists. Use it at your own risk. But, that's a different topic.

I am all for the system if they can do it without labeling anyone. ;)

Is there one for PHP?

Yap. And you may never know which one of my hacks will have the destroying code, cause from now on I am going to release all my hacks one-lined and hopefully double-encoded with ionCube and Zend. ;)

I never said that I want a title. What I want is an ability to mark hack threads as either "optimized" or "not optimized"... This mark does not necessarily need to be output into HTML, but the end-users should have an option to filter out the threads with that mark, using a specially formed URL or a usercp option.

See, those who care about their board should have a right to know how safe is it to install a certain hack. They should, therefore, have an option to filter out only those hack threads that have been marked as "optimized".

I, personally, care how well my board runs and that's why I think twice before installing any hacks that have unoptimized code or queries... This is why I click "INSTALL" on so many hacks without actually installing them later. I click it just because I like the idea and would like to review the hack later and see if it is worth installing (taking into account the code).

If the majority of this community's members do not care about their board, it's either because they are end-users who do not know much about programming, because they are end-users who are obsessed with installing all different kinds of hacks on their board, or because they are coders who care only to quickly finish the code and receive the results, without actually caring how safe or right the code is. Often the latter end up in writing "2 + 2 + 4 - 1 + 10 - 1" instead of simply writing "2 + 14".

Those, who want their boards clean, should in my opinion have the opportunity to know what they are installing without having to download the hack and read through its code, esspecially if they are not programmers and for that reason simply are not able to do it...

"non-valid" is a label.

There is no need for this - vb.org seems to have survived without this for a number of years - and as this thread clearly demostrates, all it will do is cause division and bad feeling.

I agree- as I stated earlier in this thread, a "beta- please help me with this hack" forum would be great! no stigma, no labels- just learning/teaching community helping kinda stuff.

Why is everyone so afraid of labels? You use them already under your name. Coder, Adv.Coder, etc. What's the problem? Are you afraid of being found out? Liz

No, Liz, I have no problem getting my code checked. But think of the newbies first starting out. How many of them would even think about doing another hack if they were labeled in public and felt humiliated because they didn't know as much as the more advanced coders do? Most of the people involved in this discussion have been there and would not have gotten to where they are now if they had been "labeled" in the beginning.

Yes, they are afraid of stepping up.. They want to just do those hacks and receive gratitutudes from unsuspecting public that does not know what's inside.

I am labeled as "Coder" instead of "Adv.Coder" or whatsoever. So what? I don't really care.

That's where you have the test forum...they go there first. If they can't pass the test forum, then they don't have the stigma of failing *in public*. Liz

Well, you finally got me, DV. I give up. It doesn't seem this is going anywhere anymore so I'll leave you all to it. Good luck with it. ;)

The Coder, Adv Coder, and Master Coder only seems to encourage users to create more hacks. I've never seen a user complain about being labeled because of there user title.

I have ;)

This will be my last post in this thread - In response to your threats of causing harm to someone's database I will be reporting you to several members of the Jelsoft staff for these threats...

You can argue your ideas and thoughts about so called valid code all day long - You refuse to understand the viewpoints of people who I consider to have more worth and who I respect who also happen to share my concerns - We can see yours, and are responding with the downside...

Should such a system be implemented, I shall no longer release modifications here, and will remove any that I have - If people wish to view or use my modifications I shall either host them on my own site, or band together with other respected coders to create a vBulletin.org-esque site free from these labels...

What you fail to realise is that this community has been going for almost 4 years - In these 4 years, up until now, such a system has been unnecessary - We have managed without it and we still can...

I hope you enjoy arguing your viewpoint - I can't see any good coming from it...

Satan

I guess there are dozens.
Here a few (from the first Hit returned by Google :D)
http://www.bierkandt.org/beautify/
http://www.tote-taste.de/X-Project/beautify/
http://www.semdesigns.com/Products/F...Formatter.html

Btw: I think everybody should try to clam down.
This discussion is getting way too hot, and that's not worth it IMHO.

I think there are valid points on both sides, but enforcing some kind of labeling seems to out of question.

I can't see why there shouldn't be some opt-in system for those who would like to have their Hacks reviewed/rated?.
That should hurt nobody, would be of benefit for Coders and Users - and those willing to review Hacks have smth. to do :)

That statement really gets to me. I've already reported that statement to Jelsoft. I now know not to ever use any of your hacks.

I agree with you, Kirby. I think having someone help you see where you can make it better is a great idea. I just don't agree with labeling anyone for not knowing as much as someone else already does.

Do it, if it will make you sleep better :) Good luck.

Chill, son. It was a joke. Seriously, who in their right mind would even think of double-encoding their scripts?

Does it look like I am supposed to care?

That would be a minority, consisting of those who have no will-power to stand out. All I can do is express my condolences towards them.

KirbyDE, Boofo

Thanks :)

--

Now would you please make a test run of the system? After all, 6 people have said "yes", and we can awlays cancel it if it doesn't work out. As already said, it can be without any visual labels, even though it would be better if there were some labels (the ones Revan suggested).

Exactly!

No labels, and you have my support. ;)

I'd agree to no labels as long as there is an optional filter, available to everyone. The same way as there in a option "Display Last X Threads", "Sort by X" etc..

double-encoding your scripts isn't what gets to me.

It's still a label. ;)

Maybe helping us learn the proper coding techniques will pay off more in the end that trying to start labeling anyone. ;)

Ah... I see. Then we have a serious problem ;)

Waste of time. The techniques are available at vbulletin.com and you know it.

What I really want to know is:
How is it possible to show to the end-user - which is for whom we are even discussing this in the first place - that a hack has been Verified/Approved/Optimised/$vbphrase[whatever_the_bluest_of_fks_youd_call_it], without adding a label of some sorts?

By, us, I didn't necessarily mean me. ;)

Coming to you guys for help isn't enough? You want to make them feel smaller still?

where is that info

Well, by trial and error, *I'VE* already figured out who to avoid around here. Liz

In the Manual, Appendix 4 (vBulletin Code Standards)
http://www.vbulletin.com/docs/html/codestandards

Kirby, has it been updated to 3.5? Liz

You can't... :( But you can still filter them out. Which is unnoticable.

Of course you did. Come on, Mod, take responsibility for your words. ;)

http://www.vbulletin.com/docs/html/codestandards

Care to share? :P

Even though I am not Kirby, no it was not updated. I don't think anything has changed...

One things that does come to mind about such a system is PHPBB's mod-approval system. I remember reading a post in which someone from their "QA" team said "Due to the amount of mods in the queue waiting to be processed, it may take a month or more before they are released" (or words to that effect)

If such a system where put in place here, then the same problem could occur.

In the first post of this thread, where does it say anything about approval?

DV, no, I'm not into embarrassing anyone. It's enough that I know that I won't touch that person's code or mods. Liz

globalize became $vbulletin->input->clean_[array_]gpc() and $DB_site became $db, but those changes are pretty minor - just the examples need an update.