This hack doesn't require any changes to be made to admin/index.php and never has. The only admincp file that this hack requires changes to is admin/forum.php.

NOW I FEEL STUPID!!!

...I really should learn to read. Thanks mate.
Installed sucessfully on 2.2.5. :)

I LOVE this mod!!!

I have multiple levels on my forums and have modified my templates quite a bit so they will display like I want them to. The site is http://www.aephirsden.com/forum and when you see it you will see what happens... On my levels where there are the third level I show if you close the first level above it then it only closes what would have been forums under it, so when I have all the first level categories closed, the second level categories still show. I want to close everything under each first level...

I'm gonna be playing with my code to try to fix it but I don't know exactly how you have it working yet ;)

On a final note, I use Linux 2.2.19 and KDE 2.1.2 and my Konquerer will view the page, and when you close a section it covers the sub parts up with what appears to be the background color, but doesn't move them up. Also, if I collapse 2+ of them, then try to uncollapse any of them then it crashes the browser... Kind of a pain during the setup... But it's in now ;) The attached image is the screenshot of my forum currently when viewed under Konquerer.

Khepri

nice hack, works great!!

The collapse problem is due to the html your templates.

Some of the problems you mention are directly related to kde 2.1.x, whilst others are a result of your html.

Finnally there is a problem (not exhibited on your site) with konq its self and the w3c defined function "hasfeature", which isn't fully supported by konq and pretty well unwork aroundable whilst most konquerer users spoof other browsers in the user agent string.

Any suggestions on how to modify either the templates or other code to make it collapse second and third levels when I perform the action from the first level.

Khepri

Firstly, the *no_post templates should be near uniform. That is "forumhome_forumbit_level2_nopost" should contain.
inplace of
That "forumhome_forumbit_level3_post" contains.
in place of

Ok, did that... same results as what I had before. I'll leave the mod on that portion for now too. Check it out now at http://www.aephirsden.com/forum and go down to the main category of professions, you'll see sub cats, and forums only under the sub cats. If you collapse the main category professions, it hides the bars with the sub cats but leaves all the forums under the sub cats so you really can't tell which sub cat each of the forums is supposed to be under.

I had done this before which is what prompted me to look into this deeper initially.

Khepri

The first thing that hit me, is your still using the older javascript.

Ok, got the new jscript info in there. But it still does the same thing. Sorry about earlier, I thought I had the new script in there but when I took out the old it copied it, then pasted it in again. ::mumbles::

Khepri

Khepri, the forumhome_forumbit_level2_nopost template needs to be modified.

so the first line reads
then the forumhome_forumbit_level2_post template needs to be modified to remove the <smallfont>? before $expandcontract

As a example of what happens once said afterations are made, I've grep'd your index page and attached pre modified version to compare against.

Thanks a TON!!!

They work GREAT!

Khepri

I'm having some problems with this hack on 2.2.5 saving the preferences of a user. It does not write to the "forumviewset" field.

I have read through the readme and this thread looking for answer and I reinstalled. I have updateindex.php in my forums directory, and the other two files in my admin directory. I also made the changes for the Template_options.php

Any ideas?

Hmm, sounds like the installation is good.

Out of interest what happens when you manually collapse a forum by using the url:

updateindex.php?fid=<forumid>&val=1

I'm having problems getting mine to collapse. I hit the minus, and it doesn't close, Then I notice the javascript error go off in the corner.

the address is: http://forums.yosc.net/index.php

I installed it to the readme, and I updated/added the templates. And where do I add the stuff in the "Template_Options.txt" file go?

Thanks,
CDknight

Regarding the template_option, if you don't know what it is then you don't need it. It is provided strictly as option to collapse forums with a heavly modified style.

Moving on to the javascript error, you are not including the required javascript onto the page and acordingly need to modify the forumhome template to include $expandcontractscript. That is if the forumhome_expandjscript template is present. Both of which are discribed in the readme.

I get a blank screen. Seems like it worked.

My "forumviewset" is still set to the default " : " for my userid after I ran updateindex.php

I'm a bit confused here.

Okay, that explains things nicely.

The blank page you recieved means the file was unable to include one of its required files. For this getforumview.php needs to be in the admin directory eg ./admin/getforumview.php.

Sadly ... I have both "getforumview.php" and "getbrowser.php" in the /admin directory.

Hmm, find attached a debugging version of updateindex which will echo its output as it goes along. Please tell me the point at which it stops. To use this version remove the .test from the filename and replace the version of updateindex contained in the forum root, and then reattempt to manually collapse a forum as described in the post a further back.

Ok here is what I got:

loading...
Warning: Cannot add header information - headers already sent by (output started at /web/pbc2/beta225/updateindex.php:3) in /web/pbc2/beta225/admin/functions.php on line 1544
included globalincluded requiredforumid or value was not set

Here is Function.php lines:

1543 if ($cookiedomain) {
1544 setcookie($name, $value, $expire, $cookiepath, $cookiedomain, $secure);
1545 } else {
1546 setcookie($name, $value, $expire, $cookiepath, '', $secure);
1547 }

Bizare, what version of php?
and what value where you using for <forumid> in the url?

PHP Version 4.2.0

and

Forumid = 58

/updateindex.php?fid=58&val=1

register globals are on?

Yes: register_globals = On

Would this cause a problem:
; Magic quotes
magic_quotes_gpc = Off
magic_quotes_runtime= Off
magic_quotes_sybase = Off

FYI: Ok I tried it with quotes_gpc ON and it didn't work still.

Now I restarted my machine, ran updateindex.php again and now it says this:

loading...included globalincluded requiredforumid or value was not set

Try this php4.2.0 tailored version of update index.

The correct result is to recieve the message "done".

Incorrect results will result in "error" being displayed, whilst semi incorrect results will echo back the values entered for forumid and val.

Ok now it is writing to the DB but everytime I reload the forumhome the table is still expanded.

I get this on the return from updateindex.php that you sent in the above post for 4.2:

58|:done

Wow, I wasn't expecting that result... (the number portion).

Is this a new installation of the hack, or have you previously had this working under a older version of vbulletin?

Find attached a newer version of the getforumview.php file.. which hopefully should write correct data to the database.

It is started to install this hack on my database a ways back and never used it.

I installed the new getforumview.php and it is still showing the forumhome tables expanded.

Now this may be a bit unreadable because the code is in beta but here is one of the forumhome tables...keep in mind I am using the Template_options. hack too that adds the "Forum...Posts...Thread...Last Post" to each main section.

The html looks roughly correct.

When you look at the raw user table in say phpmyadmin does the "forumviewset" column for your? userid have a entry like "57|1:" if it doesn't please try this debugging version of getforumview.php which will output details to help in cureing this bug.

The numbers in "forumviewset" look like this: 59|:192|:

I ran the debugging getforumview.php and ran updateindex.php manually and it output this:

65Array ( [59] => [192] => ) done

However, it did not set any value to "forumviewset" so now it is blank.

I'm having similar problems to Virtuetech on my board at http://www.shadowedsoul.com/forums.

The interesting thing to me is the hack works perfectly after following along with all the updates to files you've given as of now for 4.2.0 installs when Im not logged in. As soon as I log in I start getting page errors like this when I try to expand or contract.

Line: 563
Char: 1
Error: Object expected
Code: 0
URL: http://www.shadowedsoul.com/forums/index.php?s=<sessionID>

When I manually call

/updateindex.php?fid=6&val=0

and

/updateindex.php?fid=6&val=1

the hack works properly, it just doesnt work when Im trying to click my expand and contract buttons.

It didn't work for me...

Can you supply me with the mysql code that will undo the changes that were made to the database with the cx_install.php file?

That error idicates that the javascript is not being included. Compare the source output of logged in and not logged in to check that is in both cases.


I am aware of some problems still lingering with this hack and php 4.2.x so will be releasing a new version of the complete hack by the end of the week to correct these issues.

Henry-RS:
The SQL is
ALTER TABLE forum DROP collapsed
ALTER TABLE user DROP forumviewset

Thanks Dabean....I'll be anxiously awaiting your next post

Yep looking at the two sources the javascript is in one but not the other which is interesting since I thought they would both generate off the same templates and php files.

EDIT: Figured out my problem. I slipped up and put my code above the } in the

addition to index.php. Thanks for the lead that helped me track this down.

Updated the zip to include PHP 4.1.x and 4.2.x support.
Also tested this new version on vb2.2.6.

This hack can now safely be used with register globals turned off and has been tested accordingly.

To update from a older version just upload the new files. updateindex.php, getbrowser.php and getforumview.php.

There is no need to re-run the installer, however the installer can now remove the database changes.

Test configurations where
- Apache 1.3.23 + PHP 4.2.0 (freebsd)
- Apache 1.3.17 + PHP 4.1.1 (redhat7)
- IIS5.1 + PHP 4.2.1 (winxp)