This is a brilliant mod! Thanks for sharing. Working great on 4.1.5

Not that it matters much and is a quick fix, but you forgot to translate the phrase $vbphrase[sprite_navgroup_configuration] to english :)

Also, the attachment icon looks a bit weird. See attached image. How to fix this?

this mod is great but it gave me a hard time. For some reason it HIDED must of the forum images.

So I Un-Install until I know how to fix it

thanks

I am testing this I get error on refresh

Default Style
Error occurred: Your sprite folder is not writeable. Please check the permissions on the directory "".

Where can I modify the directory? What is the default directory so I can make it writable.

thanks

www.yoursite.com/forums/images/sprites

Folder needs to be 755.

Hello archet1337,

the problem is, that you are not using GD-Libary 2.0.36 (or later) and your image isn't using "color RGBA", but "gray+alpha". You can tell this problem by the vertical lines you get.

GD had a problem handling grayscale images with alpha channel correctly, wich was fixed with GD 2.0.36 in the Year 2007.

https://bitbucket.org/pierrejoye/gd-...361a31aab/NEWS

The solution is to update the GD-Libary to 2.0.36 (or later) or replace every file which uses "gray+alpha" with an version using "color RGBA".

I would advise to update the GD-Libary, cause there is also a serious security problem, that was fixed in the Year 2009 by Debian.

I am really shocked by this, since you are now the sixth person with this kind of problem and this fix is 4 years old and since 2 years known als high security fix by debian.

Best regards
Sebastian

Hello FReeSTER,

what exactly is your problem? i dont understand what you mean.

Best regards
Sebastian

Thanks still have an issue with the error above.

Tried also in Vbulletin 3.8:

Warning: array_merge() [function.array-merge]: Argument #1 is not an array in [path]/global.php(355) : eval()'d code on line 56

Fatal error: Class 'vB_Template' not found in /home/user/public_html/forum/index.php(596) : eval()'d code on line 157

I don't have time to hack it up for Vbulletin 3.8 but hopefully somebody does.

Hello popmyzit,

please look into the StyleVar imgdir_sprite. Since your error message just says

Ik looks like this StyleVar is empty on your system, you could use as a value the default sprite folder of vBulletin:

Best regards
Sebastian

Hello ZeroHour,

i just want to inform you, that i didnt forget your problem, but i didnt have the time to give you a solution at the moment.

Best regards
Sebastian

Thanks Sebastian will try the above,

best

I ran the Google Page Speed Test and My score still stinks :) It suggested that I run Css Sprites even though I put this Hack on and it appears that I have sprites in the Image Directory that was made too.

But i suppose you do see an improvement?

Yes, google will still show up css sprites beeing an issue since gradients can't be included in the sprite since they are highly dependend on styles. But since they are mostly <10px google says you should combine them.
In addition, if you have some addons installed google might pick up on pictures those addons include.

And there of course is allways the option of using the 'add_custom_image_to_sprite' hook we provide in our addon, where you can add additional custom icons your board uses.

Aside that, i have to ask this, did you make the required template changes? Without them your board won't be using the sprite.

Hi Moof, can you provide some sort of instruction to add custom icons to your (super-great) plugin?

After running the google speed test, I noticed that there is still 27 images that is not turned into css sprites.

How do I add these as well?

Most of them are in my additional.css template.

Yes, I did make ther required Template changes and the listing of images they mention that should be made into CSS Sprites are these ..

GlossyHeader.png
collapse.png
collapse_40b.png
lastpost-right.png
search.png
widget-comment.png
selected-tab-gradient-with-top-alpha.png
icon1.png
arrow.png
bottom-shadow.png
event.png
facebook_login.gif
forum_stats.png
legend.png
navbit-home.png
rss_40b.png
tab-collapsed.png
forum.png
profile.png
category-16.png
forum_link-16.png
forum_new-16.png
forum_old-16.png
post_old.gif

Tough for me to say if there's been an improvement since I didn't run the test before hand. I'm trying to make other optimizations and work on the Leverage caching. My score of 54 is pretty bad :)

Those should be covered by the addon (if you made all template changes). If they are not you are probably using some what's going on block modification - then you should search for them manually and replace them.

I'm going to translate the custom_icon_add instructions we have posted on vb-ger.org right now, as a warning. They are what i would call advanced. ;)

How-To:
Include custom icons to your sprite:

!Warning! very advanced - if you do not know what you are doing. Stop right here.


Custom icons are added via plugin and hook

• In the ACP create a new plugin
  • Add-on: vBulletin
  • Hook: sprite_add_icon
  • Titel: choose your own title. whatever makes sense for you
  • execution order: 5
  • PHP-CODE: (this is an example, path would be your icon, css would be the name of your icon!)
    
    Code:

    ---

    $files[] = array(
    'path'    => $stylevars['imgdir_siteicons']['imagedir'] . '/add.png',
    'css'    => 'siteicons_add',
    'rollup'  => $CSS_FORUMHOME_ROLLUP,
    'height' => 23,
    'width' => 24,
    'padding' => array(
        'top'    => 4,
        'right'  => 4,
        'bottom' => 4,
        'left'  => 4
    )
);

    ---

• As for the rollup part. Right now allways use $CSS_FORUMHOME_ROLLUP - in later versions we will have different sprites for FORUMHOME and SHOWTHREAD (f.e.) - then you can choose which one. right now stay with Forumhome.
• height, width and padding are optional. If you do not need them, delete all of those array values.
• set it to active
• save
• refresh css sprites
• modify the template in which your sprite is placed
  search
  
  Code:

  ---

  <img srv="http://....customimage.png"  />

  ---

  replace
  
  Code:

  ---

  <span class="sprite_custom_siteicons_add" title="custom image"></span>

  ---

• the icon should be loaded via the sprite now

I hope it helps. And do not say i didn't warn you. It is advanced. :p

I'm sorry if I made you think too much today. I just realized that I only applied the Template Changes for this version not all of the previous ones. If I had any knowledge of what TMS does I'd use that, seems easier than having to go do all of these manual edits :)

Thanks Mooff, that helps a lot :)

But some of the images I have to replace is defined in additional.css.

Do I have to find where they are called in the forumhome template and add the <span class="sprite....."></span> code there and remove the line from additional.css, or is there another way to do that?

Hello archet1337,

please give an full example of your situation, this would help us to give you the best solution :)

Best regards
Sebastian

Just installed and I get this when I run refresh. ?

/home/xxxxxx/public_html/forums/images/statusicon/forum_new_lock-16.png (with bburl_path / ) does not exist or is not readable.
/home/xxxxxx/public_html/forums/images/statusicon/forum_old_lock-16.png (with bburl_path / ) does not exist or is not readable.

Those images appear chopped of at the bottom in firefox even look worse in IE.

Hi Andyrew,

both images currently doesnt exists within vBulletin, but there are possibile values for:

I think i will remove these until they are delivered by vBulletin, to cause less confusion.

What did you mean by that? Please provide more details (an images maybe or your site-url) to this problem.

Best regards
Sebastian

Many of the icons don't look correct when I enable your plugin.

You are not using the latest Version.
This first bug is fixed in 0.7.1 (showthread icons)
The attachment icon is due to a bug in GD version 2.0.35. A version which is >4 years old and has some security issues which were fixed 4 years ago.

We need more infos on the FORUMHOME icons though. We can't reproduce that. Would be great if you can link us to your site (maybe a teststyle), where we can see what is causing that behaviour.

Just noticed in the 0.7.1 zip file, the product xml that is included in there is still 0.7.0a, or atleast the version id wasn't updated to reflect the new version.

the separate xml seems to be updated but I just downloaded the zip file since it includes both

Uh-Oh....

I am missing pretty much every icon possible on my forum after I went through and did all of the template stuff.

Any idea what I did wrong?

That's the same thing happening on the skin that I have this plugin installed on

http://vgchat.info/forum/index.php?styleid=16

Also this really needs to be changed for people who have images on subdomains/cdn's like myself. Because I tried to add http://i1.vgchat.info/ to the sprite stylevars since thats the only way I know of to point it there while the forum is sitting on http://vgchat.info/forum/
I have my images there because there, they are cookie-free

If you have some image like

http://dl.dropbox.com/u/246391/Robin.png

which looks like

http://dl.dropbox.com/u/246391/Robin_result.png

in the Sprite (it is stretched and vertical lines are added), than you possible use a GD Libary older than 2.0.36.

GD had a problem handling grayscale images with alpha channel correctly, wich was fixed with GD 2.0.36 in the Year 2007.

https://bitbucket.org/pierrejoye/gd-...361a31aab/NEWS

The solution is to update the GD-Libary to 2.0.36 (or later) or replace every file which uses "gray+alpha" with an version using "color RGBA".

I would advise to update the GD-Libary, cause there is also a serious security problem, that was fixed in the Year 2009 by Debian.

I am totally shocked by this, since there seem to be a whole bunch of people with this kind of problem and this fix is 4 years old and since 2 years known als high security fix by debian.
So there seems to be a lot problem within the maintenance of servers, if some serious security issue isnt solved since 2-4 years. If you pay money for server maintenance i would be deeply shocked, if i were you.

Best regards
Sebastian

Hello Sebastian and Mooff.

I need the following images to be converted into sprites:


http://www.radioctrl.com/highslide/g...ader.white.gif
Defined in highslide.css

http://www.radioctrl.com/images/gradients/grey-up.png
Defined in socialgroups_overview.css

and stylegenerator.css

http://www.radioctrl.com/images/styl...misc/arrow.png
Defined in additional.css

http://www.radioctrl.com/images/styl...ottomBarBG.gif
Defined in additional.css

There is a couple more, but you get the idea?

What do I do to make the images defined in css files into sprites?

@exterme-gaming
The addon has CDN support since version 0.6.2 - users have confirmed it does work with CDNs. You issue has nothing to do with our addon but simply with the fact that you do not listen at all. And god knows we tried to help.

Hello extreme-gaming,

It is impossible write the contet via HTTP, since this is a read-only access.

So you can't use an URL within the styleVar imgdir_sprite as long as you refresh the sprite. After this you can move the sprite to every folder you like and change the StyleVar.

If you are using a CDN correctly, it will synchronize your folder, so there is no need to set an URL for this StyleVar. Suppport for CDN is added since 0.6.2 and is proven by other users to work.

If you are using "Domain Sharding" you can set the correct relative path based from the forum-path to your icons.

Best regards
Sebastian

Hello steeler7,

please provide us with more information, which images are missing? have you made the template changes and refresh the sprite? can you provide us with your forum url, so we can look at it ourself?

Best regards
Sebastian

www.pittsburghsportstavern.com/forum

the images missing look to be statusicons, subforum and forum variety it looks like, last post arrow ...

I did make all of the Template changes (can't guarantee I didn't make a mistake along the way. That was a lot of Editing) and then I ran a refresh of the sprite.

Thanks!

Hi, I need more info about how to do this because every time I tried it didn't recognise the new place... for example..

Hello steeler7,

i think you got a typo in your changes.

on your site it reads:

but the "1/" is wrong, it should read

So please remove the 1/

Best regards
Sebastian

Hello extreme-gaming,

If i understand you right, i can access your file via

http://vgchat.info/forum/../i1/pagination/next-left.png

and

http://vgchat.info/forum/

is your forum url?

Than please use

you could even use a URL like

or

for this stylevar.

For the imgdir_sprite StyleVar, you must use a relative path like

Best regards
Sebastian

alright I'll try that & unfortunately hostgator won't upgrade their GD version. Is there any chance this thing can use imagemagik?

They even bumped it saying...

Hello extreme-gaming,

delicious answer "fixing a security risk is not an option", so i will never use this hoster.

As a work around you can save all images with png 8-bit grey as png rgba color.

Best regards
Sebastian

and how exactly am I supposed to do that... I have 4000 images, I need an automated solution if this this is the only work around.

Hello archet1337,

i will make an example for

If there isnt any additional padding, margin, width, ... via CSS, the code f?r the files-array is:

After this, add to

the sprite class

after this, remove the

from the css-rule highslide-loading.

if the css-rule is now empty, you can of course erase the highslide-loading from

Please note, that you need to use an own sprite-image if you want to use gradients.

Best regards
Sebastian