vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 4.x Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=245)
-   -   New Posting Features - Canned Replies v4.x - User Saved Text for Replies, Threads, PMs & Infractions (https://vborg.vbsupport.ru/showthread.php?t=241309)

inigo 08-18-2011 07:30 AM

Quote:

Originally Posted by Charlie98902 (Post 2234148)
So does this or does this not work with 4.1.5 PL1? The newer files.

Yes, it works, but with the <br> problem at the beginning of each line,

xtremecoders 08-18-2011 07:42 PM

1 Attachment(s)
Ok my friends.
I really like this mod But it Breaks my SKIN when press ADD or EDIT.

So i made a fix for all those issues with new CKeditor.

This MOD now can work again without any strange problems with any VBulletin 4.1.4+ or 4.1.5+ Version.

Please also Note that ...

If you want to avoid the <br> problem, just add a space at the end of each row.
Is an editor issue which adds html <br> automatically when you have empty rows on your text or use some BB codes.


I hope this will work fine for you also.
Just read and follow the instructions inside the zip.:up:

Take the attached zip....

Attachment 132077

sevenmix 08-18-2011 08:00 PM

Quote:

Originally Posted by xtremecoders (Post 2235048)
Ok my friends.
I really like this mod But it Breaks my SKIN when press ADD or EDIT.

So i made a fix for all those issues with new CKeditor.

This MOD now can work again without any strange problems with any VBulletin 4.1.4+ or 4.1.5+ Version.

I hope this will work fine for you also.
Just read and follow the instructions inside the zip.:up:

Take the attached zip....

Attachment 132077

Thanks, it works fine, the only problem is that keeps inserting a <br> too.

Im using [CKEditor] MARCO1 Advanced Quick Reply And Edit, maybe thats the problem.

xtremecoders 08-18-2011 08:08 PM

You was FAST !!!! :D

I added comments about <br> Issue...

Quote:

Please also Note that ...

If you want to avoid the <br> problem, just add a space at the end of each row.
Is an editor issue which adds html <br> automatically when you have empty rows on your text or use some BB codes.
I'am working on this problem and probably will update the zip with new code.

inigo 08-19-2011 06:32 AM

I can´t remove de <br> although I insert a space at the end of all lines,.. any idea?

Eric 08-19-2011 11:00 AM

I do not see any difference in this zip and the changes I posted? Unless you were just zipping up the mod with my changes :/

As far as the <br> issue, I will try to work it out.

Quote:

Originally Posted by xtremecoders (Post 2235048)
Ok my friends.
I really like this mod But it Breaks my SKIN when press ADD or EDIT.

So i made a fix for all those issues with new CKeditor.

This MOD now can work again without any strange problems with any VBulletin 4.1.4+ or 4.1.5+ Version.

Please also Note that ...

If you want to avoid the <br> problem, just add a space at the end of each row.
Is an editor issue which adds html <br> automatically when you have empty rows on your text or use some BB codes.


I hope this will work fine for you also.
Just read and follow the instructions inside the zip.:up:

Take the attached zip....

Attachment 132077


sevenmix 08-19-2011 05:16 PM

Thanks, we will be waiting the perfect mod (finally)

:D

xtremecoders 08-19-2011 05:43 PM

Quote:

Originally Posted by Eric (Post 2235309)
I do not see any difference in this zip and the changes I posted? Unless you were just zipping up the mod with my changes :/

As far as the <br> issue, I will try to work it out.


BTW the Difference is on cannedreplies.php file at edit & add Functions

My file has.....

Code:

      $templater = vB_Template::create('USERCP_SHELL');
                $templater->register_page_templates();
                $templater->register('navbar', $navbar);
                $templater->register('onload', $onload);
                $templater->register('template_hook', $template_hook);
                $templater->register('cpnav', $cpnav);
                $templater->register('headinclude', $headinclude);
                $templater->register('pagetitle', $pagetitle);
                $templater->register('HTML', $HTML);
                $templater->register('header', $header);
                $templater->register('footer', $footer);
        print_output($templater->render());




Your file has.....


Code:

        $templater = vB_Template::create('USERCP_SHELL');
                $templater->register('navbar', $navbar);
                $templater->register('headinclude', $headinclude);
                $templater->register('pagetitle', $pagetitle);
                $templater->register('cpnav', $cpnav);
                $templater->register('HTML', $HTML);
                $templater->register('header', $header);
                $templater->register('footer', $footer);
        print_output($templater->render());



and in my case this was the reason which my style was complete broken on ADD or Edit... (VB 4.1.5 PL1)

And see how affects on my site....

BEFORE the patch (your File)

https://vborg.vbsupport.ru/

AFTER the Patch (my File).....

https://vborg.vbsupport.ru/

Nice ehhhh ?????

Eric 08-20-2011 03:55 AM

Quote:

Originally Posted by xtremecoders (Post 2235465)
BTW the Difference is on cannedreplies.php file at edit & add Functions

My file has.....

Code:

      $templater = vB_Template::create('USERCP_SHELL');
                $templater->register_page_templates();
                $templater->register('navbar', $navbar);
                $templater->register('onload', $onload);
                $templater->register('template_hook', $template_hook);
                $templater->register('cpnav', $cpnav);
                $templater->register('headinclude', $headinclude);
                $templater->register('pagetitle', $pagetitle);
                $templater->register('HTML', $HTML);
                $templater->register('header', $header);
                $templater->register('footer', $footer);
        print_output($templater->render());




Your file has.....


Code:

        $templater = vB_Template::create('USERCP_SHELL');
                $templater->register('navbar', $navbar);
                $templater->register('headinclude', $headinclude);
                $templater->register('pagetitle', $pagetitle);
                $templater->register('cpnav', $cpnav);
                $templater->register('HTML', $HTML);
                $templater->register('header', $header);
                $templater->register('footer', $footer);
        print_output($templater->render());



and in my case this was the reason which my style was complete broken on ADD or Edit... (VB 4.1.5 PL1)

And see how affects on my site....

BEFORE the patch (your File)

http://www.xtremecoders.org/forums/images/before.jpg

AFTER the Patch (my File).....

http://www.xtremecoders.org/forums/images/after.jpg

Nice ehhhh ?????

Ah, I see. I do not mind, I was just curious what the changes were :)

Andyrew 08-20-2011 10:42 AM

This no longer works on my forum, when I pick the canned reply nothing appears in my editor box. ?

RE installed and it's working again, just got the <br> problem now.

Andyrew 08-20-2011 06:51 PM

Quote:

If you want to avoid the <br> problem, just add a space at the end of each row.
Is an editor issue which adds html <br> automatically when you have empty rows on your text or use some BB codes.
How do you stop this br code appearing, where are you supposed to add the spaces. I have added spaces in the canned reply but it makes no difference.

mmackinnon 08-20-2011 11:37 PM

yah same here, everything working but for the BR issue

Jman423 08-21-2011 01:48 AM

This is also working for me, but as others mentioned, the <br> is still showing up whether or not there is a space at the end of each line.

Thank you for fixing it... deleting a few extra characters is better than the way it worked before.

Eric 08-21-2011 10:19 AM

Ok, for the <br> issue, this appears to correct it. Edit the /clientscript/cannedreplies.js file (the updated one in my post or xtremecoders' zip file) and replace everything with:

Code:

function insertCannedReply(text)
{
        text = text.replace(/\n/g, "");
        text = text.replace(/<br>/g, "\n");

        if (document.getElementById("vB_Editor_001"))
        {
                CKEDITOR.instances.vB_Editor_001_editor.insertHtml(text);
        }
        else
        {
                CKEDITOR.instances.vB_Editor_QR_editor.insertHtml(text);
        }
}


Andyrew 08-21-2011 10:59 AM

Thanks Eric, works perfect now. :D:up:

inigo 08-21-2011 11:05 AM

Quote:

Originally Posted by Eric (Post 2236102)
Ok, for the <br> issue, this appears to correct it. Edit the /clientscript/cannedreplies.js file (the updated one in my post or xtremecoders' zip file) and replace everything with:

Code:

function insertCannedReply(text)
{
        text = text.replace(/\n/g, "");
        text = text.replace(/<br>/g, "\n");

        if (document.getElementById("vB_Editor_001"))
        {
                CKEDITOR.instances.vB_Editor_001_editor.insertHtml(text);
        }
        else
        {
                CKEDITOR.instances.vB_Editor_QR_editor.insertHtml(text);
        }
}


Works great for me! 4.1.5 p1

Thanks!!!!!!!!!!!!

Igel1 08-21-2011 01:40 PM

But as empty lines are inserted
better that way

Code:

function insertCannedReply(text)
{
        text = text.replace(/\\"/ig, "\"");
        text = text.replace(/ \<br\>/ig, "");

        if (document.getElementById("vB_Editor_001"))
        {
                CKEDITOR.instances.vB_Editor_001_editor.insertHtml(text);
        }
        else
        {
                CKEDITOR.instances.vB_Editor_QR_editor.insertHtml(text);
        }
}

So BB code also works without <br>

Jman423 08-21-2011 02:38 PM

Quote:

Originally Posted by Igel1 (Post 2236147)
But as empty lines are inserted
better that way

Code:

function insertCannedReply(text)
{
        text = text.replace(/\\"/ig, "\"");
        text = text.replace(/ \<br\>/ig, "");

        if (document.getElementById("vB_Editor_001"))
        {
                CKEDITOR.instances.vB_Editor_001_editor.insertHtml(text);
        }
        else
        {
                CKEDITOR.instances.vB_Editor_QR_editor.insertHtml(text);
        }
}

So BB code also works without <br>

This worked for me, thanks.

sevenmix 08-22-2011 04:45 AM

Now it works perfect, thank you so much.

8thos 08-22-2011 04:56 AM

Hey Eric, the same problem with Canned Replies, is it the same problem with Post Templates? https://vborg.vbsupport.ru/showthread.php?t=242246

angeljs 08-22-2011 09:18 AM

Working great, thanks for this :)

vBNinja 08-22-2011 04:17 PM

Just upgraded to 4.1.5 PL1 and nothing happens when i select a canned reply... Any help?

mmackinnon 08-23-2011 05:27 PM

Hmm

even after editing that file and uploading and rewriting im getting the BR.

Am i doing something wrong?

8thos 08-23-2011 08:35 PM

I completely installed this modification when it stopped working. When I reinstalled it with all the new edits, it not only worked, it brought all my old canned replies back!!!!!!!!

Awesome.

mmackinnon 08-24-2011 02:55 AM

ah perfect that did it!

DonosOdD 08-24-2011 10:28 AM

Can someone help me? Nothing happens when I select a canned reply. What am I doing wrong?

vBNinja 08-24-2011 08:16 PM

1 Attachment(s)
Okay for everyone having problems with the br or nothing showing up when you select a canned reply

Backup your canned replies first because you will need to add them again

1. Uninstall canned replies from plugin manager in admin cp
2. upload these files i have attached
3. install the product again
4. set permissions in admincp based on usergroups
5. Add your canned replies again (http://yourforum.com/forum/cannedreplies.php)

And it should work fine!

Pamela 08-25-2011 05:45 AM

Quote:

Originally Posted by ivant (Post 2237601)
Okay for everyone having problems with the br or nothing showing up when you select a canned reply

Backup your canned replies first because you will need to add them again

1. Uninstall canned replies from plugin manager in admin cp
2. upload these files i have attached
3. install the product again
4. set permissions in admincp based on usergroups
5. Add your canned replies again (http://yourforum.com/forum/cannedreplies.php)

And it should work fine!


This worked perfectly on 4.1.5 for me. Thanks so much!!! :D

DonosOdD 08-25-2011 11:35 AM

Problem solved. Thanks a lot!

cykelmyggen 09-19-2011 11:32 AM

Quote:

Originally Posted by Pamela (Post 2237767)
This worked perfectly on 4.1.5 for me. Thanks so much!!! :D

Will this version work on 4.1.4. as well?

wtfaatp 09-19-2011 01:06 PM

Not showing up @ all? I have no settings option in adminCP.

I have installed all the above fixs with no avail. :\

vb4.1.5 p1

cykelmyggen 09-19-2011 06:47 PM

Quote:

Originally Posted by cykelmyggen (Post 2247824)
Will this version work on 4.1.4. as well?

Answering my own question: yes it does :)

Successfulsteps 09-20-2011 08:18 PM

I am bit confused on what I have to do here. I am on 4.1.4 and did the edits below:

Quote:

Originally Posted by Eric (Post 2233704)
NOTE: You only need to make these changes if you have updated to vB 4.1.4+


I have attached an updated product xml file. You will need to re-import with "Allow Overwrite" set to "Yes". I then made the following changes:

In cannedreplies.php I removed all instances of:
PHP Code:

require_once(DIR '/includes/functions_wysiwyg.php'); 

I then changed all instances of
PHP Code:

    if ($vbulletin->GPC['wysiwyg'])
    {
        
$reply convert_wysiwyg_html_to_bbcode($vbulletin->GPC['message'], 1);
    } 

to
PHP Code:

    if ($vbulletin->GPC['wysiwyg'])
    {
        require_once(
DIR '/includes/class_wysiwygparser.php');

        
$html_parser = new vB_WysiwygHtmlParser($vbulletin);
        
$reply $html_parser->parse_wysiwyg_html_to_bbcode($vbulletin->GPC['message']);
    } 

and changed
PHP Code:

        $editorid construct_edit_toolbar(''0'nonforum'iif($vbulletin->options['privallowsmilies'], 10)); 

to
PHP Code:

        $editorid construct_edit_toolbar(''0'nonforum'iif($vbulletin->options['privallowsmilies'], 10), 10'fe''', array(), 'content''vBForum_Post'000true'titlefield'); 

...
PHP Code:

    $editorid construct_edit_toolbar($cr['reply'], 0'nonforum'iif($vbulletin->options['privallowsmilies'], 10)); 

to
PHP Code:

    $editorid construct_edit_toolbar($cr['reply'], 0'nonforum'iif($vbulletin->options['privallowsmilies'], 10), 10'fe''', array(), 'content''vBForum_Post'000true'titlefield'); 

I then replaced everything in clientscript/cannedreplies.js with:
Code:

function insertCannedReply(text)
{
        text = text.replace(/\n/g, "");
        text = text.replace(/<br>/g, "\n");

        if (document.getElementById("vB_Editor_001"))
        {
                CKEDITOR.instances.vB_Editor_001_editor.insertHtml(text);
        }
        else
        {
                CKEDITOR.instances.vB_Editor_QR_editor.insertHtml(text);
        }
}

It is important to make sure the template changes in the new product xml take place for this to work.

I believe that is all of the changes. You may want to backup the modified files before making the edits.


--
@mmackinnon I updated this mainly to see if I could, because I know CKEditor is a big change. I then found out someone was looking to pay to have it updated. I contacted them, but never heard back. If you do these edits, it should work - if you really have the urge to pay me something then you can find my paypal info in my released mods :P

Now I too am having the same problems as everyone else, that is getting those annoying <br> tags in the messages that once you select a message you see them. Also the canned messages when trying to edit is blank.

Quote:

Originally Posted by ivant (Post 2237601)
Okay for everyone having problems with the br or nothing showing up when you select a canned reply

Backup your canned replies first because you will need to add them again

1. Uninstall canned replies from plugin manager in admin cp
2. upload these files i have attached
3. install the product again
4. set permissions in admincp based on usergroups
5. Add your canned replies again (http://yourforum.com/forum/cannedreplies.php)

And it should work fine!

I understand the above the instructions about a fresh install. But what about all the edits I made? Is this going to overwrite those? I want to make sure once I uninstall and do the fresh install that I do not also have to worry about the templates edits previously to try to make this work. Not that I mind the edits, but I am not a coder and while I can follow instructions, that is about all I can do since I don't have the knowledge to understand the coding.

What I am trying to say, is due to the previous edits made to make this work, will a uninstall and fresh install be all that is necessary?

Thank you in advance for your assistance!

Successfulsteps 09-20-2011 08:57 PM

Ok, I uninstalled, did a fresh install marking it yes for overwriting when importing the xml.

I uploaded all the files and they looked good, but when I tried to use them in PMs, the <br> are there. The problem with the blank files are no longer a problem, but those br tags are still annoying!

Successfulsteps 09-20-2011 09:02 PM

Quote:

Originally Posted by Eric (Post 2236102)
Ok, for the <br> issue, this appears to correct it. Edit the /clientscript/cannedreplies.js file (the updated one in my post or xtremecoders' zip file) and replace everything with:

Code:

function insertCannedReply(text)
{
        text = text.replace(/\n/g, "");
        text = text.replace(/<br>/g, "\n");

        if (document.getElementById("vB_Editor_001"))
        {
                CKEDITOR.instances.vB_Editor_001_editor.insertHtml(text);
        }
        else
        {
                CKEDITOR.instances.vB_Editor_QR_editor.insertHtml(text);
        }
}


this did not fix the br tag issue for me.

Akuma2000 11-15-2011 10:21 AM

It stopped working with the upgrade to vb 4.1.7
Will a reïnstall also fix the problem with 4.1.7?

DEREKTROTTER 11-16-2011 06:30 AM

Hi There,

I was interested in installing this modification for a forum, but realised it wasn't supported.

Is there any possible chance you could make a version for vBulletin 4.1.7 or all vBulletin 4.x.x versions?

I would really like to get this for the forum I admin.

Thanks!

P.S. I've marked this as installed, so if you do decide to update this, I'll know when it is updated. :):):)

kleinschwanz 12-07-2011 04:19 PM

This would be nice, but it doesn't work with the new releases... will it be updated?

POL_ED 12-10-2011 09:10 PM

Version vb_cannedreplies_v4.1.5.zip working with vBulletin 4.1.9


vb_cannedreplies_v4.1.5 dont work with Popup Private Messaging for vBulletin 4.x!

karel1985 12-13-2011 05:47 PM

I try to contact banalive by his PM box was full so i tried by e-mail.

If someone else can help, would be very nice (i can send some donation if needed)

There is a small bug inside this mod:
(try to simulate it)

1) open a new topic, and choose directly a canned reply (without clicking in the editor first) --> the canned reply is not placed

2) the quick reply form has the same error when you open a random topic, scroll down and choose directly a canned reply --> the canned reply is not placed

Its only working when you click first inside the editor...

Any sugegstion howto fix?


All times are GMT. The time now is 07:40 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01849 seconds
  • Memory Usage 1,886KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (10)bbcode_code_printable
  • (7)bbcode_php_printable
  • (15)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (3)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete