vb.org Archive
Page 5 of 10 « First 34 5 67 Last »
Show 40 post(s) from this thread on one page

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   Modification Graveyard (https://vborg.vbsupport.ru/forumdisplay.php?f=224)
-   -   Major Additions - Classifieds (https://vborg.vbsupport.ru/showthread.php?t=205465)

Ocean-Wonders 03-02-2009 02:22 PM
Here's a working version if anyone want's a look.

I've not long had it installed myself so im still tweaking it.

Classifieds

pattycake 03-02-2009 04:42 PM
Sorry, I know this must be a stupid question but where does it give the viewer a chance to purchase an item being listed? I added two test items, entered my paypal address for each item.

The ad shows up, I see everything except a link where the viewer can purchase the item.

oops... I'm wondering now if it's because I am the one that listed the ad and since I am the one viewing the listing, a "purchase" link would make no sense???

smnet 03-02-2009 04:50 PM
You will also be hard pressed to see the 'purchase' options, since everything is tucked away in a drop down 'options' menu.

You might want to edit the template. Use the code i posted here:-
https://vborg.vbsupport.ru/showthrea...65&page=11#160

This will give you a MUCH better item layout.

pattycake 03-02-2009 05:12 PM
Quote:
Originally Posted by smnet (Post 1758623)
You will also be hard pressed to see the 'purchase' options, since everything is tucked away in a drop down 'options' menu.

You might want to edit the template. Use the code i posted here:-
https://vborg.vbsupport.ru/showthrea...65&page=11#160

This will give you a MUCH better item layout.
Very nice... worked like a champ!

MaryTheG(r)eek 03-02-2009 05:19 PM
Quote:
Originally Posted by pattycake (Post 1758617)
oops... I'm wondering now if it's because I am the one that listed the ad and since I am the one viewing the listing, a "purchase" link would make no sense???
That's right. Being the owner it has no sence to see the "Buy" link.

Mary

MaryTheG(r)eek 03-02-2009 05:29 PM
Quote:
Originally Posted by smnet (Post 1758073)
I have tweaked the main 'item display' page because I felt the layout (especially the options) was badly arranged from a usability point of view.
I believe that using less hard words it's a kind of politeness to someone who spend weeks to give you for free something that others ask lot of money.

Bypassing this, the only that I've to say is that everything is depending on user's taste. I'm the first (and maybe the only one) who never followed vB's standards on interface. I liked to use fieldsets instead of tables, HTML editor instead of vB editor, real categories and not threads.

But the fact is that most members here prefer the standard interface, that's why Classifieds (after 9 other mods), was the first one which follows the vB standards for menus. And you like it or not, "Buy Now" is a menu option, and all menus must be set in popups.

Thank you
Mary

pattycake 03-02-2009 05:40 PM
Quote:
Originally Posted by MicroHellas (Post 1758650)
That's right. Being the owner it has no sence to see the "Buy" link.

Mary
thank you for the reply... nice to see an author supporting their products.

Are the versions for 3.6, 3.7, and 3.8 the same? I installed the 3.6 version and the only thing I see lacking is the multiple image uploads. Was wondering if it was in later versions (3.7, 3.8)?

btw: Nice package... where can I send a donation?

-pat-

smnet 03-02-2009 05:52 PM
Hi Mary,

I meant no offence. I'm sorry if my choice of words bothered you, but I stand by the fact that it is badly arranged.

This does not mean i am ungrateful for the mod. If you decide to take offence at some honest to goodness well meant critisism then thats hardly my fault. I can pussy foot around and say 'not the best it could be' or dress it all up in other clothing but I'm not the kind of guy to beat around the bush.

I am a developer, long time user of the internet and specialise to some degree in usability. If I (and others in this thread) had a problem finding the 'buy it now' or equivelent action items along with other options then you can bet your ass that a lot of other people will to.

I am sorry you seem to be so offended and I guarantee that 100% I did not mean to harm your feeling.

It's a GREAT mod, and I mean that..... Like I said on PM I was trying to help. I sent you a PM before you wrote this reply...... why would i PM you offering to help if my intentions were not well meant.

Anyway, maybe if there's anything further we should take it to PM so as to not distract from this great mod.


Quote:
Originally Posted by MicroHellas (Post 1758664)
I believe that using less hard words it's a kind of politeness to someone who spend weeks to give you for free something that others ask lot of money.

Bypassing this, the only that I've to say is that everything is depending on user's taste. I'm the first (and maybe the only one) who never followed vB's standards on interface. I liked to use fieldsets instead of tables, HTML editor instead of vB editor, real categories and not threads.

But the fact is that most members here prefer the standard interface, that's why Classifieds (after 9 other mods), was the first one which follows the vB standards for menus. And you like it or not, "Buy Now" is a menu option, and all menus must be set in popups.

Thank you
Mary

samuelss 03-02-2009 06:05 PM
Thanks for this Mod. When an unregistered user clicks on the "BUY" button, the following message is shown "You have to register for buing.". Where can I change this message. The word "buing" should be buying.

Thanks.

smnet 03-02-2009 06:09 PM
in the vbulletin admin area use the 'search in phrases' tool to find the word 'buing'

smnet 03-02-2009 06:18 PM
Quote:
Originally Posted by MicroHellas (Post 1758664)
....And you like it or not, "Buy Now" is a menu option, and all menus must be set in popups.
Sorry.... I missed that bit when i first read it....

Not trying to cause offence Mary but 'Post reply', and 'new thread' are CORE, fundamental NEED TO USE actions... which i guess is why they are not tucked away in forum tools or thread tools dropdowns.

Like you say different people will like different things. I have attached an example of the layout I am using for the show ad page, which I personally feel is laid out in a more friendly way.

pattycake 03-02-2009 07:06 PM
i actually ended up using a combination of both... leaving the "Options" dropdown and adding a few buttons underneath the "Views"

tommac3 03-03-2009 12:19 AM
The uploading of the pic does not work?
I try to post a pic with my classified and it doesnt show up.
I would think you need to upload the pic first.

pattycake 03-03-2009 01:40 PM
is there a way to limit the number of active ads that a person can have ?

pattycake 03-03-2009 10:29 PM
Can't believe no one else has encountered this but....

In classifieds.php

On line 462:
print_no_permissions();

should be:
print_no_permission();

MaryTheG(r)eek 03-04-2009 05:56 AM
Hello,

A new version (1.1.0) is available for download. On this version I've added multiple photo upload. To upgrade, upload classifieds.php and re-import product-classifieds.xml

Mary

Sportsriders 03-04-2009 06:34 AM
I tried the update with vBulletin 3.8.0 and saw this message when importing the XML file.
XML Error: Mismatched tag at Line 288

Not sure if it is related to my particular case or the new XML script.

Sportsriders

MaryTheG(r)eek 03-04-2009 06:39 AM
Quote:
Originally Posted by Sportsriders (Post 1759866)
XML Error: Mismatched tag at Line 288
Open product-classifieds.xml At line 288 change:
From:
Code:
  <code version="1.1.0">
  <installcode /></installcode>
  <uninstallcode /></uninstallcode>
  </code>
To:
Code:
  <code version="1.1.0">
  <installcode />
  <uninstallcode />
  </code>
Zip file alse updated, so you can re download it

Mary

sNator 03-04-2009 07:43 AM
Quote:
Originally Posted by MicroHellas (Post 1754302)
Have you setup for user to not be able to change Theme? In anycase, try a trick. Open classifieds.php and change 46:

From:
Code:
$vbulletin->userinfo['styleid'] = $styleid;
To:
Code:
$vbulletin->userinfo['styleid'] = $vbulletin->options["classifieds_styleid"];
PS- I tried to reply to your PM, but you've choosen to not receive PMs from members here, so it was impossible to reply.

Mary
I have the same problem and your fix doesn't help. I want the style selection to work like all other vbulletin pages or an option to not use a specific Style.

sNator 03-04-2009 07:58 AM
classifieds.php doesn't intregrate with vbadvanced.

I use vbA to display a sidebar on the right side but this doesn't work with the classifieds.php script.

A hook missing perhaps?

MaryTheG(r)eek 03-04-2009 09:11 AM
Quote:
Originally Posted by sNator (Post 1759897)
classifieds.php doesn't intregrate with vbadvanced.

I use vbA to display a sidebar on the right side but this doesn't work with the classifieds.php script.

A hook missing perhaps?
Sorry, I don't use vBa, and I never wrote that this mod is for vBa, even if I post in another page a block for use with vBa.

Mary

sNator 03-04-2009 10:07 AM
Quote:
Originally Posted by MicroHellas (Post 1759941)
Sorry, I don't use vBa, and I never wrote that this mod is for vBa, even if I post in another page a block for use with vBa.

Mary
Ok, I just thought integration with vbA was basic functionality and for me it's must have.
Let's see if there is anyone else that have got it to work.

Sportsriders 03-04-2009 12:08 PM
Quote:
Originally Posted by MicroHellas (Post 1759868)
Open product-classifieds.xml At line 288 change:
From:
Code:
  <code version="1.1.0">
  <installcode /></installcode>
  <uninstallcode /></uninstallcode>
  </code>
To:
Code:
  <code version="1.1.0">
  <installcode />
  <uninstallcode />
  </code>
Zip file alse updated, so you can re download it

Mary

Thank you!! That fixed it.

Sportsriders

Sportsriders 03-04-2009 12:19 PM
Quote:
Originally Posted by Ocean-Wonders (Post 1758530)
Here's a working version if anyone want's a look.

I've not long had it installed myself so im still tweaking it.

Classifieds
Looks nice. Thanks for posting the code.

Sportsriders

pattycake 03-04-2009 07:16 PM
Is the number of pictures limitation apply across ALL of a persons classified ads instead of on a "per-ad" basis???

For example... if the limitation is 3, and he puts 3 images in one ad, he'll not be able to put any images to any of his other ads??

Please tell me that it is a "per ad" setting... please.

MaryTheG(r)eek 03-05-2009 03:55 AM
Quote:
Originally Posted by pattycake (Post 1760438)
Is the number of pictures limitation apply across ALL of a persons classified ads instead of on a "per-ad" basis???

For example... if the limitation is 3, and he puts 3 images in one ad, he'll not be able to put any images to any of his other ads??

Please tell me that it is a "per ad" setting... please.
It's per ad

Mary

pattycake 03-05-2009 06:30 AM
Quote:
Originally Posted by MicroHellas (Post 1760754)
It's per ad

Mary
nope... it's per overall. I just verified it ...

I set the images=2 for my usergroup
I had two existing ads, both have one image each in them.
I tried to add a 2nd image to one of the ads and it said " You don't have permissions to add more photos. Please upgrade, or remove old ones"

I changed the usergroup and set images=3, it and allowed me to add the 2nd image to the ad giving me a total of three ads.

I tried to create a new ad, tried to upload an image for the new ad and it again said: " You don't have permissions to add more photos. Please upgrade, or remove old ones"

So maybe your latest version might have the setting on a "per ad" basis but the version I have, (just before your newest one today), is on a "per user" basis.

Just to be double sure, I checked your code:
Code:
        $maxphotos = $permissions['maxphotosads'];
        $cnt = $db->query_first("
                SELECT COUNT(".TABLE_PREFIX."classifieds_photos.id) AS cnt
                FROM ".TABLE_PREFIX."classifieds_photos
                JOIN ".TABLE_PREFIX."classifieds_ads
                        ON ".TABLE_PREFIX."classifieds_ads.id=".TABLE_PREFIX."classifieds_photos.adid
                WHERE userid=$userid");  <--- THIS IS THE CULPRIT
this returns 3 - the number of ads currentlly used by the user for ALL ads by that userid.

and your next line:
Code:
if($cnt["cnt"] < $maxphotos && $maxphotos > 0)
                $upload = 1;

    $filename = "";
    $notuploaded = 0;
kills the upload and returns the error message.

TO FIX:... in Classifieds.php, around line 425

CHANGE:
Code:
WHERE userid=$userid");
TO:
Code:
WHERE classifieds_photos.id = ".$adid);

,

MaryTheG(r)eek 03-05-2009 07:12 AM
Quote:
Originally Posted by pattycake (Post 1760838)
nope... it's per overall. I just verified it ...
I'll check the files. This approach (overall photos) was on the early edition, later I changed it to be per ad. Maybe I've upload wrong function.php

Mary

pattycake 03-05-2009 07:55 AM
no problem... I fixed it on the version that I downloaded from here - it shows version 1.0.0

another quick question - do you check on max image size and if so, is there a setting where I can change this?

pattycake 03-05-2009 08:02 AM
also... you still have the bug that I previously mentioned.

In classifieds.php, at or around line 517.
You have: "print_no_permissions();" (notice the "s" at the end)
Should be: "print_no_permission();"

MaryTheG(r)eek 03-05-2009 08:24 AM
Quote:
Originally Posted by pattycake (Post 1760875)
no problem... I fixed it on the version that I downloaded from here - it shows version 1.0.0

another quick question - do you check on max image size and if so, is there a setting where I can change this?
Max size in Kb or in dimensions?. I'm checking dimensions. Please try to understand something very important on coding. By adding lot's of restrictions, means lots of checks, something that is not so good to performance. Sometimes by using just simple logic is better. By allowing just gif,jpg,png on a max width eg 600, the photo only in a very few situations should be more than 200kb. So why to add one more restriction? I can accept this filesize restriction on audio and video files, but not on photos.

Mary

pattycake 03-05-2009 09:25 AM
Quote:
Originally Posted by MicroHellas (Post 1760883)
Max size in Kb or in dimensions?. I'm checking dimensions. Please try to understand something very important on coding. By adding lot's of restrictions, means lots of checks, something that is not so good to performance. Sometimes by using just simple logic is better. By allowing just gif,jpg,png on a max width eg 600, the photo only in a very few situations should be more than 200kb. So why to add one more restriction? I can accept this filesize restriction on audio and video files, but not on photos.

Mary
I can have a 4000x4000 image that is less than 20k.
If I set the limit to 800x600 in the options, this image, although very small in bytes, would not be allowed if I set the limits based on width/height.

The check can be for size in pixels, or the check can be for size in bytes. You chose dimensions - I respect your decision, but I don't necessarily agree with it.

>Please try to understand something very important on coding

Thanks for the coding tip - I pretty much learned that long before I finished my masters degree in computer science.

btw: I had already added the multiple file upload before you released your 1.10 yesterday... I also added the ability to upload in .zip format and.... added additional "pay" options, added a maximum number of active ads per usergroupid option, and... changed the ad listings to show the title, the user, the price, and the expire date in tabular format in the "classifieds_categorieslistingadline" instead of just the title of the ad. Your original code however saved me a ton of work and for that, I definitely thank you.

MaryTheG(r)eek 03-05-2009 09:51 AM
Quote:
Originally Posted by pattycake (Post 1760909)
Thanks for the coding tip - I pretty much learned that long before I finished my masters degree in computer science.
Lucky you. Bad luck for me, being 1st child of a 5 children family, I had to stop the hight school and start working since my age of 15, to be give the opportunity to the upcoming boys of the family to be able to study. Bad, but true fact in Greece of 1970, that women are just to serve family. But I had the curage to finish hight school when I was 40. What I know (in programming and Englihs language) are things that I self-teached by reading books and I can say that since 1984 that for first time I started programming in dBase II, I've lots of projects around.

Mary

sNator 03-05-2009 10:27 AM
Quote:
Originally Posted by sNator (Post 1759891)
I have the same problem and your fix doesn't help. I want the style selection to work like all other vbulletin pages or an option to not use a specific Style.
I made comment on this row
PHP Code:
 $vbulletin->userinfo['styleid'] = $styleid; 
and now it works the way I wan't.

pattycake 03-05-2009 10:55 AM
Quote:
Originally Posted by MicroHellas (Post 1760919)
Lucky you. Bad luck for me, being 1st child of a 5 children family, I had to stop the hight school and start working since my age of 15, to be give the opportunity to the upcoming boys of the family to be able to study. Bad, but true fact in Greece of 1970, that women are just to serve family. But I had the curage to finish hight school when I was 40. What I know (in programming and Englihs language) are things that I self-teached by reading books and I can say that since 1984 that for first time I started programming in dBase II, I've lots of projects around.

Mary
No luck here... I ran away from home when I was 16, got a job and finished high school on my own in a city 200 miles from my parents. Worked to pay for college , dropping out whenever I ran out of money, back in again when I had saved enough for a semester or two. It took me 6 years to get a 4-year undergraduate degree in mechanical engineering... worked 10 years in research and development at Cummins Engine, then quit my job and went back to get a masters in computer science at age 35.

btw: I taught college programing for a while to help get me thru grad school - your coding is pretty good... especially for being self-taught - kudos to you.

Ok, enuff slobbering over each other.... back to "Classifieds"... sorry for the interuption folks.


.

Bulldog Stang 03-05-2009 12:59 PM
Add me the list of Blank Page being viewed. I have read all the pages in this thread and have not found a fix for the Blank Page. I followed all of the instructions to a "T". I have uninstalled and re-installed, and still nothing. I am running 3.8.1 like all the others that have this issue.

Subscribed to this thread waiting for a fix.

taytaysdad 03-06-2009 02:00 AM
Hey Mary!

Wondering if you can tell me how to point the classifieds link in the navbar on my homepage to the right place. Inside the forum it works perfect, but I have the cmps installed and on the homepage it cant find classiieds.php...should I move something out of the forums folder? I know Im missing something....

ANy help is appreciated.:confused:

MaryTheG(r)eek 03-06-2009 03:26 AM
Quote:
Originally Posted by Bulldog Stang (Post 1761013)
Add me the list of Blank Page being viewed. I have read all the pages in this thread and have not found a fix for the Blank Page. I followed all of the instructions to a "T". I have uninstalled and re-installed, and still nothing. I am running 3.8.1 like all the others that have this issue.

Subscribed to this thread waiting for a fix.
Try a trick that I found that sometimes works. From vBulletin Options choose Cookies and HTTP headers options and set to NO GZIP HTML Output.

Mary

pattycake 03-06-2009 03:21 PM
Quote:
Originally Posted by taytaysdad (Post 1761513)
Hey Mary!

Wondering if you can tell me how to point the classifieds link in the navbar on my homepage to the right place. Inside the forum it works perfect, but I have the cmps installed and on the homepage it cant find classiieds.php...should I move something out of the forums folder? I know Im missing something....

ANy help is appreciated.:confused:
what is the link to your forum?

add classified.php to that link and it should work

ie. if the link is http://yourwebsite/forum
use http://yourwebsite/forum/classifieds.php

Trek 03-06-2009 08:25 PM
Is it possible to use this with "virtual" currency? Actually, I'd rather NO currency. I'd like for people to be able to put up an add and say "this much" but not have any sort of paypal, etc...

Basically, I have members that offer virtual items in a game. I don't want anything to do with real money, etc. More of a "contract" if you will if someone buys something.


All times are GMT. The time now is 06:50 PM.
Page 5 of 10 « First 34 5 67 Last »
Show 40 post(s) from this thread on one page

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.03739 seconds
  • Memory Usage 1,867KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (10)bbcode_code_printable
  • (1)bbcode_php_printable
  • (22)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 
Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 
Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete