Ajax ftw->installed

Thank you ^^

To anyone experiencing the conditional errors when evaluating the templates, please try the following.

In your AdminCP > vBulletin Options > Collapsable First Post using AJAX Options:

Set the Forum Exclusion List to 0 (zero).

Now, resubmit the template modifications and see if you still receive the error. I'm trying to track down what would be causing this error for some of you, but I can't seem to replicate it on my development forum unfortunately.

This is what's holding up the next release, as I'd like to have this resolved before I put another version out there.

Thanks!

Update:
1.2.1 BETA : PRIVATE BETA. NOT RELEASED.

• Will no longer show expand icon next to thread redirects.
• Added ability to display first unread post.
• Completely revamped the automatic template editing system. Should now be able to make template edits to even the most modified templates as well.
• Fixed a couple non-breaking typos.
• Included JavaScript in USERCP_SHELL to allow expand/collapse of subscribed threads.
• Added a hover title to the expand icon to inform the user what they can expect when clicking it.

[hr]-[/hr]

While this isn't a major revision, it hopefully addresses the few sporatic issues a few users have been reporting. I'm hoping the alleviate the need to manually edit templates with my revamped automatic template editing system. I will not be releasing any new features until these problems are resolved!

The pre-requisites for testers are as follows:

• Previous automatic template edits did not work for you.
• (optional) You receive a conditional error when applying template edits manually.

If you meet any of the above criteria and wish to lend a hand, let me know. Thanks!

Just installed this... working great. (Tested on Safari.)

Awesome work... thanks, magnus!

A few issues/suggestions:

I see the expand/collapse button appears next to Subscribed Threads in the User CP. But the button doesn't work. If at all possible, could it be made to work? And if not, is there a way to remove the button from appearing next to those threads in the User CP? Since the button doesn't work, after all.

I'd love to see some more options in AdminCP, like the ability to turn off avatars in the expanded post. That'd be a lot easier than manually going in and editing vbpost_postbit.

I'd also like to see an option for the button to only appear next to new/unread threads, and not others. And when the button is clicked, that the status (of the very first post, at least, or whatever post is being displayed) gets marked as "read."

Good catch, easy fix. Thanks!

Hrm. Personally, I feel this is unneeded because editing the template is so simple. However, it seems the majority of people here want specific template modifications (ie. quote, reply, edit) so this may be a way to please everyone.

I'll see what I can do.

This is similar to something that was brought up previously that I've been working on. vBulletin provides the following functions:

mark_thread_read();
mark_forum_read();

There's no specific way to mark a POST as read, so unless you want the entire THREAD marked as read, I don't really see a way to do this without basically adding an new post database table to tracking the read status of each post.

What I have done, though, is added the ability to select "First Unread Post" to be displayed. So, when clicked the user will see the first unread post since their last visit. There's also an option in the AdminCP now to Mark Thread as Read when this post is viewed. So, it's configurable to that extent.

That sounds great, magnus. Thanks so much for your reply and consideration! Looking forward to your updates.

In the meantime I have gone in and tweaked vbpost_postbit to my liking. Mainly just simplifying it, removing the extras I didn't think this needed (location, post count, user title, etc.) Looking great.

Another minor request. When hovering over the button, right now I am seeing the default/standard thread preview popup. (Same as if I'd hover over the thread title itself.) I think it would make more sense if the popup said this instead:

"Click here to see the _x_ post"

(where x = "first," or "last," or "first unread," depending on the Admin CP or User CP settings for this hack.)

So users can better understand what's going on with this new feature.

Good idea. Just added that real quick. :up:

hrhr
waiting vor update*g*

Still getting these errors when setting forum to 0

The following error occurred when attempting to evaluate this template:

Warning: in_array() [function.in-array]: Wrong datatype for second argument in /includes/adminfunctions_template.php(3596) : eval()'d code on line 1

Warning: in_array() [function.in-array]: Wrong datatype for second argument in /includes/adminfunctions_template.php(3596) : eval()'d code on line 15

This is likely caused by a malformed conditional statement. It is highly recommended that you fix this error before continuing, but you may continue as-is if you wish.


I would be willing to do your beta for you seeing how I am one of the people having this issue

Great! I'll send you a copy via PM. Also, before installing the beta -- try the attached threadbit. See if that resolves the errors.

Ok that template now works fine but it still does not update the post count.

Post count? What post count? I'm glad the errors are gone, but could you try the Forum Exclusion List and tell me if it's actually working now? Just put any active Forum ID and see if the expand/collapse icons still display.

I'm sorry the THREAD VIEW count is not moving. The beta installed without a hitch. Still no thread view count going up but it did install without any issues and is working.

Thanks

So far so good. We should be ready for a release soon. Yay! :p

Ok, for those receiving errors when modifying the templates manually. See the original post for updated template modifications. The only modifications were to the threadbit template. Nothing else has changed.

If a thread is also a poll, how about having an option of either showing the poll or posts? .. maybe make it so clicking the poll icon shows the poll?

Have a think :)

Ouip, but doesn't work in 3.5 (queries).

C?dric :rolleyes:

Good to know. I've released a vB3.5 compatible version. You can find it here.

Nevermind me.... i put the images in the ~/images/buttons folder and not the ~/images/MY TEMPLATE/buttons

Nice work.

One thing I've noticed, is that the vB drop down menu that should pop up when you click on the username, only works in Firefox and not IE...in IE it just takes you to the full profile page.

I've tried copying the original code from postbit_lagacy and it still doesn't work.

Anyone know why this is?

Nice find. I just verified it on my setup, too. I'll take a look at it.

I'm also finding that the exclude forums feature isn't working, I have used manual template edits but I can't get that to work. The admin panel stores the forum IDs but the feature still operates in those forums.

AWESOME!!

installed. working great 3.6.0



FYI: couldn't do the automatic though...didn't work. I think its because if you vbplaza has slight change in the div tag for:

$thread[title_editable]
<div>


(that's the only difference I noticed)

ps. any chance for a vbadvanced cmps module? :)

great hack, waiting for 1.2.1 to come out.

Yea, I was worried about that. It works fine with the automatic template edits, but for some reason the array isn't being passed when using manual edits. The next release should allow you to successfully use the automatic template edits, which in turn, will allow the forum exclusion to work correctly as well.

I think I can probably get 1.2.1 out today.

Yea, rjmjr69 uses vBPlaza and he beta tested v1.2.1. The automatic template edits are working for him now. :)

I don't understand, what would a module of this do for vBA CMPS?

Update:
1.2.1

• Will no longer show expand icon next to thread redirects.
• Added ability to display first unread post.
• Completely revamped the automatic template editing system. Should now be able to make template edits to even the most modified templates as well.
• Fixed a couple non-breaking typos.
• Included JavaScript in USERCP_SHELL to allow expand/collapse of subscribed threads.
• Added a hover title to the expand icon to inform the user what they can expect when clicking it.

[hr]-[/hr]
I would seriously suggest removing any manual template edits you may have performed for the previous versions (except modified vbpost_postbit templates). This new version employs advanced automatic template editing logic which should have absolutely no problem performing the edits to modified templates, except in the most rare circumstances (note: I've yet to find one).

To upgrade, simply overwrite the existing files and import the product as usual.

Updated to 1.2.1 and now have two ajax icons alongside latest posts ?

clicks install also is there anything that can make the user column where they put avator smaller and all their info thinner

You didn't remove the manual template edits. Look for expand.gif in your threadbit template, and remove that line.

You can edit the vbpost_postbit template to look however you like.

Couple of points I have found on the new release which I hope are helpful. (I am now on automatic template edits)

1) I can't seem to make it go to the first unread post, it still does the first post in the thread for me.

2) Although excluding certain forums works in forumdisplay, it doesn't work in search_results.

3) Guests viewing thread lists that do not have rights to view posts still get the icon, but when they click the icon it just gives the "loading" gif permanently. With manual edits I was able to fix this using a simple template conditional, however with auto-edits it's going to need something in the plugin code. Again would be better if the icon was hidden.

[QUOTE=Mark.B;1236535]Couple of points I have found on the new release which I hope are helpful. (I am now on automatic template edits)

Are you sure there's a post in the thread marked as unread? It's weird that it would go to the first post because if you have 'First Unread Post' set and there is no unread posts, it defaults to the Last Post.

I'll look at it.

This is known, I'm trying to find a way to filter search results through the exclusion filter.

Never thought about that. Easy fix. I'll take care of it.

Yes, I've done quite extensive testing with it.

As it happens, I cannot make it do "last post" either, it always does first post no matter what the admin cp setting.

Aha...got it.

It works in forumdisplay but not in search_results.

In search_results it always goes to the first post regardless of the admin setting.

A small tweak that is really very minor but neatens things up a bit.....

Adding:
into the automatic template code for threadbit where the image is displayed will make the image line up neatly with any "view first unread" default vB images that may be next to it.

Yes, this is correct. By design, it will always return the first post in search_results. The information available in FORUMDISPLAY isn't necessarily availble in the search_results query. It's not that it can't be done, I'm just trying to keep the modification as evasive as possible when it comes to query manipulation.

I haven't written off the idea, I just won't release it until I know for certain it won't cause any future hiccups. :p

Good idea, thanks.