vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 4.x Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=245)
-   -   Moderators Functions - Show User History On Infraction Form And Postbits (https://vborg.vbsupport.ru/showthread.php?t=318633)

BrettC Frontier 07-12-2015 04:42 AM

Hi Mark,

A few bugs/issues/requests to report of on this addon.


- The text in the ACP, products, your product name shows as "MarkFL: Show Usernotes And Infraction History On I". Seems to have hit a limit or something. :)

- Would be nice to change the check boxes on the usergroup selection into a select box. Selected group names would be active, unselected would be inactive.

- The yellow background and text do not play nice with one another on the blue vbulletin admin theme. White text on yellow.

- Within user notes, if a title field is empty, it may be worth while putting N/A into the field as a placeholder.

- Within Warnings/Infractions:
  • The reason field always has a / somewhere. It would appear the slash in the code is a delimiter between a custom infraction reason and a preset reason. May be worthwhile using a "if ? :" Ternary operator php clause in that segment.
  • Infraction list does not show expiry time.
  • Infraction list does not show infraction type: warning/infraction text, only a numerical point value. May be worthwhile using the infraction icon images.
  • Infraction list does not link to the post/item that was infracted.

Observed on both sections:
- Dark themes absolutely decimate the text coloring of the rows to background coloring. The rows appear to not use vbulletin's CSS variables of blockrow, blockhead as seen elsewhere in VB.

- Having user notes and infractions all in the same blob of text is rather confusing. Moving user notes to the left side, and moving infractions to the right made the segments much more readable.

- The text bubble assigned to administrative notes on infractions should default to N/A or "No Administrative Note Assigned" if no text was put there.

- The postbit hooking appears to completely fail if there's been any edits to the segments near post counts/userinfo bits.

- Issued By / Author username is not linkable.

- "User Notes: ###" could have an additional link to the right for "Manage User Notes".

- "Warnings/Infractions" could have a link to the users profile page. For example: /member.php?u=#####&tab=infractions&pp=40#infractio ns-content


Sorry for the wall of text. Just a few knacks to advise of. :D

MarkFL 07-12-2015 06:05 AM

Hello Brett,

I truly appreciate your interest in improving this add-on, and I will see what I can do to address the issues you have outlined. :D

MarkFL 07-16-2015 09:10 PM

Update: version 2.0
  • Shortened product title so it won't be truncated in AdminCP ► Plugins & Products ► Manage Products.
  • Fixed text color on usergroup checkbox elements in product settings to be dark.
  • If usernote title is empty, displays "N/A" within user history block on infraction form.
  • Fixed infraction reason to either use chosen or custom reason, whichever applies.
  • Infractions show date/time of expiry.
  • Infractions show link to post that caused warning/infraction to be issued, using thread title.
  • Infractions are shown in descending order, sorted by time issued.
  • Background color of user history block fixed to white.
  • If no "Administrative Note" is given for an infraction, then "N/A" is displayed.
  • Execution order of postbit plugin increased to help ensure it gets run.
  • Usernames of usernote authors and infraction issuers link to user profiles.

BrettC Frontier 07-28-2015 07:14 PM

Found a slight issue with the latest version. Issuing a profile infraction rather a post infraction will cause the infraction.php page to throw up a SQL error. It's expecting a post ID.

MarkFL 07-28-2015 09:31 PM

Quote:

Originally Posted by BrettC Frontier (Post 2551607)
Found a slight issue with the latest version. Issuing a profile infraction rather a post infraction will cause the infraction.php page to throw up a SQL error. It's expecting a post ID.

Great catch! I appreciate you letting me know. I have fixed the issue. If an infraction does not have an associated postid, then "N/A" will be displayed in the post field. I have also changed the usergroup selection as you previously requested.

Update: version 2.1
  • Fixed bug regarding infraction not being associated with a post and causing and SQL
    error.
  • Changed usergroup selection from checkboxes to select elements.

Stratis 08-01-2015 11:25 AM

1 Attachment(s)
Mark very nice, I install this to my test forum, it works ok.
But that's say that some forums as mine don't use infractions, or some other don't use usernotes
How about in future if there is an option to select...

User History usernotes In Postbits Enabled?
User History infractions In Postbits Enabled?
Thanks, with some changes to my need.
Attachment 153053

imported_vauge 08-09-2015 10:51 AM

This looks awesome! How many additional queries per thread does this add?

MarkFL 08-09-2015 11:29 AM

Quote:

Originally Posted by imported_vauge (Post 2552495)
This looks awesome! How many additional queries per thread does this add?

There are 2 queries per selected user if the user history is set to display in postibts.

MarkFL 08-19-2015 02:18 AM

By request, I have made the following update:

Update: version 2.2
  • Added the display of active infraction points on infraction form.
  • Added the ability to customize the color of the active points based on value.

MarkFL 08-20-2015 01:25 AM

Update: version 2.3
  • Added the display of active infraction points on user postbits, where the number is colored as defined.


All times are GMT. The time now is 05:00 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01208 seconds
  • Memory Usage 1,746KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete