vb.org Archive
Page 5 of 6 « First 34 5 6
Show 40 post(s) from this thread on one page

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.8 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=235)
-   -   BB Code Enhancements - Validate matching quote BBCode tags. (https://vborg.vbsupport.ru/showthread.php?t=213719)

Max Taxable 09-17-2013 07:27 PM
Quote:
Originally Posted by raywjohnson (Post 2446070)
True. Thanks. I will to some testing on version 4 to see what I can find out.

--RayJ
Yes I was merely pointing out in a subtle way, that to expect a add-on that is coded for version 3.8, to work without flaw on a version 4 installation, is not reasonable.:D

Joe Blow 09-17-2013 07:48 PM
Further info:

Quote:
It was core dumping with with signal 4 when one of the regexp functions was called on the string.

raywjohnson 09-17-2013 08:01 PM
Quote:
Originally Posted by Joe Blow (Post 2446317)
Further info:
Quote:
It was core dumping with with signal 4 when one of the regexp functions was called on the string.
Yep. I found the same problem while testing. I will be working on a fix today.

The issue is that due to the recursion, it runs out of memory when crunching through large posts. I thought I had a fix for that already, but simply failed to take into account text before and after any quoted text. So a 5k post with 10 nested quotes causes 10 PHP recursive calls. The regex is also recursive!

I have re conceptualized the functionality and may have come up with a fast and efficient solution.

I hope to upload the newest version later today.

--RayJ

raywjohnson 09-17-2013 11:18 PM
Alrighty then!

Found a good solution. Version 3 does not use recursion at all. I also added an extra check to make sure the class file (class_verifyquotes.php) exists. So if the file gets deleted or renamed, your board will not go down (i.e. show a blank page).

I also added the ability to remove tags (other than just "noparse") prior to validation.

I tested it in VB4 and it worked fine.

Everyone should upgrade to version 3 of this plugin.

Standing by for bug reports! ;)

--RayJ

ozzy47 09-17-2013 11:25 PM
Quote:
Originally Posted by raywjohnson (Post 2446357)
Alrighty then!

Found a good solution. Version 3 does not use recursion at all. I also added an extra check to make sure the class file (class_verifyquotes.php) exists. So if the file gets deleted or renamed, your board will not go down (i.e. show a blank page).

I also added the ability to remove tags (other than just "noparse") prior to validation.

I tested it in VB4 and it worked fine.

Everyone should upgrade to version 3 of this plugin.

Standing by for bug reports! ;)

--RayJ
Just to be clear, this will still work in 3.8.x series? Not that I use this, just so the people that do know.

raywjohnson 09-17-2013 11:37 PM
Quote:
Originally Posted by ozzy47 (Post 2446358)
Just to be clear, this will still work in 3.8.x series? Not that I use this, just so the people that do know.
Yes. Thanks for reminding me. It is still developed on and for VB3.8.

--RayJ

Black Tiger 10-26-2013 11:12 PM
Sorry but I've got a problem on 3.8.7 with 1.3 so I think it's buggy, because this problem does not occur with version 1.2.

I've got vbulletin 3.8.7 pl3 running. When I use version 1.3 and try to make a new post, I don't get the in between lines saying that my thread is being posted, but I just get a white screen, nothing more.

When I use version 1.2 the problem is gone and I can post again.

How can this be fixed?

raywjohnson 10-26-2013 11:41 PM
When you upgraded to 1.3, did you upload the class_verifyquotes.php file to the /includes/ directory? Each version must use its own class_verifyquotes.php file.

--RayJ

Black Tiger 10-27-2013 12:03 AM
No I didn't because it said:
Quote:
v1.(0/1/2)-v1.3 : just import product-vqbc_rayj2009_v1-3.xml (Allow Overwrite)
So I thought that was not necessary.

Thank you for the quick support, I'm going to change it now!

raywjohnson 10-27-2013 12:13 AM
No worries. And thank you for the feedback. I will fix the instructions!

-RayJ


All times are GMT. The time now is 10:37 PM.
Page 5 of 6 « First 34 5 6
Show 40 post(s) from this thread on one page

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01056 seconds
  • Memory Usage 1,739KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (7)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (3)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 
Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 
Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete