vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.7 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=228)
-   -   Add-On Releases - vBulletin-Glossary (https://vborg.vbsupport.ru/showthread.php?t=188189)

Keyser Soze 08-17-2008 07:39 AM

The next bug:
If you choose a certain letter from the "alphabet-table" within a certain category, the pagination is wrong. You are displaying the pagination for the whole category and not for a certain letter.

dreads 08-17-2008 08:09 AM

gonna install when i get home

thanks

Keyser Soze 08-17-2008 10:22 AM

Next bug:
This addon is incompatible with the following addon: vBaffiliate Links (see attached image)

Vossi 08-17-2008 11:07 AM

That doesnt have anything to with this addon being incompatible to vBaffiliate Links but is a logical thought when you know about the fact, that vBaffiliate Links forces his replace-routine on the global_start-hook. In this way the routines breaks everything coming along.

Using the global_start-hook for such a routine ain't good at all, actually we actually use the parser-hooks where those linking-routines belong to. We are not responsible for other peoples fault.

Keyser Soze 08-17-2008 11:36 AM

Yes, you are right. I also noticed this a few minutes ago. I fixed the problem by removing all "vBaffilialized" words from glossary descriptions.

Another question:
Why are you replacing the letters from A to Z with their html-entities in the link-texts (function "cb" in functions_vbglossar.php)?

Keyser Soze 08-17-2008 11:43 AM

The last part of the navbar-breadcrumb seems to be a little bit confusing. Currently it looks like this in the category-view:
Code:

-- Forum Title -> Lexikon -> Kategorie-Name
 '-> Kategorie anzeigen

but I would suggest to change it to
Code:

-- Forum Title -> Lexikon
 '-> Kategorie-Name

...and likewise for the showentry-view (removing "Eintrag anzeigen")

G?rome 08-17-2008 02:10 PM

Quote:

Originally Posted by Keyser Soze (Post 1600661)
Why are you replacing the letters from A to Z with their html-entities in the link-texts (function "cb" in functions_vbglossar.php)?

It was the most easy way to avoid recursions while retaining the speed of the crosslinking-module. This approach ensures that already patched text will not be patched again.


G?rome

Keyser Soze 08-17-2008 02:15 PM

Important Security Issue: Googlebot is able to create glossary-entries!
I have noticed that "unregistered" users with the IPs 66.249.71.26 and 66.249.71.25 have been able to create numerous new Glossary entries. These entries don't have a name and no description, but they do exist in my database.
No I am asking myself:
1.) Why is it possible that unregisterd users are able to create new entries and insert data into mysql, even if I disallowed the guest-usergroup to create new entries?
2.) Why is it possible to create new entries with an empty title and description, no matter if we are talking about registered or unregistered users?

As long as these questions are not answered, I would advise everyone who is reading this to disable this addon immediately and to no longer make it avaible for download here as long as this security issue is not fixed.

Keyser Soze 08-17-2008 02:45 PM

Quote:

Originally Posted by G?rome (Post 1600732)
It was the most easy way to avoid recursions while retaining the speed of the crosslinking-module. This approach ensures that already patched text will not be patched again.

Ok. I just thought that these html-entitities might not be the best solution for SEO purposes.

G?rome 08-17-2008 02:58 PM

Quote:

Originally Posted by Keyser Soze (Post 1600759)
Ok. I just thought that these html-entitities might not be the best solution for SEO purposes.

Why? Bots do translate them back as well as browsers do.


All times are GMT. The time now is 11:56 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01361 seconds
  • Memory Usage 1,740KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_code_printable
  • (3)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete