vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   Modification Graveyard (https://vborg.vbsupport.ru/forumdisplay.php?f=224)
-   -   Statistics Modifications - Forum Search Stats V.2 (https://vborg.vbsupport.ru/showthread.php?t=153072)

coderphp 08-05-2007 08:00 PM

Quote:

Originally Posted by HDT (Post 1310618)
I have customs usergroup "Bulldog Guard" with user group id:9

Then when I set "who can see most searched keywords?" to 5,6,9 there only usergroup id 5,6 who can view the most searched keywords stats in the mainpage.

All user who included usergroup 9 doesnt see it.

Please help.

there is no reason i know for such a problem
i tested with custom usergroups and it seems to be working fine...

HDT 08-07-2007 12:22 PM

Problem solved!Thanks

coderphp 08-08-2007 06:07 PM

Quote:

Originally Posted by HDT (Post 1311850)
Problem solved!Thanks

anytime friend :)

davide101 08-16-2007 04:42 PM

<font color="DarkRed">WARNING</font>
Hi, this script is currently NOT safe. A bot searched a dozen times for a malicious phrase and got a javascript redirect to load when the top searches were displayed. Luckily it was just a redirect that can easily be removed. I would disable search logging or fix the software ASAP less someone with a lot more evil intentions starts poking around.

coderphp 08-16-2007 05:00 PM

Quote:

Originally Posted by davide101 (Post 1319016)
WARNING
Hi, this script is currently NOT safe. A bot searched a dozen times for a malicious phrase and got a javascript redirect to load when the top searches were displayed. Luckily it was just a redirect that can easily be removed. I would disable search logging or fix the software ASAP less someone with a lot more evil intentions starts poking around.

Hello
many thanx for ur interest, but I dont know how you consider this to be Not safe! as tags are removed on listing queries on forumhome,
notice this code snippet, taken from the product:
PHP Code:

if(!in_array(strip_tags($put['query']), $censor_words)) $most_searched .= "<a href=\"search.php?do=process&searchstats=nocount&q="$put['query'] ."\"><font size=\"".$r."\">" strip_tags($put['query']) . "</font></a> &nbsp;&nbsp;"

notcie the function strip_tags (read more about it at php.net/strip_tags)
I see that this is enough to trim any malicious codes, as javascript tags are removed b4 listed on page

to unserstand what im saying please try to search for
Code:

<script, language="javascript">alert('hello');</script>
of course the alert will not appear, if it appears so almost u modified the Mod

thanx for ur interest again, and looking forward to hear from you :)

Regards
Mahmoud

4x4 Mecca 08-16-2007 05:41 PM

It is unsafe, I got hacked, and this link http://www.aktifmadde.com/hacked.html replaced my forumhome. I searched my tables, and found it in the coder_search table. See the attached images.

coderphp 08-16-2007 05:47 PM

Quote:

Originally Posted by 4x4 Mecca (Post 1319055)
It is unsafe, I got hacked, and this link http://www.aktifmadde.com/hacked.html replaced my forumhome. I searched my tables, and found it in the coder_search table. See the attached images.

https://vborg.vbsupport.ru/showpost....2&postcount=45

4x4 Mecca 08-16-2007 05:56 PM

I read that post, but I don't get what you are saying... I did get hacked through this product... are you saying it's something I did wrong? :)

coderphp 08-16-2007 05:59 PM

Quote:

Originally Posted by 4x4 Mecca (Post 1319071)
I read that post, but I don't get what you are saying... I did get hacked through this product... are you saying it's something I did wrong? :)

ok please put the code of ur plugin "forumhome_complete" here

davide101 08-16-2007 06:28 PM

It was definitely in the search results code, unmodified, as I downloaded it two weeks ago. As soon as I deleted that one entry, the redirect stopped.

I wish I saved a snapshot of the code before I deleted it. It wasn't simply a Javascript tag that they posted. The link that displayed actually looked something like this: '''''""">>>>>>''>>. Whatever complicated string they fed in, it survived the code stripping process.

I don't believe that strip_tags() on its own can sufficiently clean the input to stop all attacks. Everything I'm reading now suggests that you should run htmlspecialchars() afterwards. There have been a number of vulnerabilities where strip_tags() misses an embedded tag OR the browser will auto-correct a malformed tag. For example, last year there was a bug where strip_tags() would ignore <0script> but Internet Explorer would filter out the zero for some reason. That's not happened in this case, but it may have been something similar.


All times are GMT. The time now is 05:05 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01147 seconds
  • Memory Usage 1,756KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_code_printable
  • (1)bbcode_php_printable
  • (5)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete