vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   Modification Graveyard (https://vborg.vbsupport.ru/forumdisplay.php?f=224)
-   -   Show Thread Enhancements - Automatic Embedded Video (youtube, plus many more) (https://vborg.vbsupport.ru/showthread.php?t=150472)

Hornstar 06-23-2007 11:10 PM

Quote:

Originally Posted by FleaBag (Post 1274952)
I changed the execution order of this hack, to 1, and it all works just fine now. Working with vBSEO. I'm guessing this technically should deal with the URL before anything else - as long as vB gets there first I'm happy. Will changing execution order to 1 have any detremental effects?

that is what im thinking, and how do you change the execution order ^^
Maybe vbseo execution order could be changed a little higher, could be worth asking vbseo as well.

FleaBag 06-23-2007 11:12 PM

vBSEO is already at 5. You browse plugins in ACP and click edit to change the order.

I think I spoke too soon... I sucessfully posted a URL, but the next one I tried resulted in vBSEO replacing the string again. The only thing I did in between was to try and edit an old post, to see if it would have any effect. Maybe editing the post is causing the issue.

mfyvie 06-23-2007 11:14 PM

Quote:

Originally Posted by hornstar1337 (Post 1274948)
This looks truly awesome, but it is a shame that a feature in vbseo will need to be turned off first, hopefully there can be another solution for this.

Actually, I've just confirmed this with my own internal test, and if you download this mod in about 30 minutes it won't be an issue.

Quote:

Originally Posted by FleaBag (Post 1274952)
I changed the execution order of this hack, to 1, and it all works just fine now. Working with vBSEO. I'm guessing this technically should deal with the URL before anything else - as long as vB gets there first I'm happy. Will changing execution order to 1 have any detremental effects?

I've actually changed it to 3 - just in case there is something out there later than needs to get in earlier. Changing to 1 effectively locks any other mod from going before you if it needs to.

Quote:

Originally Posted by Lizard King (Post 1274953)
I think you missed that i edited my post and included the links.

Yes, after or during my reply. From looking at the links I can see that some were working, some were not. This is due to the - character in the youtube URLs (wasn't expecting that, my test URLs didn't have them). This will be fixed in a few minutes. Watch this thread.

Lizard King 06-23-2007 11:14 PM

Strange thing , After posting a metacafe link now youtube videos also started to work on my test server. However on live server metacafe videos work but youtube videos look like [YOUTUBEvid]C7V3WCy1Ozc[/youtubevid] , Here is the link for the thread http://www.ayyas.com/road-trip/18229...ur/#post313522
I have my execution order for this product set to 1 also.

FleaBag 06-23-2007 11:19 PM

Affirmative - YouTube's without URL's work just fine. Great work, good to hear the fix is coming! :D

If you could make it let us edit posts manually and work too, you'd really make my day. My month in fact.

aj8690 06-23-2007 11:19 PM

Works great. Hope we can fix that YouTube no www. problem.

AJ

mfyvie 06-23-2007 11:25 PM

PRODUCT FILE UPDATED

All users who have downloaded and installed this mod prior to the date stamp on this post (which is after all a couple of hours after the release) should redownload and reinstall the .xml file included with this release.

This should resolve all issues reported on this to date (that I have control over).

Those who have reported issues so far, please retest to see if they are resolved after you reinstall, and raise them again if they are.

PRODUCT FILE UPDATED

mfyvie 06-23-2007 11:33 PM

Quote:

Originally Posted by aj8690 (Post 1274964)
Works great. Hope we can fix that YouTube no www. problem.

Now fixed. Also loosened the logic for all the other services in case this happens to them in the future.

Quote:

Originally Posted by FleaBag (Post 1274963)
If you could make it let us edit posts manually and work too, you'd really make my day. My month in fact.

Well I want to avoid duplicating the entire code at another hook, or using a file (I hate it when I have to upload a file). Remember that when you edit you can manually use the BBCode tags, you just won't get an automatic conversion.

If your issue is that you want to go and convert all your EXISTING posts, then I'm going to make a script to do this for you - so you wouldn't need the edit feature you are asking for.

Quote:

Originally Posted by Lizard King (Post 1274961)
Strange thing , After posting a metacafe link now youtube videos also started to work on my test server. However on live server metacafe videos work but youtube videos look like [YOUTUBEvid]C7V3WCy1Ozc[/youtubevid] , Here is the link for the thread http://www.ayyas.com/road-trip/18229...ur/#post313522
I have my execution order for this product set to 1 also.

If you are seeing the bbcode tags like that then my mod has done its work. You may be having some kind of other issue related to the bbcode itself - I'd look into that separately.

Please don't set execution order to 1, I'm now using 3. Use 1 only to verify that there isn't something sitting at 3 or lower, but nothing else should be.

Quote:

Originally Posted by FleaBag (Post 1274957)
vBSEO is already at 5. You browse plugins in ACP and click edit to change the order.

I think I spoke too soon... I sucessfully posted a URL, but the next one I tried resulted in vBSEO replacing the string again. The only thing I did in between was to try and edit an old post, to see if it would have any effect. Maybe editing the post is causing the issue.

I don't use any of the hooks for post editing, but vbseo may well be doing so. However, if the mod has already converted it to bbcode, then vbseo won't be able to touch it in the edit (since it won't see it as a link).

Quote:

Originally Posted by hornstar1337 (Post 1274954)
that is what im thinking, and how do you change the execution order ^^
Maybe vbseo execution order could be changed a little higher, could be worth asking vbseo as well.

Not needed. My mod is now at 3, vbseo default is at 5, which is also fine. Provided you've reinstalled my mod - everything should now be working.

Lizard King 06-23-2007 11:35 PM

The - problem has been solved. My other problem [YOUTUBEvid]C7V3WCy1Ozc[/youtubevid] was a conflict with another Youtube video bbcode i disabled this to test and now it works. However i have tons of messages using this tag.

mfyvie 06-23-2007 11:35 PM

Quote:

Originally Posted by nfn (Post 1274914)
Here is the first contribution.

http://videos.sapo.pt

Just to let you know - this is now included in the current version. I loosened the logic on the regular expression a little in line with some changes I made to all the others. Seems to work fine on my board.


All times are GMT. The time now is 11:56 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01348 seconds
  • Memory Usage 1,755KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (10)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete