vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.6 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=194)
-   -   Add-On Releases - vBRecycle v3.0.9 (https://vborg.vbsupport.ru/showthread.php?t=138106)

itsblack 04-20-2007 12:10 PM

It will be nice let the cron job just delete the threads in recycle bin for x days old, but not empty them all.

mhmd1983 04-20-2007 02:01 PM

man , this really great mod you have just upgrade thanks , installed

mfyvie 05-18-2007 12:11 PM

Quote:

Originally Posted by soulface (Post 1172874)
2 uncached templates on recycle forum.


1 uncached templates on forums, where threads moved to recycle forum.

I found some more. This means that the total of uncached templates in this mod are as follows:

View thread:
vbrecycle_stt

View forum:
vbrecycle_blank
vbrecycle_fdt

View recycle bin
vbrecycle_fdt
vbrecycle_tools

According to this post the best person to address these issues is the mod author, since this template caching should be incorporated into the mod itself.

I'm investigating how to do it myself, but it should probably also be addressed for future of the mod.

djbaxter 05-18-2007 12:55 PM

Pardon a novice question, but why is an uncached template a problem? :o

mfyvie 05-18-2007 01:15 PM

Uncached templates impact server performance, especially on busier systems

mfyvie 05-18-2007 01:42 PM

Ok, well I tried to fix this uncached templates issue. I got about half way through, but couldn't find the correct place in the code to insert the changes.

I'll have to shelve this idea and hope that the original author picks up this issue. I have a system which is getting very close to capacity, so I really need to make things are optimised properly...

mfyvie 05-24-2007 04:51 PM

For those people running Moderation Auto-PM I've just released a bridge mod between vBRecycle and Moderation Auto-PM. It extends the functionality of Moderation Auto-PM to also generate PMs to users when the recycle function is used.

You can find this mod here.

mfyvie 05-25-2007 01:24 PM

I've managed to produce a plugin that fixes the uncached templates with this mod, as well as make another plugin that extends the functionality into searches. I've also fixed a small bug. I'll cover each point one by one.

Rather than have these fixes available as a separate file, it would be really great if Computer_Angel could merge these changes into a new version, that way everybody could benefit from the changes.

Uncached templates fixed

If you install the plugin attached to this post you'll find that all templates are now being cached correctly.

Recycle option now appears in searches

There is now an extra plugin that will show the recycle option on the moderator menu when viewing search pages. You are already allowed to select moderation options for threads displayed as search results, so why not have the recycle option here too?

This extra plugin is also included in the same file attached to the bottom of this message.

Bug fix - recycle options no longer appear in recycle bin

I discovered that when viewing threads which are already in the recycle bin the move to recycle option appeared. The same happened when viewing the forum view in the recycle bin. Since it doesn't make any sense to move a thread or threads to the same place the following edits will make sure that you don't get offered this option when in the recycle bin.

In your admincp select Plugins & Products -> Plugin Manager -> *vBRecycle v3* - Forum Display - Edit Template

Find:

Code:

$vbulletin->templatecache['FORUMDISPLAY'] = str_replace(
        array(
                '$vbphrase[delete_threads]</option>',
                '$navbar'
        ),
        array(
                '$vbphrase[delete_threads]</option> $vbrecycle_fdt',
                '$navbar $vbrecycle_tools'
        ),
        $vbulletin->templatecache['FORUMDISPLAY']
);

Replace with:

Code:

if ($vbr_ifr['recycle']==1) {
    $vbulletin->templatecache['FORUMDISPLAY'] = str_replace(
            array(
                    '$vbphrase[delete_threads]</option>',
                    '$navbar'
                ),
            array(
                    '$vbphrase[delete_threads]</option> $vbrecycle_fdt',
                    '$navbar $vbrecycle_tools'
            ),
            $vbulletin->templatecache['FORUMDISPLAY']
    );
}

Click save

Then click on *vBRecycle v3* - Show Thread - Edit Template

Find:

Code:

$vbulletin->templatecache['SHOWTHREAD'] = str_replace(
    array(
        '$vbphrase[delete_thread]</label></div>'
    ),
    array(
        '$vbphrase[delete_thread]</label></div> $vbrecycle_stt'
    ),
    $vbulletin->templatecache['SHOWTHREAD']
);

Replace with:

Code:

if ($vbr_ifr['recycle']!=1) {
    $vbulletin->templatecache['FORUMDISPLAY'] = str_replace(
            array(
                    '$vbphrase[delete_threads]</option>',
                    '$navbar'
                ),
            array(
                    '$vbphrase[delete_threads]</option> $vbrecycle_fdt',
                    '$navbar $vbrecycle_tools'
            ),
            $vbulletin->templatecache['FORUMDISPLAY']
    );
} else {
    $vbulletin->templatecache['FORUMDISPLAY'] = str_replace('$navbar', '$navbar $vbrecycle_tools',$vbulletin->templatecache['FORUMDISPLAY']);
}

Please note: This post applies to version 3.0.9 of vBRecycle. I'm not the author of vBRecycle, but since I didn't have much other choice I've fixed this issue for my own board, and just thought I'd share the fixes.

djbaxter 05-25-2007 01:41 PM

Good stuff, mfyvie! :D

Mecho 08-26-2007 05:26 PM

recycle bin set as a default not Searchable , so bin's posts should not appear in NEW POSTS , right ??

thanks


All times are GMT. The time now is 11:43 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01646 seconds
  • Memory Usage 1,751KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (4)bbcode_code_printable
  • (1)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete