vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   Modification Graveyard (https://vborg.vbsupport.ru/forumdisplay.php?f=224)
-   -   Major Additions - iTrader v2.0.1 (https://vborg.vbsupport.ru/showthread.php?t=102965)

Daniel 12-14-2005 10:18 PM

Nicely done :)

akoj 12-14-2005 10:18 PM

Quote:

Originally Posted by The Wise One
try changing

$post[itrader_total]

to

$userinfo[itrader_total]

Did the trick...thanks so much!!!

eoc_Jason 12-14-2005 10:27 PM

akoj - the members_resultsbit is a member search result page. The variable is not $post, it is $userinfo, so use $userinfo[itrader_total]... ;)

The Wise One The phrase 'itrader_positive_feedback' is in the iTrader phrase group which probably isn't loaded. You can create one for whatever the member stuff is supposed to be on or in the GLOBAL group, or just don't use a phrase. ;) Also, you are trying to add the wrong variables, the variables are itrader_total & itrader_pcnt, not tradescore & tradepcnt. ;)

Everything variable-wise should start with 'itrader_' so that it won't ever conflict with other products or variables.

The Wise One 12-14-2005 10:38 PM

Quote:

Originally Posted by eoc_Jason
akoj - the members_resultsbit is a member search result page. The variable is not $post, it is $userinfo, so use $userinfo[itrader_total]... ;)

The Wise One The phrase 'itrader_positive_feedback' is in the iTrader phrase group which probably isn't loaded. You can create one for whatever the member stuff is supposed to be on or in the GLOBAL group, or just don't use a phrase. ;) Also, you are trying to add the wrong variables, the variables are itrader_total & itrader_pcnt, not tradescore & tradepcnt. ;)

Everything variable-wise should start with 'itrader_' so that it won't ever conflict with other products or variables.

thanks man. i pulled those from the itrader_user template thinking they might work if i included the right files. works great now. thanks again.

puertoblack2003 12-14-2005 10:39 PM

Quote:

Originally Posted by akoj
THANKS!! Upgraded on live board and all went well. In the process of deciding where to add in memberinfo and member_results...anyone have any creative ideas? :ermm:


i put mines underneath the referral

The Wise One 12-14-2005 10:43 PM

and just an FYI for ya (very minor but necessary for xhtml compliance)

the following block of code in the itrader_user template contains 4 instances of <br> where they should be <br />

Code:

                                <tr>
                                        <td><b>$vbphrase[itrader_feedback_score]:</b><br><b>$vbphrase[itrader_positive_feedback]:</b></td>
                                        <td><b>$userinfo[tradescore]<br>$userinfo[tradepcnt]%</b></td>
                                </tr>
                                <tr>
                                        <td>$vbphrase[itrader_positive_members]:<br>$vbphrase[itrader_negative_members]:</td>
                                        <td>$userinfo[tradepos]<br>$userinfo[tradeneg]</td>
                                </tr>


eoc_Jason 12-14-2005 10:54 PM

Quote:

Originally Posted by The Wise One
and just an FYI for ya (very minor but necessary for xhtml compliance)

the following block of code in the itrader_user template contains 4 instances of <br> where they should be <br />

lol, minor yes... But I'll make a mental note and correct it for the next release. I'm sure there is other little HTML cleanup that can be done too.

You should of see it before, instead of the little icons I had dropdown boxes like the "quick links" on the navbar, but that ended up looking too messy and I thought the icons were nicer and more informative.

Anyhow, I guess nobody has run into any real problems?

Before anyone says, yes technically an admin could probably rate him/her self by manually typing the URL because of how admin permissions override all the other checks. But if you can't trust the admins who can you trust? lol... All other checks should be kosher, I actually kind of went overboard in most cases, most things are double checked (i.e. checked when they want to go to the new / edit feedback page, and check again when the info is submitted) so they can't try to bypass a page and succeed.

IP checking is done only for members with a score of 5 or below I think, and if a match is found it will email the admin a warning with the IP and link and such. IPs are logged for all transactions & comments, but I just don't have any admin page for it yet.

Spinball 12-14-2005 11:34 PM

Quote:

Originally Posted by eoc_Jason
You would end up with duplicate ratings, truncate the itrader table first. Yes that query *should* work. However after you do that you will need to run a global score update. There is an included PHP file to do that, it's in the extras/admincp folder in the zip.

That SQL statement does indeed work, but the score update also times out.
Jason is there any way that you could possibly do a version of the script which processes a smaller number of records at a time like many other vB scripts?
This way, people with thousands of records stand a chance of upgrading successfully?
Many thanks for your consideration on this.

ryansmith 12-14-2005 11:39 PM

Took me a little while to figure out the templates because I'm not real good at those, but I got it and it works now.

One question though. I did this on a test board and left myself a negative feedback. On my postbit templates, I use the format:

itrader_pcnt% (itrader_total)

That gives you something like 100% (1). When I rated myself a negative, it still says 0% (0) which means it didn't count my negative. Does it count positive feedbacks only, or did I do something wrong?

duskdawn 12-14-2005 11:50 PM

Thank you, Jason, Waiting for this for a long time.


All times are GMT. The time now is 05:35 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01839 seconds
  • Memory Usage 1,750KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_code_printable
  • (5)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (3)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete