vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   Modification Graveyard (https://vborg.vbsupport.ru/forumdisplay.php?f=224)
-   -   Integration with vBulletin - Facebook Connect - Allow your users to login with their Facebook account (for 3.8) (https://vborg.vbsupport.ru/showthread.php?t=203064)

Code Monkey 03-21-2009 06:26 PM

Does this allow people to bypass the forum rules agreement?

Brandon Sheley 03-21-2009 06:59 PM

thanks for the update, I'll update our setup as soon as I get time :up:

jacobi 03-21-2009 07:34 PM

Quote:

Originally Posted by Code Monkey (Post 1773588)
Does this allow people to bypass the forum rules agreement?

Thanks for asking this... I've been wondering, too. That's an important factor for the forum/community I run and a real "deal breaker" for using this mod :)

Ted S 03-21-2009 07:44 PM

The default templates don't check for the TOS but you could easily add this once you have it installed. I've done this for my client installs and can post some code if you need it but basically just edit the template fbconnect_login and the register routine in fblogin.php. it's about 3 lines of code.

GetGamer.com 03-22-2009 01:47 AM

I've installed this mod (just updated to the latest version), and I've got a question about how this mod is supposed to handle existing forum members who want to link up their Facebook account.

What should happen
A person with an existing forum account clicks the Connect with Facebook button. They authorize my Facebook app. They are then presented with an option of selecting a nickname for the forum, or linking to an existing forum account. They choose existing, enter their forum credentials and are now signed in.

Posts that they make are updated on their Facebook Wall.

They leave my site, shut down their computer for the day. The next day, they sign-in to Facebook. Then in another browser tab, they open my forums. The forums should detect that they are signed-in to Facebook and automatically sign them into the forums, using their original forum account (which is now connected to Facebook).

What actually happens
Every time an existing user visits the forums, if they don't select Connect with Facebook, they get logged in the "old way" (no Facebook connection). And if they do select Connect with Facebook, they are prompted (again) to select a nickname or choose an existing account. This should not happen, right?

Is there something wrong with my install of this mod, or is this the way it "works?" Because this seems very wrong.

For what it's worth, this mod seems to work great for Facebook users who don't already have a forum account; the problem is really only with existing forum users.

If you'd like to check it out, I'm using the mod at this site: http://www.bigblueball.com/forums/

drsli 03-22-2009 10:05 AM

Quote:

Originally Posted by jacobi (Post 1773638)
Thanks for asking this... I've been wondering, too. That's an important factor for the forum/community I run and a real "deal breaker" for using this mod :)

I catch this point, but I think, that in most cases the rules are just let through on the nod and if there is someting fishy afterwards with a user, moderation has to be placed anyway.

Crystal Shards 03-22-2009 04:25 PM

Some styles don't use the code you want us to replace and the like. Adobe Blue is one example. Any way around this?

EDIT: Sorry, should have given an example:

Find:
<form action="newreply.php?do=postreply&amp;t=$threadid" name="vbform" method="post"<if condition="!is_browser('webtv')"> onsubmit="return vB_Editor['$editorid'].prepare_submit(0, $vboptions[postminchars])"</if>>
Replace With:
$fb_prepare_submit
<form action="newreply.php?do=postreply&amp;t=$threadid" name="vbform" method="post"<if condition="!is_browser('webtv')"> onsubmit="return fb_prepare_submit(this, 0)"</if>>

I can't do that with some of the templates.

Also, how are they supposed to add the application on Facebook if it goes straight back to the site?

drsli 03-22-2009 04:57 PM

I had to uninstall unfortunately, cause I didn´t get my existing vb-account to connect to facebook.

Hopefully I´m not wrong: if new users are connecting via facebook and if their new vb-accounts are solely related to the addon, their vb-accounts would break, if the addon isn´t compatible any more or is uninstalled?

Or does the addon create a regular vb-account (with the facebook-password), which is independent from the addon in the future, that means a login without connecting to facebook would be possible for the users too, who initially connected via facebook?

Code Monkey 03-22-2009 05:08 PM

Quote:

Originally Posted by drsli (Post 1774063)
I catch this point, but I think, that in most cases the rules are just let through on the nod and if there is someting fishy afterwards with a user, moderation has to be placed anyway.


You're missing the point. It's so later you can say "you agreed to the rules of registration" when you joined or connected with FB the first time. It's an important legal issue for some.

Ted S 03-22-2009 05:26 PM

Quote:

Originally Posted by Code Monkey (Post 1774360)
You're missing the point. It's so later you can say "you agreed to the rules of registration" when you joined or connected with FB the first time. It's an important legal issue for some.

Definitely is. I imagine the rules tool will be added shortly to this awesome mod but in the mean time for those who need it today, here's how to do it:

Part I - Check that the TOS was agreed to

Step 1: Open fblogin.php
Step 2: Go to line 93 or just after the code:

Code:

$vbulletin->input->clean_array_gpc('p', array(
  'username'            => TYPE_STR
 ));

Step 3: Add the following code:

Code:

// add tos check -- HACK
 $pagenumber = $vbulletin->input->clean_gpc('p', 'agree', TYPE_BOOL);
 if (!$vbulletin->GPC['agree'])
 {
  eval(standard_error(fetch_error('register_not_agreed')));
 }
 // end tos check

Part II - Asking the user to agree

Step 1 - Open the template fbconnect_login
Step 2 - Find the code

Code:

</fieldset>
Step 3 - After this code add:

Code:

<input type="checkbox" name="agree" value="1" checked="checked" style="font-size:11px;" />
  I agree to abide by the XYZ <a href="#" onclick="window.open('/XXXX.php','review','resizable=yes,scrollbars=yes,height=480,width=640');">Terms of Service</a>.

Step 4 - Change the above code to reflect your forum name and the path to your forum rules. The rules will be shown in a popup window.

Hope I'm not stepping on any toes here. Just thought this could help some people who have concerns get by until the mod can be upgraded.


All times are GMT. The time now is 10:32 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01728 seconds
  • Memory Usage 1,752KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (4)bbcode_code_printable
  • (4)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (3)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete