![]() |
Quote:
You're welcome to try it out yourself. Post a review and you'll see what it does. http://www.enworld.org/forum/productforums.php |
1 Attachment(s)
Quote:
Can you run this version of forum/productforums.php and see if the review saves to the database? Nothing will change in your styling. |
Quote:
The database entry contains the full text of the review, with all formatting stripped. I've double checked by copying and pasting it from PHPMYADMIN to Notepad, and there are no tags or breaks of any kind there. (Also, somewhat unfortunately, the new file undoes some changes I made which allowed me to do the latest reviews page and show publisher names next to product names; that's not too serious for the moment though). |
1 Attachment(s)
Quote:
If not, try opening up the template prodforums_review_create and use this version: These changes... were they hacks to the code and if so, at what points (so I can make them into hooks). |
Quote:
Quote:
I can upload it if you're curious (or, hell, if anyone else wants to use it). |
Quote:
|
Quote:
|
Quote:
Also, I've got a test account on your site... any sub-forums with reviews enabled that I can get too (it's "Ted S"). |
Quote:
Also the same when I try iOS. I turned off the automatic thread creation in forums (and that template change for the forum didn't seem to be working anyway). The reviews are at the default location, though. |
Quote:
|
Quote:
Nope, no difference. Now to go and turn them all back on again one at a time.... |
Incidentally, what was the productforums.php change you made? I'd like to re-upload my custom version and restore various bits of functionality, but with the posting-to-database issue fixed. Is it a small change I can apply myself?
|
Quote:
Speaking of code hacks, let's open up productforums.php and find: Code:
// make the post as HTML using the right version of wysiwyg Code:
if ($vbulletin->GPC['message']) This is not safe content filtering so be sure to revert to your current version when you're done, less someone decide to add a bunch of unfiltered links to a product. |
Quote:
1) It rejected my review saying it had 0 characters. 2) Plus it had this at the top of the screen: Quote:
|
Quote:
Code:
if ($vbulletin->GPC['message']) { echo "found on message<br>"; $comments = nl2br($vbulletin->GPC['message'); } |
So do I need to do anything now, or do you have what you need?
|
Quote:
On a related note, I'm traveling tomorrow - monday without web access. Sorry. :erm: |
Quote:
Quote:
|
Quote:
|
Quote:
|
Quote:
|
Hi Ted,
I'm trying the plugin on a 4.2.2 but each time I try to add an item from the acp The first field of the page is "Forum" if I click on it is empty and let me go back to add the empty fields :( |
Quote:
|
Ted, I've been trying to play around with the code for a few days now to figure out a way to either create a wishlist per user (user click on 'Want' and it adds it to a Want Profile tab) or allows them to favorite a product (similar to wishlist idea). Anything like that coming down the pipe because my coding skills are very basic at the moment.
|
Quote:
|
1 Attachment(s)
Ted - got another question for you.
I'm trying to import a large amount of products into the review system. When I tested the file that was provided as a sample, it worked like a charm. I then decided to create a new one with about 50 different products in it. I pulled the data from a site, exported into a csv and then converted into XML. When I go to import those 50 new products, I get two issues - 1. If any of the text fields have an apostrophe in them, it breaks the import an generates a SQL error. 2. After loading about 2-3 products, it starts to import the next one but then just stops. I've attached the XML for you to look at. At this point though, I'm stumped as to what is going wrong. |
Are you importing images along with the product data?
|
Quote:
|
What's the error on #1 and do you get any feedback at all on #2 (how far does it get if not)?
|
1 Attachment(s)
Quote:
post on line 1840 in /home/swtfyw/public_html/dbtech/vbactivity/includes/class_core.php #0 /home/swtfyw/public_html/dbtech/vbactivity/includes/class_core.php(1911): VBACTIVITY::check_feature('achievement', '5', Array) #1 /home/swtfyw/public_html/dbtech/vbactivity/hooks/threadfpdata_postsave.php(52): VBACTIVITY::check_feature_by_typenames('achievemen t', Array, Array) #2 /home/swtfyw/public_html/includes/class_dm_threadpost.php(1955) : eval()'d code(1): require('/home/swtfyw/pu...') #3 /home/swtfyw/public_html/includes/class_dm_threadpost.php(1955): eval() #4 /home/swtfyw/public_html/includes/class_dm_threadpost.php(1785): vB_DataManager_Thread_FirstPost->post_save_each(true) #5 /home/swtfyw/public_html/includes/functions_newpost.php(697): vB_DataManager_Thread_FirstPost->save() #6 /home/swtfyw/public_html/admincp/productforums.php(1701): build_new_post('thread', Array, Array, Array, Array, Array) #7 {main} Edit: Ok, just tried disabling vBActivity and then importing and it now works. However, a new issue I noticed is that for every word in the product title that has a letter 'd' in it, it automatically adds a j after the d. For instance, armageddon becomes armagedjdjon. I double checked the XML file to make sure the words were not spelled in correctly and the issue definitely does not lie there. Edit #2: After looking at the j issue some more, it really gets bizarre. The thread is created without the letter j in it but the product title has the j in it. See attached. |
Yuck. I'll dig in shortly... sorry!
|
Quote:
PHP Code:
Still doesn't work well with vBActivity but no a big deal. I'll just shut off vBActivity when I do the mass upload. Thanks for trying to help me through it. Now, only if you could do that hard part for me and build out that Wants/Gots function ;) |
Quote:
Looking into vBa (any bug is a bad bug) and that other thing this weekend. |
Do you have any mods / addons that impact the activity system?
The line with the error is calling up the hook "threadfpdata_postsave" and I'd like to fix that less is impact the frontend features (which use the same build_post routine). |
Quote:
Also, I think I found another small bug that probably needs some kind of SQL script run to fix it. When importing about 1700 products, I realized I imported them all into the wrong category. So, I fixed the issue in the XML and then re-uploaded to overwrite the data with the correct categoryid. It overwrote the data and corrected the categoryid and category name. However, the category count in the style dropdown in both admincp and frontend show the incorrect count number. Not sure the correct SQL syntax to use to fix the category count number. Edit: If you want access to admin on my site, let me know and I can send you a PM with the details. Edit #2: Just fixed the incorrect count number. Went into one of the revised items in the category just to ensure everything was correct after re-upload. All data was fine. I re-saved the item record and the count fixed itself. So the XML import overwrite won't actually fix the count until you edit a record and save again. |
Suspect that addon is doing it (not a negative to the addon, it's just likely colliding between things). I'll take a look.
As for counts, that's an easy fix I'll add in along with the character mapping. Just has to recalc at the end of the import process. Anything else strike you as off while I'm working on these tweaks? |
Quote:
I really haven't found many other issues, just those bugs listed above at this point. The special character bug doesn't speak to the function not being used much. My site focuses around beer and there's tons of beers from all over the world that have funky names and characters. I think that's the only reason why I caught it and no one else did. Sorry for pestering you with all these small tweaks. I'd do it myself but I'm really only good at reading and small tweaks to code. I'm not capable of building my own yet. Btw, great job on this mod! Love it compared to the other review mods out there. Quite a few functions that others are missing. |
So I revisited this to see if I could get it working the way I wanted it to. The post formatting issues I was having above I've decided to accept, and simply tell my users it's for a short unformatted comment rather than a full review.
The last thing I need to do is to add an extra field for external reviews, so users cna use it in a Metacritic kinda way. So here's what I did: - I changed the "Your location" text to "Original Review Location", and added some verbiage to tell the user to enter the URL of the full review in that box, and a short summary in the main message area. - All good so far. But I can't figure out which template I change to so that I can turn that into a link rather than plain text when the actual review is displayed. Ideally, what I plan to do is post a little icon, and link that to the entered URL. I figure that's an easy template edit if I can figure out which template I need to edit. |
Also, any idea why this code isn't working? I thought it was the same code I was using before, but reviews stick at the rating of the first review, and don't alter when new reviews are added.
Quote:
|
I got that code working (redid it - took the original averaging code and just applied a multiplier).
I haven't managed to figure out the location thing, though. I have added a column to display the added date (which I've renamed release date). Only issue there is you have to use PHPMYADMIN to edit the dates after they are added, but it's doable. The main reason I wanted to do that was so I could add upcoming products, but have them not show a review link until the release date. I can't for the life of me figure out how I compare today's date to that date in a bulletin template conditional, though. I suspect it's not possible. Here's where I am so far. It looks quite good, I think, though the code and templates are probably now a hideous mess: http://www.enworld.org/forum/productforums.php |
All times are GMT. The time now is 05:39 AM. |
Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information | |
---|---|
|
|
![]() |
|
Template Usage:
Phrase Groups Available:
|
Included Files:
Hooks Called:
|