vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 4.x Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=245)
-   -   Major Additions - Yet Another Awards System (https://vborg.vbsupport.ru/showthread.php?t=232684)

blackberry 08-13-2015 03:27 PM

In PM, the award image is not shown, instead link is been displayed.. How to edit the path? It is not pointing correctly.
Note: Only PM doesn't show image of award.

squidsk 08-13-2015 08:05 PM

Quote:

Originally Posted by blackberry (Post 2552767)
In PM, the award image is not shown, instead link is been displayed.. How to edit the path? It is not pointing correctly.
Note: Only PM doesn't show image of award.

You've installed the mod incorrectly or you don't have the most recent version as that bug was fixed in 4.0.7.

CAG CheechDogg 08-14-2015 01:47 AM

Quote:

Originally Posted by squidsk (Post 2552805)
You've installed the mod incorrectly or you don't have the most recent version as that bug was fixed in 4.0.7.

No squidsk even the latest version does that .... it also does it when you add the awards in the admin cp....

For the award icons you can only use the relative url , if you use the absolute url it will not show up anywhere ...

For the award image you can only use the absolute url and not the relative or it will not show up anywhere ... this was already mentioned in another post and I also sent you a PM about this a while back ...

https://vborg.vbsupport.ru/external/2015/08/11.jpg

Below is how you have to set up the icon and image urls for it to show up correctly in the awards.php and in PMs , it wont show the award image in the admin cp but it at least shows it everywhere else ...

https://vborg.vbsupport.ru/external/2015/08/12.jpg

e24h 08-14-2015 08:54 AM

So why is it handing out awards every hour for post count.?
Isn't it going to check if they have the award.?

People will have hundreds of the same award by the end of the week. lol

killah360z 08-14-2015 09:39 AM

Quote:

Originally Posted by e24h (Post 2552851)
So why is it handing out awards every hour for post count.?
Isn't it going to check if they have the award.?

People will have hundreds of the same award by the end of the week. lol

something to do with your settings

blackberry 08-14-2015 10:07 AM

Quote:

Originally Posted by squidsk (Post 2552805)
You've installed the mod incorrectly or you don't have the most recent version as that bug was fixed in 4.0.7.

i am using version 4.0.9. It is correctly installed and still the error is same. If you could point the way to fix path. It shows /forum/forum twice in PM.

blackberry 08-14-2015 10:08 AM

Quote:

Originally Posted by CAG CheechDogg (Post 2552824)
No squidsk even the latest version does that .... it also does it when you add the awards in the admin cp....

For the award icons you can only use the relative url , if you use the absolute url it will not show up anywhere ...

For the award image you can only use the absolute url and not the relative or it will not show up anywhere ... this was already mentioned in another post and I also sent you a PM about this a while back ...

https://vborg.vbsupport.ru/external/2015/08/11.jpg

Below is how you have to set up the icon and image urls for it to show up correctly in the awards.php and in PMs , it wont show the award image in the admin cp but it at least shows it everywhere else ...

https://vborg.vbsupport.ru/external/2015/08/12.jpg

did you post images? I cant see how to fix?

CAG CheechDogg 08-14-2015 11:25 PM

That is the fix right there ... for the icons used relative url: images/medals/icons/your_icon_file

For the image url use the full url: h t t p://www.your_domain.com/your_forum_root/images/medals/your_image_file

squidsk 08-17-2015 03:13 PM

Quote:

Originally Posted by blackberry (Post 2552767)
In PM, the award image is not shown, instead link is been displayed.. How to edit the path? It is not pointing correctly.
Note: Only PM doesn't show image of award.

I'm unable to reproduce this. If I use either an absolute or relative url I see the image in PMs that are issued.
Is your site running on https? Have you renamed your admincp and/or modcp directories?

Quote:

Originally Posted by CAG CheechDogg (Post 2552824)
No squidsk even the latest version does that .... it also does it when you add the awards in the admin cp....

For the award icons you can only use the relative url , if you use the absolute url it will not show up anywhere ...

For the award image you can only use the absolute url and not the relative or it will not show up anywhere ... this was already mentioned in another post and I also sent you a PM about this a while back ...


Below is how you have to set up the icon and image urls for it to show up correctly in the awards.php and in PMs , it wont show the award image in the admin cp but it at least shows it everywhere else ...

I can't reproduce the error. I'm able to use both a relative url and an absolute url to display award images. Have you renamed your admincp and/or modcp directories? I also notice that your admincp/award.php page has also been customized since it's displaying the point value of the awards which isn't included by default, though really it should be, perhaps something with your customization is causing problems.

blackberry 08-17-2015 06:46 PM

Quote:

Originally Posted by squidsk (Post 2553062)
I'm unable to reproduce this. If I use either an absolute or relative url I see the image in PMs that are issued.
Is your site running on https? Have you renamed your admincp and/or modcp directories?

not using https.. but did renamed directories for security reasons. I would be better if we are able to edit path within any php file etc.

blackberry 08-17-2015 06:51 PM

Quote:

Originally Posted by CAG CheechDogg (Post 2552918)
That is the fix right there ... for the icons used relative url: images/medals/icons/your_icon_file

For the image url use the full url: h t t p://www.your_domain.com/your_forum_root/images/medals/your_image_file

ahaan ok got it

and its fixed.:D

squidsk 08-17-2015 06:55 PM

Quote:

Originally Posted by blackberry (Post 2553078)
not using https.. but did renamed directories for security reasons. I would be better if we are able to edit path within any php file etc.

When you uploaded the most current version did you remember to rename the admincp/modcp folder in the upload folder to your renamed admincp/modcp names?

CAG CheechDogg 08-18-2015 02:16 AM

Quote:

Originally Posted by squidsk (Post 2553062)
I'm unable to reproduce this. If I use either an absolute or relative url I see the image in PMs that are issued.
Is your site running on https? Have you renamed your admincp and/or modcp directories?



I can't reproduce the error. I'm able to use both a relative url and an absolute url to display award images. Have you renamed your admincp and/or modcp directories? I also notice that your admincp/award.php page has also been customized since it's displaying the point value of the awards which isn't included by default, though really it should be, perhaps something with your customization is causing problems.

My site "IS" running on https, we discussed this months ago when I first installed this mod ...

I have also renamed my admincp and mocp, but this was happening before I installed BOP5's mod to rename the register.php which renames bot the admincp and modcp found here:https://vborg.vbsupport.ru/showthrea...ENAME+register

my adminc/award.php page only has css modifications, the point value I add it manually to the description lol ...

So no, none of my customizations are causing the problem, this was happening way before. I actually don't have any problem because the images appear everywhere except in the admincp when managing each award the way it shows in the screenshots I posted ... So really it's no big deal for me ....


Squidsk, this is what you posted when I first brought up the issue of the images and the urls:

Quote:

Originally Posted by squidsk (Post 2349060)
I don't see anything in the code that would cause absolute urls to fail. The default medals use absolute url and they display without a problem. As for relative urls not working, its because the [img] tag does not handle relative urls.

Here is the first time I posted about this issue:
https://vborg.vbsupport.ru/showpost....postcount=1182

Then you replied with this:

https://vborg.vbsupport.ru/showpost....postcount=1189

Then you replied with this lol ..:

https://vborg.vbsupport.ru/showpost....postcount=1199

Originally Posted by CAG CheechDogg View Post

Ah snaps! Makes sense..so If I enable html just in that forum it should be fine right?

No, because the post was created with the assumption that html would not work, so bbcode was used instead. The problem is that the bbcode does not handle relative links. A fix to the bbcode, no likely to be done, or a fix to the code to generate that post which prepends the site url to relative urls needs to be done. I can likely do the second, but wouldn't count on jelsoft doing the first. They may even have reasons for not doing it, which if I were to guess it would be because it is too difficult to determine what a valid relative url looks like.



Like I said no big deal really, I can live with this little bug because everything else works just fine ....

CAG CheechDogg 08-18-2015 02:22 AM

I have a request Squidsk ...

Is it possible to add a feature to approve more than one award request from the award request page instead of doing them one by one?

alcazarx 08-18-2015 05:59 PM

That could be done with a checkbox under "options" and two buttons below the list "grant selected awards" / "delete selected awards".
But this would require JavaScript me thinks and unfortunately me dont know JS :(

/* edit
CAG, you really have some nice medals/awards on your page :cool:
*/

/*
another edit:
*/
Dont know if this a bug or a feature :p ,but even when you set awards to not be recommended or requested you can by using the direct link (like ".../forum/request_award.php?award_id=6") and changing the award_id.
Maybe an oversight by master squidsk? :rolleyes:

squidsk 08-20-2015 06:31 PM

Quote:

Originally Posted by blackberry (Post 2553078)
not using https.. but did renamed directories for security reasons. I would be better if we are able to edit path within any php file etc.

Not sure what you mean, it would be pretty horrible to force people using yaas to have to edit every file just to change the path to an award. The path is set through admincp individually for each award and the path is stored with the award information in the database.

Quote:

Originally Posted by CAG CheechDogg (Post 2553128)
My site "IS" running on https, we discussed this months ago when I first installed this mod ...

I have also renamed my admincp and mocp, but this was happening before I installed BOP5's mod to rename the register.php which renames bot the admincp and modcp found here:https://vborg.vbsupport.ru/showthrea...ENAME+register

my adminc/award.php page only has css modifications, the point value I add it manually to the description lol ...

So no, none of my customizations are causing the problem, this was happening way before. I actually don't have any problem because the images appear everywhere except in the admincp when managing each award the way it shows in the screenshots I posted ... So really it's no big deal for me ....

It isn't the change the register.php mod because I added that to my test install and it causes no issues. The reason it's kind of confusing is that the code that shows the images for both the award icon and award image are the same. They are both done using calls to construct_img_html, see lines 1028/1029 for non-categorized awards and lines 1093/1094 for categorized awards. So if absolute is working for the icon image it should work for the other image. Similarly if relative urls are working for

Quote:

Squidsk, this is what you posted when I first brought up the issue of the images and the urls:
I'd forgot about that.

Quote:

Here is the first time I posted about this issue:
https://vborg.vbsupport.ru/showpost....postcount=1182

Then you replied with this:

https://vborg.vbsupport.ru/showpost....postcount=1189

Then you replied with this lol ..:

https://vborg.vbsupport.ru/showpost....postcount=1199
The first part is where I'm talking about the absolute urls in admincp, even then I couldn't find a reason why they weren't showing for you. The second part was about images not showing up in PMs because of how the image bbcode was parsed. I fully fixed the second issue in 4.0.7, but clearly the first is still there.

Quote:

Like I said no big deal really, I can live with this little bug because everything else works just fine ....
It might not be a big deal but it still bugs me that there's a problem somewhere in the code, or in compatibility with something else, and I can't figure it out.

Quote:

Originally Posted by CAG CheechDogg (Post 2553129)
I have a request Squidsk ...

Is it possible to add a feature to approve more than one award request from the award request page instead of doing them one by one?

I'll look into it.

Quote:

Originally Posted by alcazarx (Post 2553171)
That could be done with a checkbox under "options" and two buttons below the list "grant selected awards" / "delete selected awards".
But this would require JavaScript me thinks and unfortunately me dont know JS :(

That's how I'd do it.
Quote:

/*
another edit:
*/
Dont know if this a bug or a feature :p ,but even when you set awards to not be recommended or requested you can by using the direct link (like ".../forum/request_award.php?award_id=6") and changing the award_id.
Maybe an oversight by master squidsk? :rolleyes:
Definitely not a feature but an oversight.

akz645 08-20-2015 08:01 PM

Quote:

Originally Posted by squidsk (Post 2553340)
I'll look into it.

Did you see my suggestions?

Quote:

Originally Posted by akz645 (Post 2551912)
Suggestion:
- Option for awards to be stackable.
Example:
https://vborg.vbsupport.ru/external/2015/08/17.png

I would be ever so grateful, if you could make this possible :)

Edit:
Suggestion 2:
- Allow users to arrange which order they they wish to display their awards in their postbit via UserCP.
Example: Like the Navigation bar display order, they can assign numbers. The lower the number assigned, the higher up in the postbit the award they've earned will be displayed.


CAG CheechDogg 08-21-2015 01:12 AM

Quote:

Originally Posted by squidsk (Post 2553340)

It isn't the change the register.php mod because I added that to my test install and it causes no issues.

It might not be a big deal but it still bugs me that there's a problem somewhere in the code, or in compatibility with something else, and I can't figure it out.

I'll look into it.

Yeah I also don't believe it's the register.php mod at all ... I just mentioned it because you asked if I had renamed my admincp and that mod renames the admincp and modcp as well ...

Thanks for looking into possibly adding the mass approve feature that would be some awesomeness !!!

And yes I know what you mean about the "bug" ... it bugs the heck out of me as well when I can't figure something out as well ...

blackberry 08-21-2015 11:28 AM

Quote:

Originally Posted by squidsk (Post 2553340)
Not sure what you mean, it would be pretty horrible to force people using yaas to have to edit every file just to change the path to an award. The path is set through admincp individually for each award and the path is stored with the award information in the database.

Never mind tt is fixed now :)

squidsk 08-21-2015 08:19 PM

Quote:

Originally Posted by akz645 (Post 2553343)
Did you see my suggestions?

Yes. At this time only the second might get implemented at some point as the first would require a significant amount of work to change the mod to implement.

squidsk 08-25-2015 02:44 PM

Quote:

Originally Posted by CAG CheechDogg (Post 2553361)
And yes I know what you mean about the "bug" ... it bugs the heck out of me as well when I can't figure something out as well ...

By total fluke while working on something else I was finally able to replicate the issue that's causing the absolute urls not to display while in admincp. The reason I wasn't able to find it before is the issue only occurs with absolute url's that use https instead of http. Now I'm going to have to figure out how to fix it, but it definitely will be fixed in the next release. It should still work for all relative links (i.e. all links like image/medals/...)

CAG CheechDogg 08-25-2015 07:59 PM

Quote:

Originally Posted by squidsk (Post 2553618)
By total fluke while working on something else I was finally able to replicate the issue that's causing the absolute urls not to display while in admincp. The reason I wasn't able to find it before is the issue only occurs with absolute url's that use https instead of http. Now I'm going to have to figure out how to fix it, but it definitely will be fixed in the next release. It should still work for all relative links (i.e. all links like image/medals/...)

HA!!! good stuff my Man !!!

So what else are you going to try and add to the next release?

Point value in the awards page by default? :D

Mass award approval? :p

Tell me ! tell me !!! MUAHAHAHAA !!!:rolleyes:

alcazarx 08-26-2015 11:20 AM

+ fix that "bug" in #1775
+ add permission as in #1731
+ modcp option as in #1723

:D

Mangahaven 09-01-2015 01:27 PM

Might have been answered already, but will this plugin work for vb 4.2.X ?

squidsk 09-01-2015 02:15 PM

Quote:

Originally Posted by Mangahaven (Post 2554039)
Might have been answered already, but will this plugin work for vb 4.2.X ?

Yes. The version listed at the top is the minimum version required for this mod, not the maximum.

Mangahaven 09-01-2015 05:13 PM

Quote:

Originally Posted by squidsk (Post 2554040)
Yes. The version listed at the top is the minimum version required for this mod, not the maximum.

Ah thanks. I'm relatively new to the scene, so the info escaped me.

Thank you. Will likely install this bad boy.

Bit 11-09-2015 05:55 PM

Great add-on! Will this be ported for 5.x?

squidsk 11-09-2015 06:46 PM

Thanks, and certainly not before 5.2 comes out and unlikely for the foreseeable future afterwards.

CAG CheechDogg 12-20-2015 03:55 PM

Can you give extra permission so that Super Moderators can view the Award Requests and grant them from the Admin Control Panel?

So this is what I actually want, Super Moderators to be able to administer everything except for Award settings, or be able to give them individual permissions on all of the menu items in the Admin Panel. Can you make this happen my Man?

alcazarx 12-20-2015 06:43 PM

Award Settings should be only accessible when the user has the "Manage Settings" permission in vB (or how its called) since its linking to the settings page.
Dont know if this can be seperated.
To set permissions for the plugin itself, it should work with custom admin permissions (like we have).
Have to look in our code-change-library for the necessary changes.
Thanks.

squidsk 12-22-2015 01:08 PM

Quote:

Originally Posted by CAG CheechDogg (Post 2560842)
Can you give extra permission so that Super Moderators can view the Award Requests and grant them from the Admin Control Panel?

The easiest way to do that would be have them do it from modcp by copying the award_request.php file to modcp and replacing the permission condition at the top with the one from modcp/award.php.

Quote:

So this is what I actually want, Super Moderators to be able to administer everything except for Award settings, or be able to give them individual permissions on all of the menu items in the Admin Panel. Can you make this happen my Man?
Just make sure the user does not have the can administer settings administration permission.

Quote:

Originally Posted by alcazarx (Post 2560853)
Award Settings should be only accessible when the user has the "Manage Settings" permission in vB (or how its called) since its linking to the settings page.
Dont know if this can be seperated.
To set permissions for the plugin itself, it should work with custom admin permissions (like we have).
Have to look in our code-change-library for the necessary changes.
Thanks.

Admincp and modcp permissions will be in the next release.

CAG CheechDogg 12-23-2015 09:58 AM

Quote:

Originally Posted by CAG CheechDogg (Post 2553129)
I have a request Squidsk ...

Is it possible to add a feature to approve more than one award request from the award request page instead of doing them one by one?

Any news on this for the next update?

Quote:

Originally Posted by squidsk (Post 2553618)
By total fluke while working on something else I was finally able to replicate the issue that's causing the absolute urls not to display while in admincp. The reason I wasn't able to find it before is the issue only occurs with absolute url's that use https instead of http. Now I'm going to have to figure out how to fix it, but it definitely will be fixed in the next release. It should still work for all relative links (i.e. all links like image/medals/...)

How about this, did you figure this out?

alcazarx 12-23-2015 11:35 AM

1 Attachment(s)
Quote:

Originally Posted by squidsk (Post 2560956)
The easiest way to do that would be have them do it from modcp by copying the award_request.php file to modcp and replacing the permission condition at the top with the one from modcp/award.php.

Great idea, thanks.
<-- wonders why we didnt think up of that idea :o ,we did something similar in the past with approving of newly registered members via the modcp.

/* another edit
Our mods reported that they cant "see" the new file in ModCP. So you have to edit the plugin "YAAS - Give Award to User Nav -> mod_index_navigation" in ACP so it looks like
Code:

// *************************************************
    if ($vbulletin->options['aw_modcp'])
    {
        construct_nav_option($vbphrase['give_user_award'], 'award.php?do=manage');
        construct_nav_option($vbphrase['yaas_edit_delete_user_award'], 'award_user.php?do=search');
        construct_nav_option($vbphrase['award_requests'], 'award_requests.php?do=display');
        construct_nav_group($vbphrase['award_system']);
        construct_nav_spacer();
    }

Thanks.
*/

As for permissions - you are the author and decide it - for me it would be sufficient to implement the "can view award list" permission for groups and the "moderator can give this award in modcp" option (when managing awards), both described (and code provided) in earlier posts.
Custom admin permission for the award plugin itself we have already working.

/* edit
Included the code changes for custom admin permission.
Note: These are direct code changes! Use at your own risk!
(Yeah boo me coders and staff, but we are not used to the plugin system and not everything can be done with the hook system.)
*/

squidsk 01-19-2016 09:48 PM

No it isn't.

alcazarx 01-20-2016 06:52 AM

Sorry, but what is
Quote:

Originally Posted by squidsk (Post 2563004)
No it isn't.

? :confused:
Thanks.

squidsk 01-20-2016 02:10 PM

Quote:

Originally Posted by alcazarx (Post 2563017)
Sorry, but what is ? :confused:
Thanks.

It was response to someone, who's since deleted their post, asking if it was possible to remove the Yet Another Awards System link on the awards.php page.

CAG CheechDogg 01-21-2016 01:45 AM

Any update on the mass deletion and mass approval of awards squidsks?

alcazarx 01-21-2016 06:52 AM

Guess they are (maybe) coming with next update/version. :rolleyes:
Our "updates" have been posted here and will work with current version.

squidsk 01-21-2016 02:16 PM

Quote:

Originally Posted by alcazarx (Post 2563116)
Guess they are (maybe) coming with next update/version. :rolleyes:
Our "updates" have been posted here and will work with current version.

Here's the, not complete, list of changes that will be in the next version. I don't do this professionally, and when RL comes along my coding projects all take a back seat, and the last year my coding projects have been in the back a lot.
  • Added - New setting for controlling whether inactive awards are displayed in modcp, default is yes for backwards compatibility
  • Added - New moderator permission for issuing awards, only moderators with this permission will be able to issue awards in modcp
  • Added - New admin permissions, one for issuing awards and one for managing awards
  • Added - Diagnostics to show orphaned rows in the various awards tables
  • Added - Hooks to award_diagnostics.php
  • Added - Hook for deleting an award
  • Added - Edit link to header of award_user.php user page which links to user.php if the admin can admin users
  • Added - View awards permissions
    • only groups with the view awards permission will be able to see awards.php
    • only administrators start with view awards permissions
    • to recommend/request an award users will need the view awards permission in addition to the recommend/request permission
  • Changed - default usergroup permissions for recommend/request awards
    • only administrators have recommend/request permissions (new installs only)
    • all new groups, added post install, do not have the recommend/request award permissions
  • Changed - The award_user template to use {vb:link . . .} syntax
  • Changed - User links in awards.php now direct to award_user.php instead of user.php
  • Changed - Admincp nav items to have admin permissions attached to them, you will only see those items for which you have permissions
  • Fixed - Awards issued in modcp/award.php not showing relative images in PMs
  • Fixed - Awards issued in modcp/award.php and admincp/award.php not showing relative images in emails
  • Fixed - Request/Recommend award link showing on award.php if you can't request or recommend awards
  • Fixed - Missing error checking when recommending/requesting awards
  • Fixed - Absolute url https paths not displaying in admincp/modcp
  • Fixed - Uncategorized awards not displaying on awards.php
  • Fixed - Award requests not being deleted when deleting corresponding award
  • Fixed - Display of user awards in award_user.php not matching other displays

Quote:

Originally Posted by CAG CheechDogg (Post 2563105)
Any update on the mass deletion and mass approval of awards squidsks?

Award requests are being restructured, and on the admincp side I haven't exactly nailed down how the new setup will look.

CAG CheechDogg 01-21-2016 02:41 PM

Good stuff squidsks !!! thank you !!


All times are GMT. The time now is 10:53 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.02695 seconds
  • Memory Usage 1,909KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_code_printable
  • (39)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete