vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 4.x Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=245)
-   -   Miscellaneous Hacks - Rotating Banner System (https://vborg.vbsupport.ru/showthread.php?t=188328)

y2ksw 03-06-2012 08:19 PM

While adding some of the already requested features, revisiting the code, taking notes for the bloody beginners guide and general brainstorming, this is the one of the few occasions to get your 'last minute' smart features added.

Fore the next (coming) release we have:
+ 3 new options for disabling counters and squeeze a tiny bit of performance.
+ default banners locked into database; avoids me to explain how to get banners running and waste my time, while the 'experts' have them already deleted :); they can be modified though.
+ unsigned integers for all those database values which can't be less than 0.
+ external functions file adds php caching if there is one, thus enhances loading and esecution speed and generally reduces memory footprint a little; also solves the rare problem where functions are loaded twice.
+ width and height (if > 0) for img tags.

We won't add now:
- native in-place rotating, because it would add too many new options and a lot of questions I may not answer to.
- image rotation from a folder (N images for 1 banner). it was a nice idea, but unefficient in real live; maybe another time.
- style exclusion; there is no efficient way to know which style is running while handling the final output.
- section exclusion; would be another good reason why banners would not show up at all.
- banner payment, all the related front- and backend forms, scheduling and mails.

Checked:
- mailing feature: works! but it has also a relative option which must be enabled, and a cronjob which must be enabled, too.

y2ksw 03-06-2012 08:22 PM

BTW, I'm currently changing my publisher ID, thus the default banners may not show before the new release.

Videx 03-07-2012 12:01 AM

Feature requests:
  • Change the text from "Please list here one or more mail addresses to inform about banner events." to "A list of email addresses that will receive expiration notices".
  • Add an option to send expiration notices x days prior to expiration.
  • Add links to the phrase with the body and subject of the expiration emails.
  • Clarify option/text "Reset Notifications - If this option is checked, email notifications are enabled again.". There is no apparent reason expiration emails should be disabled, and no option to do it manually, so there's no need to 'enable them again'.

Gripi 03-11-2012 06:21 AM

Feature request:

Banner List > Able to sort the list by position number

thank you

bimmerbuffs 03-11-2012 05:33 PM

When do you anticipate the new release to be available?

MatiasCandy 03-15-2012 02:45 AM

This quit working for me when upgrade to 4.1.11. Anyone else having issues?

y2ksw 03-15-2012 09:30 AM

Quote:

Originally Posted by bimmerbuffs (Post 2308588)
When do you anticipate the new release to be available?

Quote:

Originally Posted by MatiasCandy (Post 2309561)
This quit working for me when upgrade to 4.1.11. Anyone else having issues?

I'm waiting for my Google Publisher Code. Until then, I can't publish the upgrade, the default banners will not show up and it may look as if it doesn't work - but it surely is :)

rhody401 03-15-2012 02:23 PM

I upgraded from 4.1.10 to 4.1.11, and all is well here. Granted, I'm just using png files with links - not adsense.

bposner 03-15-2012 06:38 PM

for some reason the banners, even though have the correct url, are linking to:

"http://www.forumname.com/forum/www.f...?id=3&userid=1"
Thoughts?

(site name changed for this post)

bposner 03-15-2012 08:25 PM

Quote:

Originally Posted by MatiasCandy (Post 2309561)
This quit working for me when upgrade to 4.1.11. Anyone else having issues?

Yes, banners are not linking to url, it adds a 2nd link, like this "www.forumname.com/forum/www.forumname.com/forum/rbs_banner.php?id=3&userid=1"

MarkusB 03-16-2012 12:40 AM

Hmm

Possibility to exclude/include each single Banner-ID from CMS, Blog,Forum,Forumhome by radio buttons would be fine if there is a reasonable way for doing so :up:

MarkusB 03-16-2012 12:53 AM

Quote:

Originally Posted by bposner (Post 2309850)
Yes, banners are not linking to url, it adds a 2nd link, like this "www.forumname.com/forum/www.forumname.com/forum/rbs_banner.php?id=3&userid=1"

bsponer, try to use the textfield and put Banner code in there, instead of the URL and Image field.
That should fix it temporary until its solved. (might be than the click counter will not work...) ;)

viper357 03-16-2012 08:53 AM

This new time feature where it sends out emails before the banners expire is definitely not working for me on 3.8.5. It works fine if I set it to 0, but I've tried both 7 days and 14 days but no emails get sent out.

y2ksw 03-16-2012 11:54 AM

Quote:

Originally Posted by bposner (Post 2309807)
for some reason the banners, even though have the correct url, are linking to:

"www.forumname.com/forum/www.forumname.com/forum/rbs_banner.php?id=3&userid=1"
Thoughts?

(site name changed for this post)

Try to use full URL's ... maybe you have changed your canonical URL settings or bburl?

y2ksw 03-16-2012 11:55 AM

Quote:

Originally Posted by MarkusB (Post 2309908)
Hmm

Possibility to exclude/include each single Banner-ID from CMS, Blog,Forum,Forumhome by radio buttons would be fine if there is a reasonable way for doing so :up:

Added to wish-list :)

y2ksw 03-16-2012 11:58 AM

Quote:

Originally Posted by viper357 (Post 2309974)
This new time feature where it sends out emails before the banners expire is definitely not working for me on 3.8.5. It works fine if I set it to 0, but I've tried both 7 days and 14 days but no emails get sent out.

I'll check it again.

Videx 03-16-2012 02:04 PM

Quote:

Originally Posted by viper357 (Post 2309974)
This new time feature where it sends out emails before the banners expire is definitely not working for me on 3.8.5. It works fine if I set it to 0, but I've tried both 7 days and 14 days but no emails get sent out.

There needs to be a reminder/link for this setting in the spot where we enter the email addresses, if it's going to be off in a separate Settings>Options page. The last time I set up a banner I completely forgot this setting existed and that I had set it to 7 days long ago. Sorry I have no idea yet if it actually works as my newest banners won't expire for a while.

rezwiebel 03-16-2012 03:30 PM

Hi,

Mod is very good.

But (maybe that was asked in the 100 comments pages before) my problem is, that the div of the banner splits the threadview in half and takes a lot of place. So the text of the post itself (and of the followning posts without banner) are very narrow displayed.

How can i workout, that the text is floating around the banner?

Thanks for help!

Bye
René

MatiasCandy 03-18-2012 08:10 AM

Quote:

Originally Posted by bposner (Post 2309807)
for some reason the banners, even though have the correct url, are linking to:

"http://www.forumname.com/forum/www.f...?id=3&userid=1"
Thoughts?

(site name changed for this post)

make sure you have the http: in the box

"http://www.forumname.com"

MatiasCandy 03-18-2012 08:11 AM

Quote:

Originally Posted by MatiasCandy (Post 2309561)
This quit working for me when upgrade to 4.1.11. Anyone else having issues?

I had wrong Google Pub id in the banner ad. Changed it and no more issues.

Thanks for great Mod and helpful people!

Cheers

y2ksw 03-19-2012 11:47 AM

Quote:

Originally Posted by rezwiebel (Post 2310096)
Hi,

Mod is very good.

But (maybe that was asked in the 100 comments pages before) my problem is, that the div of the banner splits the threadview in half and takes a lot of place. So the text of the post itself (and of the followning posts without banner) are very narrow displayed.

How can i workout, that the text is floating around the banner?

Thanks for help!

Bye
Ren?

The banner div is only an example. You may use any HTML and physical location for your banners.

bposner 03-19-2012 03:10 PM

Quote:

Originally Posted by MarkusB (Post 2309909)
bsponer, try to use the textfield and put Banner code in there, instead of the URL and Image field.
That should fix it temporary until its solved. (might be than the click counter will not work...) ;)

this doesn't work, just displays the actual url not the image

Edit oh, ok, html code, I did that, and it works, see below. Thanks for the workaround!
Code:

<body>
<div align="center"><BR>
<a href="http://www.mysite.com/FAQs" target="_blank"><img src="http://www.mysdite.com/banners/image.jpg" border="0"></a><br>
</div>
</body>

and this seems to work

bposner 03-19-2012 03:11 PM

Quote:

Originally Posted by y2ksw (Post 2310000)
Try to use full URL's ... maybe you have changed your canonical URL settings or bburl?


Sorry, not sure what you mean by changed your canonical URL settings.
I use full urls in the URL field

viper357 03-28-2012 06:42 AM

Quote:

Originally Posted by viper357 (Post 2309974)
This new time feature where it sends out emails before the banners expire is definitely not working for me on 3.8.5. It works fine if I set it to 0, but I've tried both 7 days and 14 days but no emails get sent out.

Quote:

Originally Posted by y2ksw (Post 2310003)
I'll check it again.

Thanks, I've had it set back on 0 but now today I got an email for a banner that expired 5 days ago? Anyway, I would really appreciate it if you could look into it. Thank you.

Tri@de 03-28-2012 07:59 AM

There's a way to display a banner in a certain date?

bposner 03-28-2012 11:42 PM

I still have this problem with all my sites, the banner does not go to the URL it adds
It keeps doing this
Code:


http://www.mustanggenerations.com/forum/www.mustanggenerations.com/forum/rbs_banner.php?id=12&userid=2


nacaruncr 03-30-2012 07:42 PM

I can't do anything to show the banner, I put <!--@vbbanners:0@--> or <!--@vbbanners:0--> in the ad_navbar_below or ad_footer_start and nothing, it doesn't show anyone image, I don't know if I have to put other choise in the code, or what I doing wrong? because I search in the video-tutorial and nothing :S
someone can help me please?

vantastic 03-31-2012 12:21 AM

Great mod. Really easy to use. Thank you.

I have one suggestion though, and that's a dropdown to allow "target" for the url. This would be really neat as some ads are for internal threads, others are for external sites etc.

Currently I'm doing it in the additional text field which is OK, but for ease of use it'd be nice to have this.

Great work otherwise!

sonic83 03-31-2012 05:39 PM

Hello. Thanks for the mod. I rename the folder 'admincp' by 'england2010'. A part of the name of the folder 'admincp' I downloaded renamed 'england2010', do I have to change the name somewhere else?

thank you very much

ptceuro 03-31-2012 08:38 PM

Thanks for the mod!!

y2ksw 03-31-2012 09:33 PM

Quote:

Originally Posted by Tri@de (Post 2314155)
There's a way to display a banner in a certain date?

Yes, just set the start and end date and time accordingly.

y2ksw 03-31-2012 09:36 PM

Quote:

Originally Posted by nacaruncr (Post 2315156)
I can't do anything to show the banner, I put <!--@vbbanners:0@--> or <!--@vbbanners:0--> in the ad_navbar_below or ad_footer_start and nothing, it doesn't show anyone image, I don't know if I have to put other choise in the code, or what I doing wrong? because I search in the video-tutorial and nothing :S
someone can help me please?

Please have a tiny bit more patience (a few days). A few days ago I got my new publisher code and I'm now testing the new release, which comes with a new set of working demo banners. The old demo banners won't work right now.

y2ksw 03-31-2012 09:37 PM

Quote:

Originally Posted by vantastic (Post 2315234)
Great mod. Really easy to use. Thank you.

I have one suggestion though, and that's a dropdown to allow "target" for the url. This would be really neat as some ads are for internal threads, others are for external sites etc.

Currently I'm doing it in the additional text field which is OK, but for ease of use it'd be nice to have this.

Great work otherwise!

I don't see a good way to store landing pages anywhere ... isn't intellisense of your browser good enough?

y2ksw 03-31-2012 09:39 PM

Quote:

Originally Posted by VBLUIS (Post 2315458)
Hello. Thanks for the mod. I rename the folder 'admincp' by 'england2010'. A part of the name of the folder 'admincp' I downloaded renamed 'england2010', do I have to change the name somewhere else?

thank you very much

No, the installation reads the admincp destination from your configuration, thus renaming the package admincp folder should be just fine.

y2ksw 03-31-2012 09:44 PM

Quote:

Originally Posted by bposner (Post 2314506)
I still have this problem with all my sites, the banner does not go to the URL it adds
It keeps doing this
Code:


http://www.mustanggenerations.com/forum/www.mustanggenerations.com/forum/rbs_banner.php?id=12&userid=2


For some unknown reason, sometimes $vbulletin->options['bburl'] translates to these or worse combinations. I solved this issue by using a global replacement (styles) where I would translate 'www.mustanggenerations.com/forum/www.mustanggenerations.com/forum/' to 'www.mustanggenerations.com/forum/'.

I believe it has to do with the Friendly URL settings and Canonical URL's, but I'm not sure about it, nor was I able to reproduce the problem.

Tri@de 04-01-2012 06:03 AM

I want to put in header the banner, but i see the header and the banner. Can i select just the banner?

regd87 04-01-2012 03:50 PM

I've installed this and followed all the directions but it's still not showing at my forum. Help?

vantastic 04-02-2012 02:59 AM

Quote:

Originally Posted by y2ksw (Post 2315526)
I don't see a good way to store landing pages anywhere ... isn't intellisense of your browser good enough?

Sorry maybe I didn't make my suggestion clear. I'll try again.

When setting up an advert, you are prompted for imageurl and url

currently the output is something like:

HTML Code:

<a href="http://www.yoursite.com" target="_blank"><img src="http://yoursite.com/image.png" /></a>

The 'target' should be a variable - so that one can select _blank, _self etc.

sonic83 04-02-2012 06:41 AM

Quote:

Originally Posted by y2ksw (Post 2315527)
No, the installation reads the admincp destination from your configuration, thus renaming the package admincp folder should be just fine.

Thanks for responding. For some reason it does not work. I have version 4.1.10 and reviewing past posts there is only one small mention of this version. They can confirm if it works for 4.1.10?
thanks

Videx 04-02-2012 11:49 AM

Quote:

Originally Posted by VBLUIS (Post 2315937)
Thanks for responding. For some reason it does not work. I have version 4.1.10 and reviewing past posts there is only one small mention of this version. They can confirm if it works for 4.1.10?
thanks

This mod doesn't actually use vb much at all (except for the admincp page), so it works with all versions. Your original question was very confusing and made no sense, having to do with renaming folders or something.


All times are GMT. The time now is 03:15 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.03944 seconds
  • Memory Usage 1,847KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (3)bbcode_code_printable
  • (1)bbcode_html_printable
  • (23)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (2)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete