vb.org Archive - Show Thread Enhancements

Page 45 of 50

« First

Last »

Show 40 post(s) from this thread on one page

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- Modification Graveyard (https://vborg.vbsupport.ru/forumdisplay.php?f=224)

- - Show Thread Enhancements - Who has read a Thread (https://vborg.vbsupport.ru/showthread.php?t=122594)

yinyang

03-14-2008 03:46 PM

NICE! anyone try this on 3.7?

Makc666

03-29-2008 05:44 PM

(View-All)

1.
ACP -> Who Has Read a Thread

Who has read days limit -> 0
Enable thread reset feature -> Yes

2.
Having a very-very old thread.

Code:

"Members who have read this thread : 747 (Set)"

3.
In ACP -> Who Has Read a Thread now set:

Who has read days limit -> 7

4.
Going to the thread again.

Code:

"Members who have read this thread in the last 7 days : 747 (Set)"

5.
In ACP -> Who Has Read a Thread now set:

Who has read days limit -> 1

6.
Going to the thread again.

Code:

"Members who have read this thread in the last 1 days : 747 (Set)"

--------------------------

Also.
If I have noticed that Who has read days limit influence the "(View-All)" URL.

In other words if you have:

Who has read days limit -> 0 then "(View-All)" will show you all users
Who has read days limit -> 7 then "(View-All)" will show you users who has read the thread in last 7 days
Who has read days limit -> 1 then "(View-All)" will show you users who has read the thread in last 1 day

This is very strange.
I think that there is some mess up here.
As "(View-All)" must show all users.
And Who has read days limit must influence who has read a thread feature.

Paul M

03-30-2008 01:24 PM

The day limit is designed as a cutoff for all views (including View-All) so that part is correct - the only bug is that it is not being used if reset is enabled, but no date has actually been set. In this case it defaults to showing all readers of the thread, ignoring the days limit. That is fixed in version 3.7.004 (the 3.7 version). It will not be fixed in the 3.6 version.

Makc666

03-31-2008 06:03 PM

Quote:

Originally Posted by Paul M (Post 1478291)

The day limit is designed as a cutoff for all views (including View-All) so that part is correct

Paul M, a very little question.

I am 100% sure that it will be wonderful if options of this modification allows as to select (set) if we want "View-All" to show as all messages nevertheless (in spite of) "Who has read days limit" option is set to.

It will be really nice if in thread we will be able to see, for example, only last 3 days "reads" and when we press "View-All" we will be able to see all "reads".

Can you please add this one to your future request list?!

Thanks
Maxim

Paul M

03-31-2008 07:27 PM

Sorry but no, the limit is working as designed and I have no intention of changing it.

Makc666

04-02-2008 11:38 AM

Just a little notice.
There is a point in line of file "Who-has-read-thread.xml"

Code:

<title>Who Has Read a Thread.</title>

Quote:

Originally Posted by Paul M (Post 1479348)

Sorry but no, the limit is working as designed and I have no intention of changing it.

I think that adding one little option which will be used in IF condition will not brake any functionality.

Now:

Code:

// Set Cutoff Date //

$cutoff = 0;

if ($vbulletin->options['wrtlimit']) 

{

        $cutoff = TIMENOW - 86400 * $vbulletin->options['wrtlimit'];

}

Will be:

Code:

// Set Cutoff Date //

$cutoff = 0;

if ($vbulletin->options['wrtlimit'] AND $vbulletin->options['wrtlimit_all']) 

{

        $cutoff = TIMENOW - 86400 * $vbulletin->options['wrtlimit'];

}

I am ready to assist you if you don't have time for this one :)

Paul M

04-02-2008 05:58 PM

Quote:

Originally Posted by Makc666 (Post 1480823)

I am ready to assist you if you don't have time for this one :)

Perhaps you didnt understand me. I didnt say anything about not having time. I said I have no intention of changing it. It works as I designed it, and I see no reason to change that design.

Evolution06

04-02-2008 07:15 PM

Awesome mod! this will help my free hosting site I can see who actually read the TOS now.

Makc666

04-03-2008 04:40 PM

Quote:

Originally Posted by Paul M (Post 1481154)

Perhaps you didnt understand me. I didnt say anything about not having time. I said I have no intention of changing it. It works as I designed it, and I see no reason to change that design.

And I thought you didn't understand me :)
The only reasons for this one I proporsed are:

On the viewthread.php page we have to limit the request to save some database time/page load time
It will be nice to see some times all the list of users who read the thread and when

For me it is.
Any way - I can change it for my need any time :)
And maybe my proporse will "help" some one :p

Paul M, thanks for replies :)

Golzarion

04-04-2008 08:55 AM

It does not work with 3.7.0 ! any similar hack for 3.7.0 ?
thx

All times are GMT. The time now is 02:30 AM.

Page 45 of 50

« First

Last »

Show 40 post(s) from this thread on one page

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01401 seconds Memory Usage 1,746KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (6)bbcode_code_printable (4)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (4)pagenav_pagelink (1)pagenav_pagelinkrel (1)post_thanks_navbar_search (1)printthread (10)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: