vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 4.x Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=245)
-   -   Major Additions - Product Review Forums ? Research, Review & Compare Items (https://vborg.vbsupport.ru/showthread.php?t=269808)

Ted S 06-19-2013 10:53 PM

Quote:

Originally Posted by GCC LLC (Post 2429237)
Ted, sent you a PM about it. Thanks!

We handle all support in the thread so other members can chime in with their thoughts and see what's happening with the mod. Thanks for your understanding.

GCC LLC 06-19-2013 11:10 PM

What XML file exactly are you talking about?

Is it 100% safe to reinstall the product over top of itself so that it would install into all skins? I can't find how to check if the hooks are in the mobile theme.

Ted S 06-20-2013 02:00 AM

Quote:

Originally Posted by GCC LLC (Post 2429240)
What XML file exactly are you talking about?

Is it 100% safe to reinstall the product over top of itself so that it would install into all skins? I can't find how to check if the hooks are in the mobile theme.

The main product files modification xml.

Changing that applies across the board but you can always adjust, see what it does and adjust back.

GCC LLC 06-20-2013 02:02 AM

Quote:

Originally Posted by Ted S (Post 2429256)
The main product files modification xml.

Changing that applies across the board but you can always adjust, see what it does and adjust back.

Filename, please?

Ted S 06-20-2013 02:08 AM

Quote:

Originally Posted by GCC LLC (Post 2429257)
Filename, please?

product_forums.xml

GCC LLC 06-20-2013 02:21 AM

Perhaps this is why I'm so confused - I don't have a product_forums.xml anywhere on my servers.

GCC LLC 06-20-2013 02:29 AM

Ah, the product install XML file. So I need to put the echo statements in there, reinstall the product and cross my fingers that it won't mess up anything in my existing installation in the other theme?

Ted S 06-20-2013 03:46 AM

Quote:

Originally Posted by GCC LLC (Post 2429261)
Ah, the product install XML file. So I need to put the echo statements in there, reinstall the product and cross my fingers that it won't mess up anything in my existing installation in the other theme?

You certainly don't have to but it's an effective way to debug where the issue is. If the echo statements show up, you know the mod is getting loaded and it's a problem with templates rendering them out.

GCC LLC 06-20-2013 05:46 AM

Yeah, the plugin doesn't seem to be getting called at all from the mobile theme. Do you have any idea how I'd check to see if the hooks are there in this theme, and if not how to manually add them?

Ted S 06-20-2013 05:41 PM

Quote:

Originally Posted by GCC LLC (Post 2429285)
Yeah, the plugin doesn't seem to be getting called at all from the mobile theme. Do you have any idea how I'd check to see if the hooks are there in this theme, and if not how to manually add them?

To be clear, are you seeing any output from the echo statements (if not, where did you add them)?

What mobile theme are you using? The default vB one?

GCC LLC 06-20-2013 06:15 PM

I wrapped it around the XML in product_forums.xml and reinstalled the product into vbulletin. It appeared to update something in all skins and I saw no errors (I also saw nothing get echo'ed back - but it went by all very fast in the install).

Links in the product review forum still do not click through to the corresponding threads. It is not the default vb mobile style, it is another mobile style designed for vB Suite 4.1.x.

Ted S 06-20-2013 07:02 PM

Quote:

Originally Posted by GCC LLC (Post 2429404)
I wrapped it around the XML in product_forums.xml and reinstalled the product into vbulletin. It appeared to update something in all skins and I saw no errors (I also saw nothing get echo'ed back - but it went by all very fast in the install).

Links in the product review forum still do not click through to the corresponding threads. It is not the default vb mobile style, it is another mobile style designed for vB Suite 4.1.x.

It's not quite that simple... to test you'd have to add it to varrious plugin routines inside the xml script so that echo statements are invoked as you load the pages you want to test (for example, you could echo back a test on the thread / product page or on the forum / product list).

As for how to fix it, I'd still suggest starting with the debugging to insure the mod is getting fired up but that's probably the case which means template hooks become the issues. For that you need to open up a default vB template and your mobile skin's (i.e. SHOWTHREAD which holds the product information) and see which hook variables have been removed.

If that sounds like greek, as the mod author if they ported over all the standard hooks into their SHOWTHREAD and FORUMDISPLAY templates.

GCC LLC 06-20-2013 09:23 PM

Got it figured out. I dug through the plugins and traced everything back to the following, in case anyone else runs into the same issue. Tom, you were correct in that the template hooks are not there by default in mobile styles. I also had to manually create each of the prodforum_* templates in our mobile style for some reason, but that's not a big deal.

The plugin renders the product information at the top of the showthread template into a template called showthread_above_posts. I looked for the hook inside of the SHOWTHREAD template in the mobile theme and it's just not there, so I added it in as follows:

{vb:raw template_hook.showthread_above_posts}

All is well!

Ted S 06-21-2013 04:47 AM

Quote:

Originally Posted by GCC LLC (Post 2429448)
Got it figured out. I dug through the plugins and traced everything back to the following, in case anyone else runs into the same issue. Tom, you were correct in that the template hooks are not there by default in mobile styles. I also had to manually create each of the prodforum_* templates in our mobile style for some reason, but that's not a big deal.

The plugin renders the product information at the top of the showthread template into a template called showthread_above_posts. I looked for the hook inside of the SHOWTHREAD template in the mobile theme and it's just not there, so I added it in as follows:

{vb:raw template_hook.showthread_above_posts}

All is well!

Fantastic!

How's everything else looking in the mobile theme? You can do a light version of the product page if you use it...

snakedevil 06-25-2013 07:42 AM

Hello Ted,

Thank you for this great mod, but I have a problem when sending an image in PNG, the image sent is no longer transparent but with a black background.

How to fix this please?

Thank you again!

Ted S 06-25-2013 02:30 PM

Quote:

Originally Posted by snakedevil (Post 2430335)
Hello Ted,

Thank you for this great mod, but I have a problem when sending an image in PNG, the image sent is no longer transparent but with a black background.

How to fix this please?

Thank you again!

That's up to the settings of GD on your server as it resizes the images... Does it happen elsewhere in vB?

snakedevil 06-25-2013 02:42 PM

No problem elsewhere, only on this mod :(

I have Chevereto and no problem

Ted S 06-25-2013 03:04 PM

Quote:

Originally Posted by snakedevil (Post 2430430)
No problem elsewhere, only on this mod :(

I have Chevereto and no problem

Hrm.

It's something in the image upload script but from the looks of it, could be one of a number of factors. We'll have to play around with it this weekend to see if we can force transparency on all GD setups.

snakedevil 06-25-2013 03:10 PM

Ok thank you,

In the meantime it is possible to display white instead of black? :)


Can be here ? :p

Quote:

function resize($width,$height) {
$new_image = imagecreatetruecolor($width, $height);
imagecopyresampled($new_image, $this->image, 0, 0, 0, 0, $width, $height, $this->getWidth(), $this->getHeight());
$this->image = $new_image;
}

Ted S 06-25-2013 03:26 PM

You can certainly try shifting the function around to see if it helps.

Functions stackoverflow shows people using for transparency:
imagealphablending($pathname, false); imagesavealpha($pathname, true);

snakedevil 06-25-2013 03:28 PM

A little too complicated for me :D

WildWayz 06-26-2013 08:25 AM

Hi guys

Thanks for creating this brilliant addon - working like a charm :)

Just got a very easy question (i hope) but how do I change the currency from $ into ??

Or even make it user-selectable?

Thanks! :)

WildWayz 06-26-2013 08:51 AM

Found it in Phrases :)


However, is there a mod to make it a dropdown?

Ted S 06-26-2013 02:41 PM

Quote:

Originally Posted by WildWayz (Post 2430577)
Found it in Phrases :)


However, is there a mod to make it a dropdown?

Nope.

snakedevil 06-26-2013 07:31 PM

Hello, how to display the list alphabetically?

here: forum/productforums.php

Thanks ! :)

Ted S 06-26-2013 10:53 PM

Quote:

Originally Posted by snakedevil (Post 2430657)
Hello, how to display the list alphabetically?

here: forum/productforums.php

Thanks ! :)

Hack the script and change the query to ORDER BY title ASC as default

snakedevil 06-27-2013 12:00 AM

Line ? :p

It's ok thanks !

addamroy 06-27-2013 12:51 PM

Quote:

Originally Posted by Ted S (Post 2427294)
Looks like a bug in the bulk script...

Please try removing all the existing thumbnail / smaller versions and running it with the attached version of admincp/productforums.php

Sorry for the delay, had other things to do prior to addressing this.

This fix worked. Thank you!

addamroy 06-27-2013 01:45 PM

New issue though. The 'matches' page that lists the reviews of a particular product, the page you are viewing when you click the 'reviews' area of a product in the product list, it doesn't load properly.

The reviews show 'outside' the body of the main forum, almost like there's a missing div tag, or some sort of issue like that I can't figure it out.

Like if you view, yourforum.com.com/productforums.php?do=matches&productid=4

it's layed out wrong for some reason.

It's correct here, yourforum.com/productforums.php just not on the matches page to view reviews.

I tried to open both templates side by side to see what could be missing from the matches one but I couldn't figure it out. I suppose it's possible the issue is in the productforums.php file itself but I'm not sure.

A fix for this would be appreciated.

edit; I'd also like to know if there's any simple way, or known websites we can get this xml file to import mass products from? If a website's RSS feed is in xml format, is there a way to use that?

I mean I definitely don't have any scraping software to go through websites, compile all the exact data I need them format it into an XML file I can import into the product :P Any help on this would be appreciated by myself and many others I'm sure.

addamroy 07-02-2013 10:24 AM

Soo any tips of advice on getting our hands on an XML sheet like I mentioned in my above comment?

Ted S 07-02-2013 03:17 PM

Quote:

Originally Posted by addamroy (Post 2430796)
New issue though. The 'matches' page that lists the reviews of a particular product, the page you are viewing when you click the 'reviews' area of a product in the product list, it doesn't load properly.

I'm not seeing this in our test build but will take a deeper look later in the week to be sure there aren't any hanging tags in the template.

Quote:

Originally Posted by addamroy (Post 2430796)
I'd also like to know if there's any simple way, or known websites we can get this xml file to import mass products from? If a website's RSS feed is in xml format, is there a way to use that?

Many vendors can provide XML feeds of their products which can be used or reformated through a simple dataset tool to match the right field names and ordering.

Of course there's no central repository for product data out there so you'd have to ask each individually.

a0809k35 07-09-2013 03:08 AM

Ted,
I am running VB 4.2 and have been getting the same error:
https://vborg.vbsupport.ru/external/2013/07/25.jpg

a0809k35 07-09-2013 03:09 AM

Ted,
I am running VB 4.2 and have been getting the same error:
https://vborg.vbsupport.ru/external/2013/07/25.jpg

Ted S 07-09-2013 03:47 AM

Quote:

Originally Posted by a0809k35 (Post 2432849)
Ted,
I am running VB 4.2 and have been getting the same error:
https://vborg.vbsupport.ru/external/2013/07/25.jpg

Do you have any reviews on that or any other products? Have there been reviews which were removed?

Bubble #5 08-22-2013 03:42 AM

1 Attachment(s)
Really love the idea of this hack but the buttons look really rough on our forum.

Can someone good at coding tell us where/how to change the template(s) so that the review button is moved from up top, to the side?

This is how it should look when finished (see screenshot).

Quick Update;

So many issues with this hack, where to begin?

For starters, none of the 'manage' buttons work. They show my test review, but won't let me manage it. When you click on it it says no review exist, even though one is on the forum.

Also, there doesn't seem to be a way to add images. Yes the image directory path was typed in.

These are just the beginning of problems we're seeing. Not sure if these issues are 4.2.1 related or hack related, or both.

And yes of course we tried to read the instructions (see screenshot) but it's kind of hard to read black text on a black background :rolleyes:

Very disappointed :(

Just found yet another issue: Now Activity Stream does't work at all. All we get is errors. Hopefully vB can fix it. Time to delete this.

Ted S 08-25-2013 01:49 AM

Quote:

Originally Posted by Bubble #5 (Post 2440278)
Just found yet another issue: Now Activity Stream does't work at all. All we get is errors. Hopefully vB can fix it. Time to delete this.

Sorry the addon was not for you... best of luck with your site!

Bubble #5 08-27-2013 12:10 AM

Quote:

Originally Posted by Ted S (Post 2440887)
Sorry the addon was not for you...

So am I.

zapiy 09-03-2013 10:03 PM

Quote:

Originally Posted by Ted S (Post 2428327)
You need to delete all of the files uploaded as uninstalling can not do this for you.

I did fella, and you can still see the menu in the themes?

Ted S 09-03-2013 11:10 PM

Quote:

Originally Posted by zapiy (Post 2442996)
I did fella, and you can still see the menu in the themes?

Admin side or user?

Spangle 09-20-2013 11:48 AM

Quote:

Originally Posted by Bubble #5 (Post 2440278)
Really love the idea of this hack but the buttons look really rough on our forum.

Can someone good at coding tell us where/how to change the template(s) so that the review button is moved from up top, to the side?

This is how it should look when finished (see screenshot).

Quick Update;

So many issues with this hack, where to begin?

For starters, none of the 'manage' buttons work. They show my test review, but won't let me manage it. When you click on it it says no review exist, even though one is on the forum.

Also, there doesn't seem to be a way to add images. Yes the image directory path was typed in.

These are just the beginning of problems we're seeing. Not sure if these issues are 4.2.1 related or hack related, or both.

And yes of course we tried to read the instructions (see screenshot) but it's kind of hard to read black text on a black background :rolleyes:

Very disappointed :(

Just found yet another issue: Now Activity Stream does't work at all. All we get is errors. Hopefully vB can fix it. Time to delete this.

You must be doing something wrong, missed a file when uploading them or similar, it took a while for me to figure out, but I followed the instructions from the link above, and it's working perfectly.

I'm using 4.2.1 as well


All times are GMT. The time now is 02:08 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.03048 seconds
  • Memory Usage 1,846KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (22)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete