vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   Modification Graveyard (https://vborg.vbsupport.ru/forumdisplay.php?f=224)
-   -   Portal Software - [Chris] Classifieds (https://vborg.vbsupport.ru/showthread.php?t=297847)

Christos Teriakis 06-24-2013 02:11 PM

Quote:

Originally Posted by Dr. HaZaRd (Post 2429943)
Nice mod, thanks! I use it for my community of Gran Turismo game. The users use this mod for trade the cars and game object.

Glad that it's useful for your community.

Quote:

Originally Posted by Dr. HaZaRd (Post 2429943)
2 question: it's a bad idea to add comments?

I've in plans to add it. Personally, I don't think that classifieds (unlike reviews or articles) needs comments. But if the community here has different opinion I respect it and I'll try to add this feature.

Quote:

Originally Posted by Dr. HaZaRd (Post 2429943)
I can add extra field, but I cann't remove them.. we will never see these features in the next release?

:cool: Don't I have remove extra field available?:confused:

sadiq6210 06-24-2013 03:02 PM

I opened [Chris classifieds] for around 25 moderators to test it and give me their feedback after that I will open it for all ~30,000 students.

I have two points not clear for me

1- If I put (Grace period) = 0, then no classified will be removed yes? I don't want to remove any classified. Even if it is expired I want to keep it as archive.

2- As administrator, how can I see the expired classifieds for a user? and how can I see all the closed/expired classifieds?

Thanks dear :)

cryhav0c 06-26-2013 06:54 PM

Hi Chris,

I am really having fun with this but I've come across an issue with the "Categories" & "Search In Classifieds" images not displaying while on the classifieds page when using Internet Explorer and only partially displaying when using Firefox. Also, the "Latest Classifieds", "Should Expire Soon" and Popular Classifieds" on the right side appear incorrectly. I've tried to verify everything but have not been able to figure this out. Could you give some advise. Thanks again.

cryhav0c 06-26-2013 07:44 PM

I have found the problem. It is due to the style I am using. It appears to only work with the default style. Is it possible for me to address this? Thank you for your help.

cryhav0c 06-27-2013 02:08 PM

Does anyone else utilize the classifieds with different styles? I would like to retain my style but it would seem that I'd need to modify it somehow?

Christos Teriakis 06-28-2013 05:07 AM

Quote:

Originally Posted by cryhav0c (Post 2430799)
Does anyone else utilize the classifieds with different styles? I would like to retain my style but it would seem that I'd need to modify it somehow?

I believe that the best way to get help on this issue is to post your installation URL. This way is easier to understand what's going wrong. Otherwise "does not works well.." is very general.

sadiq6210 06-28-2013 09:23 AM

Any update Chris?

cryhav0c 06-28-2013 05:10 PM

This is my install URL: http://internethopexchange.com/forums/classifieds.php The userid = "guest" The password is "classified" .

I utilize a purchased theme called Primus Slate. Thanks for taking a look. I'm really enjoying the mod.

Thanks,
Chris

studify 06-29-2013 02:48 AM

Hello,
I encountered two bugs within the file "classifieds_usercp.php". From around line 90 I've modified the code like shown below.

The first edit is a fix for the possibility, that no adtype is given (e.g. http://www.example.com/classifieds_u...php?do=addedit).

The second one is a quick and dirty fix for a permission error, cause the function getCheckMaxAds() did not execute correctly, which means that users who already had maximum number of ads running were able to create unlimited new ones.

Code:

        if(!$adtype){
                $item["adtype"] = 1;
        } else {
                $item["adtype"] = $adtype;
        }//EDITED so that if no adtype is given we'll make it 1
        $item["categoryid"] = 0;
        $item["userid"] = $vbulletin->userinfo['userid'];
        $checkuserid = $item["userid"];
        $docheckmax = getCheckMaxAds($checkuserid);//EDITED cause of permission

Correct me if I'm wrong ;) Oh, and nice mod, chris!!

All the best,
Alex

Christos Teriakis 06-29-2013 04:11 PM

Quote:

Originally Posted by studify (Post 2431133)
Code:

   
if(!$adtype){
    $item["adtype"] = 1;
} else {
    $item["adtype"] = $adtype;
}


Code:

Even if your additional check is 100% correct, I prefer to avoid giving default values, as you never know where the link comes from. As this URL is accessible only from 2 menu options, and on these options there is the adtype=xx, means that the link is not really comes from a normal menu option. eg maybe a bot.

[quote=studify;2431133]
    $item["userid"] = $vbulletin->userinfo['userid'];
    $checkuserid = $item["userid"];
    $docheckmax = getCheckMaxAds($checkuserid);//EDITED cause of permission

Why do you think that this is mistaken? First of all have you seen that the function getCheckMaxAds, calls another function getMaxAllowed ? Also have you understood how this function works? eg My primary usergroup is Registered Member which allows me to have 3 concurrent Ads. But at the same time I'm member (additional usergroupids) to VIP usergroup, which allows me 5 concurrent Ads. These 2 functions will return the maximum allowed value, which in this example is: 5.

But to be honest I haven't checked it in this version. But as these 2 functions are copy&paste from my previous Classifieds addon where it has been tested globaly, I can't see a reason that they don't work. But as I said, I haven't tested it, so you maybe be right and thank you for reporting it.


All times are GMT. The time now is 01:42 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01412 seconds
  • Memory Usage 1,751KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (3)bbcode_code_printable
  • (5)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete