vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.5 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=113)
-   -   vRewrite - SEOed URLs for vBulletin (https://vborg.vbsupport.ru/showthread.php?t=104484)

Immortal 02-14-2006 06:20 PM

The fix should've worked. If you wait just a wee bit longer, 1.0 stable will be released.

trilljester 02-14-2006 06:26 PM

yayvb: Try moving this rule:

RewriteRule ^(.*)-(.*)-(.*).html showthread.php?goto=$3&t=$2 [L]

to the bottom (before the vbseo stuff), and see what happens.

yayvb 02-14-2006 07:56 PM

I tried a bunch of things. I guess it's not the .hataccess file, I believe the problem lies in this code:
Code:

/*
#------------------------------
# SHOWTHREAD and page
#------------------------------
$found = preg_match_all('#showthread\.php\?t=([0-9]+)&page=([0-9]+)#i', $output, $matches);

if($found)
{
    // Build an array of ID's
    $ids = array();

    // Keep track of page nums that go with tid's
    $temp = array();

    for($i = 0; $i < $found; $i++)
    {
        // $temp[<threadid>] = <page>
        $temp[ $matches[1][$i] ] = $matches[2][$i];

        if(is_numeric($matches[1][$i]))
            $ids[] = $matches[1][$i];
    }
    $ids = implode(',', $ids);

    // Go through each
    $res = $vbulletin->db->query_read("SELECT threadid, forumid, title FROM " . TABLE_PREFIX . "thread WHERE threadid IN($ids)");

    while($t = $vbulletin->db->fetch_array($res))
    {
        $title = urlize($t['title']);
        $tid = $t['threadid'];
        $fid = $t['forumid'];
        $foruminfo = $vbulletin->db->query_first("SELECT title FROM " . TABLE_PREFIX . "forum WHERE forumid='$fid'");
        $fname = urlize($foruminfo['title']);
        $page = $temp[$tid];
       

        $output = str_replace("showthread.php?t=$tid&amp;page=$page", "$fname/t-$title-$tid-page-$page.html", $output);


    }

*/


}

I tried making small changes and retrying thinking that'll help, but no matter what I do page number links aren't being changed. It's a simple program I imagine, something looks for the URL and rewrites it. Then when you click on the rewritten URLS the .htaccess file redirects you to the RIGHT place if I'm not mistaken.

So if my urls aren't being rewritten then that must mean it's not the .htaccess file right? I will definitely wait for the stable version, I hope it's soon!!! Thanks again.

*EDIT*
I think I found the reason for the problem. It appears that the above code that is in question has comment tags before and after basically commenting all of this code!!! If I take out the 2 comment codes around this code I posted then I get a parse error grrr. The parse error I get after removing the comments codes is: Parse error: parse error, unexpected $ in /home/youradul/public_html/420boards/includes/functions.php(4314) : eval()'d code on line 646

Line 4314 of functions.php appears to be the global_complete hook, so obviously the code that was commented out that I pasted above is erroneous?

robertorg 02-16-2006 10:45 PM

It's possible to apply that modification to VBAdvanced??
Is recomended any robots.txt?

Good Work!!!! (It's installed, the only issue is VBAdvanced support)

Immortal 02-16-2006 11:15 PM

I posted a tutorial wayyyy back when. You may want to search the thread for "tutorial" and see if anything bites. It was for custom written rules, I haven't had a chance to play with vBA to see how it does it however. May require some plugin/file changes.

As far as robots.txt is concerned, I'm by far no SEO expert.

/me pokes T2DMan

DavidWilson 02-17-2006 12:56 AM

Hi, I've looked at the examples and downloaded the code; very easy install compared to Dan's.

One question I have in the installation is the follow:

As per step #3, I can't find the variable $headinclude in the following files:

showthread.php, newreply.php, newthread.php, forumdisplay.php, memberinfo.php

Smiry Kin's 02-17-2006 01:00 AM

Quote:

Originally Posted by DavidWilson
Hi, I've looked at the examples and downloaded the code; very easy install compared to Dan's.

One question I have in the installation is the follow:

As per step #3, I can't find the variable $headinclude in the following files:

showthread.php, newreply.php, newthread.php, forumdisplay.php, memberinfo.php

i think it means the templates?

Immortal 02-17-2006 01:07 AM

Yup, Styles & Templates, no file modifications needed :)

DavidWilson 02-17-2006 03:12 AM

Yes, for those of you that don't know, the default template file is located here: /install/vbulletin-style.xml

Custom template files are also *.xml and can be uploaded and imported over existing templates.

PGP 02-17-2006 04:23 AM

Immortal, why not just invoke <base href="$vboptions[bburl]/" /> into the top of the headinclude tempate? IMHO, it's more easier and faster? Am I right?


All times are GMT. The time now is 04:33 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01700 seconds
  • Memory Usage 1,746KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_code_printable
  • (1)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (4)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete