vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 4.x Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=245)
-   -   Major Additions - Product Review Forums ? Research, Review & Compare Items (https://vborg.vbsupport.ru/showthread.php?t=269808)

Ted S 06-08-2013 06:31 PM

Quote:

Originally Posted by addamroy (Post 2426604)
I'm using 4.2.1 fresh install.

Any plans on fixing the activity stream bug?

Also how do I remove the entry from the activity stream so its not broken? I've disabled the mod but the stream is still broken.

This is the first time hearing about it where it wasn't cleared up with a reinstall... One site is hard to identify or isolate (i.e. there are endless possible conflicts) but for several, absolutely, bugs are no good :eek:

Ted S 06-08-2013 06:36 PM

1 Attachment(s)
The attached version of PRF removes the activity stream section without impacting any other functions.

For those who were having issues with the system, please give it a try and we will proceed from there developing further fixes to bring that back.

addamroy 06-08-2013 08:04 PM

Quote:

Originally Posted by Ted S (Post 2426703)
This is the first time hearing about it where it wasn't cleared up with a reinstall... One site is hard to identify or isolate (i.e. there are endless possible conflicts) but for several, absolutely, bugs are no good :eek:

I'm not the only person who has a problem with this mod breaking the activity stream, there are a few others in this thread. So it's definitely not just one site.

I'll try reinstalling the mod again like you suggested. If that doesn't work I'll use the version you provided that doesn't use the activity stream.

addamroy 06-08-2013 08:26 PM

Also, there isn't really a need for the updated xml you provided because so long as the mod doesn't insert anything into the activity feed it's fine. And you already have an option in the current mod to turn that off. I tested it just now the activity feed works fine so long as the mod doesn't create entries for it. specifically, replies/review entries in the activity stream from the product forum dont break it, just the 'new thread' entries. It's the new thread entries in the activity feed that cause it to break, not replies or reviews.

Ted S 06-08-2013 08:31 PM

Quote:

Originally Posted by addamroy (Post 2426724)
I'm not the only person who has a problem with this mod breaking the activity stream, there are a few others in this thread. So it's definitely not just one site.

I'll try reinstalling the mod again like you suggested. If that doesn't work I'll use the version you provided that doesn't use the activity stream.

We've had a few mentions but as far as I can tell, all resolved (from a reinstall , option changes, or the person moved on and thus we couldn't track it down). Now that there are two of you reporting a problem actively, we can call it a bug.

Ted S 06-08-2013 08:34 PM

Quote:

Originally Posted by addamroy (Post 2426732)
Also, there isn't really a need for the updated xml you provided because so long as the mod doesn't insert anything into the activity feed it's fine. And you already have an option in the current mod to turn that off. I tested it just now the activity feed works fine so long as the mod doesn't create entries for it. specifically, replies/review entries in the activity stream from the product forum dont break it, just the 'new thread' entries. It's the new thread entries in the activity feed that cause it to break, not replies or reviews.

The activity stream is not really designed to be bolted on top of, at least not in a graceful way, which means errors become significant impacting more than just the mod.

Sites using older vB versions are prone to these sorts of collisions and not something we can stop but if there's a problem impacting new installs, we consider it reason to remove the feature and revisit it, if there's even demand to do so.

Assuming everything else works right for you and the other site reporting this in the activity-stream free version we'll change our standard download and take it from there.

Thanks for the report & follow up!

addamroy 06-08-2013 08:48 PM

Also (sorry for so many replies lol), how do I choose which fields are and aren't required? I know you mentioned I can edit the templates but what if I want to remove some required fields or add new ones, how do I do that?

Ted S 06-09-2013 06:21 AM

Quote:

Originally Posted by addamroy (Post 2426738)
Also (sorry for so many replies lol), how do I choose which fields are and aren't required? I know you mentioned I can edit the templates but what if I want to remove some required fields or add new ones, how do I do that?

You can add new fields for reviews through the ACP (there's a manger tool under the PRF group).

Other fields would require hacking the hack (templates to capture the data, table fields to hold it, queries to show it) although we'd be glad to add a few more hook locations if you want to make it more modular.

Toorak Times 06-09-2013 07:01 AM

Hi Ted, I just reuploaded that xml above and everything seems to be looking REAl good, cheers

sadiq6210 06-09-2013 11:43 AM

Thanks dear

Quote:

Originally Posted by Ted S (Post 2426702)
(whether an upgrade or just clearing the system stuff) should help.

Just for my information, how could I clear the system stuff?
Because I tried to uninstall another mod and I faced the same problem. I don't want to run (upgrade.php) everytime when I remove a mod.

Sorry to ask here.

addamroy 06-09-2013 03:32 PM

FEATURE REQUESTS

1 - An options panel to edit required and custom fields for product submissions.

2 - The thumbnail image used on the productdisplay page should have the option to use the main image resized, probably via a script instead of having to upload a separate image.

addamroy 06-09-2013 10:52 PM

Found another bug.

My other administrators can't access the product forums control panel via the admincp, they get a no permission message.

Ted S 06-10-2013 03:50 AM

Quote:

Originally Posted by sadiq6210 (Post 2426823)
Thanks dear



Just for my information, how could I clear the system stuff?
Because I tried to uninstall another mod and I faced the same problem. I don't want to run (upgrade.php) everytime when I remove a mod.

Sorry to ask here.

Try running the rebuild processes (which depends on what the mod does... ie this mod edits threads & posts).

Ted S 06-10-2013 03:51 AM

Quote:

Originally Posted by addamroy (Post 2426987)
Found another bug.

My other administrators can't access the product forums control panel via the admincp, they get a no permission message.

Not a bug... they'll need access to edit posts to use the mod (as it impacts posts).

Ted S 06-10-2013 03:52 AM

Quote:

Originally Posted by addamroy (Post 2426880)
2 - The thumbnail image used on the productdisplay page should have the option to use the main image resized, probably via a script instead of having to upload a separate image.

This already exists if your setup supports image resizing via GD.

Ted S 06-10-2013 03:52 AM

Quote:

Originally Posted by Toorak Times (Post 2426793)
Hi Ted, I just reuploaded that xml above and everything seems to be looking REAl good, cheers

Awesome!

Toorak Times 06-10-2013 01:44 PM

Quote:

Originally Posted by Ted S (Post 2427030)
Awesome!

Yeah, between you, Michael and Christos we have a real cool way of selling reviewing and marketing on a few different levels.

As most mod makers here know I have gone overboard in trying all the best, and worst mods, and quite clearly got myself a bit TOO modified.

BUT it seems I'm one of the few sites that is trying to flesh out the CMS, as a publishing suite.

Marketing wise, if you don't own a vB site, and if you do and don't know or use vb.org, no one would know about these wonderful mods you guys make.

I think a lot more people would start building with vB4 particularly if they could have a decent, understandable way of seeing the mods in action. MOST mods I want to see in action are either dead links or something displayed in the default template.

The bigger mobs are getting their act together, this isn't another go at you Ted...lol...just an observation, and seem to be co opting the best mods into their various systems. I get freaked out just thinking of VHS vs Beta still, :erm: this issue of incompatibility.

To that end I offered vBSocial an opp to promote their products live on my site so that people can see them working. For their mods its a certain as they are not content providing mods, more familiarisation mods for vB.

Whereas yours, Christos and Michael's, and many others are proactive modules that a lot of site builders would only dream of, and I think if more widely put out there and branded for vB and the Mod maker could only enhance vB's potential.

But seriously most of this crew are Forum builders and don't even use the cms, or just use it cold as is, the Blogs and calendars are probably the MOST important parts of the suite as I need it and are totally overlooked.

Sorry for the rave Ted

Toorak Times 06-10-2013 01:54 PM

...having said that Ted I'm a dyed in the wool forumite, starting from getting banned in yahoo and establishing what is the largest Oz lawn bowls forum Bowlsworld around 10 years ago and long term member of a vB 3.6 site www.bowlsblog.com, the second largest, and part of the biggest www.julianhainesbowls.co.uk. I came out of forums but AM a publisher. I would plead to you and all mod builders to think CMS and Blog as the worlds reality in media shifts around

addamroy 06-10-2013 01:57 PM

1 Attachment(s)
Quote:

Originally Posted by Ted S (Post 2427028)
Not a bug... they'll need access to edit posts to use the mod (as it impacts posts).

I've uploaded an attachment showing the admin permissions. There is no 'manage posts' permission option in the 4.2.1 admin permissions it doesn't seem.

Any other way to solve this?

Quote:

Originally Posted by Ted S (Post 2427029)
This already exists if your setup supports image resizing via GD.

How do I turn GD on or off? I'm pretty sure I have it though because I use the Damn Comp Member Map mod which requires that, and that mod works fine.

Ted S 06-10-2013 06:39 PM

Quote:

Originally Posted by Toorak Times (Post 2427104)
Sorry for the rave Ted

No problem and I totally agree.

I started releasing mods way back when vB was new (and before it on UBB) because it came apparent that there just wasn't any sort of marketing / ux approach to the software. Not that I have all the answers but work in digital marketing for enough years and you start to see things from a different perspective. That's gotten better over the years but if you look at something like the registration page in 4/5 it's clear there's still a huge miss...

These days we try and turn a few features into reality when we think it helps the community but of course free mods for a widely used system are inherently limited in their scope and scale.

As such it's my belief that any site which really wants to scale (and even bigger boards who want to improve value / traffic / use) should be investing heavily in custom development or at least extending mods. To think that a skin, couple of basic mods and particular setting choices will make a forum ideally meet an industry is really missing the point.

Of course we don't actually do any such work so it's sort of a half baked remark :D

Ted S 06-10-2013 06:41 PM

Quote:

Originally Posted by Toorak Times (Post 2427107)
...having said that Ted I'm a dyed in the wool forumite, starting from getting banned in yahoo and establishing what is the largest Oz lawn bowls forum Bowlsworld around 10 years ago and long term member of a vB 3.6 site www.bowlsblog.com, the second largest, and part of the biggest www.julianhainesbowls.co.uk. I came out of forums but AM a publisher. I would plead to you and all mod builders to think CMS and Blog as the worlds reality in media shifts around

With vB5 looming we're not planing much of anything at this time but will do, if & when we build something new :)

Ted S 06-10-2013 06:43 PM

Quote:

Originally Posted by addamroy (Post 2427108)
I've uploaded an attachment showing the admin permissions. There is no 'manage posts' permission option in the 4.2.1 admin permissions it doesn't seem.

Hrmm...

You can comment out

Quote:

if (!can_administer('canadminposts'))
{
print_cp_no_permission();
}
From admincp/productforums.php although checking for some access level would be a good idea.

We will of course switch this around in the next release.


Quote:

Originally Posted by addamroy (Post 2427108)
How do I turn GD on or off? I'm pretty sure I have it though because I use the Damn Comp Member Map mod which requires that, and that mod works fine.

GD is installed at the server level.

Have you used the image uploader (on the edit screen) / bulk importer?

addamroy 06-10-2013 08:09 PM

Quote:

Originally Posted by Ted S (Post 2427175)

Have you used the image uploader (on the edit screen) / bulk importer?

No I have been using the product submission form, this section of the forum will run almost entirely off products submitted by members so this feature likely won't be used at all.

Also, if (!can_administer('canadminposts')) does not show up in the productforums.php file I have. I narrowed it down to canadminposts for a search in the file and it doesn't exist.

Another question, is there anyway you can write up a quick plug-in that hooks into showthread somewhere that registers the {vb:raw product.productid} variable for use in the showthread template of my product forums?

The reason for this is I've already added a custom 'write a review' button elsewhere on that page, a big blatant one, but I need to be able to append the product ID to the URL so it works and goes to the write a review page when it's clicked.

Ted S 06-10-2013 09:13 PM

Quote:

Originally Posted by addamroy (Post 2427184)
No I have been using the product submission form, this section of the forum will run almost entirely off products submitted by members so this feature likely won't be used at all.

Ahh!

If members input urls just run the bulk script and it should resize them for you.

Quote:

Originally Posted by addamroy (Post 2427184)
Also, if (!can_administer('canadminposts')) does not show up in the productforums.php file I have. I narrowed it down to canadminposts for a search in the file and it doesn't exist.

Are you looking in the admincp folder version? It's line 33 in my version.

Quote:

Originally Posted by addamroy (Post 2427184)
Another question, is there anyway you can write up a quick plug-in that hooks into showthread somewhere that registers the {vb:raw product.productid} variable for use in the showthread template of my product forums?

The reason for this is I've already added a custom 'write a review' button elsewhere on that page, a big blatant one, but I need to be able to append the product ID to the URL so it works and goes to the write a review page when it's clicked.

Try editing the hook showthread_post_start and adding

$thread['productid'] = $product['productid'];

Right after $show['largereplybutton'] = false;

This will make the variable thread.productid

addamroy 06-10-2013 09:50 PM

When I run the sync external images script I get the following error.

Quote:

couldnt save the image for - skipping
couldnt save the image for - skipping
All Done!
I checked the folder I set up for these images in the core settings with my FTP software and the images are in fact being created in this folder.

The thumbnails are not showing up on the productforums.php display page. Folder permissions are at 755. :(

Other than that it's going great though, that hook edit you mentioned worked perfectly this is all in all a great mod.

Ted S 06-10-2013 10:46 PM

Quote:

Originally Posted by addamroy (Post 2427198)
The thumbnails are not showing up on the productforums.php display page. Folder permissions are at 755.

Either the path is wrong or the server is unable to write to it.

addamroy 06-10-2013 11:40 PM

Quote:

Originally Posted by Ted S (Post 2427210)
Either the path is wrong or the server is unable to write to it.

Alright, I'm pretty sure the path is right because the files are being created and written to the correct place, and the view image url in my core settings is the same of coarse just a shortened version of the full url.

Other than that what do you suppose would cause the server to be unable to read/write that folder or the images?

Ted S 06-11-2013 12:01 AM

Quote:

Originally Posted by addamroy (Post 2427221)
Alright, I'm pretty sure the path is right because the files are being created and written to the correct place, and the view image url in my core settings is the same of coarse just a shortened version of the full url.

Other than that what do you suppose would cause the server to be unable to read/write that folder or the images?

\

I think I'm missing something...

The files (full and thumbnail) are being created, are in the folder specified, load up (if downloaded via ftp) but don't show on the site?

addamroy 06-11-2013 01:30 AM

1 Attachment(s)
Quote:

Originally Posted by Ted S (Post 2427229)
\

I think I'm missing something...

The files (full and thumbnail) are being created, are in the folder specified, load up (if downloaded via ftp) but don't show on the site?

Yes the thumbnail isn't showing on the productforums.php page, in addition to the error I pasted above when I run the sync images script which is strange because the images DO seem to be getting created and stored in the folder, I've attached an image.

Ted S 06-11-2013 01:36 AM

Quote:

Originally Posted by addamroy (Post 2427251)
Yes the thumbnail isn't showing on the productforums.php page, in addition to the error I pasted above when I run the sync images script which is strange because the images DO seem to be getting created and stored in the folder, I've attached an image.

Hrm....

Perhaps the script is erroring before the database gets updated... Do any of the mainphoto or thumb values exist in the table prf?

addamroy 06-11-2013 02:07 AM

1 Attachment(s)
Quote:

Originally Posted by Ted S (Post 2427252)
Hrm....

Perhaps the script is erroring before the database gets updated... Do any of the mainphoto or thumb values exist in the table prf?

There is no prf table, they're all pf_ , but I looked in the pf_product table and I believe the values are not there, (assuming I'm looking in the right place).

Ted S 06-11-2013 07:17 AM

1 Attachment(s)
Quote:

Originally Posted by addamroy (Post 2427254)
There is no prf table, they're all pf_ , but I looked in the pf_product table and I believe the values are not there, (assuming I'm looking in the right place).

Looks like a bug in the bulk script...

Please try removing all the existing thumbnail / smaller versions and running it with the attached version of admincp/productforums.php

deverill2010 06-12-2013 06:02 PM

I'm using an older version (can't upgrade due to changes I made which I can no longer remember).

Anyhow it has been working for ages as far as I'm aware, however I just went to post a review on the front end of the site but got this -

Oh great, you had to go and press THAT button. There goes the whole site. Just kidding...

We had an issue posting your review, please try again or contact support and use code 164251-E.

Ted S 06-12-2013 08:40 PM

Quote:

Originally Posted by deverill2010 (Post 2427736)
I'm using an older version (can't upgrade due to changes I made which I can no longer remember).

Anyhow it has been working for ages as far as I'm aware, however I just went to post a review on the front end of the site but got this -

Oh great, you had to go and press THAT button. There goes the whole site. Just kidding...

We had an issue posting your review, please try again or contact support and use code 164251-E.

That error indicates an issue with making the post for the review.

How you go about fixing it is of course difficult if you're not willing to upgrade but in many cases these errors are due to other settings (like requiring prefixes) that we've since build workarounds for).

If you search productforums.php for that error code you can find the section that triggers it and force a hard error (i.e. see the exact problem) by adding the code echo $errors; die; before the eval code.

zapiy 06-15-2013 02:12 PM

I have removed this mod as it did not get used.. sadly the admin menus are still in place how do i remove them?

Thanks

Toorak Times 06-15-2013 02:56 PM

Zapiy, I don't think members will generally get it, best used as a shop I reckon

Ted S 06-15-2013 05:37 PM

Quote:

Originally Posted by zapiy (Post 2428290)
I have removed this mod as it did not get used.. sadly the admin menus are still in place how do i remove them?

Thanks

You need to delete all of the files uploaded as uninstalling can not do this for you.

GCC LLC 06-19-2013 04:37 PM

Ted, do you see any reason why this mod would not work in a mobile theme? The prodforum_* templates did not exist in the mobile skin, so we manually created them all there but the links are not clicking from the review forum and when we manually go to a review thread, it's not showing the product information at the top of the thread - it just looks like a regular vb mobile thread display.

Ted S 06-19-2013 07:10 PM

Quote:

Originally Posted by GCC LLC (Post 2429177)
Ted, do you see any reason why this mod would not work in a mobile theme? The prodforum_* templates did not exist in the mobile skin, so we manually created them all there but the links are not clicking from the review forum and when we manually go to a review thread, it's not showing the product information at the top of the thread - it just looks like a regular vb mobile thread display.

Are the right hooks in your mobile theme to pull the templates in?

Perhaps the best bet is to add a couple "echo" statements around the xml file for a quick test to see if it's a problem with the mod getting called up or the templates showing up.

Code:

echo "this shows up";

GCC LLC 06-19-2013 10:33 PM

Ted, sent you a PM about it. Thanks!


All times are GMT. The time now is 02:18 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.03088 seconds
  • Memory Usage 1,873KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_code_printable
  • (33)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete