vb.org Archive
Page 40 of 50 « First 303839 40 4142 Last »
Show 40 post(s) from this thread on one page

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 4.x Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=245)
-   -   Anti-Spam Options - vbStopForumSpam (https://vborg.vbsupport.ru/showthread.php?t=230921)

TheSupportForum 11-02-2012 06:42 PM
i currently have a script i developed which i can integrate this into its
Re-usable Code so it fits nicely with my newest mod which automatically blocks site access and registration attempts, i have already implemented projecthoneypot with it

ShannonA 11-02-2012 10:57 PM
The folks at SFS report that one of the problems I'm hitting is that vBSFS tries to get info on blank email addresses:
Quote:
2840 /api?email=
Could this be addressed in a future update?

TheSupportForum 11-02-2012 11:00 PM
Quote:
Originally Posted by ShannonA (Post 2377934)
The folks at SFS report that one of the problems I'm hitting is that vBSFS tries to get info on blank email addresses:

Could this be addressed in a future update?
that's due to the wrong variable, it might not be registered in the php file correctly
but if i integrate this script into mine i will fix issues like this

justing looking at it, its not even used properly

it should be api?email=$email

ShannonA 11-02-2012 11:14 PM
Based on the logs, the emails and user names getting reported seem really flaky. Lots of repeats and those blank emails. This is how they're accessed in the code:
Quote:
$username = $vbulletin->userinfo['username'];
$email = $vbulletin->GPC['email'];
Have they changed by vb4.2?

Edit: That's called in register_addmember_process

TheSupportForum 11-02-2012 11:21 PM
Quote:
Originally Posted by ShannonA (Post 2377936)
Based on the logs, the emails and user names getting reported seem really flaky. Lots of repeats and those blank emails. This is how they're accessed in the code:

Have they changed by vb4.2?

Edit: That's called in register_addmember_process
you need to call the php variable for email which is $email

where is says
Code:
Remote URL to the www.StopSpamLinks.com website for testing an email address
you replace :
http://www.stopforumspam.com/api?email=
with
http://www.stopforumspam.com/api?email=$email

ShannonA 11-02-2012 11:38 PM
Quote:
Originally Posted by simonhind (Post 2377937)
you replace :
http://www.stopforumspam.com/api?email=
with
http://www.stopforumspam.com/api?email=$email
Maybe I'm misunderstanding you, but the code certainly seems to add the email address all on its own:

Quote:
$spambot = getSFSXML($vbulletin->options['vbstopforumspam_url_check_' . $field] . urlencode($data));
In this example, $field would be email and $data would be $email.

The problem is that sfsProcess() seems to be getting really weird results from the two variables I noted:
Quote:
$username = $vbulletin->userinfo['username'];
$email = $vbulletin->GPC['email'];
Including blanks for $email, or at least that's what it's logging.

ShannonA 11-02-2012 11:57 PM
It looks to me like all those variables are set right and being passed right, but the problem is that vbStopForumSpam sends out those requests even before the spammer has been let in to register. Thus, if they haven't set an email and would be rejected, it checks their email anyway. If they fail at the human question, it checks anyway, sometimes again and again ...

TheSupportForum 11-03-2012 12:02 AM
Quote:
Originally Posted by ShannonA (Post 2377941)
Maybe I'm misunderstanding you, but the code certainly seems to add the email address all on its own:



In this example, $field would be email and $data would be $email.

The problem is that sfsProcess() seems to be getting really weird results from the two variables I noted:

Including blanks for $email, or at least that's what it's logging.
change

PHP Code:

        global $vbulletin, $userdata;

        $ip = $vbulletin->session->vars['host'];
        $username = $vbulletin->userinfo['username'];
        $email = $vbulletin->GPC['email'];
        if (($email == '') && (isset($userdata))) { // hook for new FB Connect procedures
            $username = $userdata->fetch_field('username');
            $email = $userdata->fetch_field('email');
        }

        $message = '  GPC_user: '.$vbulletin->GPC['username'].'         GPC_email: '.$vbulletin->GPC['email'];
        $message .= ' Data_user: '.$userdata->fetch_field('username').' Data_email:'.$userdata->fetch_field('email');
        $message .= ' Info_user: '.$vbulletin->userinfo['username'].'   Info_email: '.$vbulletin->userinfo['email'];
        $message .= ' REQ_username: '.$_REQUEST['username'].'           REQ_email: '.$_REQUEST['email'];

        if (($username != '') && ($username != 'Unregistered')) { //disable check if not set
            $result = VBSFSSpam($username, 'username');
            if ($result !== VBSFS_NO_TEST) {
                VBGHSFS_Action('username', $username, $username, $email, $ip, $result);
            }
        }

        if ($email != '') { //disable check if not set
            $result = VBSFSSpam($email, 'email');
            if ($result !== VBGHSFS_NO_TEST) {
                VBGHSFS_Action ('email', $email, $username, $email, $ip, $result);
            }
        }

        $result = VBSFSSpam($ip, 'ip');
        if ($result !== VBSFS_NO_TEST) {
            VBGHSFS_Action('ip', $ip, $username, $email, $ip, $result);
        } 

TheSupportForum 11-03-2012 12:11 AM
Quote:
Originally Posted by ShannonA (Post 2377941)
Maybe I'm misunderstanding you, but the code certainly seems to add the email address all on its own:



In this example, $field would be email and $data would be $email.

The problem is that sfsProcess() seems to be getting really weird results from the two variables I noted:

Including blanks for $email, or at least that's what it's logging.

change

PHP Code:
    global $vbulletin;
            
    $ip = $vbulletin->session->vars['host'];
    $username = $vbulletin->userinfo['username'];
    $email = $vbulletin->GPC['email'];

    // todo handle the null error results.
    $result = checkSFSSpam($username, 'username');
    if ($result !== VBSFS_NO_TEST) {        
        sfsActions('username', $username, $username, $email,$ip, $result); 
    }
    
    $result = checkSFSSpam($ip, 'ip');    
    if ($result !== VBSFS_NO_TEST) {
            sfsActions('ip', $ip, $username, $email, $ip, $result);
    }
    
    $result = checkSFSSpam($email, 'email');
    if ($result !== VBSFS_NO_TEST) {
            sfsActions ('email', $email, $username, $email, $ip, $result);
    } 
to

PHP Code:

        global $vbulletin, $userdata;

        $ip = $vbulletin->session->vars['host'];
        $username = $vbulletin->userinfo['username'];
        $email = $vbulletin->GPC['email'];
        if (($email == '') && (isset($userdata))) { // hook for new FB Connect procedures
            $username = $userdata->fetch_field('username');
            $email = $userdata->fetch_field('email');
        }

        $message = '  GPC_user: '.$vbulletin->GPC['username'].'         GPC_email: '.$vbulletin->GPC['email'];
        $message .= ' Data_user: '.$userdata->fetch_field('username').' Data_email:'.$userdata->fetch_field('email');
        $message .= ' Info_user: '.$vbulletin->userinfo['username'].'   Info_email: '.$vbulletin->userinfo['email'];
        $message .= ' REQ_username: '.$_REQUEST['username'].'           REQ_email: '.$_REQUEST['email'];

        if (($username != '') && ($username != 'Unregistered')) { //disable check if not set
            $result = VBSFSSpam($username, 'username');
            if ($result !== VBSFS_NO_TEST) {
                sfsActions ('username', $username, $username, $email, $ip, $result);
            }
        }

        if ($email != '') { //disable check if not set
            $result = VBSFSSpam($email, 'email');
            if ($result !== VBGHSFS_NO_TEST) {
                sfsActions ('email', $email, $username, $email, $ip, $result);
            }
        }

        $result = VBSFSSpam($ip, 'ip');
        if ($result !== VBSFS_NO_TEST) {
            sfsActions ('ip', $ip, $username, $email, $ip, $result);
        } 

ShannonA 11-03-2012 03:46 AM
Thanks. Running an updated version now ...


All times are GMT. The time now is 11:19 AM.
Page 40 of 50 « First 303839 40 4142 Last »
Show 40 post(s) from this thread on one page

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01657 seconds
  • Memory Usage 1,812KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_code_printable
  • (3)bbcode_php_printable
  • (9)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 
Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 
Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete