vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   Modification Graveyard (https://vborg.vbsupport.ru/forumdisplay.php?f=224)
-   -   Show Thread Enhancements - OS/Browser Display in Postbits (https://vborg.vbsupport.ru/showthread.php?t=280899)

Boots 05-02-2012 01:17 PM

It's too bad Android posts don't show up as Android instead of Linux.

nhawk 05-04-2012 09:27 PM

Quote:

Originally Posted by Boots (Post 2325500)
It's too bad Android posts don't show up as Android instead of Linux.

If you want that added, I'll need the useragent string from 'Who's Online'. Once I have that I can add it.

rhody401 05-04-2012 11:08 PM

Last week you added ForumRunner support, and I showed you the USER AGENT at the time.

It stopped working, and now the user agent seems to have a different look:

ForumRFree 1.5.12 rv:40 (iPhone; iPhone OS 4.3.5; en_AU)

The user is on the paid version, from an iPad.

I just wanted to give you the updated info, for future consideration.

Thanks

Boots 05-07-2012 12:38 PM

Quote:

Originally Posted by nhawk (Post 2326297)
If you want that added, I'll need the useragent string from 'Who's Online'. Once I have that I can add it.

Code:

Mozilla/5.0 (Linux; Android 4.0.4; Galaxy Nexus Build/IMM76I) AppleWebKit/535.19 (KHTML, like Gecko
That's Android 4.0.4 (Ice Cream Sandwich)

nhawk 05-07-2012 09:32 PM

Quote:

Originally Posted by Boots (Post 2327047)
Code:

Mozilla/5.0 (Linux; Android 4.0.4; Galaxy Nexus Build/IMM76I) AppleWebKit/535.19 (KHTML, like Gecko
That's Android 4.0.4 (Ice Cream Sandwich)

Linux is the correct OS icon using that useragent. If you want it narrowed down, it would be a 'Mobile' icon with a Galaxy Nexus operating system and version.

The browser would be Android. ;)

Boots 05-09-2012 11:44 AM

Android is a Linux based O/S but most people would identify it as Android. Mobile users on my forum would love to see the little Android icon next to posts they make from their Android phones :)

EliasAlucard 05-09-2012 05:11 PM

I'm working on my own OS/Browser postbit display plugin, and it shows Android as Android (with the specific version icons, such as Froyo, Honeycomb, ICS etc.), Ubuntu as Ubuntu and so on. I'll upload it when I'm finished with it. This plugin is for vBulletin 3.8 though, not sure if it'll work with 4.x but we'll see if I can add support for vB4.

EliasAlucard 05-10-2012 10:12 AM

By the way nhawk, do you mind if I fork this plugin and code my own version and upload it as a separate plugin? I have some disagreements on a few issues such as icon size. Also, I'll add a lot more icons for various browsers and operating systems. The plugin I'm working on now is an update/modification of the plugin Fighter1405 worked on for vB3.8 but this plugin of yours is very good with the exception of some issues I'd like to see changed.

Also, you've coded it far more complicated than it needs to be.

nhawk 05-10-2012 12:04 PM

Quote:

Originally Posted by EliasAlucard (Post 2327960)
By the way nhawk, do you mind if I fork this plugin and code my own version and upload it as a separate plugin? I have some disagreements on a few issues such as icon size. Also, I'll add a lot more icons for various browsers and operating systems. The plugin I'm working on now is an update/modification of the plugin Fighter1405 worked on for vB3.8 but this plugin of yours is very good with the exception of some issues I'd like to see changed.

Also, you've coded it far more complicated than it needs to be.

I would prefer you didn't.

And I feel it's as complicated as it needs to be for what it does. If you disagree with that, use PMs and we'll discuss it.

Also, the system does identify Ubuntu, etc.

ejup2009 05-10-2012 01:37 PM

Excelente hack muy vistoso y ofrece informaci?n detallada sobre el explorador..

Saludos cordiales:)

EliasAlucard 05-10-2012 01:59 PM

Quote:

Originally Posted by nhawk (Post 2327993)
I would prefer you didn't.

And I feel it's as complicated as it needs to be for what it does. If you disagree with that, use PMs and we'll discuss it.

Also, the system does identify Ubuntu, etc.

Well, if we may not come to agreement, I may just install it and use my own modification of it on my forum. I'm using vB3.8.7 now though, so I'm not using your plugin.

You've done a good job in adding more browser and OS support, but it's still quite incomplete (hey, I don't blame ya, I've learned myself that this takes quite some time).

We can take it here rather than PM. For one, I don't understand why you've grouped together Windows 7 and Server 2008 R2? They are clearly distinguishable by user agent string (6.1 and 6.0) and so it's possible to separate them in the postbit information. You also don't have a specific icon for Windows 7; you're using the Vista icon.

Personally, I think the icons should be sized at least 20 on the height and 24 as a max.

I wouldn't really need to modify your plugin though. I guess all I need is to add browser/OS version support for Fighter1405's old vB3.8 plugin, in the alt text. Do I need $tmp_array, $useragent and $client_data for that?

nhawk 05-10-2012 02:06 PM

Windows 7 and Vista do have the same logo from Microsoft. They never changed it.

So far as icon size, they are sized at 19. But if you like 20, I can't please everyone. ;)

I can't help with Fighter1405's plugin since I've never seen it and I don't know a thing about it.

datoneer 05-10-2012 02:16 PM

Installed and nominated

EliasAlucard 05-10-2012 02:16 PM

Quote:

Originally Posted by nhawk (Post 2328032)
Windows 7 and Vista do have the same logo from Microsoft. They never changed it.

So far as icon size, they are sized at 19. But if you like 20, I can't please everyone. ;)

I can't help with Fighter1405's plugin since I've never seen it and I don't know a thing about it.

Well, there are Windows 7 icons like this one:

http://www.pconline.se/wp-content/up...7/windows7.jpg

Here's Fighter's plugin:

https://vborg.vbsupport.ru/showthread.php?t=219687

nhawk 05-10-2012 02:22 PM

Quote:

Originally Posted by EliasAlucard (Post 2328034)
Well, there are Windows 7 icons like this one:

http://www.pconline.se/wp-content/up...7/windows7.jpg

Here's Fighter's plugin:

https://vborg.vbsupport.ru/showthread.php?t=219687

Well, the ones I user are the ones shown on most Microsoft packaging.

And if you didn't know it the Server 2008 version numbers are the same for Windows 7 and Vista.

Windows7/Server 2008 = 6.1
Vista/Server 2008 = 6.0

And the newest is Windows 8 = 6.2

I have no intention of using my time to decode someone else add-on. If you want to change it you are on your own.

EliasAlucard 05-10-2012 02:32 PM

Quote:

Originally Posted by nhawk (Post 2328037)
Well, the ones I user are the ones shown on most Microsoft packaging.

Yeah, but still, it would be like using a win2k icon for winxp if you know what I mean.

Quote:

Originally Posted by nhawk (Post 2328037)
And if you didn't know it the Server 2008 version numbers are the same for Windows 7 and Vista.

Windows7/Server 2008 = 6.1
Vista/Server 2008 = 6.0

And the newest is Windows 8 = 6.2

Yes, but most forum posters don't actually use Windows Server 2008 R2 so it's kind of redundant to even have that as the alt text.

Quote:

Originally Posted by nhawk (Post 2328037)
I have no intention of using my time to decode someone else add-on. If you want to change it you are on your own.

I can understand that. Looks like I'll be playing around with your plugin then :p

Also, you lack iOS icons and so on. I've currently done a good job with updating Fighter's plugin, but it's for vB3.8 only so I'm not sure if it's worth working any more on it.

nhawk 05-10-2012 02:41 PM

Quote:

Originally Posted by EliasAlucard (Post 2328043)
Also, you lack iOS icons and so on.


Quote:

1.0.6 - (May 10, 2012)
Add - iPhone/iPad iPhone OS
Hmmm :D

EliasAlucard 05-10-2012 03:21 PM

Quote:

Originally Posted by nhawk (Post 2328047)
Hmmm :D

That's good, although I've added icons for every Android version ;)

By the way, I was thinking... is it possible that you could add some statistics counter or something? In admincp or something that shows how many posts were made with this OS and that browser, something like that, would be nice.

Robru 05-10-2012 04:44 PM

Thank you for this update! :)

wally07 06-23-2012 08:57 PM

thanks for the update! :D

New Joe 07-26-2012 03:05 PM

Strange bug which sometimes happens.
I tick the users who I want to be able to see this mod and it all works fine.
Then for some un known reason they all get set back to being un-ticked.
This has happened a few times, but one now and again.

any ideas?

nhawk 07-26-2012 03:13 PM

Quote:

Originally Posted by New Joe (Post 2351612)
Strange bug which sometimes happens.
I tick the users who I want to be able to see this mod and it all works fine.
Then for some un known reason they all get set back to being un-ticked.
This has happened a few times, but one now and again.

any ideas?

I haven't seen this on my site and nobody else has reported this.

Is it possible that someone else is resetting the usergroups without telling you?

10giay.com 07-27-2012 07:21 AM

don't work vb 4.2.0 :(

New Joe 07-27-2012 09:12 AM

Quote:

Originally Posted by 10giay.com (Post 2351806)
don't work vb 4.2.0 :(

Yes it does :D

DirtRider 07-27-2012 10:33 AM

Installed it but it will not allow me to save any of the selected Usergroups

DaveTaylor 07-27-2012 12:20 PM

Quote:

Originally Posted by New Joe (Post 2351825)
Yes it does :D

Doesn't seem to for me on 4.2.0

DirtRider 07-27-2012 04:59 PM

Ok I got my story sorted out. I am using the Advanced Product Management and when I used this I could not save it. However if I go through the normal way Options/OS/Browser Display Settings it works 100%

nhawk 07-27-2012 07:16 PM

Quote:

Originally Posted by DaveTaylor (Post 2351858)
Doesn't seem to for me on 4.2.0

It does work on 4.2.0. My site uses this and it is running 4.2.0.

Are you making a new post? The mod can't display the OS and Browser for old posts because that info wasn't collected when the old posts were made.

Did you upload all of the files to the proper locations?

Did you turn the mod on in ACP->Settings->Options->OS/Browser Display Settings?

Did you set the usergroups that can see the OS and Browser types? At least one usergroup for both OS and Browser must be selected.

nhawk 07-27-2012 07:33 PM

Quote:

Originally Posted by DirtRider (Post 2351914)
Ok I got my story sorted out. I am using the Advanced Product Management and when I used this I could not save it. However if I go through the normal way Options/OS/Browser Display Settings it works 100%

Advanced Product Management will not work with most of my mods that set usergroups using checkboxes or radio buttons.

DirtRider 07-28-2012 01:08 PM

nhawk on your forum it shows the Blackberry icon but when I installed it I see the ? unknown icon. Also nothing for Tapatalk at all just a blank.

nhawk 07-28-2012 01:48 PM

Quote:

Originally Posted by DirtRider (Post 2352098)
nhawk on your forum it shows the Blackberry icon but when I installed it I see the ? unknown icon. Also nothing for Tapatalk at all just a blank.

I'm running the next version that hasn't been released yet.

The next time the person that isn't showing tapatalk is on, go to Who's Online and set 'User Agent' to 'Yes'. Then send me the useragent that isn't showing on your site.

EliasAlucard 08-03-2012 08:51 AM

Okay, I've installed vB 4.2 now, a few issues:

Android isn't supported when using Firefox; only the Firefox icon is shown, and the reason for that is because Firefox doesn't show the version number of Android. Here's the UA:

Mozilla/5.0 (Android; Mobile; rv:14.0) Gecko/14.0 Firefox/14.0.1

Using Konqueror:

Mozilla/5.0 (X11; Linux x86_64) KHTML/4.8.4 (like Gecko) Konqueror/4.8

It shows Konqueror as 4.8.4 but isn't that the KHTML version?

When using Chromium, it shows the Chrome icon. It's possible to show the Chromium, I've done this with my plugin. Here's the UA for Chromium:

Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/535.19 (KHTML, like Gecko) Ubuntu/12.04 Chromium/18.0.1025.168 Chrome/18.0.1025.168 Safari/535.19

Moreover, the Chrome icon is the old and outdated Chrome icon, in my opinion, it would look better if you used the updated 2011 Chrome icon. And the 2011 Chromium icon.

And then there's this bug that keeps deselecting all usergroups in admincp, so basically no one can see the icons. Not sure what's causing this. Maybe installation of new plugins or something. Shouldn't be like that though, because it's a pain in the ass to select all usergroups.

If you need to identify a user agent string, you should use this site:

http://id.furud.net/

And its database is most helpful:

http://id.furud.net/showdb.php

I would also prefer if you resized the icons to 24 pixels in height, it looks better than 19. You can use my icons, I even have customised versions of Android for each major release (ICS, Honeycomb, CyanogenMod etc.) and I also have more icons than you.

nhawk 08-03-2012 10:13 AM

Quote:

Originally Posted by EliasAlucard (Post 2353962)
Okay, I've installed vB 4.2 now, a few issues:

Android isn't supported when using Firefox; only the Firefox icon is shown, and the reason for that is because Firefox doesn't show the version number of Android. Here's the UA:

Mozilla/5.0 (Android; Mobile; rv:14.0) Gecko/14.0 Firefox/14.0.1

Using Konqueror:

Mozilla/5.0 (X11; Linux x86_64) KHTML/4.8.4 (like Gecko) Konqueror/4.8

It shows Konqueror as 4.8.4 but isn't that the KHTML version?

When using Chromium, it shows the Chrome icon. It's possible to show the Chromium, I've done this with my plugin. Here's the UA for Chromium:

Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/535.19 (KHTML, like Gecko) Ubuntu/12.04 Chromium/18.0.1025.168 Chrome/18.0.1025.168 Safari/535.19

Moreover, the Chrome icon is the old and outdated Chrome icon, in my opinion, it would look better if you used the updated 2011 Chrome icon. And the 2011 Chromium icon.

And then there's this bug that keeps deselecting all usergroups in admincp, so basically no one can see the icons. Not sure what's causing this. Maybe installation of new plugins or something. Shouldn't be like that though, because it's a pain in the ass to select all usergroups.

If you need to identify a user agent string, you should use this site:

http://id.furud.net/

And its database is most helpful:

http://id.furud.net/showdb.php

I would also prefer if you resized the icons to 24 pixels in height, it looks better than 19. You can use my icons, I even have customised versions of Android for each major release (ICS, Honeycomb, CyanogenMod etc.) and I also have more icons than you.

I'll look into the Android/Firefox combination for the next release.

KHTML is the heart of Konqueror so the versioning is correct.

I'll look into Chromium for the next release.

The Chrome icon IS the new one. Look closely at it.

I've always known where to check useragents, but I am not going to run through the thousands of useragents to accomodate obscure rarely used ones. If someone reports one that is in use and not displayed, I do my best to add it.

I have no intention of increasing the size of the icons. If you want to change them on your site, that's up to you.

And I'm going to try to be nice about this. Please stop referring to 'Your' plugin in this thread, it is off topic and irrelevant to vB 4.x in this thread. In my opinion it is not your plugin, but that's up to the people at vB.org to decide. And also, please stop attempting to educate me. I have been doing this type of work since the inception of the internet. If I don't already know something, I ask.

What that boils down to in your case is... if you don't like it, uninstall it.

EliasAlucard 08-03-2012 10:54 AM

Quote:

Originally Posted by nhawk (Post 2353981)
I'll look into the Android/Firefox combination for the next release.

Great.

Quote:

Originally Posted by nhawk (Post 2353981)
KHTML is the heart of Konqueror so the versioning is correct.

Ok, I stand corrected then.

Quote:

Originally Posted by nhawk (Post 2353981)
I'll look into Chromium for the next release.

Great.

Quote:

Originally Posted by nhawk (Post 2353981)
The Chrome icon IS the new one. Look closely at it.

No it's not. It is as a matter of fact, the old Chrome icon. How could you possibly not have noticed this?

Quote:

Originally Posted by nhawk (Post 2353981)
I've always known where to check useragents, but I am not going to run through the thousands of useragents to accomodate obscure rarely used ones. If someone reports one that is in use and not displayed, I do my best to add it.

I think you should. I've added support for various obscure browsers. On most forums, they're not needed because most people use the major browsers and operating systems, but on software forums for example, such obscure browsers are more common. I understand the extra work may not seem like it's worth it, but still, such plugins are all about perfection.

Quote:

Originally Posted by nhawk (Post 2353981)
I have no intention of increasing the size of the icons. If you want to change them on your site, that's up to you.

I could do it easily, were it not for the browser-icon-sprites.png, this makes every icon a pain in the ass to change. Is it possible to ditch the browser-icon-sprites.png? It's not used in the other plugins of this kind.

Quote:

Originally Posted by nhawk (Post 2353981)
And I'm going to try to be nice about this. Please stop referring to 'Your' plugin in this thread.

Why? Is there a rule here that one cannot discuss other similar plugins? I'm not promoting my plugin, I think yours is better but it does need some improvements.

Quote:

Originally Posted by nhawk (Post 2353981)
In my opinion it is not your plugin, but that's up to the people at vB.org to decide. And also, please stop attempting to educate me. I have been doing this type of work since the inception of the internet. If I don't already know something, I ask.

What's with the attitude? I can play this game too: this isn't your plugin either, and you should also stop taking credit for it, because you've stolen most of the source code directly from Web Browser Identifier v0.9, which is licensed under the GPL, and so you're violating the GPL, yet you're acting like this plugin is all copyrighted. I have no problem acknowledging that I've modified Fighter's plugin and improved upon it a little, but most of these browser/os postbit icons share the same GPL source code. This one for example has much code in common with yours:

http://custom.simplemachines.org/mod...x.php?mod=1515

I also think I should educate you, since you didn't even notice it was the old Chrome icon you were using, which means your perception is less than impeccable.

Listen, I'm trying to help out here, and I don't like your condescending attitude. There are some things you don't know, such as the fact that you're using the old Chrome icon.

Quote:

Originally Posted by nhawk (Post 2353981)
What that boils down to in your case is... if you don't like it, uninstall it.

No, I like it fine. Somehow you seem to think it doesn't need improvement, or you're simply not intellectually mature enough to understand constructive criticism (this is a common problem amongst many developers though, especially Linux developers).

nhawk 08-03-2012 11:18 AM

Ok, that's the end of this mod on vB.org.

LouiseWilson 08-03-2012 11:23 AM

Quote:

Originally Posted by nhawk (Post 2353997)
Ok, that's the end of this mod on vB.org.

I wouldn't let 1 person discourage you, you have done some good work for vb mods :), just ignore and move on in my opinion.

EliasAlucard 08-03-2012 11:26 AM

Quote:

Originally Posted by nhawk (Post 2353997)
Ok, that's the end of this mod on vB.org.

That's good, I think you did the right thing in removing it, because you're simply not doing a good job. I'll improve upon "your" stolen GPL source code and modify it properly, and I'll upload it later when it's done, and of course I'll add the GPL license which you didn't. If you can't handle criticism then don't bother uploading plugins in the first place.

Quote:

Originally Posted by LouiseWilson (Post 2353998)
I wouldn't let 1 person discourage you, you have done some good work for vb mods :), just ignore and move on in my opinion.

I'm not discouraging him. I was even trying to help him out, give him friendly advice, even recommended him using the icons I had spent time on resizing. I don't see how that's discouraging anything. The problem is that he has a childish and hostile mentality to any one giving him suggestions on what could be done to improve things. He could have just added two different sizes in icons, for example.

Also, it's quite pointless to remove the plugin from vbulletin.org especially when it has been downloaded 403 times, which means that someone will upload it somewhere else, if not here, then on rapidshare or similar sites. I think nhawk is behaving like a control freak over this. It's just a plugin for crying out loud.

nhawk 08-03-2012 11:39 AM

Quote:

Originally Posted by EliasAlucard (Post 2353999)
That's good, I think you did the right thing in removing it, because you're simply not doing a good job. I'll improve upon "your" stolen GPL source code and modify it properly, and I'll upload it later when it's done, and of course I'll add the GPL license which you didn't. If you can't handle criticism then don't bother uploading plugins in the first place.

I never claimed it was all mine. As a matter of fact...
http://snogssite.com/showthread.php?...fo-in-postbits

I don't mind suggestions, but in my opinion the level you took it to should have been done via a private discussion.

If you don't understand what the sprites are for, try looking into them. They are a good thing.

But, it's no sweat off my back. Either way, have fun.

EliasAlucard 08-03-2012 12:03 PM

Quote:

Originally Posted by nhawk (Post 2354002)
I never claimed it was all mine. As a matter of fact...
http://snogssite.com/showthread.php?...fo-in-postbits

If it's not all yours, then why did you act so proprietary over it when I suggested that I fork it?

Quote:

Originally Posted by nhawk (Post 2354002)
I don't mind suggestions, but in my opinion the level you took it to should have been done via a private discussion.

I don't see the need for that, it's better discussed here so that everyone can see.

Quote:

Originally Posted by nhawk (Post 2354002)
If you don't understand what the sprites are for, try looking into them. They are a good thing.

Are the sprites really needed? Like I said, the Simple Machines version doesn't use the CSS sprites, and it's working just fine.

Quote:

Originally Posted by nhawk (Post 2354002)
But, it's no sweat off my back. Either way, have fun.

I still think your behaviour is immature and childish. It's like, 'don't tell me what to do, don't talk to me that way, or else I'll take it down!!!!!', which is lame, and your 'don't educate me' reeks of a big ego who can't handle friendly suggestions. Chill dude, I'm just giving my two cents so that you can improve a good plugin.

nhawk 08-03-2012 12:26 PM

Discussions are one thing, but the way you present information is like your way is the best and/or the only good way. That is not conducive to friendly discussions. And is what has resulted in me pulling this mod from vB.org. I've been around too long to put up with someone telling me that their way is better without presenting it in a civil manner and accepting my decision on if something happens or doesn't happen. Remember, the coder always has the final say no matter how much you disagree with them.

So far as sprites go, just about every page speed test around recomends using them. vBulletin itself uses them for a few things. Look into them, they are a good thing.


All times are GMT. The time now is 09:14 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.02040 seconds
  • Memory Usage 1,882KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_code_printable
  • (37)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (3)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete