Ed:

Since this works so well do you think that John will incoroporate it into the next version of vBulletin? It sure would make it a lot easier if it was already included.

One thing that I think would really be cool is a feature that would offer a java pop up if they wanted like ICQ. When you have private messages waiting, you as a member could choose the option, could have a pop up window with the messages that you could scroll through and then close the window out.

Just thinking!

Parker

Java could be a bad idea for the sake of compatibility.

Just wanted to say, Great Hack!

Which zip file has the latest bug fixes, files, and instructions?

Thanks!

OKAY, I must be real stupid.

6. Add $pminfo to 'forumhome' template where you want 'pmloggedin' or 'pmloggedout' template to appear.


Where the heck are these templates????? This line of the instructions speak like I'm supposed to know or something.

:)

Can we have "PM Hack for Dummies?"

in other words.....help?

OKAY, I must be real stupid.

-----------INSTRUCTIONS----------------------------
6. Add $pminfo to 'forumhome' template where you want 'pmloggedin' or 'pmloggedout' template to appear.
---------------END------------------------

Where the heck are these templates????? This line of the instructions speak like I'm supposed to know or something.

:)

Can we have "PM Hack for Dummies?"

in other words.....help?

*bump*

Can someone tell me please?

Uhm, on the first page, perhaps?

Does this hack work in any incarnations of 1.1.3?

Yes, see my board.

And about those templates someone mentioned: look in the list - they're there.

Cold Steel : yes it works but you will have to look a little bit for the correct place to put it as the instructions don't exactly match up.

Does the PM hack currently check against baneip / banemail if enablebanning is switched on via the Control Panel?

If not can this functionality be introduced please?

Your board is beautiful! Can I use your light bulbs?

My board?!? Wow, I don't even like it too much anymore ;) But if you were talking to me, sure.

About the new version - it's coming along well. I'll look through this whole thread and tell what's been added so far.

Well, here's just a list of new features and such for the new version:

------
Done!

Not yet, but it sounds simple (I'm just trying to avoid making changes to vB's standard files.

Been done!

Yep, been done too!

A little hard, but ... Done too!

Done too!

I haven't tested it, but Done! (Admins/Mods exempt too) (Even sends email if full)

Done!

Done!

Not yet, but I think that's simple too...

Not yet

Not quite yet...

Coming...

See above (aka Done!)

Don't really know if this is possible without adding another field...

Done! (I just need a folder that has an R)

Fixed

I don't want to add another field to the user table :)

Not done yet...

Nope...

Done! (That was the simplest fix ever)
-------

Oh, and this was amusing:

Views: 2250. Wow, 2250 views of this one thread :D

Ed:

One other thing. I think you should make it to where the member can turn this option off. I know you have control as an admin to turn it off or on to the whole board but a lot our members don't like the private messging and don't want anyone sending them anything. This should also remove the icon that you put in the forumdisplay pages too so that they can't send a private message from there either.

Parker

Ed:

You know looking at what you have done already it would nice if you put all the member selection in an options section. That way on one page you could set up your folders, set up your ban list, enable or disable private messaging, etc.

Just a thought.

Parker

Thanks! :D



Agree 100%


[Edited by Ciaran on 07-12-2000 at 02:58 AM]

all we need now are polls in a pm...;)

Ed:

One thing too. Do you have it written for 1.1.3 yet? I used the version that you have but noticed today that in the faq and bbcode pages you get a database error like:

Database error in vBulletin: Invalid SQL: SELECT announcementid,userid,startdate,title FROM announcement WHERE startdate<=963412951 AND enddate>=963412951 AND (forumid= OR forumid=-1) ORDER BY startdate DESC LIMIT 1
mysql error: You have an error in your SQL syntax near 'OR forumid=-1) ORDER BY startdate DESC LIMIT 1' at line 1
mysql error number: 1064
Date: Wednesday 12th of July 2000 09:42:31 AM
Script: /htforum/index.php?action=bbcode
Referer: http://www.hometheaterforum.com/htfo...php?action=faq

so it is probably where I am putting the code that have in the index.php file.

Could you look at 1.1.3 and see what changes need to be made in the placement of your code?

BTW, when I put the original code from 1.1.3 back in it took care of the problem.

Thanks,
Parker

Parker-
See my list, it's "Coming...", as in I'm programming it right now.

Maybe if I feel like writing another template. I really hate making templates, and I'm already up to about 30 (!!!) :D

Yes, works fine on 1.1.3. Look at my board.

Umm... I don't get them.

Doron-
LOL, that's coming in version v80.1 :)

Ed:

Since it is the index.php file that is causing the trouble
this is what I have.

Just below:
if ($action=="showforums") {

I have:

//PM HACK
if ($bbusername) {
$username = $bbusername;
$pmcounta = $DB_site->query_first("SELECT COUNT(msgid) AS msgid FROM privatercvd WHERE toid=$bbuserid");
$pmcount = $pmcounta[msgid];
$newpmcounta = $DB_site->query_first("SELECT COUNT(msgid) AS msgid FROM privatercvd WHERE toid=$bbuserid AND UNIX_TIMESTAMP(datetime)>$bblastvisit");
$newpmcount = $newpmcounta[msgid];
if ($newpmcount == 0) {
$lightbulb = 'images/off.gif';
} else {
$lightbulb = 'images/on.gif';
}
$lastsent = $DB_site->query_first("SELECT fromid,UNIX_TIMESTAMP(datetime) AS datetime FROM privatercvd WHERE toid=$bbuserid ORDER BY msgid DESC");
if ($lastsent) {
$lastid = trim($lastsent[fromid]);
$lastdate=date($dateformat,$lastsent[datetime]+(($timeoffset+$bbtimezoneoffset)*3600));
$lasttime=date($timeformat,$lastsent[datetime]+(($timeoffset+$bbtimezoneoffset)*3600));
$lastsentuser = $DB_site->query_first("SELECT username FROM user WHERE userid=$lastid");
$lastuser = htmlspecialchars($lastsentuser[username]);
}
eval("\$pminfo .= \"".gettemplate("pmloggedin")."\";");
} else {
eval("\$pminfo .= \"".gettemplate("pmloggedout")."\";");
}
//END PM HACK

and this is just above:

$numbersmembers=$DB_site->query_first("SELECT COUNT(userid) AS users FROM user");
$numbermembers=$numbersmembers[users];

Does this look right?

Parker

Parker - that code is fine, although the new version makes some changes.

Now, the weird thing: I just downloaded the new beta 3, and did some searches, both in global.php and index.php. And that SQL isn't even in either! So, it's not my hack that's causing them to die :)

That IS weird. If I put the orginal index.php file back in I don't get the error. If I put the one with the code added in I get the database error.

What I was wanting in the previous message was to know if I was putting it in right or not.

Maybe the new version will take care of this problem. Who knows.

Parker

[Edited by Parker Clack on 07-12-2000 at 01:18 PM]

Maybe I'm missing the point, or didn't catch the sarcasm, but... :)

What's the point with polls in a private message?

There would be two votes MAX...so it seems rather, pointless. :)

you could mass mail them and have a central poll..nah, that was a joke. ;)

This is sweet! :) Goodbye mass e-mails hello personal messages! ;)

Ed:

I sent you an email back with the file you requested.

Did you get it?

Parker

Yeah, I haven't looked at it extensively yet though. Can you do a quick search in your global.php for something in that SQL error (like, announcement) or something - I really have no clue what would cause that.

When forumid=-1 in an announcement, that means it's going to any forum. So what the script is trying to grab looks like a forumdisplay.php routine: grab announcements for any forum (-1) or this forum (the blank space, since you're not in a forum). But, w(why)tf would it be doing that in index.php?!

*shrug* Not sure yet...

And, to everyone, I'm very close to the new release. Tonight if I rush to document all the changes, most likely tomorrow though.

Some misc. stuff now:
- Yes, there is an upgrade route to the new version, but some of the templates have significant changes. I suggest using the default versions, and just rehacking :) (Besides, I'm not even sure of everything I've changed)
- 95% of the suggestions have been implemented, including a few that weren't "Done!" before.
- Unfortunately, with new features, comes more editing to vB's standard files--much more. :(

Now, some bragging rights: :D
- 4 new profile fields, 2 customizable via "modifyprofile", other 2 from PM hack itself
- one new field to "usergroup" table
- (Get ready) 35 new templates (!!)
- 3 new tables:
* privatercvd, now with 10 fields
* privatesent, with 8 fields
* and pmstats, with 4 (new feature, still lacking though) :(

Anyway, get ready :)

It's inevitable, even though Idid think about creating a fuction file and using that to reduce the code you enter (for the poll hack).

Ed:

Thanks for looking into it. I found the problem. It was in my index.php file. I was trying to put an announcement thing on the main page found out I couldn't get it to work but forgot to take the code back out. That is what was causing the error. You didn't see it because it wasn't in index.php to begin with.

Duh!

I look forward to the newest version. Do you think you could document the names of the templates that you have created and are adding. It's kind of hard to look through the list and figure out which ones go with the private messages.

Thanks again,

Parker

[Edited by Parker Clack on 07-13-2000 at 09:10 AM]

doron - that's not really possible because a lot of the stuff is replacing lines.

Parker - see, it wasn't my hack :) And about template names: Well, most (95%) start with pm, error_pm, or redirect_pm, but ok.

Ummm...stupid question but it is possible to set this feature for admins and mods to mass mail members? Not all but simply more than one member?

ie.
In the input field you would ask the admin/mod to separate the user names using commas.

I know how to do this in perl but don't even know where to start in php... I need a book

Not in this version.

Okay, no worries ed! :) Thanks though. (btw when I said MAIL I meant POST, sorry for the confusion)

[Edited by SonnetCelestial on 07-14-2000 at 05:41 PM]