vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.5 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=113)
-   -   vRewrite - SEOed URLs for vBulletin (https://vborg.vbsupport.ru/showthread.php?t=104484)

Dean C 01-08-2006 01:41 PM

Quote:

Originally Posted by Immortal
What do you mean? Dean must be angry that his Mom didn't give him his cereal this morning, or exams are getting too tough. One of the small prices of being a coder that's still in school. vRewrite is just as efficient as Dean's. I can't say the same about vBSEO as it's encoded. If you find anything that's not "efficient" then let me know, and I'll be happy to investigate the problem.

First of all, stop throwing your dummy out the pram. Second of all, I explained to you exactly what is inefficient about your modification. Take it or leave it, and don't take it personally. You should be trying to learn, not snap because you can't take criticism.

Immortal 01-08-2006 01:48 PM

Quote:

Originally Posted by Dean C
First of all, stop throwing your dummy out. Second of all, I explained to you exactly what is inefficient about your modification. Take it or leave it, and don't take it personally. You should be trying to learn, not snap because you can't take criticism.

All I can see is you yellin' at my hack saying don't install it. Yet you never once said what was wrong specifically. You used a general term, and I looked through it and didn't see anything of that nature. I'll admit, I'm a PHP programmer, not a vB coder. I'm still learning the tricks of the trade, so I won't doubt there is problems. But you used a general term which I could not find. So could you? I would love to fix any issues before 1.0. But I still can't see anything of the nature you described.

croportal 01-08-2006 01:49 PM

Quote:

There is absolutely no need to run a query to get the forum titles for example, that information is in the forumcache, and also the forumtitle is available in other variables depending on the page you are on. Most of all you have un-necessary regex's being run on pages they don't need to be run on. It's far more efficient to redirect old URLs to their new equivalent using .htaccess, than to to try and rewrite every rule everywhere or at least limit the regex's on pages they only need to be on.
i agree with Dean, i have very large board and this will be...uffff

Guest190829 01-08-2006 01:59 PM

Everyone please remain calm here. Immortal, Dean's criticism was all constructive in my opinion and he wasn't being personal about any of it. I must assure everyone to keep their posts in this thread towards this hack only. Please do not bring up any other similiar modifications or anything else for that matter, it is not fair to the author and anyone else looking for valuable content concerning the hack. If you feel you need to discuss a hack or multiple hacks, you can do so maturely in an independent thread in the General Modifications Forum. :)

adb22791 01-08-2006 02:00 PM

Quote:

Originally Posted by Dean C
My SEO mod is not aimed at just rewriting URLs, when it comes out of beta it'll rewrite many sections of the vB HTML output, and also come with a sitemap generator of it's own and SEO tips in the readme. But the rewriting of URLs in my modification is done a lot more efficiently, the regexs are only called when they need to be. And no queries are run to get any of the information. :)

Good for you, now shut up and go write yours instead of picking on other peoples threads. Telling people not to install a hack somebody worked hard on is ridiculus. None of us would do that in your thread would we, so grow up and learn to show some respect.

Dean C 01-08-2006 03:56 PM

Quote:

Originally Posted by adb22791
Good for you, now shut up and go write yours instead of picking on other peoples threads. Telling people not to install a hack somebody worked hard on is ridiculus. None of us would do that in your thread would we, so grow up and learn to show some respect.

I didn't bring my modification into this topic whatsoever until someone mentioned it.

Anyways, Immortal, you should look at only running code on certain pages by checking the value of THIS_SCRIPT. Also the forum titles are stored in the datastore cache and you should use that to get the title associated with an ID.

vau7 01-08-2006 04:59 PM

Quote:

Originally Posted by Immortal
What do you mean? Dean must be angry that his Mom didn't give him his cereal this morning, or exams are getting too tough. One of the small prices of being a coder that's still in school. vRewrite is just as efficient as Dean's. I can't say the same about vBSEO as it's encoded. If you find anything that's not "efficient" then let me know, and I'll be happy to investigate the problem.

Sorry, but youre a bad loser. Deans arguments posting by posting are full of facts & hints for you and you just spit these childish stuff instead of arguments.

Go ahead, read the Code by Dean an learn.

@Dean: Concentrate on your exams and dont look in threads like this. ;)

MidnightPyro 01-08-2006 05:32 PM

Quote:

Originally Posted by vau7
Sorry, but youre a bad loser. Deans arguments posting by posting are full of facts & hints for you and you just spit these childish stuff instead of arguments.

Go ahead, read the Code by Dean an learn.

@Dean: Concentrate on your exams and dont look in threads like this. ;)

Bad loser? I don't really think anyone's losing here - especially someone who takes the time and effort to release their work to the community for free. While I know Dean most likely didn't have bad intentions, when you recommend NOT installing someone's hack in their thread, I can see why the hack author would get upset.

Immortal 01-08-2006 05:41 PM

Quote:

Originally Posted by Dean C
Anyways, Immortal, you should look at only running code on certain pages by checking the value of THIS_SCRIPT. Also the forum titles are stored in the datastore cache and you should use that to get the title associated with an ID.

Thank you Dean. I'm fixing it now for 1.0. As I said, I'm not a vB programmer ;)

Chroder 01-08-2006 05:43 PM

Also keep in mind this plugin is still considered 'beta' (as anyone can clearly see by looking at the 'Mod Version' information above).

The author is taking suggestions, fixing errata and is trying to optimize for version 1.0. We can't ask anything more then that :)

Anyway, good job thus far on the mod.

xtreme-mobile 01-08-2006 05:57 PM

great product works better tahn the one by dean too :) this one does everything :D

thanks

dean

Floris 01-08-2006 06:03 PM

Quote:

Originally Posted by croportal
is this better than DEAN C or??????


i have seen that in this are members rewrite and get daily posts also, but in dean c are not

Definitly.

croportal 01-08-2006 07:25 PM

thanks Floris, but what will all that queries, if you have large board

Immortal 01-08-2006 07:34 PM

Quote:

Originally Posted by croportal
thanks Floris, but what will all that queries, if you have large board

All queries were fixed for 1.0. Which I hope to release very shortly :)

croportal 01-08-2006 07:36 PM

Quote:

Originally Posted by Immortal
All queries were fixed for 1.0. Which I hope to release very shortly :)


oh.....thats great, this is then defintly better than DEAN C

SCI 01-08-2006 09:54 PM

Is the link in the last post columns going to be rewritten in the 1.0 version?

Immortal 01-08-2006 10:09 PM

Quote:

Originally Posted by SCI
Is the link in the last post columns going to be rewritten in the 1.0 version?

Seems I forgot that :mad:

Fixed for 1.0. Thanks :)

croportal 01-08-2006 10:46 PM

can u tell me what exactly will be in 1.0 version, what is fixed and what urls are rewritten

this is some my points what the Vrewrite should have (and sorry for my bad english)

1. previosu thread and next thread (https://vborg.vbsupport.ru/showthrea...oto=nextoldest https://vborg.vbsupport.ru/showthrea...oto=nextnewest)
2.you have told that all members are rewirten, and the list http://www.myxite.com/members/list/
3.whats with the pages 1,2,3,4,5,6, in thread
4.when i go to new posts that all url be rewriten not like showthread.php?t=
5.when i go to search some words that all url be rewriten
6.move id from the username, like this www.vbulletin.org/member/croportal not lik member/croportal-154.ui.html or something like this
7.merging threads that work with rewrite urls
8.move id to from thread or put on the back of url
9.is this compatible with vbseo sitemap generator
10.Can we add custom rewrite rules for example , vbadvanced cmps , arcade , geek article and review system ?

sorry for that all questions heh

Immortal 01-08-2006 11:16 PM

1.0 - 1,2,3,4,7

And the rest should be 1.5. Although I have been working on getting the sitemap converted :)

AshokForums.com 01-09-2006 01:38 AM

This plugin is compatible with vbAdvanced CMPS???

Immortal 01-09-2006 02:03 AM

Quote:

Originally Posted by AshokForums.com
This plugin is compatible with vbAdvanced CMPS???

I don't have a board with it installed, so I can't speak with certainty. But I don't think it would be compatible but running them at the same won't cause any harm to your board.

croportal 01-09-2006 11:00 AM

wow immortal i have vb 3.5.0 and if this will work with this version i will donate to you...thanks allot. this is just great

AshokForums.com 01-09-2006 12:37 PM

Any idea when we can expect vRewrite ver 1.0??

croportal 01-09-2006 12:59 PM

today or tomorow i think

AshokForums.com 01-09-2006 01:10 PM

Quote:

Originally Posted by croportal
today or tomorow i think

Thats great :)

yayvb 01-09-2006 01:11 PM

I think this is a great idea because I purchased vbseo for $150 and was told that my site was 'adult' in nature or something and that I couldn't have the script so I had to be refunded!!! :( My site needs traffic too!!! :)

StarBuG 01-09-2006 01:28 PM

Quote:

Originally Posted by Immortal
It is still in Beta. So, why not suggest a few features if you don't think it's got anywhere "near the functionality of vBSEO"? ;)

Ok here is a suggestion:

To prevent doublicate content if someone comes to the forum via an old url a 301 redirect to the rewritten url would be good especialy for SEs and PR

Then you don?t rewrite all urls yet like

? Previous Thread | Next Thread ?
search resault links with highlight
go to last post

keep up the good work

jonblaze3 01-09-2006 04:08 PM

Quote:

Originally Posted by yayvb
I think this is a great idea because I purchased vbseo for $150 and was told that my site was 'adult' in nature or something and that I couldn't have the script so I had to be refunded!!! :( My site needs traffic too!!! :)

thats horrible business practices first off because anyone can add an adult forum anytime after they buy a license whenever they want so what are they gonna do? Monitor every external forum everyday to make sure the posts are appropriate? what happens if they get 100,000 people buy? they gonna monitor all those forums and all the posts in them? dictate a website's content? i'm pretty sure this is not gonna last too long or the business will eventually die especially when competitive products come, then they won't be able to take business for granted anymore

ConqSoft 01-09-2006 04:32 PM

Quote:

Originally Posted by jonblaze3
thats horrible business practices first off because anyone can add an adult forum anytime after they buy a license whenever they want so what are they gonna do? Monitor every external forum everyday to make sure the posts are appropriate? what happens if they get 100,000 people buy? they gonna monitor all those forums and all the posts in them? dictate a website's content? i'm pretty sure this is not gonna last too long or the business will eventually die especially when competitive products come, then they won't be able to take business for granted anymore

This discussion has been hashed out already, and does not belong in this thread. ( https://vborg.vbsupport.ru/showthread.php?t=103546)

Jelsoft limits sites with illegal content from using vBulletin. How do they monitor 100,000 sites? They have a company that does it for them.

version2 01-09-2006 04:58 PM

Quote:

Originally Posted by ConqSoft
This discussion has been hashed out already, and does not belong in this thread. ( https://vborg.vbsupport.ru/showthread.php?t=103546)

Jelsoft limits sites with illegal content from using vBulletin. How do they monitor 100,000 sites? They have a company that does it for them.

So, for a forum that is already high ranked in Google, among other spider sites. Should I do something like this? I make money from advertising dollars and it is mostly guests giving me those dollars. I am afraid to install something like this and -lose- traffic.

Should I just pass this by?

Immortal 01-09-2006 06:04 PM

There is one issue regarding vRewrite 1.0 which I am currently still struggling with and hope to get it fixed. I won't release a version if I know there are bugs in it and call it a "stable" release. Just not very ethical of me.


Quote:

Originally Posted by StarBuG
Ok here is a suggestion:

To prevent doublicate content if someone comes to the forum via an old url a 301 redirect to the rewritten url would be good especialy for SEs and PR

Then you don?t rewrite all urls yet like

? Previous Thread | Next Thread ?
search resault links with highlight
go to last post

keep up the good work

Previous/Next/Last post were all fixed for 1.0. I've added redirects (or should I say trying to), for 1.0. This is what is stopping me from releasing 1.0 currently. As for the searches, I doubt that'll ever be rewritten. The goal of vRewrite is to better assist SEs in spidering your site, and since they can't use the search function, it kinda defeats the purpose. :)

croportal 01-09-2006 06:16 PM

i think that better rewrite url like previous and next thread, and go to last post, search you dont

its not so much duplicate content

KoC 01-09-2006 10:46 PM

Thanks for this nice hack. I have installed it sucessfully and i think i must donate it now :) We wait for the new release :)

AshokForums.com 01-10-2006 10:57 AM

I am waiting for vRewrite 1.0 ;)

Immortal 01-10-2006 07:00 PM

Update:

Hello everyone. Just when I thought I had it perfect idea, it didn't work again. I'm going to update that thread....yet again, and hope/pray for a response. I thought I was on the right track, but I guess not, heh. So, I'm still hoping to release it ASAP, but this isn't something that I can do, so its dependent on others, and that thread has been there for awhile with 0 replies :(

croportal 01-10-2006 10:12 PM

what thread???

Immortal 01-11-2006 12:09 AM

The Thread regarding the redirect bug :(

Illustrious 01-11-2006 12:27 AM

I still get error 1064 when I use the latest update of this plugin. It seems to work perfectly when I'm not logged in though.

Immortal 01-11-2006 12:30 AM

Could you post the full error?

Illustrious 01-11-2006 12:35 AM

Certainly, it's the same one that was posted earlier on the board though:

Quote:

Database error in vBulletin 3.5.1:

Invalid SQL:
SELECT userid, username FROM vbuser WHERE username='User';

MySQL Error : You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'User'' at line 1
Error Number : 1064
Date : Tuesday, January 10th 2006 @ 07:26:35 PM
Script : localhost/forums/
Referrer : localhost/forums/index.php
IP Address : *.*.*.*
Username : User
Classname : vb_database
It's strange because the hack seems to be functioning perfectly when I'm logged off. And I read through all the pages and edited my xml file several times.


All times are GMT. The time now is 02:03 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.02437 seconds
  • Memory Usage 1,842KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (20)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete