vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   Modification Graveyard (https://vborg.vbsupport.ru/forumdisplay.php?f=224)
-   -   Major Additions - iTrader v2.0.1 (https://vborg.vbsupport.ru/showthread.php?t=102965)

zlos 12-17-2005 06:18 AM

Quote:

Originally Posted by zlos
Unfortunately I cannot upgrade, still getting some mysql erorrs:



???

I have found the problem source:

line 148 ./includes/functions_itrader.php

simply replace

Code:

itrader_pcnt = " . $userinfo['tradepcnt'] . "
with

Code:

itrader_pcnt = '" . $userinfo['tradepcnt'] . "'
:)

eoc_Jason 12-17-2005 03:18 PM

Chrisbaktis - I'll be releasing an update today, and that will be included as an admincp option. ;)

Areku - Admin's override all restrictions, for various reasons, that's why you can leave multiple feedback within the restricted timeframe. If a postid is submitted in the URL all it does is back-check to the the threadid, it's just there for convience. I allowed duplicate threadid's because on many sites a person has a single "FS" listing URL, thus multiple people could end up linking to it. Like I said, a person is free to edit this however they feel fit for their own forum use. Everyone runs their forum differently, for instance, in my FS/WTB sections, a user can create the thread and edit it, but that's it. People can not reply because that would alter the natural order of items being listed FS.

zlos - I'll be sure to fix that with the next update.

ChrisBaktis 12-17-2005 03:32 PM

Sweet!

klaush 12-17-2005 05:13 PM

Quote:

Originally Posted by zlos
I have found the problem source:

line 148 ./includes/functions_itrader.php

simply replace

Code:

itrader_pcnt = " . $userinfo['tradepcnt'] . "
with

Code:

itrader_pcnt = '" . $userinfo['tradepcnt'] . "'
:)

Thanks, i had the same error with a fresh install.

Any idea why only we!

By the way, great product!

dsotmoon 12-17-2005 05:25 PM

Quote:

Originally Posted by eoc_Jason
Chrisbaktis - I'll be releasing an update today

great news, thanks Jason

eoc_Jason 12-18-2005 12:22 AM

Here's a quick list of some things for the 2.0.1 version. I'm sure there is more but these are just off the top of my head. It's late and my brain is only halfway functioning so I'm going to wait to release this till tomorrow so I can double-check everything one last time and make sure I package up everything properly in the zip. If I do it tonight I'm sure there will be something small I'll miss. ;)

Please let me know if I happened to miss any bugs. I looked over the thread tonight and did not see anything that I haven't fixed. I meant to get this out earlier today but one thing always leads to another, you know how it goes.
  • Fixed:
    • Several Changes In Upgrade Script to process users in batches
    • Checks PM for errors before attempting to save
    • Altered user table to accomidate negative scores
    • Some phrase fixes
    • Changed templates to $show (instead of $itrader) when deciding blocks of HTML to show
    • Changed a few instances of <br> to <br />
  • Changed:
    • Edit Time Limit is now specified in minutes (instead of seconds)
    • Duplicate User Rating Time Limit is now specified in hours (instead of seconds)
    • Adjusted checking to accomidate more than 3 types of deals (ex: loan, rent, whatever)
  • Added:
    • AdminCP iTrader Menu - Update iTrader Scores (Batch Updating)
    • Admin Option - Detail comments minimum characters (0 will disable / make comments optional)
    • Admin Option - Contact staff on negative rating (Y/N)
    • Admin Option - Maximum Time To Return Rating (specified in days)
    • Admin Option - "New Trader" Score (Affects how other options function)
    • Added indexes on ipaddress for faster IP checking (No admincp IP searching yet)

Kihon Kata 12-18-2005 12:24 AM

woot, im the first and pee pee cometh

dsotmoon 12-18-2005 12:31 AM

Quote:

Originally Posted by eoc_Jason
Here's a quick list of some things for the 2.0.1 version.

think you got it covered Jason, great job as always, cant wait

dsotmoon 12-18-2005 12:32 AM

oh, will the script change the seconds to minutes, etc or will we have to go in and change them after upgrade?

thanks

cbr929rrerion 12-18-2005 03:25 AM

Clicks install.. great item.. the icons for the positive, negative neatural are not included.. Did not read the whole thread but I am sure it says somewhere to chose your own.. lol

OttawaGolf 12-18-2005 07:27 AM

I guess the home page with top ten isn't going to make it. My users are asking for this.

Just a question, not to be taken as critical;
Why do you consider it such a low priority when so many users want it? I would hope for a rankings overview page with a full set of options for listing rankings by various parameters and flexible list lengths. I'd write it myseld if I could.

Thanks for your consideration.

djwins 12-18-2005 09:03 AM

OttawaGolf, you probably missed this...
Quote:

Originally Posted by eoc_Jason
There is no home page like before. However since so many people have requested it I will create one.


OttawaGolf 12-18-2005 11:40 AM

Yes I did see that, but I see it did not make it into this update.
He also said this
Quote:

It's not that it will be an option, it will be a separate file, so if someone wants to use it they can, if not then they don't even have to bother uploading it. However I will tell you now that it will not be maintained all that much as I personally do not see much value in it.
So I just want him to know that although he does not see much value to it, My users have asked for a rankings overview page so I know they will use it. I am hoping for something a touch more versatile than he described, ( sort by a few fields, and variable lenth lists, not just top ten) I am also advocating that it not get ignored as development continues. :up:

djwins 12-18-2005 11:55 AM

I agree the home page is very useful.
I have a very active Trader Ratings 1.2 installed on my boards (11,000+ ratings and 1,200+ users rated). I am going to hold off on the update to iTrader until the home page is implemented as I think my users will mostly focus on the removed home page, rather than the added features.

eoc_Jason 12-18-2005 07:56 PM

dsotmoon - Users upgrading will need to make 2 changes in the admincp to accomidate the changes in time value, It is documented in the upgrade text & changelog. I recommend all people read over AdminCP options carefully as there are a few more now. ;)

cbr929rrerion - pos/neg/neu icons are just default vB emoticons. I made a plea in an earlier post asking for a talented graphic artist to maybe create some nicer custom images for everyone to use.

OttawaGolf - No, the home page is not going to make it with the release. I'll try to convert the old one this afternoon and get a separate file online as a temporary fix for you guys. I was going to re-code some of the functions to make it handle the global scope, but I can do that with the next version to integrate it all better. I consider it a low priority because it is a low priority to me and I'm the one having to code everything. ;) It does not affect functionality or increase usefulness, thus it is a lower priority than things that actually contribute to the rating system itself. The very nature of the rating system negates everything that is displayed on a summary page like that. It does not matter who the top rated people are if you are not engaged in a deal with them. It does not matter who the negative rated people are because you would see the negative rating on any item they tried to list FS. There is just nothing (from a user standpoint) that a summary page can accomplish in a productive manner. I'm not trying to dog you, I'm just trying to give you my point of view on the matter.

---------------

Anyhow, I've got a couple little things to fix in the upgrade script, and update some documentation, then I'll be posting v2.0.1 online & sending out a notice. I updated my forum and everything seems kosher, it made the table changes correctly, updated templates & phrases, and added the admincp options. :bunny:

eoc_Jason 12-18-2005 10:04 PM

I have updated the package to v2.0.1 here & sent out an email update. Please read the "Readme First.html" file included in the package for instructions on what needs to be changed manually (just 2 admincp options).

If you find a bug and do not see me reply about it, please send me a PM after waiting a day or so.

romow 12-18-2005 10:25 PM

do we need to reinstall the product as well, or just modify those two options only?
thanks,

Quote:

Originally Posted by eoc_Jason
I have updated the package to v2.0.1 here & sent out an email update. Please read the "Readme First.html" file included in the package for instructions on what needs to be changed manually (just 2 admincp options).


cbr929rrerion 12-18-2005 10:28 PM

Before I upgrade can you tell us what bugs were fixed and what options were changed/added

eoc_Jason 12-18-2005 10:34 PM

romow - You need to upgrade the product first (do not uninstall the existing product). To upgrade you click on the add/import product link, just like the initial install. It will do the upgrade process for you. Very important to select "Yes" for "Allow Overwrite" on that page.

cbr929rrerion - Bug list is kind of several posts up, I don't remember every last little thing I changed, you can always do a diff on the files & templates. All templates were changed, some more than others. Most files were changed, it would probably be easiest just to re-upload them all. Images did not change any.

Oh, I also uploaded a screenshot of the admincp menu options.

chimaira 12-18-2005 10:44 PM

Ah awsome... Now the amount of ratings appear in itrader ( here )
top job

dsotmoon 12-18-2005 11:10 PM

Quote:

Originally Posted by chimaira
Ah awsome... Now the amount of ratings appear in itrader ( here )
top job

yes, everything working correctly now as far as the PM bug goes, thanks jason

sellbuydomain 12-19-2005 03:02 AM

i have a problem like this , after i submit a feedback, i see an error, however , it redirect to itrade page, here is the error

Warning: array_merge() [function.array-merge]: Argument #1 is not an array in /itrader_feedback.php on line 243

also i test all feedback , the percentage count incorrectly, if i post negative feedback more , will only list 50% ,for example 4 negative feedback, 3 postive feedback, should 42% , why always 50%

sadecosefo 12-19-2005 03:51 AM

*clicked install*

Have installed mine with no problems as of yet. Will need to continue test drive to see if anything comes up. This is a fantastic thing you got going here. Thank you very much. REALLY appreciate all the hard work you've put into this. It is what our forum has been needing for quite some time.

I'd like to try and mess with it to see if I can get different icons for the amount of (good) trades. If anyone has figured that out and would like to share, that would be great. If I figure it out I'll pass on the info.

d2sector 12-19-2005 06:36 AM

Are you any closer to releasing a better Template documentation for the hack?
One of the places i've implemented it so far is in the popup menu for a username. Underneath the Homepage, Send X a Private message etc.

Code:

<!-- iTrader -->
        <tr><td class="thead">Trading</a></td></tr>
                <tr><td class="vbmenu_option"><a href="itrader_feedback.php?u=$post[userid]" rel="nofollow">Leave Trade Feedback!</a></td></tr>
                <tr><td class="vbmenu_option"><a href="itrader.php?u=$post[userid]" rel="nofollow">View Trade History</a></td></tr>
<!-- /iTrader -->

Is there a better way to code this?

Oblivion Knight 12-19-2005 06:43 AM

Superb addon.! Thanks for sharing your hard work.. :D

[high]* Oblivion Knight installs.[/high]

Spinball 12-19-2005 08:26 AM

Thanks Jason. Installed and upgraded without problems.

mrderanged 12-19-2005 12:55 PM

Jason,

Is there a reason that the "short comment" field is limited to 80 characters? (re: formatting maybe?). Any possibility to make the character limit admin configurable for those that would like to allow larger "visible to all users" ratings?

Thanks

eoc_Jason 12-19-2005 01:02 PM

sellbuydomain - Ah, minor bug, I'll release a file update in about an hour once I get to the office. All that will be needed is to re-upload a couple files, no other modifications needed.

The reason it would still be 50% is because calculations are done based on UNIQUE userids. Unless you change the option in the admincp to non-unique.

d2sector - I'll try to write up some more documentation today, I meant to yesterday but did not get a chance. Really template implementation is a user-preference on exactly where and how they want to do it.

eoc_Jason 12-19-2005 01:49 PM

Attention:

To fix a small glitch in the code I've updated the zip file. If you already upgraded to 2.0.1 then simply re-upload the following two files that have been fixed.
  • itrader_feedback.php
  • itrader_detail.php

Noonster 12-19-2005 03:22 PM

Upgraded from 2.0.0 to 2.0.1 :D

Thanks and keep up the great work!!

GTAce 12-19-2005 05:33 PM

How do I get this to display in the memberlist? Simply adding a line to memberlist_resultsbit isn't enough...there is more to it than that.

Thanks!

msimplay 12-19-2005 05:42 PM

Quote:

Originally Posted by GTAce
How do I get this to display in the memberlist? Simply adding a line to memberlist_resultsbit isn't enough...there is more to it than that.

Thanks!



yeah the documentation isn't completed , i personally took reference from the 1.2 version of this hack for vbulletin3.X
and added the itrader ratings to the memberlist aswell

GTAce 12-19-2005 06:11 PM

Quote:

Originally Posted by msimplay
yeah the documentation isn't completed , i personally took reference from the 1.2 version of this hack for vbulletin3.X
and added the itrader ratings to the memberlist aswell

So you got it to work?

I tried adding this
Code:

(<a href="itrader.php?$session[sessionurl]u=$post[userid]">$post[itrader_total]</a>)
After this
Code:

<a href="member.php?$session[sessionurl]u=$userinfo[userid]">$userinfo[musername]</a>
in memberlist_resultsbit....but all it showed was ( )

Even if it did work, I would consider it a temporary solution...as I'd like to see Trader Ratings as its own, separate column

eoc_Jason 12-19-2005 06:18 PM

I know the documentation is incomplete, however look what you are doing...

the variables used should be $userinfo not $post for that template. ;)

GTAce 12-19-2005 06:28 PM

Oh :nervous:

oops, you're right

Code:

(<a href="itrader.php?$session[sessionurl]u=$userinfo[userid]">$userinfo[itrader_total]</a>)
^^^ that works...but I'd still love to see it in its own column

ryansmith 12-19-2005 06:56 PM

Jason,

I have a question. I switched the eBay Style option from No to Yes, but now I need to recalculate the point scores. You mentioned earlier in the post about a mass-update script. Where is that exactly? I know there's one in the zip file in Extas/admincp but that's for upgrading from the old to the new versions. Is there another one located somewhere?

Ryan

eoc_Jason 12-19-2005 06:57 PM

It's meant to be short... lol. Probably because I think eBay does 80, that's why I chose that number.

Anyhow, it's limited in the DB (you can change the field from 80 to 255), and in the template field form. No other length checking is done, so it would be easy to customize.

Quote:

Originally Posted by mrderanged
Jason,

Is there a reason that the "short comment" field is limited to 80 characters? (re: formatting maybe?). Any possibility to make the character limit admin configurable for those that would like to allow larger "visible to all users" ratings?

Thanks


eoc_Jason 12-19-2005 06:58 PM

In your AdminCP there should be a new section called "iTrader Options", there is currently only one choice which is to re-calc all the scores.

Quote:

Originally Posted by ryansmith
Jason,

I have a question. I switched the eBay Style option from No to Yes, but now I need to recalculate the point scores. You mentioned earlier in the post about a mass-update script. Where is that exactly? I know there's one in the zip file in Extas/admincp but that's for upgrading from the old to the new versions. Is there another one located somewhere?

Ryan


ryansmith 12-19-2005 06:59 PM

Ah ha :) I knew it must be easy. LOL. Thanks Jason, it's working great.

Ryan

Spinball 12-19-2005 07:45 PM

Hi Jason,
quick question. Might it be possible to specify the user groups/ user ids to email when there is suspicious activity? At the moment all the moderators are getting the emails and it's not appropriate.
Thanks


All times are GMT. The time now is 05:50 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.02025 seconds
  • Memory Usage 1,843KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (8)bbcode_code_printable
  • (12)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete