vb.org Archive
Page 4 of 5 « First 23 4 5
Show 40 post(s) from this thread on one page

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.0 Beta Releases (https://vborg.vbsupport.ru/forumdisplay.php?f=34)
-   -   Geek Article System 3 - RC1 (https://vborg.vbsupport.ru/showthread.php?t=75795)

The Geek 02-06-2005 03:40 PM
Quote:
Originally Posted by xmitchx
Hi,

First off I'd like to tip my hat off to such a great hack :) Second, I found a typo

Step 8.6:


The bold part should be $template :)
Nice one! Thanks for that.

I updated the package to 2-06 with this typo fixed.

rlamego -> Forgot that option is not wired up all the way yet. I really only put it in for hockeyfan. I'll wire it up most likely tomorrow. What it should do is toggle x amount of comments on all pages OR just the last page (if you remember everyone wanted them on last page only and he wanted the option).

Thanks again.

rlamego 02-06-2005 04:37 PM
Oh, ok. That's what I recall from the early dev stages but wasn't sure you changed it.

hockyfan 02-06-2005 07:57 PM
Quote:
Originally Posted by the nail geek
rlamego -> Forgot that option is not wiredupallthe way yet. I really only put it in for hockeyfan. I'll wire itupmostlikely tomorrow. What it should do is toggle x amount ofcommentson allpages OR just the last page (if you remember everyonewantedthem on lastpage only and he wanted the option).

Thanks again.
Ahh, you didn't have to do all that just for me! I do appreciate it though. :D

I'm not a very talented coder, so I'm just waiting until this is donewith the beta testing to install. A big thank you to all those who aredoing such a great job with that as well! Can't wait to install this,muchthanks! :up:


h

xmitchx 02-06-2005 08:58 PM
Another bug. The article byline is not grabbed for editpost.

Fix:

Find in editpost.php:
PHP Code:
    if ($edit['title'] != '')
    {
        $title = htmlspecialchars_uni($edit['title']);
    }
    else
    {
        $title = $postinfo['title'];
    } 
Add BELOW:
PHP Code:
    // === GEEK ARTICLES START ===
    if ($edit['articlebyline'] != '')
    {
        $articlebyline = htmlspecialchars_uni($edit['articlebyline']);
    }
    else
    {
        $articleinfo = getArticleInfo($postinfo['threadid']);
        $articlebyline = $articleinfo['byline'];
        unset($articleinfo);
    }
    // === GEEK ARTICLES END === 

xmitchx 02-06-2005 09:09 PM
Another problem, this time with templates. In the GAS_article_pb template, the message/title section of the article is not vertical aligned to the top, so if the article is smaller than the sidebar, it is centered, which is not very article-like. To fix, open up GAS_article_pb and find:

HTML Code:
            <td class="alt1">
            <!-- message, attachments, sig -->
Replace with:

HTML Code:
            <td class="alt1" valign="top">
            <!-- message, attachments, sig -->

xmitchx 02-06-2005 09:14 PM
Bug on installation step 8.7/8.8. Find should either include the "}" in the end, or step 8.8 should get rid of the "}" in the end so it should look like this:

PHP Code:
    // === GEEK ARTICLES step 8.6 ===
    // WAS:
    //eval('$postbits .= "' . fetch_template('printthreadbit') . '";');
    // NOW:
    eval('$postbits .= "' . fetch_template($template) . '";');
    // === /GEEK ARTICLES === 
:) I think the latter is a better choice.

The Geek 02-06-2005 09:16 PM
Quote:
Originally Posted by xmitchx
Another problem, this time with templates. In the GAS_article_pb template, the message/title section of the article is not vertical aligned to the top, so if the article is smaller than the sidebar, it is centered, which is not very article-like. To fix, open up GAS_article_pb and find:

HTML Code:
            <td class="alt1">
            <!-- message, attachments, sig -->
Replace with:

HTML Code:
            <td class="alt1" valign="top">
            <!-- message, attachments, sig -->
Yea, just noticed the valign problem.

Odd about the editpost. Thought I did that. Ill fold in your changes tomorrow into a new release.

Thanks a lot! (Keep em coming!)

The Geek 02-06-2005 09:20 PM
xmitchx : Can you verify the editpost problem again? Mines is working fine here. Anyone else? I may have missed something in the install... Ill go back over it.

xmitchx 02-06-2005 09:21 PM
Quote:
Originally Posted by the nail geek
xmitchx vbmenu_register("postmenu_608280", true); : Can you verify the editpost problem again? Mines is working fine here. Anyone else? I may have missed something in the install... Ill go back over it.
I already verified it by posting a few articles and reading over the editpost.php section of the install. I believe you may have forgotten it there :)

winky6 02-06-2005 09:25 PM
The directions for the printhread edits are off a bit -

HTML Code:
Find :
eval('$postbits .= "' . fetch_template($template) . '";');
HTML Code:
8.8 REPLACE with:        // === GEEK ARTICLES step 8.6 ===
// === GEEK ARTICLES step 8.6 ===
    // WAS:
    //eval('$postbits .= "' . fetch_template('printthreadbit') . '";');
    // NOW:
        eval('$postbits .= "' . fetch_template($template) . '";');
    }
        // === /GEEK ARTICLES ===
It should be -

HTML Code:
Find :
eval('$postbits .= "' . fetch_template('printthreadbit') . '";');


All times are GMT. The time now is 09:19 AM.
Page 4 of 5 « First 23 4 5
Show 40 post(s) from this thread on one page

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.03862 seconds
  • Memory Usage 1,758KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (7)bbcode_html_printable
  • (3)bbcode_php_printable
  • (4)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (3)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 
Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 
Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete