vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   Member Archives (https://vborg.vbsupport.ru/forumdisplay.php?f=202)
-   -   [RELEASE] Poll Hack v1.0.1 (https://vborg.vbsupport.ru/showthread.php?t=4386)

11-04-2000 01:53 AM

This hack is very unoptimized....the person who told me this will remain anonymous.

11-04-2000 02:23 AM

Wasn't I as I have never actually looked at it other than to help fix todays problem..

11-04-2000 05:15 AM

Hmm, after looking through the code, the killer lies here:
Code:

  $pollidcheck=$DB_site->query_first("SELECT pollid FROM post WHERE threadid=$threadid");
That SQL query is issued for each table row displayed in forumdisplay, so if you have 50 threads listed per page, thats 50 extra queries.

11-04-2000 05:28 AM

ouch...maybe I should take this off for now.

11-04-2000 07:27 AM

Quote:

Originally posted by VirtueTech
This hack is very unoptimized....the person who told me this will remain anonymous.
I would love to see their version of it.

It's easy to sit back and complain about the work of others, not so easy to do it yourself. Your source would do well to remember that doron is doing this out of the goodness off his heart and doesn't have to contribute anything at all.

11-04-2000 08:51 AM

Quote:

Originally posted by Stallion
Hmm, after looking through the code, the killer lies here:
Code:

  $pollidcheck=$DB_site->query_first("SELECT pollid FROM post WHERE threadid=$threadid");
That SQL query is issued for each table row displayed in forumdisplay, so if you have 50 threads listed per page, thats 50 extra queries.

Sorry for this confusion, I was working fast to fix that spce in name thing that I messed some stuff up. argghhh

that is need however, as forumdisplay checks threads, not posts. And users wanted to have the poll icon showed without it being choosen. I could add a table to thread which would help. You can remove that code, but the custom icon won't show then.

http://www.naboonline.com/pollhack/pollmodule.php has the fix for the nonescaped showresults, it regressed cause of trying to fix the space thing at 1 AM here, and I was not thinking correctly.

I'll fix the pollidcheck thing today and add a column to the thread table.

Sorry again for this, I shoudl have tested this more, but I had 30 people email me last week requesting this hack.

11-04-2000 12:23 PM

ok, I now have the optimised version done, thanks to Ed for finding that. i had removed such code away from all other files before, somehow forgot to do that for forumdisplay.php

http://www.naboonline.com/pollhack/pollupgrade.zip is for those who are stuck with the unoptomised version.
http://www.naboonline.com/pollhack/pollv101.zip has the full version

If anyone else finds anything wrong, don't hesitate to tell.

thanks to you all for testing this and all, I guess I should be spanked for this (anyone have a paddle)?

11-04-2000 12:41 PM

Works just fine. Thanks to all. :p

11-04-2000 06:27 PM

Hello Martin,

The comment made about the hack was simply to notify everyone about the truth of the hack....the person who I will still keep anonymous is very understanding that the hack was out of the goodness of dorons heart....we were just making him aware....and thanks goes to doron for his fix. :)

11-04-2000 08:33 PM

I keep getting this error emailed to my administrators email address:
Quote:

Database error in vBulletin: Invalid SQL: SELECT threadid FROM post WHERE pollid=
mysql error: You have an error in your SQL syntax near '' at line 1
mysql error number: 1064
Date: Saturday 04th of November 2000 03:27:00 PM
Script: /poll.php
Referer: http://209.15.159.99/poll.php
Any ideas?


All times are GMT. The time now is 08:38 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01117 seconds
  • Memory Usage 1,738KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_code_printable
  • (3)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete