![]() |
This hack is very unoptimized....the person who told me this will remain anonymous.
|
Wasn't I as I have never actually looked at it other than to help fix todays problem..
|
Hmm, after looking through the code, the killer lies here:
Code:
$pollidcheck=$DB_site->query_first("SELECT pollid FROM post WHERE threadid=$threadid"); |
ouch...maybe I should take this off for now.
|
Quote:
It's easy to sit back and complain about the work of others, not so easy to do it yourself. Your source would do well to remember that doron is doing this out of the goodness off his heart and doesn't have to contribute anything at all. |
Quote:
that is need however, as forumdisplay checks threads, not posts. And users wanted to have the poll icon showed without it being choosen. I could add a table to thread which would help. You can remove that code, but the custom icon won't show then. http://www.naboonline.com/pollhack/pollmodule.php has the fix for the nonescaped showresults, it regressed cause of trying to fix the space thing at 1 AM here, and I was not thinking correctly. I'll fix the pollidcheck thing today and add a column to the thread table. Sorry again for this, I shoudl have tested this more, but I had 30 people email me last week requesting this hack. |
ok, I now have the optimised version done, thanks to Ed for finding that. i had removed such code away from all other files before, somehow forgot to do that for forumdisplay.php
http://www.naboonline.com/pollhack/pollupgrade.zip is for those who are stuck with the unoptomised version. http://www.naboonline.com/pollhack/pollv101.zip has the full version If anyone else finds anything wrong, don't hesitate to tell. thanks to you all for testing this and all, I guess I should be spanked for this (anyone have a paddle)? |
Works just fine. Thanks to all. :p
|
Hello Martin,
The comment made about the hack was simply to notify everyone about the truth of the hack....the person who I will still keep anonymous is very understanding that the hack was out of the goodness of dorons heart....we were just making him aware....and thanks goes to doron for his fix. :) |
I keep getting this error emailed to my administrators email address:
Quote:
|
All times are GMT. The time now is 08:38 PM. |
Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information | |
---|---|
|
|
![]() |
|
Template Usage:
Phrase Groups Available:
|
Included Files:
Hooks Called:
|