Ok, in testing the product further, it seems moderated users can see their own posts, but not threads they started.
So it works for posts, but not for threads.
Any suggestions on how to fix this in the product? It would be nice to keep it as a product rather than having to edit the source files directly as before...

Are you talking about the product I uploaded?

I assume it's yours? This one here.

Yes, I wasn't sure if that's what you are using. What version of vB are you running? I can test this on either vB 3.8.11 or vB 4.2.5...it's been so long since I did this I would have to get familiar with it again. I seem to recall it working correctly for me though.

Thanks! I'm using 4.2.5. I had tried the direct modifications to the files in 4.2.3 and that had worked. Just trying the product version and as I say, it seems to work for posts, but not threads. Not sure if I'm doing something wrong, but it would be great if you could check it out as I love this hack. Saves me getting all sorts of double-posts because people don't realize their moderated posts won't show up until approved (and of course they never read the message they get that tells them the same)... ;-)

Yes, I know exactly what you mean...they post over and over and finally give up and usually don't return.

I'll check this out ASAP and post back. :)

Okay, I just retested this on my dev site, and I found moderated users can see both their new threads and posts. :)

I had mistakenly thought that it was partially working. I realize now that it doesn't work at all on my forum.
I'll try the direct file modification again and see if that works.

I would guess some other add-on is interfering.

I got blank pages as well until I did the change in post #2 differently.
I changed:
TO:
Instead of what is shown in post #2.

I have no idea if I've broken something else by doing it this way, but at least it works now...