vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 4.x Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=245)
-   -   Show Thread Enhancements - Digital Point Ad Positioning (https://vborg.vbsupport.ru/showthread.php?t=254332)

digitalpoint 12-01-2010 05:25 PM

Quote:

Originally Posted by naisho (Post 2127892)
I wish this mod could accept differents ads according to forum ids.

Well it was never designed to be a full-blown ad delivery system. We *do* happen to have something for that (ability to target specific forums, along with full-blown bidding system for advertisers to bid on ad space), but's it something different... http://advertising.digitalpoint.com/publisher.php

BadgerDog 12-01-2010 05:42 PM

Quote:

Originally Posted by digitalpoint (Post 2128033)
You could probably just reorder the execution order so the ad positioning one gets triggered before the other.

Thanks .. :)

I'm not really a programmer, but I assume you're referring to the Execution Order of the plugins for both mods?

If so, both mods are currently a 5, so should I make yours a 4, or something like that?

Regards,
Doug

digitalpoint 12-01-2010 06:18 PM

Yep... try making mine 1 or something even... that way mine goes first and isn't doing anything to non-standard stuff that other plug-ins are injecting into the post.

BadgerDog 12-01-2010 06:27 PM

1 Attachment(s)
Quote:

Originally Posted by digitalpoint (Post 2128056)
Yep... try making mine 1 or something even... that way mine goes first and isn't doing anything to non-standard stuff that other plug-ins are injecting into the post.

I made yours a "1" ...

Doing that caused the "Thanks" to execute properly, but it placed its box under your ad, whereas it's normally tucked up flush under the post...

Since all of its plugins (lots of them) are 5's, should I make yours a 6, which might cause it to put itself under their "Thanks" box? :confused:

Thanks again .. :)

Regards,
Doug

Edit: I did try 6 with ordering your mod, but that blocked out the "Thanks" box, except using 1, which split the "Thanks" box away from the bottom of the post.

digitalpoint 12-01-2010 06:43 PM

The ad that my addon inserts isn't necessarily at the end of the post... it inserts it into a random location inside the post (check it with a long post with lots of paragraphs in it to see what I mean). Because of that, there wouldn't really be a way to insert it after the "Thanks" part since it's inserting somewhere random inside the post, not necessarily the end of the post.

BadgerDog 12-01-2010 06:59 PM

Quote:

Originally Posted by digitalpoint (Post 2128066)
The ad that my addon inserts isn't necessarily at the end of the post... it inserts it into a random location inside the post (check it with a long post with lots of paragraphs in it to see what I mean). Because of that, there wouldn't really be a way to insert it after the "Thanks" part since it's inserting somewhere random inside the post, not necessarily the end of the post.

Ok, I think I understand that but ... :)

It only happens when I turn ON the Insert Ad After Post part of the mod, not the part that displays inside the ad, which works fine, even with the "Thanks" mod.

Check the pic in my last post and you can see that the ad splits the post when your plugin is set to 1 and overwrites the "Thanks" box (makes it disappear) when set to "5".

Regards,
Doug

digitalpoint 12-01-2010 07:30 PM

Oh, I see what you mean now... I was getting confused thinking it was something else. I fixed it for the next version, but for now if you go into the "Insert Inside & After Current Post" plug-in, change this:
Code:

$template_hook['postbit_end'] = $vbulletin->options['dppa_afterpost_html'];
to this:
Code:

$template_hook['postbit_end'] .= $vbulletin->options['dppa_afterpost_html'];
Adding the one period will make it append to vs. overwrite anything else using that template hook location.

BadgerDog 12-01-2010 08:18 PM

1 Attachment(s)
Quote:

Originally Posted by digitalpoint (Post 2128085)
Oh, I see what you mean now... I was getting confused thinking it was something else. I fixed it for the next version, but for now if you go into the "Insert Inside & After Current Post" plug-in, change this:
Code:

$template_hook['postbit_end'] = $vbulletin->options['dppa_afterpost_html'];
to this:
Code:

$template_hook['postbit_end'] .= $vbulletin->options['dppa_afterpost_html'];
Adding the one period will make it append to vs. overwrite anything else using that template hook location.

Worked great !! :up:

All plugins left set to 5 and patching with your method above, conflicts with Abe's "Thanks" mod disappear, using 4.04 ...

Thanks partner .. :)

Regards,
Doug

digitalpoint 12-02-2010 08:16 AM

If the post only has one paragraph it would always be in the same place. The randomness of it inserts it between paragraphs. It looked terribly weird/awkward when you were splitting between sentences within the same paragraph.

w3rk3d 12-02-2010 07:33 PM

This mod is great, but so far doesn't do much more for me than the existing Google AdSense plugin built into vB. In fact I'm seeing conflicts between the two. When the after post option of this mod is enabled, it shows the space for the ad, but no ad actually shows up. Furthermore, it hides the ad at the bottom of the page that was already there for the built-in plugin (again, the space is there, but ad is missing) whether the after post option is enabled or not.

A few suggestions came to mind:
  1. Typically admins would want to show ads to fewer groups. Therefore, switch from "hide from groups" to "show to groups". This might also help solve the secondary group logic issue.
  2. Make the ads show up in and below more than just the first post.
  3. Improve functionality in conjunction with the vB version for Adsense.
The one thing this does beyond the built-in plugin is display an ad for permalinked posts, which is great. I have it installed just for that.

Thanks!


All times are GMT. The time now is 07:14 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01959 seconds
  • Memory Usage 1,751KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (4)bbcode_code_printable
  • (5)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete