vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 4.x Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=245)
-   -   vBulletin Project Tools - vBulletin Project Tools Open Source 2.2.2 (https://vborg.vbsupport.ru/showthread.php?t=270346)

rbc 06-04-2017 07:57 AM

Quote:

Originally Posted by Dave (Post 2587256)
Yea, it seems that it will not work properly with the latest vBulletin version that supports PHP 7.
It should work if you change all instances of
PHP Code:

parent::vB_DataManager($registry$errtype); 

to
PHP Code:

parent::__construct($registry$errtype); 

And the function which contains that call should be changed to __construct since a class can not have a function that has the same name as the class. (For example change function vB_DataManager_Pt_Project to function __construct

I took a quick look and it seems that a bunch of files do this so you might have to apply these changes to multiple files.

@Dave ;)

Thank you for pointing this out. :up:
I will try to change these functions - and then try a new installation.

I took a look too and compared some new files from vB 4-2-5 with 4-2-4 and it`s
exactly how you wrote.

best regards

rbc 06-04-2017 12:16 PM

Some good and some bad news ...........

After updating this files :

class_dm_attachment.php (Z. 82)
class_dm_pt_issue.php (Z. 138)
class_dm_pt_issueassign.php (Z. 77)
class_dm_pt_issuechange.php (Z. 83)
class_dm_pt_issuenote.php (Z. 91/708/824/911)
class_dm_pt_issuepetition.php (Z. 79)
class_dm_pt_issuereport.php (Z. 85)
class_dm_pt_issuestatus.php (Z. 84)
class_dm_pt_issuesubscribe.php (Z. 75)
class_dm_pt_issuetype.php (Z. 104)
class_dm_pt_issuevote.php (Z. 78)
class_dm_pt_magicselect.php (Z. 71/232)
class_dm_pt_milestone.php (Z. 94)
class_dm_pt_project.php (Z. 87)
class_dm_pt_projectgroup.php (Z. 75/820)

the install script works perfect :)

All database entries, the sample project group and an example project Is created.
Everything is as good as it should be ..... but

If you want to make a new issue click on submit, a white page appears. You go back to project main page and the just created issue is listed in timeline and wherever. When you click on them -> white page.

Php.log:
[04-Jun-2017 15:14:16 Europe/Zurich] PHP Strict Standards: Only variables should be assigned by reference in /home/xxxx/vbtest/includes/adminfunctions_projecttools.php on line 428
[04-Jun-2017 15:15:07 Europe/Zurich] PHP Strict Standards: Only variables should be assigned by reference in /home/xxxx/vbtest/projectpost.php on line 1403
[04-Jun-2017 15:15:07 Europe/Zurich] PHP Strict Standards: Only variables should be assigned by reference in /home/xxxx/vbtest/projectpost.php on line 1409
[04-Jun-2017 15:15:07 Europe/Zurich] PHP Strict Standards: Declaration of vB_DataManager_Pt_IssueNote::verify_ipaddress() should be compatible with vB_DataManager::verify_ipaddress($ipaddress) in /home/xxxx/vbtest/includes/class_dm_pt_issuenote.php on line 0
[04-Jun-2017 15:15:07 Europe/Zurich] PHP Strict Standards: Only variables should be assigned by reference in /home/xxxx/vbtest/projectpost.php on line 1572
[04-Jun-2017 15:15:07 Europe/Zurich] PHP Strict Standards: Only variables should be passed by reference in /home/xxxx/vbtest/includes/class_dm_pt_issue.php on line 506
[04-Jun-2017 15:15:07 Europe/Zurich] PHP Strict Standards: Only variables should be passed by reference in /home/xxxx/vbtest/includes/class_dm_pt_issue.php on line 507
[04-Jun-2017 15:15:13 Europe/Zurich] PHP Strict Standards: Only variables should be assigned by reference in /home/xxxx/vbtest/projectpost.php on line 1403
[04-Jun-2017 15:15:13 Europe/Zurich] PHP Strict Standards: Only variables should be assigned by reference in /home/xxxx/vbtest/projectpost.php on line 1409
[04-Jun-2017 15:15:13 Europe/Zurich] PHP Strict Standards: Declaration of vB_DataManager_Pt_IssueNote::verify_ipaddress() should be compatible with vB_DataManager::verify_ipaddress($ipaddress) in /home/xxxx/vbtest/includes/class_dm_pt_issuenote.php on line 0
[04-Jun-2017 15:15:13 Europe/Zurich] PHP Strict Standards: Only variables should be assigned by reference in /home/xxxx/vbtest/projectpost.php on line 1572
[04-Jun-2017 15:15:13 Europe/Zurich] PHP Strict Standards: Only variables should be passed by reference in /home/xxxx/vbtest/includes/class_dm_pt_issue.php on line 506
[04-Jun-2017 15:15:13 Europe/Zurich] PHP Strict Standards: Only variables should be passed by reference in /home/xxxx/vbtest/includes/class_dm_pt_issue.php on line 507
[04-Jun-2017 15:15:13 Europe/Zurich] PHP Strict Standards: Declaration of vB_Attachment_Dm_vBProjectTools_Issue::pre_delete( ) should be compatible with vB_Attachment_Dm::pre_delete($list, $checkperms = true) in /home/xxxx/vbtest/packages/vbprojecttools/attach/issue.php on line 0
[04-Jun-2017 15:15:13 Europe/Zurich] PHP Strict Standards: Declaration of vB_Attachment_Dm_vBProjectTools_Issue::pre_delete( ) should be compatible with vB_Attachment_Dm::pre_delete($list, $checkperms = true) in /home/xxxx/vbtest/packages/vbprojecttools/attach/issue.php on line 0
[04-Jun-2017 15:15:13 Europe/Zurich] PHP Fatal error: Unhandled BB Code Call : vB_BbCodeParser in /home/xxxx/vbtest/includes/class_bbcode.php on line 221

A coder will quickly recognize where the problem lies. I'm not a coder :confused:

best regards ...

Dave 06-04-2017 01:18 PM

Every
PHP Code:

=& datamanager_init 

has to be changed to
PHP Code:

datamanager_init 

in all files.

--

In /includes/class_dm_pt_issuenote.php
PHP Code:

function verify_ipaddress(&$ipaddress

Remove the ampersand.

--

In /packages/vbproejcttools/attach/issue.php
PHP Code:

public function pre_delete($list

to
PHP Code:

public function pre_delete($list$checkperms true

--

I'm not sure about the fatal error though, it's not clear to me where it's called from.

rbc 06-04-2017 01:32 PM

Thank you @Dave :)

I will check and fix this - I come back with feedback!

best regards

rbc 06-04-2017 03:42 PM

@ Dave

I changed the files:
/vbhome/
projectajax.php (c 100/202/363/374)
projectpost.php (c 406/704/757/1407/1414/1578/2697/2714/3103/3296/3353/3438/3973/4554)
projectsearch.php (c 791/928/961/)
/vbhome/includes/
adminfunctions_projecttools.php (c 428/459/
class_dm_pt_issue.php (c 570/587/645/670/680/907/995/1408)
class_dm_pt_issueassign.php (c 139/183/)
class_dm_pt_issuechange.php (c 167/247)
class_dm_pt_issuenote.php (c 389/403/503/517/568/582/619/696)
class_dm_pt_issuepetition.php (c 158/187)
class_dm_pt_issuemagicselect.php (c 299)
--
/vbhome/includes/class_dm_pt_issuenote.php (117)
/vbhome/packages/vbprojecttools/attach/issue.php (520)
--

I uninstalled vb PT. AdminCP remove plugins.
Installed it new - > no problems.
install script :up:
create issue -> :down: white page. :mad:

Of course i uploaded all the altered files ....

php.log:

[04-Jun-2017 18:16:25 Europe/Zurich] PHP Strict Standards: Declaration of vB_Attachment_Dm_vBProjectTools_Issue::pre_delete( ) should be compatible with vB_Attachment_Dm::pre_delete($list, $checkperms = true) in /home/xxxx/vbtest/packages/vbprojecttools/attach/issue.php on line 0
[04-Jun-2017 18:16:45 Europe/Zurich] PHP Strict Standards: Declaration of vB_Attachment_Dm_vBProjectTools_Issue::pre_delete( ) should be compatible with vB_Attachment_Dm::pre_delete($list, $checkperms = true) in /home/xxxx/vbtest/packages/vbprojecttools/attach/issue.php on line 0
[04-Jun-2017 18:38:44 Europe/Zurich] PHP Strict Standards: Declaration of vB_Attachment_Dm_vBProjectTools_Issue::pre_delete( ) should be compatible with vB_Attachment_Dm::pre_delete($list, $checkperms = true) in /home/xxxx/vbtest/packages/vbprojecttools/attach/issue.php on line 0
[04-Jun-2017 18:39:01 Europe/Zurich] PHP Strict Standards: Declaration of vB_Attachment_Dm_vBProjectTools_Issue::pre_delete( ) should be compatible with vB_Attachment_Dm::pre_delete($list, $checkperms = true) in /home/xxxx/vbtest/packages/vbprojecttools/attach/issue.php on line 0
[04-Jun-2017 18:52:45 Europe/Zurich] PHP Strict Standards: Only variables should be assigned by reference in /home/xxxx/vbtest/admincp/projectcounters.php on line 153
[04-Jun-2017 18:53:04 Europe/Zurich] PHP Strict Standards: mktime(): You should be using the time() function instead in /home_p2/c/o/compusoft.li/htdocs/includes/class_core.php(4735) : eval()'d code on line 2
[04-Jun-2017 18:53:15 Europe/Zurich] PHP Strict Standards: Only variables should be passed by reference in /home/xxxx/vbtest/includes/class_dm_pt_issue.php on line 506
[04-Jun-2017 18:53:15 Europe/Zurich] PHP Strict Standards: Only variables should be passed by reference in /home/xxxx/vbtest/includes/class_dm_pt_issue.php on line 507

[04-Jun-2017 19:14:13 Europe/Zurich] PHP Strict Standards: Only variables should be assigned by reference in /home/xxxx/vbtest/includes/adminfunctions_plugin.php(1201) : eval()'d code on line 568

[04-Jun-2017 19:14:13 Europe/Zurich] PHP Strict Standards: Only variables should be assigned by reference in /home/xxxx/vbtest/includes/adminfunctions_plugin.php(1201) : eval()'d code on line 633
[04-Jun-2017 19:14:13 Europe/Zurich] PHP Strict Standards: Only variables should be assigned by reference in /home/xxxx/vbtest/includes/adminfunctions_plugin.php(1201) : eval()'d code on line 683

[04-Jun-2017 19:14:30 Europe/Zurich] PHP Strict Standards: Only variables should be assigned by reference in /home/xxxx/vbtest/admincp/project.php on line 957
[04-Jun-2017 19:14:52 Europe/Zurich] PHP Strict Standards: Only variables should be assigned by reference in /home/xxxx/vbtest/admincp/project.php on line 647
[04-Jun-2017 19:17:08 Europe/Zurich] PHP Strict Standards: Only variables should be passed by reference in /home/xxxx/vbtest/includes/class_dm_pt_issue.php on line 506
[04-Jun-2017 19:17:08 Europe/Zurich] PHP Strict Standards: Only variables should be passed by reference in /home/xxxx/vbtest/includes/class_dm_pt_issue.php on line 507

@Dave
feel free to abort your kind advice at any time ... :)

best regards

rbc 06-04-2017 06:19 PM

@ Dave

GOT IT !! :)

In class_bbcode_pt.php i changed :
PHP Code:

parent::vB_BbCodeParser($registry$tag_list$append_custom_tags); 

to : (it is crazy i know, but it works ...)
PHP Code:

parent::__construct($registry$tag_list$append_custom_tags); 

and now eveything works perfect. Without your valuable tips I would never have done that.

Thank you very much again and have a nice evening.

best regards ;)

Dave 06-04-2017 06:58 PM

Ah that explains, I thought you already fixed that. Glad it's working now. :)

rbc 06-05-2017 11:48 AM

Quote:

And the function which contains that call should be changed to __construct
It should work if you change "all" instances of ......
@ Dave

At first i thought only this function must be exchanged "vB_DataManager".
I was wrong.

best regards :)

Hostboard 07-03-2017 12:05 PM

Quote:

Originally Posted by Paul M (Post 2587211)
Actually, i noticed Yves did some work in svn the other day.


Is there anyway to access the SVN? I have tried from http://svn.vbulletin.org/svn/project_tools as noted on
https://www.vb-os.com/ but all I ever get is a white blank page...


Anyone interested in uploading the changed files and save me some work form having to edit all of them :p

Dave 07-03-2017 12:09 PM

Quote:

Originally Posted by Hostboard (Post 2588090)
Is there anyway to access the SVN? I have tried from http://svn.vbulletin.org/svn/project_tools as noted on
https://www.vb-os.com/ but all I ever get is a white blank page...


Anyone interested in uploading the changed files and save me some work form having to edit all of them :p

Yes, use a SVN client. :) If you look at the source code of the SVN pages you will see XML which a SVN client can parse properly.


All times are GMT. The time now is 03:16 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01829 seconds
  • Memory Usage 1,801KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (9)bbcode_php_printable
  • (4)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete