vb.org Archive - Show Thread Enhancements - [AJAX] Post Thank You Hack

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vBulletin 4.x Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=245)

- - Show Thread Enhancements - [AJAX] Post Thank You Hack (https://vborg.vbsupport.ru/showthread.php?t=231666)

I know this hack isn't supported any longer, but I'm hoping someone might know a fix for a problem that cropped up when I updated to a newer PHP (v 7.1). I'm told on the main vBulletin forum that PHP 7.1 is the latest version of PHPP that vB 4.2.5 will work with. So, I recently moved from PHP5.7 to 7.1. So far the basic forum seems to function fine, but I did run into an issue with this hack (which I really like). When someone clicks the "Thanks" icon in a post, it now throws the following error:

PHP Code:


		
			
[] operator not supported for strings on line 182 in /home/bcf/public_html/bcf/includes/functions_post_thanks.php

#0 /home/bcf/public_html/bcf/includes/functions_post_thanks.php(137): fetch_thanks('1120562', '', false)

#1 /home/bcf/public_html/bcf/post_thanks.php(64): thanked_already(Array)

#2 {main}

I backed off to PHP 7.0 and the error goes away. I tried looking at the differences between 7.0 and 7.1 in the PHP manual, but didn't see anything that jumped out as something that might cause this.

The code at or around like 182 in the script is:

PHP Code:


		
			
    180 if (empty($postids))

    181    {

    182        $postids[] = $postid;

    183    }

Any ideas how I might modify this script to work with PHP 7.1? Thanks in advance.

Just insert

PHP Code:


		
			
$postids = array();

before line 182.

Thank you! I added that just before the "if statement" on line 180 and that solved the problem! Thanks you thank you thank you!

Quote:

Originally Posted by Dave (Post 2600621)

Just insert

PHP Code:


		
			
$postids = array();

before line 182.

Thanks! That did fix the error problem, but another weird issue persists. When I "Thank" someone in a post, at first I see the names of myself and any others who have added thanks to that post. But if I leave at the forum in question, then come back and look at that same post, the names are no longer listed.

Any ideas or help would be appreciated.

See this for example of issue: https://youtu.be/krg5TExY79Q

Quote:

Originally Posted by BasilFawlty (Post 2600645)

Thank you! I added that just before the "if statement" on line 180 and that solved the problem! Thanks you thank you thank you!

Before if statement on line 180 is wrong position. Dave wrote "before line 182".

So correct is

PHP Code:


		
			
    180 if (empty($postids))
    181    {
    181a         $postids = array();
    182        $postids[] = $postid;
    183    }

Alternative for line new + 182 is
    182          $postids = array($postid);

But what is your used mod version? On top in version 7.88 this backward incompatibility was removed (running here with vB4.2.5 and php7.1.32)

Thank's shka (and Dave). I had misplaced the statement and put it to early. I have placed it exactly before line 182 and now it seems to be working with PHP 7.1. A million thanks to you both.

Hi ppl,

can you tell me which version works with 4.2.5 version?
Tried to install post_thanks_7_88_for_vB_423_with_collapse_scroll_p ostbit_fix_and_added_features. zip
but get error
This product is not compatible with version 4.2.5 of vBulletin. (Compatible starting with 4.2.0 / Incompatible with 4.2.4 and greater)

Regards

Working in v4.2.5

with

post_thanks_7_88_for_vB_423_with_collapse_scroll_p ostbit_fix_and_added_features. zip

Quote:

Originally Posted by dnikola (Post 2601526)

Hi ppl,

can you tell me which version works with 4.2.5 version?
Tried to install post_thanks_7_88_for_vB_423_with_collapse_scroll_p ostbit_fix_and_added_features.zip
but get error
This product is not compatible with version 4.2.5 of vBulletin. (Compatible starting with 4.2.0 / Incompatible with 4.2.4 and greater)

Regards

remove the <dependencies> xxxx </dependencies> code completely in the product xml

doesnt work vb 4.2.5

X vBulletin 3.8.12 by vBS Debug Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (5)bbcode_php_printable (3)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (4)pagenav_pagelink (3)pagenav_pagelinkrel (1)post_thanks_navbar_search (1)printthread (10)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages:

Phrase Groups Available:

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.04837 seconds Memory Usage 1,754KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (5)bbcode_php_printable (3)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (4)pagenav_pagelink (3)pagenav_pagelinkrel (1)post_thanks_navbar_search (1)printthread (10)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: