vb.org Archive - Major Additions - [DBTech] vBDonate Donations

Page 36 of 45

Show 40 post(s) from this thread on one page

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vBulletin 4.x Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=245)

- - Major Additions - [DBTech] vBDonate Donations - PayPal Donate Manager v1 (vB4) (https://vborg.vbsupport.ru/showthread.php?t=287053)

DragonByte Tech

07-28-2014 04:27 AM

Quote:

Originally Posted by Barbecue_Eater (Post 2508556)

Thanks so far.
Which exact language setting are we talking about here?
I'll probably have to download the english language xml, we only have the German one.

I'm pretty sure there is nothing broken about the files, I remember having the bug before upgrading to the newer version (4.2.1 > 4.2.2).

EDIT:
By setting the language to English (US), the problem is resolved.
How do I fix it with the German language?

It's probably because of the decimal separator.
In the US, you use as a decimal separator - here in middle EU you use

The same applies to the thousand separator: you're using while we're using

But the code needs to be changed in order for the plugin to work properly.

.
.
.
.
-- EDIT 2: Our fix that we use from now:

I fixed it by changing Line 26 of dbtech\vbdonate\includes\functions.php to

Code:

$dbt_vbd_pp_amount_options = explode('/', $vbulletin->options['dbtech_vbdonate_don_amount']);

and started separating the amounts by the character "/" in the vBDonate settings and using a comma instead a dot as the decimal character.

This will not work for the english language pack though, therefore I suggest you guys implement an automatic parser that converts the amounts to the correlating decimal systems of the language. There is a vbulletin variable that can read the decimal character, you can use that automatically based on the users language setting.

Regards.

That's an interesting fix to the problem, I was going to post that it might be the issue. I'll see if I can work forward with that idea.

We have found with several things that the language decimals/separators are usually the issue. Changing the settings in the main options seems to work better than using the language separators.

I'll see if I can work a permanent fix in for you. :)

Matt

Maniac199

07-31-2014 11:55 PM

I know many of you have asked for this so here is a widget I made that will show the username, date, and amount of the last 10 donations. You can feel free to modify, use, and do whatever you want with this code. Make it as a PHP direct execution.

Code:

$output = "<table width=\"100%\"><tr><td width=\"40%\">Username:</td><td width=\"35%\">Date:</td><td width=\"25%\">Amount:</td></tr>";

$result=vB::$db->query_read("

SELECT userid, amount, dateline

FROM " . TABLE_PREFIX . "dbtech_vbdonate_donations ORDER BY id DESC LIMIT 10");

$i = 0;

while ($array = vB::$db->fetch_array($result))

{

$thename = vB::$db->query_first("

SELECT username FROM " . TABLE_PREFIX . "user WHERE userid = '$array[userid]'");

$output .= "<tr><td width=\"40%\"><a href=\"/member.php?" . $array[userid] . "\">" . $thename[username] . "</a></td><td width=\"35%\">" . date("m/d/y", $array[dateline]) . "</td><td width=\"25%\">$" . $array[amount] . "</td></tr>";

}

$output .= "</table>";

Barbecue_Eater

08-02-2014 01:16 AM

Though we fixed the comma at the point I told you, the system didn't recognize the money that was contributed.

Just a question in general: About when can we count for the new version?

DragonByte Tech

08-03-2014 08:47 AM

Quote:

Originally Posted by Barbecue_Eater (Post 2509390)

Though we fixed the comma at the point I told you, the system didn't recognize the money that was contributed.

Just a question in general: About when can we count for the new version?

What do you mean about it not recognizing? If you can elaborate today I might be able to get the fix out tomorrow. I'm working on it atm in the spare time I get between Classifieds and work. :)

Matt

Barbecue_Eater

08-03-2014 09:51 AM

I mean: Using the German language pack - no matter what way you donate, it doesn't show up in the added contributions list and also not in the overall contribution amount of the donation bar.
So for example my donation goal is 100€, I can donate any amount I want, it will not come any closer to the goal.
The sandbox mode is not activated.

Also, the custom amount doesn't work with the commas, showing an error which states that the entered amount is not a number if I have a comma in it. There must be some other part of a script responsible for stripping the custom amount as well.

Don't you have a development version of vBulletin anywhere that you can simply drop the language pack on and see yourself?

DragonByte Tech

08-03-2014 02:36 PM

I'm taking a look at this now to see if I can trace a solution. There have always been problems in the way the language packs pass settings of customized numbers back to scripts.

I've an idea on how we can permanently resolve the issue in v2 which will have to wait until then as it will require some of the additions/changes we plan on implementing. In the mean time, if you can, test it by clearing the language settings for your German pack. If that passes the variable correctly, it is the language pack that is definitely causing the issue. If not, then it's something else.

I've got a Spanish pack installed I used for testing the Classifieds money settings on which I'll have a play around with now. How I fixed it for Classifieds requires the changes I mentioned above for vBDonate. ;)

Matt

DragonByte Tech

08-03-2014 04:09 PM

Having looked at this, I think I have a solution. I've tested this as far as I can (On my dev install I can't go beyond the PayPal payment section).

I've created a setting now that let's you choose your separator for the values and the system checks that. My tests show fine. It's my guess that your contributions are going into the 'unconfirmed' section in your tests.

Once I've marked it as confirmed the correct amount is added to the banner.

Let me know if you want to give the code a test as per the PM I sent you and we can see if we've got a fix for you. :)

Matt

DragonByte Tech

08-11-2014 09:49 PM

Hi everyone,

An update for vBDonate (1.4.7) includes some bug fixes as well as a new setting aimed at improving support for other languages. It had been problematic trying to create values if the language you had on your site used a comma ',' for the decimal point (separator), i.e. 20,00 instead of 20.00. Now it's possible to use the comma as the decimal point and change the separator we use for the amounts available to users to pick from. Before the amounts needed to be listed like 5.00,10.00,15.00. But with the Amount Separator setting you can choose to use another character such as '/' allowing users who need the comma for their decimal point to be able to do so. Several of the fixes also improved the formatting of the currency values for other languages, something we will be continuing to expand as we move towards version 2 of vBDonate.

Lite version is available here, vBDonate DragonByte Tech - vBulletin Mods & Addons or here vBulletin.org. The Pro version is available in your Customer Area if you have purchased a license and it is still valid.

If you like the product you can show your support by nominating it for mod of the month here, vBDonate Donations - Donate Manager - vBulletin.org Forum and also please rate it to help cancel out the users who 1 star our mods.

A full changelog is below:

Bug Fixes And Issue Fixes:
Fixed: Bad image links in the Lite version Admin Dashboard area
Fixed: Number formatting for total amount received on the main donation bar
Fixed: Redirect Error when returning from PayPal
Fixed: Incorrect links in one phrase

Additions To Product From Feature Requests Or Just Something Else Added:
Feature: Setting to allow for changing the the amount separator for values that can be donated to allow for using a comma ',' as a decimal separator for various languages in the language settings

Matt

kamran_dotnet

08-13-2014 04:59 PM

any plan for add new feature to use local vbulletin payment api?
you already done this in db AD

DragonByte Tech

08-13-2014 08:34 PM

We've got a few plans to expand things like that, yes. :)

Matt

All times are GMT. The time now is 09:11 PM.

Page 36 of 45

« First

Last »

Show 40 post(s) from this thread on one page

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01257 seconds Memory Usage 1,753KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (2)bbcode_code_printable (2)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)pagenav (1)pagenav_curpage (4)pagenav_pagelink (1)pagenav_pagelinkrel (1)post_thanks_navbar_search (1)printthread (10)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start pagenav_page pagenav_complete bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: