vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 4.x Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=245)
-   -   Board Optimization - United-Forum CSS Sprites - ludicrous speed - NOW! (https://vborg.vbsupport.ru/showthread.php?t=266696)

Mooff 09-18-2011 10:34 PM

I see.

The addon does know you have GD installed and it is working (partly) as shown here:
Quote:

Starting with images/sprites/sprite-49-main_rtl.png.
18 icons added.
Creating sprite (width:313px height:18px).
Sprite saved, updating css-rules.
CSS template successfully updated.
So it does sprite something.

As for the errors. That particular error does hit here:
Quote:

Originally Posted by sprite.php_pseudo_code
else if(~imagetypes() & $imageinfo[2])
-> throw error, skip icon

If your gd version does not support the imagetype that image has, the addon cannot add that icon and therefore doesn't.
In your case i assume (unfortunately the error message doesn't show us which image type due to an oversight) that your gd version doesn't support *.gif files. So the fix would be to update your GD version.

Regards Mooff

Mickie D 09-19-2011 06:47 PM

I will have a go at updating GD but I do not want to have to recompile PHP.

That is why ImageMagick in my opinion is a much better solution than GD.

EDIT
----------------------
gd

GD Support enabled
GD Version bundled (2.0.34 compatible)
GIF Read Support enabled
GIF Create Support enabled
PNG Support enabled
libPNG Version 1.2.44
WBMP Support enabled
XBM Support enabled
-----------------------

It seems I have GIF enabled ?

Mick

klaus 09-20-2011 04:21 AM

Will there be an updated version soon that incorporates more images in the sprite?

baerwurz 09-20-2011 09:50 AM

Will this be updated to vbcms too?

Mooff 09-20-2011 11:18 AM

@Mickie D
untested:
in the admincp/sprite.php file find that code:
Code:

                        else if(~imagetypes() & $imageinfo[2])
                        {
                            echo '<span style="color:red">Error occurred:</span> Your System does not support ' . image_type_to_mime_type() . '.<br />';
                        }

replace with
Code:

                        else if(~imagetypes() & $imageinfo[2])
                        {
                            echo '<span style="color:red">Error occurred:</span> Your System does not support --- Imageinfo:' . $imageinfo[2]. '<br />';
                        }

that should return a clearer error message.

@klaus
FORUMDISPLAY and FORUMHOME are pretty much final. I think 0.8.0 does add 3 icons there.
Next big release will be SHOWTHREAD with 0.8.0.
On our board we have a 0.8.0alpha already running for some weeks now. Unfortunately it's a bit harder to use sprites on SHOWTHREAD. We had to use :after and :before css classes and the css in the default vbulletin version has a lot {vb:math 2/3*{vb:stylevar padding}/{vb:world}*sqrt(275)} expressions in there - which are kinda hard to reproduce for backgroundimages. So in order to release a version here, we have to debug that a lot, so we can be sure it doesn't look off in custom styles where the icons are bigger, or the font is different and so on.
One of those graphic bugs can be found on our live board using chrome - the top button is broken in german language there (look for "nach oben"). And some other bugs like the notices box, or problems in the profile.

In addition i can't really say when we will have the time to polish 0.8.0 since we are really packed codingwise right now. My spare time gets eaten up by a secret project which should be done in about a month or so - and after that 2 other projects are waiting. As for Osbes, he is currently working on our new server, which does include optimizing that new box a lot, since that is the only time we can actually squeeze more performance out without an additional downtime. After that we will prolly finally go for 4.1.(7)(8) which is scary cause we need to convert our 10 years old vbulletin database to utf8 and there is of course the new editor, which scares me a lot.


That aside the addon as of right now does provide a hook you can use to include your own icons into the sprite. And we will continue to provide support on here, we just can't release a new version in the near future.

@bearwurz
vbcms support isn't planned as of right now since there aren't that many icons which can be caught - for example previewimages and avatars can't be supported, since that doesn't make sense. Icons like quote, reply and so on will be automatically included once 0.8.0 is out i think, not 100% sure, depends on if they use the same css classes as showthread.
In addition the cms is prolly different for every site, depending on what widgets you use and do not use - and it doesn't make sense to include icons for widgets which won't ever be used on your site.
But as posted above, the addon does have a hook, where you can add your own icons into the sprites.

FReeSTER 09-22-2011 02:20 PM

how is the Update looking? lol

thecore762 09-26-2011 08:38 AM

After adding the https://vborg.vbsupport.ru/showthread.php?t=152931 My forum icons stop showing....default and custom style too.

Gato 09-26-2011 03:14 PM

The scripts look very very good.
If you can do it with an installer for add in the Products/addons in ADMINCP, and with information for the people that can´t be so technical or the people that doesn´t know very much about sprites will be EXCELENT!!!

I will wait for non beta version!!

Mooff 09-26-2011 03:46 PM

@thecore762
What is your question? If you have issues with the TMS you should ask in the TMS thread.

@Gato
This is already a producs/addon ACP modification. You have two ways of installing it:
a) Install it and then do the template edits manually
b) Install the TMS first, then install the sprites addon and everything should work out of the box.

This behaviour cannot change.

As for beta or no beta. Codingwise not that much will change in a non beta version (when ever that will be ready). Basecially you should do the same as you do with all addons, install it on your testboard first and then if you experience no bugs (or fixed them) port it to your liveboard. What i'm trying to say - we have some high standards before we would ever call something gold or final. In addition with every new vb4 version new bugs might show up in every addon, so basecially it might never pass beta state. :P But it's fully functional on both forumhome and forumdisplay.

imported_stefan 10-04-2011 10:57 PM

Google Site Speed increased from 56 to 60 ;-). So nice but not fascinating ;-)


All times are GMT. The time now is 08:29 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.02114 seconds
  • Memory Usage 1,748KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_code_printable
  • (2)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (2)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete