vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.6 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=194)
-   -   Major Additions - GRPS: Groups Commune 2.0.x (https://vborg.vbsupport.ru/showthread.php?t=127303)

Merriweather 03-05-2007 03:02 PM

Quote:

Originally Posted by sabret00the (Post 1196311)
i honestly have no idea. they should update in your master style (default vBulletin) and all child styles. when you click user to override installation, do you see it rebuild styles?

Yep.

sabret00the 03-05-2007 03:06 PM

Quote:

Originally Posted by Merriweather (Post 1196316)
Every single thread has this problem. Maybe its another template issue?

viewthread.php

Code:

<?php

/*****************************\
* Name: GRPS: Groups Commune
* Written By: Paul "sabret00the" Walker-Daley
* Concept: 30 October 2003
* Spawned: 26 March 2005
* Copyright Since: 23 April 2004
* Gold: 19 October 2006
* Modified: 07 November 2006
* Contact: sabe@ebslive.com
\*****************************/

// ################ SET SCRIPT LOCATION ENVIRONMENT ######################
require_once('./includes/config_grps.php');

// ####################### SET PHP ENVIRONMENT ###########################
error_reporting(E_ALL & ~E_NOTICE);

// #################### DEFINE IMPORTANT CONSTANTS #######################
define('NO_REGISTER_GLOBALS', 1);
define('THIS_SCRIPT', 'groupsdiscussion');

// ################### PRE-CACHE TEMPLATES AND DATA ######################
$globaltemplates = array(
        'GROUPS',
        'groups_display',
        'groups_display_main',
        'groups_display_member',
        'groups_display_memberbit',
        'groups_display_post',
        'groups_display_viewthread',
        'groups_navbar',
        'groups_viewthread_postbit',
        'groups_viewthread_quickreply',
        'bbcode_code',
        'bbcode_html',
        'bbcode_php',
        'bbcode_quote',
        'editor_clientscript',
        'editor_jsoptions_font',
        'editor_jsoptions_size',
        'im_aim',
        'im_icq',
        'im_msn',
        'im_yahoo',
        'navbar',
        'postbit',
        'postbit_deleted',
        'postbit_legacy',
        'postbit_ip',
        'postbit_onlinestatus',
        'postbit_reputation',
        'postbit_wrapper',
        'showthread_quickreply',
);

// get special phrase groups
$phrasegroups = array('grps', 'postbit', 'posting', 'showthread');

// ######################### REQUIRE BACK-END ############################
require_once("./global.php");
require_once(DIR . '/includes/functions_grps.php');
require_once(DIR . '/includes/functions_bigthree.php');
require_once(DIR . '/includes/class_postbit.php');
require_once(DIR . '/includes/class_grps.php');
$parser =& new vB_BbCodeParser($vbulletin, fetch_tag_list());

// #######################################################################
// ######################## START MAIN SCRIPT ############################
// #######################################################################

($hook = vBulletinHook::fetch_hook('grps_global_start')) ? eval($hook) : false;

$navbits = array();
$navbits[''] = $vbphrase['grps_groups'];
$navbits = construct_navbits($navbits);

// pre-cache templates used by all actions
$globaltemplates = array();

// globalize variables
$vbulletin->input->clean_array_gpc('r', array(
        'page' => TYPE_INT,
        'perpage' => TYPE_INT,
        'pagenumber' => TYPE_INT,
        'do' => TYPE_STR,
        'view' => TYPE_STR,
        'g' => TYPE_INT,
        't' => TYPE_INT,
        'goto' => TYPE_STR,
));

if (!$vbulletin->GPC['g'])
{ // make sure theirs a groupid
        eval(standard_error(fetch_error('invalidid', $vbphrase['grps_group'], $vbulletin->options['contactuslink'])));
}

if (!intval($vbulletin->GPC['g']))
{ // make sure it's a number
        eval(standard_error(fetch_error('invalidid', $vbphrase['grps_group'], $vbulletin->options['contactuslink'])));
}

if (!$vbulletin->GPC['t'])
{ // make sure theirs a groupid
        eval(standard_error(fetch_error('invalidid', $vbphrase['grps_thread'], $vbulletin->options['contactuslink'])));
}

if (!intval($vbulletin->GPC['t']))
{ // make sure it's a number
        eval(standard_error(fetch_error('invalidid', $vbphrase['grps_thread'], $vbulletin->options['contactuslink'])));
}

$threadid = intval($vbulletin->GPC['t']);

$groupid = intval($vbulletin->GPC['g']);
$grps_ids = explode(' ', trim($vbulletin->userinfo['grps']));
$show['grps_wordjoin'] = (in_array($groupid, $grps_ids)) ? TRUE : FALSE;
$show['grps_is_member'] = $show['grps_wordjoin'];
$pagenav = FALSE;

// ##############################################################################
// ####################### HANDLE HEADER() CALLS ################################
// ##############################################################################

// let's define the page number
if ($vbulletin->GPC['goto'])
{
        $grps_numberofposts = $db->query_first("
                SELECT COUNT(*) AS posttotal
                FROM grps_post
                WHERE visible != 0 AND groupid = $groupid AND threadid = " . intval($vbulletin->GPC['t']) . "
        ");

        $whatpage = floor($grps_numberofposts['posttotal'] / $vbulletin->options['grpspostsperpage']);
        if ($whatpage > 1)
        {
                $gotopage = "&amp;page=" . $whatpage;
        }
        else
        {
                $gotopage = FALSE;
        }
}

switch($vbulletin->GPC['goto'])
{
        case 'lastpost':
                $getlastpost = $db->query_first("
                        SELECT MAX(postid) AS postid
                        FROM grps_post AS post
                        WHERE groupid = " . intval($groupid) . " AND threadid = " . intval($vbulletin->GPC['t']) . "
                        LIMIT 1
                ");

                if ($getlastpost['postid'])
                {
                        exec_header_redirect('viewthread.php?' . $vbulletin->session->vars['sessionurl'] . "g=" . $groupid . '&amp;t=' . $vbulletin->GPC['t'] . $gotopage . '#post' . $getlastpost['postid']);
                }
        break;
        case 'newpost':
                $newpost = $db->query_first("
                        SELECT MIN(postid) AS postid
                        FROM grps_post
                        WHERE groupid = $groupid AND threadid = " . intval($vbulletin->GPC['t']) . " AND dateline > " . $vbulletin->userinfo['lastvisit'] . "
                        LIMIT 1
                ");

                if ($newpost['postid'])
                {
                        exec_header_redirect('viewthread.php?' . $vbulletin->session->vars['sessionurl'] . 'g=' . $groupid . '&amp;t=' . $vbulletin->GPC['t'] . $gotopage . '#post' . $newpost['postid']);
                }
                else
                {
                        exec_header_redirect('viewthread.php?' . $vbulletin->session->vars['sessionurl'] . 'g=' . $groupid . '&amp;t=' . $vbulletin->GPC['t'] . '&amp;goto=lastpost');
                }
        break;
        case 'mylastreply':
                $getmylastreply = $db->query_first("
                        SELECT MAX(postid) AS postid
                        FROM grps_post AS post
                        WHERE groupid = " . intval($groupid) . " AND threadid = " . intval($vbulletin->GPC['t']) . " AND userid = " . intval($vbulletin->userinfo['userid']) . "
                        LIMIT 1
                ");

                if ($getmylastreply['postid'])
                {
                        exec_header_redirect('viewthread.php?' . $vbulletin->session->vars['sessionurl'] . 'g=' . $groupid . '&amp;t=' . $vbulletin->GPC['t'] . $gotopage . '#post' . $getmylastreply['postid']);
                }
                else
                {
                        exec_header_redirect('viewthread.php?' . $vbulletin->session->vars['sessionurl'] . 'g=' . $groupid . '&amp;t=' . $vbulletin->GPC['t'] . '&amp;goto=lastpost');
                }
        break;
}
// end switch($goto)

// ###################### extracts info for grps groups page
// ###################### query for group info
$grps_showgroup = $db->query_first("
        SELECT grps.groupid, grps.title, grps.description, grps.approved, grps.create_date, grps.leaderid, user.username AS leadername, grps_categories.catid, grps_categories.title AS catname, grps_setting.image_name, grps_setting.private_posts, grps_setting.moderate_members, grps_setting.hidden_group, grps_setting.hide_image, grps_setting.edit_details, grps_setting.leaderonly_threads, grps_grouptext.pagetext AS spew, grps_grouptext.edit_reason, grps_grouptext.edit_dateline, grps_grouptext.edit_username
        FROM grps_post
        LEFT JOIN grps_setting ON (grps_setting.groupid = grps_post.groupid)
        LEFT JOIN grps ON (grps.groupid = grps_setting.groupid)
        LEFT JOIN " . TABLE_PREFIX . "user AS user ON (user.userid = grps.leaderid)
        LEFT JOIN grps_grouptext ON (grps_grouptext.groupid = grps.groupid)
        LEFT JOIN grps_categories ON (grps_categories.catid = grps.catid)
        WHERE grps.groupid = $groupid
        GROUP BY grps.groupid
        ORDER BY grps.groupid DESC
");

$totalposts = $db->query_first("SELECT COUNT(*) AS totalposts FROM grps_post WHERE groupid = " . intval($groupid) . " AND threadid = " . intval($vbulletin->GPC['t']));
$grps_showgroup = array_merge($grps_showgroup, $totalposts);

$grps_pagetitle = construct_phrase($vbphrase['grps_x_discussion'], $grps_showgroup['title']);
$grps_html_title = construct_phrase($vbphrase['grps_x_discussion'], $grps_showgroup['title']) . ' - ' . $grps_showgroup['catname'] . ' - ';
$grps_showgroup = grps_getgroupsettings($grps_showgroup);
$show['leaderoptions'] = ($grps_showgroup['leaderid'] == $vbulletin->userinfo['userid']) ? TRUE : FALSE;

// ###################### query for newest members
$grps_newestmembers = grps_getmembers($groupid, 0, 5);
$grps_memberbits = grps_getmemberbits($grps_newestmembers, 5);
$grps_members = '';
$page = FALSE;

eval("\$grps_members .= \"".fetch_template("groups_display_member")."\";");


// ###################### no permission if not a member

$privacy_override = (!empty($vbulletin->options['grps_admins_see_private_content']) AND ($vbulletin->userinfo['permissions']['grpspermissions'] & $vbulletin->bf_ugp_grpspermissions['groupsmoderator'])) ? TRUE : FALSE;

if($grps_showgroup['private_posts'] AND !in_array($grps_showgroup['groupid'], $grps_ids) AND !$privacy_override)
{
        print_no_permission();
}

// ###################### pagenav
$page = ($page < 1) ? 1 : intval($page);
$totalposts = $grps_showgroup['totalposts'];
$currentlocation = "viewthread.php?" . $vbulletin->session->vars['sessionurl'] . "g=" . $groupid;
$perpage = intval($vbulletin->options['grpspostsperpage']); //lower limit
$pagenumber = $page;
$upperlimit = ($page * $perpage);
$final_calculations = ($upperlimit - $perpage);

// ###################### query for latest posts
$grps_thread = $db->query_first("
        SELECT grps_thread.threadid, grps_thread.groupid, grps_thread.userid, grps_thread.username, grps_thread.title, grps_thread.dateline, grps_thread.iconid, grps_thread.lastposterid, user.username AS lastposterusername, grps_thread.lastpostdateline, grps_thread.replies, grps_thread.firstpostid, grps_thread.closed, grps_thread.stuck
        FROM grps_thread
        LEFT JOIN " . TABLE_PREFIX . "user AS user ON (user.userid = grps_thread.lastposterid)
        WHERE grps_thread.threadid = $threadid
        LIMIT 1
");

$grps_pagetitle = stripslashes($grps_thread['title']);
$grps_pageextras = ($grps_thread['stuck']) ? "<div style=\"text-align: center; font-weight: bold;\">" . $vbphrase['grps_pinned_thread'] . " <img class=\"inlineimg\" src=\"" . $stylevar['imgdir_misc'] . "/sticky.gif\" alt=\"" . $vbphrase['sticky_thread'] . "\" /></div>" : FALSE;

// creates the pagenav
$page = ($vbulletin->GPC['page'] < 1) ? "1" : intval($vbulletin->GPC['page']);
$totalposts = $db->query_first("SELECT COUNT(postid) AS total FROM grps_post WHERE threadid = $threadid");
$totalposts = $totalposts['total'];
$currentlocation = "viewthread.php?" . $vbulletin->session->vars['sessionurl'] . "g=" . $groupid . "&amp;t=" . $threadid;
$perpage = 25;
$pagenumber = $page;
$lowerlimit = ($page * $perpage);
$query_lowerlimit = ($lowerlimit - $perpage);

$grps_html_title = stripslashes($grps_thread['title']) . (($vbulletin->GPC['page'] < 1) ? '' : ' (' . $page . ')') . ' - ' . $grps_html_title;

// ###################### query for posts
$posts = $db->query_read("
        SELECT grps_post.postid, grps_post.groupid, grps_post.username AS postusername, grps_post.ipaddress AS ip, grps_post.title AS posttitle, grps_post.dateline, grps_post.pagetext, grps_post.iconid, i.title AS icontitle, i.iconpath, grps_post.visible, grps_post.allowsmilie, grps_post.showsignature, grps_post.edit_username, grps_post.edit_userid, grps_post.edit_reason, grps_post.edit_dateline, grps_post.delete_username, grps_post.delete_userid, grps_post.delete_reason, grps.leaderid, u.*, uf.*, utf.*, a.avatarid, a.avatarpath, NOT ISNULL(ca.userid) AS hascustomavatar, ca.dateline AS avatardateline, ca.width AS avwidth, ca.height AS avheight
        FROM grps_post
        LEFT JOIN grps ON (grps.groupid = grps_post.groupid)
        LEFT JOIN " . TABLE_PREFIX . "user u ON (u.userid = grps_post.userid)
        LEFT JOIN " . TABLE_PREFIX . "userfield uf ON (uf.userid = u.userid)
        LEFT JOIN " . TABLE_PREFIX . "usertextfield utf ON (utf.userid = u.userid)
        LEFT JOIN " . TABLE_PREFIX . "icon i ON (i.iconid = grps_post.iconid) > 0
        LEFT JOIN " . TABLE_PREFIX . "avatar a ON (a.avatarid = u.avatarid)
        LEFT JOIN " . TABLE_PREFIX . "customavatar ca ON (ca.userid = u.userid)
        WHERE grps_post.groupid = $groupid and grps_post.threadid = $threadid
        ORDER BY grps_post.dateline ASC
        LIMIT $query_lowerlimit, $perpage
");

$grps_showgroup['allowposting'] = ($vbulletin->userinfo['userid'] AND in_array($grps_showgroup['groupid'], $grps_ids) AND !$grps_thread['closed']) ? TRUE : FALSE;
$grps_thread['open'] = ($vbulletin->userinfo['userid'] AND in_array($grps_showgroup['groupid'], $grps_ids) AND !$grps_thread['closed']) ? TRUE : FALSE;

$postbits = '';
$show['spacer'] = FALSE;
$show['warning'] = FALSE;

//$vbulletin->options['legacypostbit'] = (empty($vbulletin->options['grps_legacypostbit'])) ? 0 : 1;

$ignore = explode(' ', $vbulletin->userinfo['ignorelist']);

$postbit = '';
$postbit_factory =& new vB_Postbit_Factory();
$postbit_factory->registry =& $vbulletin;
$postbit_factory->forum =& $grps_showgroup;
$postbit_factory->thread =& $grps_thread;
$postbit_factory->cache = array();
$postbit_factory->bbcode_parser =& new vB_BbCodeParser($vbulletin, fetch_tag_list());

$cell  = 0;

while ($post = $db->fetch_array($posts))
{
        if ($tachyuser = in_coventry($post['userid']))
        {
                $fetchtype = 'post_global_ignore';
        }
        else if (isset($ignore[$post['userid']]))
        {
                $fetchtype = 'post_ignore';
        }
        else if ($post['visible'] == 2)# OR ($thread['visible'] == 2 AND $postcount == 1))
        {
                $fetchtype = 'post_deleted';
        }
        else
        {
                $fetchtype = 'post';
        }

        $postbit_obj =& $postbit_factory->fetch_postbit($fetchtype);

        $postbit .= $postbit_obj->construct_postbit($post);

        $cell++;

} //got all that info

// let's rewrite the postbit links and make the images work       
$vbulletin->options['grps_viewthreadfind'] = str_replace(
        array(
                '$stylevar[\'imgdir_button\']',
                '$vbulletin->options[\'bburl\']',
                '$vbulletin->options[\'homeurl\']',
                '{\n\n}'
        ),
        array(
                $stylevar['imgdir_button'],
                $vbulletin->options['bburl'],
                $vbulletin->options['homeurl'],
                '' . "\n\n" . ''
        ),
$vbulletin->options['grps_viewthreadfind']);

$vbulletin->options['grps_viewthreadreplace'] = str_replace(
        array(
                '$stylevar[\'imgdir_button\']',
                '$vbulletin->options[\'bburl\']',
                '$vbulletin->options[\'homeurl\']',
                '{\n\n}'
        ),
        array(
                $stylevar['imgdir_button'],
                $vbulletin->options['bburl'],
                $vbulletin->options['homeurl'],
                '' . "\n\n" . ''
        ),
$vbulletin->options['grps_viewthreadreplace']);

$viewthread = array(
        'find' => explode(', ', $vbulletin->options['grps_viewthreadfind']),
        'replace' => explode(', ', $vbulletin->options['grps_viewthreadreplace'])
);

$postbit = str_replace($viewthread['find'], $viewthread['replace'], $postbit);

// *********************************************************************************
$show['quickreply'] = ($vbulletin->userinfo['userid'] AND in_array($grps_showgroup['groupid'], $grps_ids) AND !$grps_thread['closed'] AND $vbulletin->options['quickreply']) ? TRUE : FALSE;
// *********************************************************************************

// build quick reply if appropriate
if ($show['quickreply'])
{
        require_once(DIR . '/includes/functions_editor.php');

        $forum = array();

        $show['wysiwyg'] = ($forum['allowbbcode'] = TRUE) ? is_wysiwyg_compatible() : 0;
        $istyles_js = construct_editor_styles_js();

        // set show signature hidden field
        $showsig = ($vbulletin->userinfo['signature']) ? 1 : 0;
        $vbulletin->options['quickreply'] = 1;
        $threadedmode = FALSE;
        $qrpostid = 'who cares';
        $effective_lastpost = FALSE;

        $show['qr_require_click'] = 0;
        $show['threadedmode'] = 0;

        // temporarily?
        $threadedmode = 0;
        $show['allow_ajax_qr'] = 0;
        // end temp

        $editorid = construct_edit_toolbar('', 0, $foruminfo['forumid'], ($foruminfo['allowsmilies'] ? 1 : 0), 1, false, 'qr');
        $messagearea = "
                <script type=\"text/javascript\">
                <!--
                        var threaded_mode = $threadedmode;
                        var require_click = $show[qr_require_click];
                        var is_last_page = $show[allow_ajax_qr]; // leave for people with cached JS files
                        var allow_ajax_qr = $show[allow_ajax_qr];
                        var ajax_last_post = " . intval($effective_lastpost) . ";
                // -->
                </script>
                $messagearea
        ";

        if (is_browser('mozilla') AND $show['wysiwyg'] == 2)
        {
                // Mozilla WYSIWYG can't have the QR collapse button,
                // so remove that and force QR to be expanded
                $show['quickreply_collapse'] = false;

                unset(
                        $vbcollapse["collapseobj_quickreply"],
                        $vbcollapse["collapseimg_quickreply"],
                        $vbcollapse["collapsecel_quickreply"]
                );
        }
        else
        {
                $show['quickreply_collapse'] = true;
        }
}
else if ($show['ajax_js'])
{
        require_once(DIR . '/includes/functions_editor.php');

        $vBeditJs = construct_editor_js_arrays();
        eval('$vBeditTemplate[\'clientscript\'] = "' . fetch_template('editor_clientscript') . '";');
}

$show['quickedit'] = ($vbulletin->options['quickedit'] AND !$show['threadedmode']);

$vBeditTemplate['clientscript'] = str_replace('="clientscript', '="' . $vbulletin->options['bburl'] . '/clientscript', $vBeditTemplate['clientscript']);

// ###################### query for number of new posts
$grps_newpoststext = grps_newgroupposts($groupid);
$grps_moderation = display_mod_options($grps_thread, $grps_showgroup);

eval("\$grps_mainspace = \"".fetch_template("groups_display_viewthread")."\";");
eval("\$grps_main = \"".fetch_template("groups_display_main")."\";");

$pagenav = construct_page_nav($pagenumber, $perpage, $totalposts, 'viewthread.php?' . $vbulletin->session->vars['sessionurl'] . 'g=' . $groupid . '&amp;t=' . $threadid, '' . (!empty($vbulletin->GPC['perpage']) ? '&amp;pp=' . $perpage : '') . '');
// draw nav bar
$navbits = array();
$navbits['browse.php?' . $vbulletin->session->vars['sessionurl'] . 'c=' . $grps_showgroup['catid']] = $grps_showgroup['catname'];
$navbits['groups.php?' . $vbulletin->session->vars['sessionurl'] . 'g=' . $grps_showgroup['groupid']] = $grps_showgroup['title'];
$navbits[''] = stripslashes($grps_thread['title']);
$navbits = construct_navbits($navbits);

//handles the rest of the page and layout.
eval('$grps_navbar = "' . fetch_template('groups_navbar') . '";');
eval('$headinclude = "' . fetch_template('headinclude') . '";');
$headinclude = grps_rewrite_links($headinclude);
eval('$navbar = "' . fetch_template('navbar') . '";');
$navbar = grps_rewrite_links($navbar);
eval('$footer = "' . fetch_template('footer') . '";');
$footer = grps_rewrite_links($footer);
($hook = vBulletinHook::fetch_hook('grps_global_complete')) ? eval($hook) : false;

$final_template= 'groups_display';
eval("print_output(\"".fetch_template($final_template)."\");");

?>

PMing you the source as it has links to my board in it.

ok, can you do me a favour and just go to your postbit template, and then click save and reload then recheck a thread and let me know is the problem still exists.

Merriweather 03-05-2007 03:12 PM

I went to Postbit Templates >> postbit, clicked "Save and Reload", then went back to a thread, reloaded the page.... and still have the same issue.

sabret00the 03-05-2007 03:14 PM

Quote:

Originally Posted by Merriweather (Post 1196327)
I went to Postbit Templates >> postbit, clicked "Save and Reload", then went back to a thread, reloaded the page.... and still have the same issue.

Just to confirm, this is a problem which all of your users have not just you correct?

Merriweather 03-05-2007 03:15 PM

Hm, let me check.

Merriweather 03-05-2007 03:19 PM

Yes, other members have the same issue. They see the red x where the image is missing, and no post title.

Merriweather 03-05-2007 03:20 PM

Also just found out that a member who joins a group and then gets moved to a usergroup WITHOUT group permissions can still see the group and post to it. Seems like a future bug fix, unless it's just me again. :(

sabret00the 03-05-2007 03:37 PM

Quote:

Originally Posted by Merriweather (Post 1196332)
Hm, let me check.

can you run this plugin (it's a plugin not a product) and then go to a thread within your groups and let give me the results please.

Merriweather 03-05-2007 03:49 PM

Doing that now.

Merriweather 03-05-2007 03:52 PM

Same as the last one:

sabe these are my image paths:
PHP Code:


    http
://www.<edit>.com/forums/images/icons/icon1.gif
    
http://www.<edit>.com/forums/images/smilies/icon_arrow.gif
    
http://www.<edit>.com/forums/images/smilies/icon_idea.gif
    
http://www.<edit>.com/forums/images/smilies/icon_exclaim.gif
    
http://www.<edit>.com/forums/images/smilies/icon_question.gif
    
http://www.<edit>.com/forums/images/smilies/icon_smile.gif
    
http://www.<edit>.com/forums/images/smilies/icon_evil.gif
    
http://www.<edit>.com/forums/images/smilies/icon_sad.gif
    
http://www.<edit>.com/forums/images/smilies/icon_lol.gif
    
http://www.<edit>.com/forums/images/smilies/icon_redface.gif
    
http://www.<edit>.com/forums/images/smilies/icon_wink.gif
    
http://www.<edit>.com/forums/images/smilies/icon_down.gif
    
http://www.<edit>.com/forums/images/smilies/icon_up.gif 

Are you not having these issues on your site? Are you able to see post icons and thread titles?

sabret00the 03-05-2007 04:00 PM

Quote:

Originally Posted by Merriweather (Post 1196353)
Same as the last one:

sabe these are my image paths:
PHP Code:


    http
://www.<edit>.com/forums/images/icons/icon1.gif
    
http://www.<edit>.com/forums/images/smilies/icon_arrow.gif
    
http://www.<edit>.com/forums/images/smilies/icon_idea.gif
    
http://www.<edit>.com/forums/images/smilies/icon_exclaim.gif
    
http://www.<edit>.com/forums/images/smilies/icon_question.gif
    
http://www.<edit>.com/forums/images/smilies/icon_smile.gif
    
http://www.<edit>.com/forums/images/smilies/icon_evil.gif
    
http://www.<edit>.com/forums/images/smilies/icon_sad.gif
    
http://www.<edit>.com/forums/images/smilies/icon_lol.gif
    
http://www.<edit>.com/forums/images/smilies/icon_redface.gif
    
http://www.<edit>.com/forums/images/smilies/icon_wink.gif
    
http://www.<edit>.com/forums/images/smilies/icon_down.gif
    
http://www.<edit>.com/forums/images/smilies/icon_up.gif 

Are you not having these issues on your site? Are you able to see post icons and thread titles?

nope, this problem seems to be unique to you. can you install this plugin and print the results please. feel free to delete both plugins straight after you've collected the results.

sabret00the 03-05-2007 04:02 PM

oh and here's the patch for the posting problem:

sabret00the 03-05-2007 04:05 PM

do your post icons show up on groups.php?g=ANYGROUP

Merriweather 03-05-2007 04:47 PM

Quote:

Originally Posted by sabret00the (Post 1196366)
do your post icons show up on groups.php?g=ANYGROUP

Nope.

Merriweather 03-05-2007 04:48 PM

Quote:

Originally Posted by sabret00the (Post 1196363)
oh and here's the patch for the posting problem:

Stupid question -- where do I put it??

sabret00the 03-05-2007 04:48 PM

Quote:

Originally Posted by Merriweather (Post 1196398)
Nope.

So the only page they appear on is editpost.php?

sabret00the 03-05-2007 04:48 PM

Quote:

Originally Posted by Merriweather (Post 1196399)
Stupid question -- where do I put it??

forums/includes/

folder.

Merriweather 03-05-2007 04:50 PM

Quote:

Originally Posted by sabret00the (Post 1196400)
So the only page they appear on is editpost.php?

Yes.

sabret00the 03-05-2007 06:29 PM

Quote:

Originally Posted by Merriweather (Post 1196404)
Yes.

i'm still trying to figure this out. bare with me.

sabret00the 03-05-2007 06:38 PM

Quote:

Originally Posted by Merriweather (Post 1196404)
Yes.

can you upload these two to the groups folder please.

and then run:
www.yoursite.com/groups/test_groups.php?g=XX
http://www.yoursite.com/groups/test_....php?g=XX&t=YY

please substitute XX and YY for numbers in which icons display or in your case don't, in the normal groups.php and viewthread.php

Merriweather 03-05-2007 07:14 PM

On the posting issue, some users are still getting this database error:

Invalid SQL:

SELECT COUNT(*) AS replies
FROM grps_thread
WHERE threadid =;

MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 3 Error Number : 1064
Date : Monday, March 5th 2007 @ 01:04:01 PM
Script : http://www.<edit>.com/groups/newreply.php
Referrer : http://www.<edit>.com/groups/newreply.php?do=newreply&t=36
IP Address : <edit>
Username : <edit>
Classname : vb_database

I will do the other tests for you this evening, I have to go for a while.

Merriweather 03-06-2007 03:40 AM

Quote:

Originally Posted by sabret00the (Post 1196491)
can you upload these two to the groups folder please.

and then run:
www.yoursite.com/groups/test_groups.php?g=XX
http://www.yoursite.com/groups/test_....php?g=XX&t=YY

please substitute XX and YY for numbers in which icons display or in your case don't, in the normal groups.php and viewthread.php

test_groups.php just gave this:

Code:

=>
test_viewthread.php gave this:

Code:

=>=>=>=>=>=>=>=>=>=>=>=>=>=>

Merriweather 03-06-2007 03:45 AM

Another issue users are having is that it's putting HTML in the text entry box if a user previews their post. Seeing as we don't allow HTML in posts on the fourm, it's casuing a problem with formatting.

Merriweather 03-06-2007 03:49 AM

This whole random inability to post is really troublesome on my forums. It's the same DB error over and over:

Quote:

Database error in vBulletin 3.6.5:

Invalid SQL:

SELECT COUNT(*) AS replies
FROM grps_thread
WHERE threadid =;

MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 3
Error Number : 1064
Date : Monday, March 5th 2007 @ 09:47:35 PM
Script : http://www.<edit>.com/groups/newreply.php
Referrer : http://www.<edit>.com/groups/newreply.php?do=newreply&t=98
IP Address : <edit>
Username : <edit>
Classname : vb_database
We can't find any rhyme or reason for it, but some of my groups, you can only start threads and can't reply to them at all!!!

sabret00the 03-06-2007 07:22 AM

Quote:

Originally Posted by Merriweather (Post 1196838)
Another issue users are having is that it's putting HTML in the text entry box if a user previews their post. Seeing as we don't allow HTML in posts on the fourm, it's casuing a problem with formatting.

can i get a screenshot of this one please?

as for the database error, i'm on it

sabret00the 03-06-2007 07:34 AM

Quote:

Originally Posted by Merriweather (Post 1196840)
This whole random inability to post is really troublesome on my forums. It's the same DB error over and over:



We can't find any rhyme or reason for it, but some of my groups, you can only start threads and can't reply to them at all!!!

can you run this query please and give me the results [sql] SELECT COUNT(*) AS replies
FROM grps_thread
WHERE threadid = 98[/sql]

sabret00the 03-06-2007 07:34 AM

Quote:

Originally Posted by Merriweather (Post 1196838)
Another issue users are having is that it's putting HTML in the text entry box if a user previews their post. Seeing as we don't allow HTML in posts on the fourm, it's casuing a problem with formatting.

can i get a screenshot of that because i'm unable to replicate that.

sabret00the 03-06-2007 07:35 AM

Quote:

Originally Posted by Merriweather (Post 1196837)
test_groups.php just gave this:

Code:

=>
test_viewthread.php gave this:

Code:

=>=>=>=>=>=>=>=>=>=>=>=>=>=>

And there was DEFINITELY use of posticons on both pages correct?

sabret00the 03-06-2007 07:47 AM

Quote:

Originally Posted by Merriweather (Post 1196837)
test_groups.php just gave this:

Code:

=>
test_viewthread.php gave this:

Code:

=>=>=>=>=>=>=>=>=>=>=>=>=>=>

can you please run this query with the same values for which you used XX and YY on the test_viewthread.php please

[sql] SELECT grps_post.postid, grps_post.groupid, grps_post.username AS postusername, grps_post.ipaddress AS ip, grps_post.title AS posttitle, grps_post.dateline, grps_post.pagetext, grps_post.iconid, i.title AS icontitle, i.iconpath, grps_post.visible, grps_post.allowsmilie, grps_post.showsignature, grps_post.edit_username, grps_post.edit_userid, grps_post.edit_reason, grps_post.edit_dateline, grps_post.delete_username, grps_post.delete_userid, grps_post.delete_reason, grps.leaderid, u.*, uf.*, utf.*, a.avatarid, a.avatarpath, NOT ISNULL(ca.userid) AS hascustomavatar, ca.dateline AS avatardateline, ca.width AS avwidth, ca.height AS avheight
FROM grps_post
LEFT JOIN grps ON (grps.groupid = grps_post.groupid)
LEFT JOIN user u ON (u.userid = grps_post.userid)
LEFT JOIN userfield uf ON (uf.userid = u.userid)
LEFT JOIN usertextfield utf ON (utf.userid = u.userid)
LEFT JOIN icon i ON (i.iconid = grps_post.iconid) > 0
LEFT JOIN avatar a ON (a.avatarid = u.avatarid)
LEFT JOIN customavatar ca ON (ca.userid = u.userid)
WHERE grps_post.groupid = XX and grps_post.threadid = YY
ORDER BY grps_post.dateline ASC
[/sql]

and please just look for the iconpath column and let me know if it's empty on all counts.

hold on, i think i've figured it out. are you using a default icon on your forums?

Merriweather 03-06-2007 02:31 PM

Quote:

Originally Posted by sabret00the (Post 1196939)
can you run this query please and give me the results [sql] SELECT COUNT(*) AS replies
FROM grps_thread
WHERE threadid = 98[/sql]

Results: 1

Merriweather 03-06-2007 02:36 PM

Quote:

Originally Posted by sabret00the (Post 1196934)
can i get a screenshot of this one please?

I PMed you the screenshot. :)

Merriweather 03-06-2007 02:42 PM

Quote:

Originally Posted by sabret00the (Post 1196948)
can you please run this query with the same values for which you used XX and YY on the test_viewthread.php please

[sql] SELECT grps_post.postid, grps_post.groupid, grps_post.username AS postusername, grps_post.ipaddress AS ip, grps_post.title AS posttitle, grps_post.dateline, grps_post.pagetext, grps_post.iconid, i.title AS icontitle, i.iconpath, grps_post.visible, grps_post.allowsmilie, grps_post.showsignature, grps_post.edit_username, grps_post.edit_userid, grps_post.edit_reason, grps_post.edit_dateline, grps_post.delete_username, grps_post.delete_userid, grps_post.delete_reason, grps.leaderid, u.*, uf.*, utf.*, a.avatarid, a.avatarpath, NOT ISNULL(ca.userid) AS hascustomavatar, ca.dateline AS avatardateline, ca.width AS avwidth, ca.height AS avheight
FROM grps_post
LEFT JOIN grps ON (grps.groupid = grps_post.groupid)
LEFT JOIN user u ON (u.userid = grps_post.userid)
LEFT JOIN userfield uf ON (uf.userid = u.userid)
LEFT JOIN usertextfield utf ON (utf.userid = u.userid)
LEFT JOIN icon i ON (i.iconid = grps_post.iconid) > 0
LEFT JOIN avatar a ON (a.avatarid = u.avatarid)
LEFT JOIN customavatar ca ON (ca.userid = u.userid)
WHERE grps_post.groupid = XX and grps_post.threadid = YY
ORDER BY grps_post.dateline ASC
[/sql]

and please just look for the iconpath column and let me know if it's empty on all counts.

hold on, i think i've figured it out. are you using a default icon on your forums?

I am using a default icon. But even if a different icon is selected, it doesn't show.

The results are 0 for all iconids, null for all icontitles and paths. Posttitle is NOT blank for some, but the title doesn't show on the posts.

sabret00the 03-06-2007 03:35 PM

Quote:

Originally Posted by Merriweather (Post 1197186)
I am using a default icon. But even if a different icon is selected, it doesn't show.

The results are 0 for all iconids, null for all icontitles and paths. Posttitle is NOT blank for some, but the title doesn't show on the posts.

can you please go to your Admin CP => vBulletin Options => Thread Display Options

and check your default post icon path please.

sabret00the 03-06-2007 03:37 PM

Quote:

Originally Posted by sabret00the (Post 1196940)
can i get a screenshot of that because i'm unable to replicate that.

confirmed, it's a problem with the WYSIWYG editor. being worked on now.

Merriweather 03-06-2007 04:28 PM

Quote:

Originally Posted by sabret00the (Post 1197246)
can you please go to your Admin CP => vBulletin Options => Thread Display Options

and check your default post icon path please.

Adding my full URL there fixed the default (YAY!) but there is still the issue that if you choose a different icon, or enter a title, they don't show. :)

sabret00the 03-06-2007 11:00 PM

Quote:

Originally Posted by Merriweather (Post 1197300)
Adding my full URL there fixed the default (YAY!) but there is still the issue that if you choose a different icon, or enter a title, they don't show. :)

enter a title?

Merriweather 03-07-2007 12:39 AM

Quote:

Originally Posted by sabret00the (Post 1197573)
enter a title?

Yes, when you post, you can enter a post title and your message. If you enter a title, it is supposed to show next to the post icon. Neither the selected post icon (if you select one) nor the post title (if you enter one) ever show. It only shows the default post icon. It's saving the titles, because I can see them in the DB, but they aren't displayed. I'm not sure about the post icons.

Merriweather 03-07-2007 02:36 AM

Other issues my users have reported:

(1) If a user has no avatar, it shows a red X or missing image placeholder for the user. It should not show anything, or at least some default "missing avatar" placeholder.

(2) When you post to a thread, the page refreshes to the start of page one, instead of where you just posted. So if you post to page five, it bounces you back to page one, and you have to click and scroll to get back where you left off.

(3) The [View My Last Reply] [View New Posts] [View Last Reply] links just take you to the start of the thread.

My own issue is that the system does not seem to check a user's permissions, only if they are a member. So when I had a member join a group, then get changed to a usergroup without group joining privileges, she could still see and post to the group because she was still a member. If the system could check the user against their usergroup permissions to make sure that they have permissions to access the groups, whether or not they are a member or leader of a group would be great. Perhaps a cron job to remove users from groups once their permissions change, even.

Merriweather 03-07-2007 03:02 AM

I've made some progress figuring out this maddening DB error on replying to posts as well as why it takes you to the start of the post and not where you left off. :)

If I click to reply on certain group threads, the HTML source looks like this:

Code:

<input type="hidden" name="s" value="" />
                <input type="hidden" name="do" value="postreply" />
                <input type="hidden" name="t" value="0" />
                <input type="hidden" name="p" value="" />
                <input type="hidden" name="posthash" value="" />
                <input type="hidden" name="poststarttime" value="" />
                <input type="submit" class="button" name="sbutton" id="vB_Editor_001_save" value="Submit Reply" accesskey="s" tabindex="1" />
                <input type="submit" class="button" name="preview" value="Preview Post" accesskey="p" tabindex="1" />

Obviously, the topicid and postid are missing.

On the ones that work, the source is like this:

Code:

<input type="hidden" name="s" value="" />
                <input type="hidden" name="do" value="postreply" />
                <input type="hidden" name="t" value="47" />
                <input type="hidden" name="p" value="" />
                <input type="hidden" name="posthash" value="" />
                <input type="hidden" name="poststarttime" value="" />
                <input type="submit" class="button" name="sbutton" id="vB_Editor_001_save" value="Submit Reply" accesskey="s" tabindex="1" />
                <input type="submit" class="button" name="preview" value="Preview Post" accesskey="p" tabindex="1" />

The topicid is there, though the postid is not. This is why I can reply to the post, but it takes me to the start of the thread, and not the post I made, after I submit.

Interestingly, on threads that have no topicid when replying, you CAN quote them -- the topicid gets pulled there. So perhaps an investigation of the code to see what the difference is in pulling the topicid for the quote vs. the new reply will help you solve this?

I will let you know if I figure out any more. :)

Merriweather 03-07-2007 03:07 AM

Another bug -- I deleted a post from a thread, but it still shows the thread as having a reply, which it no longer does. The info block on the right, however, that says "Posts in this Thread" has the correct count.


All times are GMT. The time now is 09:10 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.03165 seconds
  • Memory Usage 2,003KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (9)bbcode_code_printable
  • (2)bbcode_php_printable
  • (27)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (2)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete