vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 4.x Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=245)
-   -   Major Additions - [DBTech] vBDonate Donations - PayPal Donate Manager v1 (vB4) (https://vborg.vbsupport.ru/showthread.php?t=287053)

DragonByte Tech 04-22-2014 04:59 PM

Not sure I'm afraid. Maybe try a hard refresh, or clearing the cache of any caching software you use just in case. I've not come across that issue before. :(

Matt

PS the last update fixed issues with links that Google might have, nothing more.

katie hunter 07-21-2014 01:09 PM

Quote:

Originally Posted by ruger (Post 2494069)
I just uploaded the files and xml. 2 of the images in the admin panel are not showing for some reason and when I look in the dbtech/vbdonate/images/admin file they are definitely there. Ive tried reimporting the product as well and still doesnt fix the issue.

http://www.redriversyndicate.com/images/admindon.png

Any ideas?

Quote:

Originally Posted by DragonByte Tech (Post 2494167)
Not sure I'm afraid. Maybe try a hard refresh, or clearing the cache of any caching software you use just in case. I've not come across that issue before. :(

Matt

PS the last update fixed issues with links that Google might have, nothing more.

Fillip, i also have the same issue with these two images not showing. Try installing the lite version and see. I am testing the lite version around and i like it, i might consider buying the pro version however few things i'd love to see happening

1. The contribution list. Adam had a pretty contribution list with members' avatars displaying and the style was displaying in yui (it was pretty sleek) https://vborg.vbsupport.ru/showthrea...light=donation (his plugin is dead though as many know)

2. The donation bar for the donation goal was progressive and animated in many nice ways when you refresh the page, you would see the progress bar moves.

3. He had many user-group control like which usergroup can (this is actually very important setting for me) :
- see the donation goal
- can see the donate button and donate
- can see the contributor list

Barbecue_Eater 07-24-2014 01:27 PM

So I found the bug that causes 5.00 turning into 500 that I stated here:
Quote:

Originally Posted by Barbecue_Eater (Post 2490311)
Greetings.

We're using vBulletin 4.2.2 PL 1 and tried different currencies (USD and EUR), the specified amount (f.e. "5.0") will always ignore the dot after being redirected to paypal

For example I choose: 5.00, get redirected to paypal and it shows up as 500 USD/EUR.
This must be a bug of some kind and also doesn't get fixed when I chose USD instead EUR.

The bug is caused by:


put this in your dodonate.php file replacing line 23 with these and see the difference:
PHP Code:

echo "actual amount: ".$_REQUEST['amount']."<br/>";
$vbulletin->input->clean_gpc('p''amount'TYPE_UNUM);
echo 
"broken amount by the gpc function: ".$vbulletin->GPC['amount']."<br/>";
exit(); 

do not use this on your actual vbulletin systems, it's only for the dbtech team!

the result for me is:
Quote:

actual amount: 5.00
broken amount by the gpc function: 500

I just don't want to fix this by myself as this is a good hint for you guys to fix something and also I don't want to make any errors regarding security, as clean_gpc is needed somehow anyways.
I don't know how to use it and at the same time fix the bug....

Would you please fix this asap?

Regards

DragonByte Tech 07-24-2014 03:00 PM

Quote:

Originally Posted by katie hunter (Post 2507619)
Fillip, i also have the same issue with these two images not showing. Try installing the lite version and see. I am testing the lite version around and i like it, i might consider buying the pro version however few things i'd love to see happening

1. The contribution list. Adam had a pretty contribution list with members' avatars displaying and the style was displaying in yui (it was pretty sleek) https://vborg.vbsupport.ru/showthrea...light=donation (his plugin is dead though as many know)

2. The donation bar for the donation goal was progressive and animated in many nice ways when you refresh the page, you would see the progress bar moves.

3. He had many user-group control like which usergroup can (this is actually very important setting for me) :
- see the donation goal
- can see the donate button and donate
- can see the contributor list

I'll try and look over what might be causing the missing images, I'm slightly puzzled by it. If possible, could you check what the exact broken link is to the image and post it here?

I will take a look at trying to implement your ideas when we do our big update on vBDonate which is due soon. I'm currently working on getting the v2 of the DBTech Classifieds ready and then I'll be concentrating on vBDonate.

@Barbeque_Eater, thanks for the headsup. I'll take a look and see what might be causing the issue. So far I've not been able to replicate this bug myself, but that info might just help me. It may be that I need to test somethings on your install, would that be possible?

Matt

Barbecue_Eater 07-24-2014 03:08 PM

Sorry, I'm not too sure about giving a 3rd party access to our installation.

Though I'd love to work together and do everything you need me to by myself or give you all neccessary information.
If you want, we can talk on Teamspeak (preferrably) or Skype.

DragonByte Tech 07-24-2014 03:11 PM

That should be fine. I'll let you know how I get on chasing the bug over the weekend and send you a message if I need to test a few things.

Matt

katie hunter 07-25-2014 11:39 AM

Quote:

Originally Posted by DragonByte Tech (Post 2508119)
I'll try and look over what might be causing the missing images, I'm slightly puzzled by it. If possible, could you check what the exact broken link is to the image and post it here?

I will take a look at trying to implement your ideas when we do our big update on vBDonate which is due soon. I'm currently working on getting the v2 of the DBTech Classifieds ready and then I'll be concentrating on vBDonate.

@Barbeque_Eater, thanks for the headsup. I'll take a look and see what might be causing the issue. So far I've not been able to replicate this bug myself, but that info might just help me. It may be that I need to test somethings on your install, would that be possible?

Matt

Hi Matt, it simply doesn't link to the image extension, so like this

http://vb4.domain.net/dbtech/vbdonate/images/admin/

instead of ex

http://vb4.domain.net/dbtech/vbdonat...mnt%20sett.png

Shanakar 07-26-2014 11:51 AM

I was wondering if it was possible for you to add an option to the Donation Goals. Right now it has Month and Year. Is there any way to add another option called Project? I would like my users to be able to donate towards projects that they want to be made rather than the monthly, yearly options. Any way to do this please?

DragonByte Tech 07-27-2014 06:35 AM

Quote:

Originally Posted by katie hunter (Post 2508234)
Hi Matt, it simply doesn't link to the image extension, so like this

http://vb4.domain.net/dbtech/vbdonate/images/admin/

instead of ex

http://vb4.domain.net/dbtech/vbdonat...mnt%20sett.png

I've found what was causing the problem. The options were being displayed from the Pro version that shouldn't exist in the Lite. I've fixed that for the next update.

Quote:

Originally Posted by Shanakar (Post 2508337)
I was wondering if it was possible for you to add an option to the Donation Goals. Right now it has Month and Year. Is there any way to add another option called Project? I would like my users to be able to donate towards projects that they want to be made rather than the monthly, yearly options. Any way to do this please?

I was thinking of something similar. We'll see what we can do with that for v2. :)

@Barbecue_Eater: I'm still tracing that issue I can't replicate it exactly. Is it possible to test whether you still have the same issue if you use English as the main language if possible? My gut feeling is that the issue is connected to the language somehow.

The only other suggestion I have to try for now (pending some input from Fillip @DBTech) is that you redownload the latest vB4 files and reupload them in case there was something in the way the GPC works that has been accidentally corrupted.

Matt

Barbecue_Eater 07-27-2014 05:54 PM

Quote:

Originally Posted by DragonByte Tech (Post 2508451)
@Barbecue_Eater: I'm still tracing that issue I can't replicate it exactly. Is it possible to test whether you still have the same issue if you use English as the main language if possible? My gut feeling is that the issue is connected to the language somehow.

The only other suggestion I have to try for now (pending some input from Fillip @DBTech) is that you redownload the latest vB4 files and reupload them in case there was something in the way the GPC works that has been accidentally corrupted.

Matt

Thanks so far.
Which exact language setting are we talking about here?
I'll probably have to download the english language xml, we only have the German one.

I'm pretty sure there is nothing broken about the files, I remember having the bug before upgrading to the newer version (4.2.1 > 4.2.2).


EDIT:
By setting the language to English (US), the problem is resolved.
How do I fix it with the German language?

It's probably because of the decimal separator.
In the US, you use
Quote:

.
as a decimal separator - here in middle EU you use
Quote:

,

The same applies to the thousand separator: you're using
Quote:

,
while we're using
Quote:

.
But the code needs to be changed in order for the plugin to work properly.

.
.
.
.
-- EDIT 2: Our fix that we use from now:

I fixed it by changing Line 26 of dbtech\vbdonate\includes\functions.php to
Code:

$dbt_vbd_pp_amount_options = explode('/', $vbulletin->options['dbtech_vbdonate_don_amount']);
and started separating the amounts by the character "/" in the vBDonate settings and using a comma instead a dot as the decimal character.

This will not work for the english language pack though, therefore I suggest you guys implement an automatic parser that converts the amounts to the correlating decimal systems of the language. There is a vbulletin variable that can read the decimal character, you can use that automatically based on the users language setting.

Regards.


All times are GMT. The time now is 08:37 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.02243 seconds
  • Memory Usage 1,788KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_code_printable
  • (1)bbcode_php_printable
  • (13)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete