vb.org Archive
Page 33 of 53 « First 233132 33 343543 Last »
Show 40 post(s) from this thread on one page

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.6 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=194)
-   -   Add-On Releases - Rewrite eBay Links (https://vborg.vbsupport.ru/showthread.php?t=144214)

Dismounted 10-29-2008 05:05 AM
Sorry, I haven't had any time to look at anything.

noppid 10-29-2008 01:46 PM
Quote:
Originally Posted by ShadMan (Post 1648094)
Same thing is happening on mine, starting today. Here is the original link posted on my forum:

Code:
http://cgi.ebay.com/ws/eBayISAPI.dll?ViewItem&ssPageName=STRK:MEWAX:IT&item=140159953844
And here is what the link was re-written to, which gives the "Invalid Item" page:

Code:
http://rover.ebay.com/rover/1/711-53200-19255-0/1?campid=5335887982&toolid=10001&mpre=http%3A%2F%2Fcgi.ebay.com%2Fws%2FeBayISAPI.dll%3FViewItem%26amp%3BssPageName%3DSTRK%3AMEWAX%3AIT%26amp%3Bitem%3D140159953844
This results in some additional characters being placed into the URL (see bold and compare to original link above):

Code:
http://cgi.ebay.com/ws/eBayISAPI.dll?ViewItem&ssPageName=STRK:MEWAX:IT&item=140159953844
The problem is the encoded ampersand on the item URL var.

urlencode is doing it. I had this issue in an eBay Developer Application I run.

In the functions file on like line 57, add one line of code after the urlencode that looks like this.

PHP Code:
    // encode URL
    $encodedlink = urlencode($rightlink);
    $encodedlink = str_replace("%26amp%3B", "&" , $encodedlink); 
That fixed it for us. YMMV.

ashley76 10-29-2008 06:03 PM
Thanks Noppid! That did the trick!

noppid 10-29-2008 06:06 PM
Quote:
Originally Posted by ashley76 (Post 1655508)
Thanks Noppid! That did the trick!
Glad to help. When I saw the bug and that dismounted was busy, I had to do something. I use this hack and it's important to us. So, hopefully this can be the permanent fix.

This is shorter.

PHP Code:
$encodedlink = str_replace("%26amp%3B", "&" , urlencode($rightlink)); 

dwessell 10-31-2008 01:19 PM
Thanks Noppid, much appreciated!

rinkrat 11-19-2008 04:12 AM
Works great!

benFF 11-24-2008 12:42 PM
This goes horribly wrong if someone posts up an already rovered link or forwards a PM which has been pre-rovered as it then double rovers them, which breaks all the links..

It should really look if the link has been rovered and if so, strip the url out and rover it with your own settings.

benFF 11-24-2008 12:57 PM
Oh and if a user edits a post which has an ebay link and had already been changed - it completely destroys it.

BadgerDog 11-24-2008 01:27 PM
Quote:
Originally Posted by benFF (Post 1671930)
This goes horribly wrong if ...... <snip>
Are you referring to noppid's fix?

... or, v1.4 of the mod itself without the fix?

Thanks ...

Regards,
Badger

benFF 11-24-2008 04:12 PM
Both. The fix doesn't stop double / triple rewrites.

We need a v1.5 which doesn't rewrite the link if a rover address already exists - and if it does, make sure it's using thr right rover settings and modify if appropriate.


All times are GMT. The time now is 12:44 PM.
Page 33 of 53 « First 233132 33 343543 Last »
Show 40 post(s) from this thread on one page

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01475 seconds
  • Memory Usage 1,744KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (3)bbcode_code_printable
  • (2)bbcode_php_printable
  • (3)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (2)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 
Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 
Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete