vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 2.x Full Releases (https://vborg.vbsupport.ru/forumdisplay.php?f=4)
-   -   mYvBindex v3.1 (https://vborg.vbsupport.ru/showthread.php?t=44691)

TECK 12-28-2002 09:23 AM

Aha, post 2 more articles and let me know what's happening to the no. of queries. You will see that increases every time you post a new article, because you use queries in a loop.
Cheers.

PS. You still use my latest threads code. Hihi, bad boy. :p

Tigga 12-28-2002 09:39 AM

Quote:

Originally posted by TECK
Aha, post 2 more articles and let me know what's happening to the no. of queries. You will see that increases every time you post a new article, because you use queries in a loop.
Cheers.

My God, would you like me to make some more news posts on my site? Or would you like the url to my test server where there are about 8 news posts at the moment? You really have no idea what you're talking about. :rolleyes:

Cloud Strife 12-28-2002 09:47 AM

Wow... I really like this one, i got rid of vbindex2 to put this one on...

Great job...

Clicks install

cloud

Tigga 12-28-2002 09:59 AM

Thanks Cloud. Glad you like it. :)

Here's a couple of other sites you can compare as well Teck
http://killianboard.net/vbull/myvbindex.php
http://www.ls6.com/

TECK 12-28-2002 10:04 AM

Quote:

Originally posted by PlurPlanet

My God, would you like me to make some more news posts on my site? Or would you like the url to my test server where there are about 8 news posts at the moment? You really have no idea what you're talking about. :rolleyes:

Brian, quit being rude and listen instead. You obviously don't know that you perform a query in the loop for every article.
Let me explain to you where are the problems:
First, you use the getavatarurl() function that adds an extra query for each article you display.

Second, you really need to check your code syntax. I saw several mistakes there... like for example:
Code:

DESC LIMIT 1");{
Third, if you made your own code, why do you use the time() function, when in vBulletin is already defined? (not really important... but it shows if you know or not the vBulletin functions)

I could go on and on... but you get the idea. Why not be a nice guy and ask for help instead? And also post the credit where is due? Do you want me also to post here what php code and functions you used from vbHome?

Tigga 12-28-2002 10:19 AM

Quote:

Originally posted by TECK
First, you use the getavatarurl() function that performs an extra query for each article you display. Is better to ask instead of complaining...
Maybe you should take a look at the code again. The only place the getavatarurl function is used is to pull the users avatar in the welcome box. The way I pull the news avatar will not add any extra queries at all.
PHP Code:

// News Avatar
if ($shownewsavatar) {
  if (
$news[avatarpath]!="") {
  
$newsavatarurl "$bburl/$news[avatarpath]";
  } else if (
$news['hascustom']) {
  
$newsavatarurl "$bburl/avatar.php?userid=$news[postuserid]&dateline=$news[avatardateline]";
  } else {
  
$newsavatarurl "https://vborg.vbsupport.ru/images/clear.gif";
  }
  eval(
"\$news[avatar] = \"".gettemplate("index_newsbits_avatar")."\";");



Quote:

Second, you really need to check your code syntax. I saw several mistakes there... like for example:
Code:

DESC LIMIT 1");{

Thank you for pointing that out. I'm sure it's very possible that I have a typo or two in there, nobody's perfect. Something like that really isn't that big of a deal, but if saw other mistakes please point them out to me.


Quote:

Third, if you made your own code, why do you use the time() function, when in vBulletin is already defined?
The time function is only used in the original vBulletin code.

PHP Code:

Do you want me also to post here what php code and functions you used from vbHome

Please do. I've learned quite a bit about PHP since the first version of this hack and v3.0 is all original code or code straight from vBulletin, with the exception of the calendar and weather parts in which full credit is given.

Quote:

Not to mention that you infringe the Jelsoft copyright by copying several code segments onto your file...
If that's the case, then don't you as well? Where did the poll and online users part of your hack come from?

TECK 12-28-2002 10:52 AM

1. Aha, I see.. I thought you did this from my previous vbHome versions (1.0 or 1.1).
Good to know you didn't make the same mistake like I did.

2. Glad I could help. :)

3. Use $ourtimenow instead.

4. So far, from what I see you got ideas from my script on the following areas:
- alternate colors on threads function (old vbHome version)
- threads permissions
- latest threads
- plural function
- article
Basically you copied the code and edited a little the variables to look different.

5. I removed that remark, but you were to fast for me, since is not my place to judge this but the mods here at vb.org. Sorry.
However, my poll and online users code is not the vBulletin one.
Feel free to compare it.

jeffj 12-28-2002 03:17 PM

I just installed it and the instructions are very well done...

my only problem is that myvbindex.php hangs as soon as i add the forum ID that contain the polls if that forum has a POLL or a thread in it.

It does not hang if the forum is empty.

- jeff

jarvis 12-28-2002 04:22 PM

Plur,

Thanks for the response. I will do the modifications for multiple myvbindex loads tonight.

Your support has been first rate! Hope you feel better...

FWIW... Teck, you really should take your comments offline. This petty conversations just seems like an attempt at one upping or proving who the better coder is.

I looked at your product as well and thought it was great, but I just liked the way I could play around with the formatting in this one a bit better. It's the add-on community that continues to make vB a great product, but this mine-is-better routine is wearing thin.

/me steps down off soap box.

Take care!

MartynJ 12-28-2002 04:55 PM

Yes, I'd have to agree with jarvis. It is getting quite tedious. I've something to add to this thread (attachment wise) though I can't, because every time I click the "post reply" button I get the following error message:

Fatal error: Maximum execution time of 15 seconds exceeded in /www/vbulletin.org/htdocs/forum/admin/functions.php on line 1067

Anyone else got that?


All times are GMT. The time now is 10:56 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01794 seconds
  • Memory Usage 1,756KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_code_printable
  • (2)bbcode_php_printable
  • (6)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (4)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete