vb.org Archive
Page 30 of 173 « First 202829 30 31324080130 Last »
Show 40 post(s) from this thread on one page

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vBulletin 3.5 Add-ons (https://vborg.vbsupport.ru/forumdisplay.php?f=113)
-   -   vRewrite - SEOed URLs for vBulletin (https://vborg.vbsupport.ru/showthread.php?t=104484)

Dean C 01-25-2006 10:06 AM
Quote:
Originally Posted by Immortal
Dean never did it himself either he didn't want to or didn't know how.
There were far too many ascii characters to write a replacement.

El_Muerte 01-26-2006 07:48 AM
This gets a long way:
PHP Code:
$string= strtr($string,  "?????????????????????????????????????????????????????", "aaaaaaaaaaaaooooooooooooeeeeeeeecciiiiiiiiuuuuuuuuynn"); 
Don't know about performance.

Snake 01-26-2006 12:11 PM
You must be using a foreign language. Note that this hack will work on English boards only.

Brandon Sheley 01-26-2006 06:33 PM
has anyone had this issue I posted here ??

http://www.forumuniversity.com/campu...0&postcount=49

ChuanSE 01-27-2006 01:27 AM
i get a 403 error as soon as the .htaccess file is in place :/

You don't have permission to access /forums/index.php on this server.

Fender963 01-27-2006 04:24 AM
Excellent hack Immortal, one problem though. It's not rewriting my thread urls or my member profile urls. It rewrites the forum ones fine.

www.plantedtank.net/forums/ is my link.

EDIT: After further inspection I noticed the following:
1. It rewrites the url in any forum, for the most recent post.
2. Any post that is not rewritten will give an incorrect url for page 2 of posts. It only does it for page 2, not 3,4,5,32 .... you get the point.

This is very odd behavior.

Brandon Sheley 01-27-2006 05:28 AM
Quote:
Originally Posted by ChuanSE
i get a 403 error as soon as the .htaccess file is in place :/

You don't have permission to access /forums/index.php on this server.
make sure you edit the htaccess to show /forums ;)


btw,, has anyone else had the issue I'm having ? I'll have to uninstall this untill this is fixed.. :(

10sion 01-28-2006 11:42 PM
Hey Immortal, I must say thanks for this great hack, it seams to be running great except for one minor thing.

It only SEOs the first thread in every forum... Have any idea why?

Example:

General Forum
>whoa new post! -thread
>who likes cheese? -thread
>sweet! -thread

It only rewrites the first thread (whoa new post!) and not the others. Any quick fix? Thanks a lot.

in'dira 01-29-2006 12:54 AM
Hello, Can you explain more precisely how and what to make at the time of the 3rd stage of the installation with $headinclude and < bases href="$vboptions[bburl ]/"/> please ?

Thx lot :)

Immortal 01-29-2006 01:44 AM
Quote:
Originally Posted by 10sion
Hey Immortal, I must say thanks for this great hack, it seams to be running great except for one minor thing.

It only SEOs the first thread in every forum... Have any idea why?

Example:

General Forum
>whoa new post! -thread
>who likes cheese? -thread
>sweet! -thread

It only rewrites the first thread (whoa new post!) and not the others. Any quick fix? Thanks a lot.
It's weird..Try overwritting your code in Plugin Manager->vRewrite under global_complete with this:

PHP Code:
if($vbulletin->options['vRewrite_on'])
{
if($vbulletin->options['vRewrite_forumrewrite'] == "2") {
#------------------------------
# Replace Forums
#------------------------------
$found = preg_match_all('#<a href="forumdisplay\.php\?f=([0-9]+)"#i', $output, $matches);

if($found)
{
    // Build an array of ID's
    $ids = array();

    for($i = 0; $i < $found; $i++)
    {
        if(is_numeric($matches[1][$i]))
            $ids[] = $matches[1][$i];
    }
    $ids = implode(',', $ids);

    // Go through each
    $res = $vbulletin->db->query_read("SELECT forumid, title FROM " . TABLE_PREFIX . "forum WHERE forumid IN($ids)");

    while($f = $vbulletin->db->fetch_array($res))
    {
        $title = urlize($f['title']);
        $fid = $f['forumid'];
        $title = str_replace("-","",$title);

        $output = str_replace("<a href=\"forumdisplay.php?f=$fid\"", "<a href=\"siteforums/$title-$fid.html\"", $output);
    }


}
    }
#------------------------------
# Replace Forums
#------------------------------
$found = preg_match_all('#<a href="forumdisplay\.php\?f=([0-9]+)"#i', $output, $matches);

if($found)
{
    // Build an array of ID's
    $ids = array();

    for($i = 0; $i < $found; $i++)
    {
        if(is_numeric($matches[1][$i]))
            $ids[] = $matches[1][$i];
    }
    $ids = implode(',', $ids);

    // Go through each
    $res = $vbulletin->db->query_read("SELECT forumid, title FROM " . TABLE_PREFIX . "forum WHERE forumid IN($ids)");

    while($f = $vbulletin->db->fetch_array($res))
    {
        $title = urlize($f['title']);
        $fid = $f['forumid'];

        $output = str_replace("<a href=\"forumdisplay.php?f=$fid\"", "<a href=\"f-$title-$fid.html\"", $output);
    }


}
if($vbulletin->options['vRewrite_memberrewrite'] == "2") {
#------------------------------
# Replace User
#------------------------------
$found = preg_match_all('#member\.php\?u=([0-9]+)#i', $output, $matches);

if($found)
{
    // Build an array of ID's
    $ids = array();

    for($i = 0; $i < $found; $i++)
    {
        if(is_numeric($matches[1][$i]))
            $ids[] = $matches[1][$i];
    }
    $ids = implode(',', $ids);

    // Go through each
    $res = $vbulletin->db->query_read("SELECT userid, username FROM " . TABLE_PREFIX . "user WHERE userid IN($ids)");

    while($u = $vbulletin->db->fetch_array($res))
    {
        $username = urlize($u['username']);
        $uid = $u['userid'];

        $output = str_replace("member.php?u=$uid", "members/$username-$uid.html", $output);
    }


}
    }
#------------------------------
# Replace User
#------------------------------
$found = preg_match_all('#member\.php\?u=([0-9]+)#i', $output, $matches);

if($found)
{
    // Build an array of ID's
    $ids = array();

    for($i = 0; $i < $found; $i++)
    {
        if(is_numeric($matches[1][$i]))
            $ids[] = $matches[1][$i];
    }
    $ids = implode(',', $ids);

    // Go through each
    $res = $vbulletin->db->query_read("SELECT userid, username FROM " . TABLE_PREFIX . "user WHERE userid IN($ids)");

    while($u = $vbulletin->db->fetch_array($res))
    {
        $username = urlize($u['username']);
        $uid = $u['userid'];

        $output = str_replace("member.php?u=$uid", "u-$username-$uid.html", $output);
    }


}

#------------------------------
# Replace showthread.php?goto=newpost
#------------------------------
$found = preg_match_all('#<a href="showthread\.php\?goto=newpost&amp;t=([0-9]+)"#i', $output, $matches);

if($found)
{
    // Build an array of ID's
    $ids = array();

    for($i = 0; $i < $found; $i++)
    {
        if(is_numeric($matches[1][$i]))
            $ids[] = $matches[1][$i];
    }
    $ids = implode(',', $ids);

    // Go through each
    $res = $vbulletin->db->query_read("SELECT threadid, title, forumid FROM " . TABLE_PREFIX . "thread WHERE threadid IN($ids)");

    while($n = $vbulletin->db->fetch_array($res))
    {
        $title = urlize($n['title']);
        $tid = $n['threadid'];
        $fid = $n['forumid'];


        $output = str_replace("<a href=\"showthread.php?goto=newpost&amp;t=$tid\"", "<a href=\"$title-$tid-newpost.html\"", $output);
    }


}

#------------------------------
# Replace Last Post User (Forum)
#------------------------------
$found = preg_match_all('#<a href="member\.php\?find=lastposter&amp;f=([0-9]+)"#i', $output, $matches);

if($found)
{
    // Build an array of ID's
    $ids = array();

    for($i = 0; $i < $found; $i++)
    {
        if(is_numeric($matches[1][$i]))
            $ids[] = $matches[1][$i];
    }
    $ids = implode(',', $ids);

    // Go through each
    $res = $vbulletin->db->query_read("SELECT lastposter, forumid FROM " . TABLE_PREFIX . "forum WHERE forumid IN($ids)");

    while($f = $vbulletin->db->fetch_array($res))
    {
        $lp = $f['lastposter'];

        $lpidinfo = $vbulletin->db->query_first("SELECT userid, username FROM " . TABLE_PREFIX . "user WHERE username='$lp'");
        $lp = urlize($lpidinfo['username']);
        $lpid = $lpidinfo['userid'];
        $fid = $f['forumid'];

        

        $output = str_replace("<a href=\"member.php?find=lastposter&amp;f=$fid\"", "<a href=\"u-$lp-$lpid.html\"", $output);
    }


}

#------------------------------
# Replace Last Post User (Thread)
#------------------------------
$found = preg_match_all('#<a href="member\.php\?find=lastposter&amp;t=([0-9]+)"#i', $output, $matches);

if($found)
{
    // Build an array of ID's
    $ids = array();

    for($i = 0; $i < $found; $i++)
    {
        if(is_numeric($matches[1][$i]))
            $ids[] = $matches[1][$i];
    }
    $ids = implode(',', $ids);

    // Go through each
    $res = $vbulletin->db->query_read("SELECT lastposter, threadid FROM " . TABLE_PREFIX . "thread WHERE threadid IN($ids)");

    while($f = $vbulletin->db->fetch_array($res))
    {
        $lp = $f['lastposter'];

        $lpidinfo = $vbulletin->db->query_first("SELECT userid, username FROM " . TABLE_PREFIX . "user WHERE username='$lp'");
        $lp = urlize($lpidinfo['username']);
        $lpid = $lpidinfo['userid'];
        $tid = $f['threadid'];

        

        $output = str_replace("<a href=\"member.php?find=lastposter&amp;t=$tid\"", "<a href=\"u-$lp-$lpid.html\"", $output);
    }


}
#-----------------------------------
# DO NOT REMOVE OTHERWISE YOU 
# WILL BE SENT A DMCA FOR COPYRIGHT 
# INFRINGEMENT YOU MAY NOT USE THIS 
# PLUGIN WITHOUT THIS LINE OF CODE
# IF YOU WISE TO REMOVE THIS AND
# ADD IT TO YOUR STYLE, FEEL FREE
# AS LONG AS THE COPYRIGHT REMAINS
#-----------------------------------

$output .= '<div align="center" class="smallfont">SEOed URLs completed by <a href="http://www.techhelpforum.com">Tech Help Forum</a>.</div>';


if($vbulletin->options['vRewrite_showthreadrewrite'] == "2") {
#------------------------------
# SHOWTHREAD
#------------------------------
$found = preg_match_all('#<a href="showthread\.php\?t=([0-9]+)"#i', $output, $matches);

if($found)
{
    // Build an array of ID's
    $ids = array();

    for($i = 0; $i < $found; $i++)
    {
        if(is_numeric($matches[1][$i]))
            $ids[] = $matches[1][$i];
    }
    $ids = implode(',', $ids);

    // Go through each
    $res = $vbulletin->db->query_read("SELECT threadid, forumid, title FROM " . TABLE_PREFIX . "thread WHERE threadid IN($ids)");

    while($t = $vbulletin->db->fetch_array($res))
    {
        $title = urlize($t['title']);
        $tid = $t['threadid'];
        $fid = $t['forumid'];
        $foruminfo = $vbulletin->db->query_first("SELECT title FROM " . TABLE_PREFIX . "forum WHERE forumid='$fid'");
        $fname = urlize($foruminfo['title']);
        $fname = str_replace("-","",$fname);
        $title = str_replace("-"," ",$title);

        $output = str_replace("<a href=\"showthread.php?t=$tid\"", "<a href=\"$fname/$title-$tid.html\"", $output);
    }


}
    }
#------------------------------
# SHOWTHREAD
#------------------------------
$found = preg_match_all('#<a href="showthread\.php\?t=([0-9]+)"#i', $output, $matches);

if($found)
{
    // Build an array of ID's
    $ids = array();

    for($i = 0; $i < $found; $i++)
    {
        if(is_numeric($matches[1][$i]))
            $ids[] = $matches[1][$i];
    }
    $ids = implode(',', $ids);

    // Go through each
    $res = $vbulletin->db->query_read("SELECT threadid, forumid, title FROM " . TABLE_PREFIX . "thread WHERE threadid IN($ids)");

    while($t = $vbulletin->db->fetch_array($res))
    {
        $title = urlize($t['title']);
        $tid = $t['threadid'];
        $fid = $t['forumid'];
        $foruminfo = $vbulletin->db->query_first("SELECT title FROM " . TABLE_PREFIX . "forum WHERE forumid='$fid'");
        $fname = urlize($foruminfo['title']);

        $output = str_replace("<a href=\"showthread.php?t=$tid\"", "<a href=\"$fname/t-$title-$tid.html\"", $output);
    }


}

#------------------------------
# SHOWTHREAD and page
#------------------------------
$found = preg_match_all('#showthread\.php\?t=([0-9]+)&amp;page=([0-9]+)#i', $output, $matches);

if($found)
{
    // Build an array of ID's
    $ids = array();

    // Keep track of page nums that go with tid's
    $temp = array();

    for($i = 0; $i < $found; $i++)
    {
        // $temp[<threadid>] = <page>
        $temp[ $matches[1][$i] ] = $matches[2][$i];

        if(is_numeric($matches[1][$i]))
            $ids[] = $matches[1][$i];
    }
    $ids = implode(',', $ids);

    // Go through each
    $res = $vbulletin->db->query_read("SELECT threadid, forumid, title FROM " . TABLE_PREFIX . "thread WHERE threadid IN($ids)");

    while($t = $vbulletin->db->fetch_array($res))
    {
        $title = urlize($t['title']);
        $tid = $t['threadid'];
        $fid = $t['forumid'];
        $foruminfo = $vbulletin->db->query_first("SELECT title FROM " . TABLE_PREFIX . "forum WHERE forumid='$fid'");
        $fname = urlize($foruminfo['title']);
        $page = $temp[$tid];
        

        $output = str_replace("showthread.php?t=$tid&amp;page=$page", "$fname/t-$title-$tid-page-$page.html", $output);


    }


}

#------------------------------
# showpost
#------------------------------
$found = preg_match_all('#<a href="showpost\.php\?p=([0-9]+)&amp;postcount=([0-9]+)"#i', $output, $matches);

if($found)
{
    // Build an array of ID's
    $ids = array();

    for($i = 0; $i < $found; $i++)
    {
        $temp[ $matches[1][$i] ] = $matches[2][$i];
        if(is_numeric($matches[1][$i]))
            $ids[] = $matches[1][$i];
    }
    $ids = implode(',', $ids);


    // Go through each
    $res = $vbulletin->db->query_read("SELECT postid, title FROM " . TABLE_PREFIX . "post WHERE postid IN($ids)");

    while($p = $vbulletin->db->fetch_array($res))
    {
        $pid = $p['postid'];
        $postcount = $temp[$pid];
        $output = str_replace("<a href=\"showpost.php?p=$pid&amp;postcount=$postcount\"", "<a href=\"p-$pid.html\"", $output);    }



}


#------------------------------
# Print SHOWTHREAD
#------------------------------
$found = preg_match_all('#<a href="printthread\.php\?t=([0-9]+)"#i', $output, $matches);

if($found)
{
    // Build an array of ID's
    $ids = array();

    for($i = 0; $i < $found; $i++)
    {
        if(is_numeric($matches[1][$i]))
            $ids[] = $matches[1][$i];
    }
    $ids = implode(',', $ids);

    // Go through each
    $res = $vbulletin->db->query_read("SELECT threadid, title FROM " . TABLE_PREFIX . "thread WHERE threadid IN($ids)");

    while($t = $vbulletin->db->fetch_array($res))
    {
        $title = urlize($t['title']);
        $tid = $t['threadid'];

        $output = str_replace("<a href=\"printthread.php?t=$tid\"", "<a href=\"print-$title-$tid.html\"", $output);
    }


}

#------------------------------
# Email SHOWTHREAD
#------------------------------
$found = preg_match_all('#<a href="sendmessage\.php\?do=sendtofriend&amp;t=([0-9]+)"#i', $output, $matches);

if($found)
{
    // Build an array of ID's
    $ids = array();

    for($i = 0; $i < $found; $i++)
    {
        if(is_numeric($matches[1][$i]))
            $ids[] = $matches[1][$i];
    }
    $ids = implode(',', $ids);

    // Go through each
    $res = $vbulletin->db->query_read("SELECT threadid, title FROM " . TABLE_PREFIX . "thread WHERE threadid IN($ids)");

    while($t = $vbulletin->db->fetch_array($res))
    {
        $title = urlize($t['title']);
        $tid = $t['threadid'];

        $output = str_replace("<a href=\"sendmessage.php?do=sendtofriend&amp;t=$tid\"", "<a href=\"sendtofriend-$title-$tid.html\"", $output);
    }


}

#------------------------------
# New Thread
#------------------------------
$found = preg_match_all('#<a href="newthread\.php\?do=newthread&amp;f=([0-9]+)"#i', $output, $matches);

if($found)
{
    // Build an array of ID's
    $ids = array();

    for($i = 0; $i < $found; $i++)
    {
        if(is_numeric($matches[1][$i]))
            $ids[] = $matches[1][$i];
    }
    $ids = implode(',', $ids);

    // Go through each
    $res = $vbulletin->db->query_read("SELECT forumid, title FROM " . TABLE_PREFIX . "forum WHERE forumid IN($ids)");

    while($f = $vbulletin->db->fetch_array($res))
    {
        $title = urlize($f['title']);
        $fid = $f['forumid'];

        $output = str_replace("<a href=\"newthread.php?do=newthread&amp;f=$fid\"", "<a href=\"$title-$fid/newthread.php\"", $output);
    }


}

#------------------------------
# New Post
#------------------------------
$found = preg_match_all('#<a href="newreply\.php\?do=newreply&amp;noquote=1&amp;p=([0-9]+)"#i', $output, $matches);

if($found)
{
    // Build an array of ID's
    $ids = array();

    for($i = 0; $i < $found; $i++)
    {
        if(is_numeric($matches[1][$i]))
            $ids[] = $matches[1][$i];
    }
    $ids = implode(',', $ids);

    // Go through each
    $res = $vbulletin->db->query_read("SELECT threadid, postid FROM " . TABLE_PREFIX . "post WHERE postid IN($ids)");

    while($t = $vbulletin->db->fetch_array($res))
    {
        $tid = $t['threadid'];
        $pid = $t['postid'];
        $threadinfo = $vbulletin->db->query_first("SELECT title, forumid FROM " . TABLE_PREFIX . "thread WHERE threadid='$tid'");
        $title = urlize($threadinfo['title']);
        $fid = $threadinfo['forumid'];
        $f = fetch_foruminfo($fid); 
        $fname = urlize($f['title']);



        $output = str_replace("<a href=\"newreply.php?do=newreply&amp;noquote=1&amp;p=$pid\"", "<a href=\"$fname/newpostnoquote-$pid.php\"", $output);
    }


}

#------------------------------
# New Post
#------------------------------
$found = preg_match_all('#<a href="newreply\.php\?do=newreply&amp;p=([0-9]+)"#i', $output, $matches);

if($found)
{
    // Build an array of ID's
    $ids = array();

    for($i = 0; $i < $found; $i++)
    {
        if(is_numeric($matches[1][$i]))
            $ids[] = $matches[1][$i];
    }
    $ids = implode(',', $ids);

    // Go through each
    $res = $vbulletin->db->query_read("SELECT threadid, postid FROM " . TABLE_PREFIX . "post WHERE postid IN($ids)");

    while($t = $vbulletin->db->fetch_array($res))
    {
        $tid = $t['threadid'];
        $pid = $t['postid'];
        $threadinfo = $vbulletin->db->query_first("SELECT title, forumid FROM " . TABLE_PREFIX . "thread WHERE threadid='$tid'");
        $title = urlize($threadinfo['title']);
        $fid = $threadinfo['forumid'];
        $f = fetch_foruminfo($fid); 
        $fname = urlize($f['title']);



        $output = str_replace("<a href=\"newreply.php?do=newreply&amp;p=$pid\"", "<a href=\"$fname/newpost-$pid.php\"", $output);
    }


}

#------------------------------
# Search
#------------------------------
$found = preg_match_all('#<a href="search\.php\?searchid=([0-9]+)"#i', $output, $matches);

if($found)
{
    // Build an array of ID's
    $ids = array();

    for($i = 0; $i < $found; $i++)
    {
        if(is_numeric($matches[1][$i]))
            $ids[] = $matches[1][$i];
    }
    $ids = implode(',', $ids);

    // Go through each
    $res = $vbulletin->db->query_read("SELECT userid, searchid FROM " . TABLE_PREFIX . "search WHERE searchid IN($ids)");

    while($s = $vbulletin->db->fetch_array($res))
    {
        $userid = $s['userid'];
        $searchid = $s['searchid'];
        

        $output = str_replace("search.php?searchid=$searchid", "search-$userid-$searchid.html", $output);
    }


}


#------------------------------
# misc pages
#------------------------------
$output = str_replace("search.php?do=getnew","search-getnew.html",$output);
$output = str_replace("search.php?do=getdaily","search-getdaily.html",$output);
$output = str_replace("forumdisplay.php?do=markread","markread.html",$output);
}

/**
 * Turn a string into a URL friendly string
 *
 * @param string $txt The string to work on
 * @return string The new string
 */
function urlize($txt)
{
    $txt = unaccent($txt);
    $txt = html_entity_decode($txt);
    $txt = str_replace(' ', '-', $txt);
    $txt = preg_replace('#[^a-zA-Z0-9_\-]+#', '', $txt);
    $txt = preg_replace('#[\-]+#', '-', $txt);

    return strtolower($txt);
}

/**
 * Turn accented characters into normal characters
 *
 * @param string $txt The string to remove the accents from
 * @return string Your new clean string
 */
function unaccent($txt)
{
    $trans = get_html_translation_table(HTML_ENTITIES);
    
    foreach($trans as $literal => $entity)
    {
        if(ord($literal) >= 192)
        {
            $search[]   = $literal;
            $replace[]  = substr($entity, 1, 1);
        }
    }

    return str_replace($search, $replace, $txt);
} 
Let me know if that works for you :)

Quote:
Originally Posted by in'dira
Hello, Can you explain more precisely how and what to make at the time of the 3rd stage of the installation with $headinclude and < bases href="$vboptions[bburl ]/"/> please ?

Thx lot
You want to add the base href after the $headinclude in the templates it mentions. Does that help?


All times are GMT. The time now is 05:05 PM.
Page 30 of 173 « First 202829 30 31324080130 Last »
Show 40 post(s) from this thread on one page

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.02087 seconds
  • Memory Usage 2,040KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_php_printable
  • (4)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (4)pagenav_pagelinkrel
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 
Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 
Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete